ardour.git
7 years agoFix #6774, Moving start/end markers doesn't set Session as modified/dirty
Tim Mayberry [Fri, 9 Sep 2016 12:04:26 +0000 (22:04 +1000)]
Fix #6774, Moving start/end markers doesn't set Session as modified/dirty

If a Session is saved and then the start or end session markers are moved,
closing the Session will not result in "Unsaved Session" dialog being presented
even though the Session has been modified. This change sets the Session as
modified when either the Session start or end markers are modified.

7 years agoFix #7003, Store/Restore state of checkboxes in Export dialog
Tim Mayberry [Sat, 10 Sep 2016 22:39:08 +0000 (08:39 +1000)]
Fix #7003, Store/Restore state of checkboxes in Export dialog

7 years agoclosing the normalize dialog should not run normalize (#7016)
Paul Davis [Fri, 9 Sep 2016 23:15:10 +0000 (19:15 -0400)]
closing the normalize dialog should not run normalize (#7016)

7 years agofix WM close handling for session lock dialog (#7017)
Paul Davis [Fri, 9 Sep 2016 23:09:15 +0000 (19:09 -0400)]
fix WM close handling for session lock dialog (#7017)

7 years agofor files imported without copy, _origin is a full path. We should use this when...
Paul Davis [Wed, 7 Sep 2016 16:38:39 +0000 (12:38 -0400)]
for files imported without copy, _origin is a full path. We should use this when looking for the file at session load

7 years agocorrect comment for FileSource::find()
Paul Davis [Wed, 7 Sep 2016 16:22:15 +0000 (12:22 -0400)]
correct comment for FileSource::find()

7 years agoadd ActionManager::rec_sensitive_actions and put "add track/bus" in this group, which...
Paul Davis [Tue, 6 Sep 2016 20:56:46 +0000 (16:56 -0400)]
add ActionManager::rec_sensitive_actions and put "add track/bus" in this group, which is disabled during active recording

7 years agouse moved version of reset_focus()
Paul Davis [Tue, 6 Sep 2016 20:56:07 +0000 (16:56 -0400)]
use moved version of reset_focus()

7 years agoExpose record enable/disable to Lua bindings
Johannes Mueller [Sat, 3 Sep 2016 14:32:35 +0000 (16:32 +0200)]
Expose record enable/disable to Lua bindings

7 years agouse moved version of reset_focus()
Paul Davis [Tue, 6 Sep 2016 20:17:39 +0000 (16:17 -0400)]
use moved version of reset_focus()

7 years agomove kbd focus reset method into ARDOUR_UI where it (probably) belongs
Paul Davis [Tue, 6 Sep 2016 20:17:08 +0000 (16:17 -0400)]
move kbd focus reset method into ARDOUR_UI where it (probably) belongs

7 years agoUpdate clear-gray-ardour.colors
cooltehno [Tue, 6 Sep 2016 19:34:27 +0000 (23:34 +0400)]
Update clear-gray-ardour.colors

This commit changes item "gtk_bases" from light (color22) to darker (color88). The knob of "Enable/Disable MIDI input" in Edit List had the same colour and was not visible. This commit makes it clear visible, and it has no much influence on a general design.

7 years agouse existing Editor::reset_focus() method to reset focus after audio clock editing...
Paul Davis [Tue, 6 Sep 2016 19:40:22 +0000 (15:40 -0400)]
use existing Editor::reset_focus() method to reset focus after audio clock editing is done

7 years agodo not set the focus widget to be a toplevel window in Editor::reset_focus.
Paul Davis [Tue, 6 Sep 2016 19:39:50 +0000 (15:39 -0400)]
do not set the focus widget to be a toplevel window in Editor::reset_focus.

See comments in code for the reason why

7 years agoFix incorrect estimate of future revision.
nick_m [Tue, 6 Sep 2016 14:32:02 +0000 (00:32 +1000)]
Fix incorrect estimate of future revision.

7 years agoRemove unused variable.
nick_m [Tue, 6 Sep 2016 14:27:01 +0000 (00:27 +1000)]
Remove unused variable.

7 years agoLoad midi region length and start correctly in sessions modified by v5.0 -> 5.3-41
nick_m [Tue, 6 Sep 2016 14:18:35 +0000 (00:18 +1000)]
Load midi region length and start correctly in sessions modified by v5.0 -> 5.3-41

7 years agoremove duplicate enum -- copy/paste typo
Robin Gareus [Mon, 5 Sep 2016 23:31:55 +0000 (01:31 +0200)]
remove duplicate enum -- copy/paste typo

7 years agoexpose PeakMeter Lua bindings
Robin Gareus [Mon, 5 Sep 2016 23:26:36 +0000 (01:26 +0200)]
expose PeakMeter Lua bindings

7 years agoSet start_pulse and length_pulse from state, neither need to be a PBD::Property.
nick_m [Mon, 5 Sep 2016 14:04:00 +0000 (00:04 +1000)]
Set start_pulse and length_pulse from state, neither need to be a PBD::Property.

7 years agoFix the tempo note-type hallucination.
nick_m [Mon, 5 Sep 2016 06:28:46 +0000 (16:28 +1000)]
Fix the tempo note-type hallucination.

- after reports that a tempo with non-4.0 note type
  would produce a ramp in the preceding section, an incorrect
  assumption was made leading to a bogus 'fix' that redefined
  Tempo's pulses_per_minute().
  the real fix was simple:
  the ramp's function constant was calculated using the note type
  of the proceding tempo rather than the current one.

- this patch reverts e82482e8e9c and a4d67279e0086258
  and maintains the old definition of Tempo::pulses_per_minute()

7 years agoSanity check for TempoMap::get_grid ()
nick_m [Sat, 3 Sep 2016 18:19:34 +0000 (04:19 +1000)]
Sanity check for TempoMap::get_grid ()

7 years agoRevert part of d50df8279966.
nick_m [Sat, 3 Sep 2016 17:19:13 +0000 (03:19 +1000)]
Revert part of d50df8279966.

7 years agoFix graphical issues in tempo curve.
nick_m [Sat, 3 Sep 2016 17:18:12 +0000 (03:18 +1000)]
Fix graphical issues in tempo curve.

7 years agoMove check for detected bundle earlier in install process.
Todd Naugle [Fri, 2 Sep 2016 15:37:37 +0000 (10:37 -0500)]
Move check for detected bundle earlier in install process.

Previously if the bundle being installed did not support the detected
system the user would get an error message about the .size file
being missing.

7 years agoFix various paste errors in tempo.cc. Should fix recent regressions.
nick_m [Fri, 2 Sep 2016 15:22:41 +0000 (01:22 +1000)]
Fix various paste errors in tempo.cc. Should fix recent regressions.

7 years agoEnsure the correct position is passed to MidiRegionView::get_grid_beats().
nick_m [Thu, 1 Sep 2016 19:18:53 +0000 (05:18 +1000)]
Ensure the correct position is passed to MidiRegionView::get_grid_beats().

7 years agoUse the stored beat to recalculate pulse when setting position as sub_num is irrelevent.
nick_m [Thu, 1 Sep 2016 19:13:53 +0000 (05:13 +1000)]
Use the stored beat to recalculate pulse when setting position as sub_num is irrelevent.

7 years agoEditor::get_grid_type_as_beats() returns the quarter note equivalent of BBT beat...
nick_m [Thu, 1 Sep 2016 19:11:54 +0000 (05:11 +1000)]
Editor::get_grid_type_as_beats() returns the quarter note equivalent of BBT beat and bar.

7 years agoConsolidate the meaning of beat divisions.
nick_m [Thu, 1 Sep 2016 19:10:32 +0000 (05:10 +1000)]
Consolidate the meaning of beat divisions.

- bar and beat snapping is BBT beat based while other
  music divisions are quarter note based. Reflect this in
  the way exact_beat/qn is calculated.

7 years agoFix a bug when formatting time strings
John Emmas [Thu, 1 Sep 2016 11:31:33 +0000 (12:31 +0100)]
Fix a bug when formatting time strings

It seems that 'strftime()' (on Windows) works differently from its non-Windows counterparts. Specifically, some formatting options (e.g. %F) are not recognised in the Windows implementation.

Fortunately, glibmm comes to our rescue here! So let's use the glib implementation which will hopefully work the same on all platforms.

7 years agoOSC: don't restore User preset before writing new one
Len Ovens [Thu, 1 Sep 2016 02:56:48 +0000 (19:56 -0700)]
OSC: don't restore User preset before writing new one

7 years agoAttempt to clarify tempo map comments.
nick_m [Wed, 31 Aug 2016 18:01:29 +0000 (04:01 +1000)]
Attempt to clarify tempo map comments.

7 years agoRevert 894cdb6f5c2064.
nick_m [Wed, 31 Aug 2016 16:43:29 +0000 (02:43 +1000)]
Revert 894cdb6f5c2064.

- once again we snap to BBT beats when snapping to 'beat'.

7 years agoSnap to beat snaps to quarter note.
nick_m [Wed, 31 Aug 2016 15:35:53 +0000 (01:35 +1000)]
Snap to beat snaps to quarter note.

7 years agoNo-op - rename var in MidiRegionView::note_dropped().
nick_m [Wed, 31 Aug 2016 12:46:09 +0000 (22:46 +1000)]
No-op - rename var in MidiRegionView::note_dropped().

7 years agoTempoMap::pulse_at_frame() handles separated musical sections as per beat_at_frame().
nick_m [Wed, 31 Aug 2016 12:45:25 +0000 (22:45 +1000)]
TempoMap::pulse_at_frame() handles separated musical sections as per beat_at_frame().

7 years agoFix incorrect inclusion of note_type in Tempo::pulses_per_minute().
nick_m [Tue, 30 Aug 2016 20:57:46 +0000 (06:57 +1000)]
Fix incorrect inclusion of note_type in Tempo::pulses_per_minute().

7 years agoKeep region beat and pulse separated, ensure pulse is updated when setting position.
nick_m [Tue, 30 Aug 2016 19:49:11 +0000 (05:49 +1000)]
Keep region beat and pulse separated, ensure pulse is updated when setting position.

7 years agoFix incorrect start_pulse in MidiRegion copy-with-offset ctor.
nick_m [Tue, 30 Aug 2016 19:05:30 +0000 (05:05 +1000)]
Fix incorrect start_pulse in MidiRegion copy-with-offset ctor.

7 years agoAmend f3c0c1a865 (Add quarter-note position methods).
nick_m [Tue, 30 Aug 2016 18:30:34 +0000 (04:30 +1000)]
Amend f3c0c1a865 (Add quarter-note position methods).

7 years agoNoteCreateDrag uses quarter-notes.
nick_m [Tue, 30 Aug 2016 17:30:09 +0000 (03:30 +1000)]
NoteCreateDrag uses quarter-notes.

7 years agoMidiRegionView uses quarter note snapping.
nick_m [Tue, 30 Aug 2016 17:27:35 +0000 (03:27 +1000)]
MidiRegionView uses quarter note snapping.

- also ensures poiinter ghost note respects the snap modifier.

7 years agoUse quarter-note based 'beat' when snapping.
nick_m [Tue, 30 Aug 2016 17:24:45 +0000 (03:24 +1000)]
Use quarter-note based 'beat' when snapping.

7 years agoBeatsFramesConverter uses quarter-note 'beat' position.
nick_m [Tue, 30 Aug 2016 17:22:10 +0000 (03:22 +1000)]
BeatsFramesConverter uses quarter-note 'beat' position.

7 years agoAdd quarter-note position methods to TempoMap.
nick_m [Tue, 30 Aug 2016 17:19:39 +0000 (03:19 +1000)]
Add quarter-note position methods to TempoMap.

7 years agoAdd length_pulse to MidiSource, usr quarter-notes in midi_read().
nick_m [Tue, 30 Aug 2016 17:17:26 +0000 (03:17 +1000)]
Add length_pulse to MidiSource, usr quarter-notes in midi_read().

- MidiSource _length_beats is in quarter notes.
  Here we duplicate length_beats for backwards compatibility

7 years agoAdd start_pulse and length_pulse to midi region for beat/note separation.
nick_m [Tue, 30 Aug 2016 17:03:40 +0000 (03:03 +1000)]
Add start_pulse and length_pulse to midi region for beat/note separation.

7 years agoAdd a pulse property to region.
nick_m [Tue, 30 Aug 2016 16:59:14 +0000 (02:59 +1000)]
Add a pulse property to region.

- separates ardour beat (meter-based) and note (pulse-based)
  musical position.

7 years agoand another SNAFU...
Robin Gareus [Tue, 30 Aug 2016 21:54:25 +0000 (23:54 +0200)]
and another SNAFU...

7 years agofix jump out of local scope
Robin Gareus [Tue, 30 Aug 2016 21:41:07 +0000 (23:41 +0200)]
fix jump out of local scope

7 years agocorrect comments and avoid /={4+}/
Robin Gareus [Tue, 30 Aug 2016 21:20:32 +0000 (23:20 +0200)]
correct comments and avoid /={4+}/

7 years ago-put method print_help() inside factory() (!) -nop / add comments
Thomas Brand [Tue, 30 Aug 2016 19:55:15 +0000 (21:55 +0200)]
-put method print_help() inside factory() (!) -nop / add comments

Signed-off-by: Thomas Brand <tom@trellis.ch>
7 years agotom's loop: fix arguments to add_region()
Robin Gareus [Tue, 30 Aug 2016 18:42:27 +0000 (20:42 +0200)]
tom's loop: fix arguments to add_region()

7 years ago-adapt to new method syntax of add_region() to make script work with latest lua API...
Thomas Brand [Tue, 30 Aug 2016 18:08:26 +0000 (20:08 +0200)]
-adapt to new method syntax of add_region() to make script work with latest lua API -add help text; displayed on error in script output window

Signed-off-by: Thomas Brand <tom@trellis.ch>
7 years agoUpdate our MSVC project files to generate the most recent Ardour session file format...
John Emmas [Tue, 30 Aug 2016 06:15:00 +0000 (07:15 +0100)]
Update our MSVC project files to generate the most recent Ardour session file format (ver 5) rather than the older v3 format

7 years agoNOOP: whitespace
Paul Davis [Mon, 29 Aug 2016 10:38:48 +0000 (06:38 -0400)]
NOOP: whitespace

7 years agoimproved (more general) fix for preferences window visibility
Paul Davis [Mon, 29 Aug 2016 10:38:34 +0000 (06:38 -0400)]
improved (more general) fix for preferences window visibility

7 years agoRevert "apparent fix for preferences window visibility"
Paul Davis [Mon, 29 Aug 2016 10:37:45 +0000 (06:37 -0400)]
Revert "apparent fix for preferences window visibility"

This reverts commit 9d6d9c650193fa098c0d85c505b5eb3b61f8d2f8.

7 years agoapparent fix for preferences window visibility
Paul Davis [Mon, 29 Aug 2016 10:35:45 +0000 (06:35 -0400)]
apparent fix for preferences window visibility

7 years agofix focus-on-clock action 5.3
Paul Davis [Sun, 28 Aug 2016 13:05:27 +0000 (09:05 -0400)]
fix focus-on-clock action

7 years agoChange (slightly) the previous modification to 'fluidsynth/config.h'
John Emmas [Sun, 28 Aug 2016 12:54:16 +0000 (13:54 +0100)]
Change (slightly) the previous modification to 'fluidsynth/config.h'

7 years agoupdate fluidsynth patch for MSVC
Robin Gareus [Sun, 28 Aug 2016 11:47:12 +0000 (13:47 +0200)]
update fluidsynth patch for MSVC

7 years agofix Coreaudio Aggregate for separate devices with identical names
Robin Gareus [Sun, 28 Aug 2016 11:44:30 +0000 (13:44 +0200)]
fix Coreaudio Aggregate for separate devices with identical names

7 years agoundo modifications to upstream fluidsynth code
Robin Gareus [Sun, 28 Aug 2016 11:23:18 +0000 (13:23 +0200)]
undo modifications to upstream fluidsynth code

7 years agofix lv2 ttl
Robin Gareus [Sun, 28 Aug 2016 11:18:48 +0000 (13:18 +0200)]
fix lv2 ttl

7 years agoConfigure the new 'fluidsynth' library to be buildable with MSVC
John Emmas [Sun, 28 Aug 2016 09:31:43 +0000 (10:31 +0100)]
Configure the new 'fluidsynth' library to be buildable with MSVC

(haven't built any fluidsynth plugins yet)

7 years agoFix a crash when toggling back and forth between a generic plugin GUI window and...
John Emmas [Sun, 28 Aug 2016 09:26:02 +0000 (10:26 +0100)]
Fix a crash when toggling back and forth between a generic plugin GUI window and a VST plugin's own GUI

7 years agoFix a crash when we display the 'Plugin Analysis' window (in a generic plugin GUI...
John Emmas [Sun, 28 Aug 2016 09:23:57 +0000 (10:23 +0100)]
Fix a crash when we display the 'Plugin Analysis' window (in a generic plugin GUI window) and then close the GUI

7 years agoAccommodate newly introduced source(s) in our MSVC project (ardour_osc)
John Emmas [Sun, 28 Aug 2016 09:20:56 +0000 (10:20 +0100)]
Accommodate newly introduced source(s) in our MSVC project (ardour_osc)

7 years agoAccommodate newly introduced source(s) in our MSVC project (gtk2_ardour)
John Emmas [Sun, 28 Aug 2016 09:19:42 +0000 (10:19 +0100)]
Accommodate newly introduced source(s) in our MSVC project (gtk2_ardour)

7 years agosingle action punch in 5.2
Paul Davis [Sat, 27 Aug 2016 23:57:40 +0000 (19:57 -0400)]
single action punch in

Consecutive execution (e.g. from a control surface button) engages punch in, then punch out, then clears both.
Patch by Nathan Stewart

7 years agonotch: narrow the bandwidth with increasing frequency
Robin Gareus [Sat, 27 Aug 2016 22:18:06 +0000 (00:18 +0200)]
notch: narrow the bandwidth with increasing frequency

7 years agofix typo in notch example script
Robin Gareus [Sat, 27 Aug 2016 22:02:16 +0000 (00:02 +0200)]
fix typo in notch example script

7 years agonewbie documentation
Robin Gareus [Sat, 27 Aug 2016 21:35:02 +0000 (23:35 +0200)]
newbie documentation

7 years agonotch-bank: increase max Q, use logscale
Robin Gareus [Sat, 27 Aug 2016 17:56:08 +0000 (19:56 +0200)]
notch-bank: increase max Q, use logscale

7 years agoupdate notch-bank to variable i/o, increase max stages to 100
Robin Gareus [Sat, 27 Aug 2016 17:47:53 +0000 (19:47 +0200)]
update notch-bank to variable i/o, increase max stages to 100

7 years agobackwards compatible a-comp stereo sidechain ports
Robin Gareus [Sat, 27 Aug 2016 16:08:46 +0000 (18:08 +0200)]
backwards compatible a-comp stereo sidechain ports

7 years agoadd a notch-bank filter
Robin Gareus [Sat, 27 Aug 2016 15:48:11 +0000 (17:48 +0200)]
add a notch-bank filter

7 years agoNo discrimination against systems which don't have a PI define
Robin Gareus [Sat, 27 Aug 2016 15:20:27 +0000 (17:20 +0200)]
No discrimination against systems which don't have a PI define

7 years agoPrepare a-comp for click-free bypass/enable
Robin Gareus [Sat, 27 Aug 2016 15:14:49 +0000 (17:14 +0200)]
Prepare a-comp for click-free bypass/enable

7 years agoclick-free a-delay bypass/enable
Robin Gareus [Sat, 27 Aug 2016 14:59:15 +0000 (16:59 +0200)]
click-free a-delay bypass/enable

7 years agoNO-OP clean up plugin ttl
Robin Gareus [Sat, 27 Aug 2016 14:01:16 +0000 (16:01 +0200)]
NO-OP clean up plugin ttl

7 years agofix copy/paste typo in 1d7c14496
Robin Gareus [Sat, 27 Aug 2016 13:53:38 +0000 (15:53 +0200)]
fix copy/paste typo in 1d7c14496

7 years agoadd NaN/Inf protection now that bypass no longer de/activates
Robin Gareus [Sat, 27 Aug 2016 12:10:51 +0000 (14:10 +0200)]
add NaN/Inf protection now that bypass no longer de/activates

7 years agoclick-free a-reverb bypass
Robin Gareus [Sat, 27 Aug 2016 12:09:47 +0000 (14:09 +0200)]
click-free a-reverb bypass

7 years agoAdd automatable click-free bypass/enable feature to a-eq
Robin Gareus [Sat, 27 Aug 2016 11:23:25 +0000 (13:23 +0200)]
Add automatable click-free bypass/enable feature to a-eq

7 years agoNO-OP: indentation
Paul Davis [Sat, 27 Aug 2016 10:02:43 +0000 (06:02 -0400)]
NO-OP: indentation

7 years agofix display of preferences window when detached.
Paul Davis [Sat, 27 Aug 2016 10:02:28 +0000 (06:02 -0400)]
fix display of preferences window when detached.

GTK+ apparently unpacks/hides a widget whose requistion at window show/packing time is negative for x or y axes. The RC option editor
was being created AFTER its Tabbable self packed it into its own window (when detached), and GTK+ rejected it because the
treeview had a size requisition with -1 for width.

So build it first, then call Tabbable::set_state() later

7 years agoExpose PluginInfo bindings (eg plugin-type, unique id, etc)
Robin Gareus [Fri, 26 Aug 2016 17:04:07 +0000 (19:04 +0200)]
Expose PluginInfo bindings (eg plugin-type, unique id, etc)

processor:to_insert():plugin(0):get_info().type

7 years agoallow to access data-members in weak/shared ptr classes
Robin Gareus [Fri, 26 Aug 2016 17:01:09 +0000 (19:01 +0200)]
allow to access data-members in weak/shared ptr classes

7 years agoadd "sameinstance()" lua binding for all shared/weak ptrs
Robin Gareus [Fri, 26 Aug 2016 16:25:15 +0000 (18:25 +0200)]
add "sameinstance()" lua binding for all shared/weak ptrs

7 years agoforward Lua print() to Ardour's Log.
Robin Gareus [Fri, 26 Aug 2016 14:59:11 +0000 (16:59 +0200)]
forward Lua print() to Ardour's Log.

7 years agoUpdate CC automation menu when changing channel selection
Julien "_FrnchFrgg_" RIVAUD [Fri, 26 Aug 2016 14:18:28 +0000 (16:18 +0200)]
Update CC automation menu when changing channel selection

7 years agoadd a static function to access processor selection from a Lua script
Robin Gareus [Fri, 26 Aug 2016 01:24:06 +0000 (03:24 +0200)]
add a static function to access processor selection from a Lua script

  local ps = ArdourUI.processor_selection()
  for p in ps:iter() do print (p:name ()) end

7 years agoAdd Lua bindings for ProcessorVector (really ProcSelection)
Robin Gareus [Fri, 26 Aug 2016 01:21:05 +0000 (03:21 +0200)]
Add Lua bindings for ProcessorVector (really ProcSelection)

7 years agoincrease pre-allocated Lua DSP memory pool size to 3MB
Robin Gareus [Thu, 25 Aug 2016 23:47:05 +0000 (01:47 +0200)]
increase pre-allocated Lua DSP memory pool size to 3MB

...now that bindings alone need approx 700K and some more complex DSP
scripts are showing up 2MB is not much :(

7 years agotweak lua GC (once again)
Robin Gareus [Thu, 25 Aug 2016 23:18:48 +0000 (01:18 +0200)]
tweak lua GC (once again)

fixes OOM with extreme automation in HP/LP.

7 years agofix a-eq grid layout
Robin Gareus [Thu, 25 Aug 2016 23:10:38 +0000 (01:10 +0200)]
fix a-eq grid layout

7 years agoupdate fluidsynth patch
Robin Gareus [Thu, 25 Aug 2016 20:37:12 +0000 (22:37 +0200)]
update fluidsynth patch