ardour.git
10 years agoMerge branch 'windows' of git.ardour.org:ardour/ardour into windows
John Emmas [Tue, 3 Sep 2013 14:58:58 +0000 (15:58 +0100)]
Merge branch 'windows' of git.ardour.org:ardour/ardour into windows

10 years ago'libs/panners' - Remove the temporary export specifiers that were only used for testing
John Emmas [Tue, 3 Sep 2013 14:53:24 +0000 (15:53 +0100)]
'libs/panners' - Remove the temporary export specifiers that were only used for testing

10 years ago'libs/panners' - Disable a compiler-specific warning
John Emmas [Tue, 3 Sep 2013 13:50:56 +0000 (14:50 +0100)]
'libs/panners' - Disable a compiler-specific warning

10 years ago'libs/panners' - Fix a typo in 'vbap/vbap.cc'
John Emmas [Tue, 3 Sep 2013 13:49:49 +0000 (14:49 +0100)]
'libs/panners' - Fix a typo in 'vbap/vbap.cc'

10 years ago'libs/panners' - Use 'std::vector' to implement arrays whose size is unknown (require...
John Emmas [Tue, 3 Sep 2013 13:47:46 +0000 (14:47 +0100)]
'libs/panners' - Use 'std::vector' to implement arrays whose size is unknown (required to be buildable with MSVC)

10 years ago'libs/panners' - Use 'alloca()' for a stack based array whose size is unknown (requir...
John Emmas [Tue, 3 Sep 2013 13:46:01 +0000 (14:46 +0100)]
'libs/panners' - Use 'alloca()' for a stack based array whose size is unknown (required to be buildable with MSVC)

10 years agoMerge branch 'master' into windows
Paul Davis [Tue, 3 Sep 2013 12:50:38 +0000 (08:50 -0400)]
Merge branch 'master' into windows

10 years agofix error introduced during recent changes to Mackie control support, involving ambig...
Paul Davis [Tue, 3 Sep 2013 12:48:11 +0000 (08:48 -0400)]
fix error introduced during recent changes to Mackie control support, involving ambiguous enum usage

10 years agofix a few minor compilation warnings
Paul Davis [Tue, 3 Sep 2013 12:46:57 +0000 (08:46 -0400)]
fix a few minor compilation warnings

10 years agoMerge branch 'master' into windows
Paul Davis [Tue, 3 Sep 2013 12:34:27 +0000 (08:34 -0400)]
Merge branch 'master' into windows

10 years agouse visibility macros to control visibility in control surface DLL/DSO's
Paul Davis [Tue, 3 Sep 2013 12:33:51 +0000 (08:33 -0400)]
use visibility macros to control visibility in control surface DLL/DSO's

10 years agoadd comment
Paul Davis [Tue, 3 Sep 2013 12:33:26 +0000 (08:33 -0400)]
add comment

10 years agoupdated .po files from waf i18n, plus an updated gtk2_ardour/de.po from Edgar Aichinger
Paul Davis [Tue, 3 Sep 2013 12:00:58 +0000 (08:00 -0400)]
updated .po files from waf i18n, plus an updated gtk2_ardour/de.po from Edgar Aichinger

10 years agoRevert "bump to 3.4"
Paul Davis [Tue, 3 Sep 2013 11:59:59 +0000 (07:59 -0400)]
Revert "bump to 3.4"

This reverts commit ad7ab8f09afe1eac025a6da87a45c83ada15544d.

10 years agorevert to --backtrace enabled by default, since the original goal of this change...
Paul Davis [Tue, 3 Sep 2013 02:10:51 +0000 (22:10 -0400)]
revert to --backtrace enabled by default, since the original goal of this change was addressed in other ways

10 years agobump to 3.4
Paul Davis [Tue, 3 Sep 2013 01:57:30 +0000 (21:57 -0400)]
bump to 3.4

10 years agoadd std:: to clarify use of llabs on OS X
Paul Davis [Mon, 2 Sep 2013 21:43:55 +0000 (17:43 -0400)]
add std:: to clarify use of llabs on OS X

10 years agoreplace recently added attempt to use visibility macros with one based on gcc guidelines
Paul Davis [Mon, 2 Sep 2013 20:41:56 +0000 (16:41 -0400)]
replace recently added attempt to use visibility macros with one based on gcc guidelines

I can see no reason to define the "C API Call Type", but perhaps it really is needed for some reason.

I have tested this on Linux only.

10 years agoadd visibility.h to provide generic DSO/DLL visibility macros for use with ardour...
Paul Davis [Mon, 2 Sep 2013 20:32:36 +0000 (16:32 -0400)]
add visibility.h to provide generic DSO/DLL visibility macros for use with ardour "helper" and associated libs

10 years ago'libs/panners' - Streamline my previous API changes and include Tim's additions to...
John Emmas [Mon, 2 Sep 2013 15:54:17 +0000 (16:54 +0100)]
'libs/panners' - Streamline my previous API changes and include Tim's additions to support the GCC compiler

10 years agoLV2 extUI handling - amend to previous commit.
Robin Gareus [Mon, 2 Sep 2013 14:57:46 +0000 (16:57 +0200)]
LV2 extUI handling - amend to previous commit.

10 years agoLV2 external UI handling - revert to <= 3.3. behaviour
Robin Gareus [Mon, 2 Sep 2013 14:21:12 +0000 (16:21 +0200)]
LV2 external UI handling - revert to <= 3.3. behaviour

Don't ever clean up external UI plugins that use the LV2plug.in URI.
only free the memory of the last instance when the plugin is removed
or ardour closes.

10 years agoimprove scroll and drag behaviour of volume-controller knob
Robin Gareus [Sun, 1 Sep 2013 01:19:13 +0000 (03:19 +0200)]
improve scroll and drag behaviour of volume-controller knob

10 years agofix keyboard interaction with volume knobs (monitor section)
Robin Gareus [Sat, 31 Aug 2013 18:37:02 +0000 (20:37 +0200)]
fix keyboard interaction with volume knobs (monitor section)

10 years ago'libs/panners' - Add a conventional 'C' API call type to test building with MSVC
John Emmas [Sat, 31 Aug 2013 15:19:36 +0000 (16:19 +0100)]
'libs/panners' - Add a conventional 'C' API call type to test building with MSVC

10 years ago'libs/panners' - A small test (before going too far) to see if these changes have...
John Emmas [Fri, 30 Aug 2013 18:51:45 +0000 (19:51 +0100)]
'libs/panners' - A small test (before going too far) to see if these changes have any detrimental affect on the non-MSVC builds.

10 years agofix typo in IEC-meter 'weird-float' protection.
Robin Gareus [Thu, 29 Aug 2013 16:46:03 +0000 (18:46 +0200)]
fix typo in IEC-meter 'weird-float' protection.

10 years agoprotect meters against weird float values
Robin Gareus [Thu, 29 Aug 2013 15:36:52 +0000 (17:36 +0200)]
protect meters against weird float values

10 years agoupdate external plugin UI handling
Robin Gareus [Thu, 29 Aug 2013 11:05:11 +0000 (13:05 +0200)]
update external plugin UI handling

amend to 4cdb018 and 1d972d0

override ui_closed() behavior for lv2ui:external
Keep UI around and do not re-instantiate, but simply show it again.
(this is against the original specs but was agreed upon by various
authors and the previous behavior or Ardour.)

kx:external-ui are cleaned up after ui_closed().

10 years agofix vari-speed phase (when used for calculation only)
Robin Gareus [Tue, 27 Aug 2013 18:55:15 +0000 (20:55 +0200)]
fix vari-speed phase (when used for calculation only)

and clarify an old comment.

10 years agoModify 'ardourext/misc.h' so that it only uses C++ constructs when the compilation...
John Emmas [Tue, 27 Aug 2013 16:10:46 +0000 (17:10 +0100)]
Modify 'ardourext/misc.h' so that it only uses C++ constructs when the compilation is cplusplus

10 years ago'libs/clearlooks-newer' - Clearlooks needs to be buildable as conventional 'C' but...
John Emmas [Tue, 27 Aug 2013 16:07:53 +0000 (17:07 +0100)]
'libs/clearlooks-newer' - Clearlooks needs to be buildable as conventional 'C' but many 'C' compilers require that variables be declared at the top of each function. Move declarations as necessary to accommodate this.

10 years agoMinor tweaks to MSVC build (hopefully of little consequence)
John Emmas [Mon, 26 Aug 2013 16:50:17 +0000 (17:50 +0100)]
Minor tweaks to MSVC build (hopefully of little consequence)

10 years ago'libs/gtkmm2ext' - Compiler specific includes
John Emmas [Mon, 26 Aug 2013 16:47:28 +0000 (17:47 +0100)]
'libs/gtkmm2ext' - Compiler specific includes

10 years ago'libs/gtkmm2ext' - Main body of changes required for building with MSVC (mostly ...
John Emmas [Mon, 26 Aug 2013 16:45:18 +0000 (17:45 +0100)]
'libs/gtkmm2ext' - Main body of changes required for building with MSVC (mostly #includes and casting)

10 years ago'libs/gtkmm2ext' - Use 'std::vector' instead of dynamically sized arrays (required...
John Emmas [Mon, 26 Aug 2013 16:28:03 +0000 (17:28 +0100)]
'libs/gtkmm2ext' - Use 'std::vector' instead of dynamically sized arrays (required to be buildable with MSVC)

10 years ago'libs/gtkmm2ext' - Remove "using namespace Gdk;" to avoid confusion (in 'fastmeter...
John Emmas [Mon, 26 Aug 2013 14:43:20 +0000 (15:43 +0100)]
'libs/gtkmm2ext' - Remove "using namespace Gdk;" to avoid confusion (in 'fastmeter.cc') over whether we want namespace ::Cairo or namespace Gdk::Cairo

10 years agoadd LV2 support for kx:external-ui#
Robin Gareus [Sun, 25 Aug 2013 14:20:27 +0000 (16:20 +0200)]
add LV2 support for kx:external-ui#

the ABI of http://kxstudio.sf.net/ns/lv2ext/external-ui# is identical to
http://lv2plug.in/ns/extensions/ui#external
It just adds a distinction between #Host and #Widget for cosmetic reasons.
Sadly some newer plugins are released with only support for kxstudio URI :(

10 years agofree memory of external plugins on GUI close (major mem leak).
Robin Gareus [Sun, 25 Aug 2013 13:54:43 +0000 (15:54 +0200)]
free memory of external plugins on GUI close (major mem leak).

There is at least one known plugin that has a problem with this
(custom thread race condition) but it also crashes in other hosts:
http://www.drumgizmo.org/wiki/doku.php?id=bugs&do=showcaselink&showid=8&project=drumgizmo

tested to be working with various nedko, falktx and x42 plugins

10 years agofix compilation on linux
Paul Davis [Sat, 24 Aug 2013 16:27:40 +0000 (12:27 -0400)]
fix compilation on linux

10 years agofix merge conflicts from master
Paul Davis [Sat, 24 Aug 2013 16:18:06 +0000 (12:18 -0400)]
fix merge conflicts from master

10 years agopot/po file updates caused by waf i18n
Paul Davis [Sat, 24 Aug 2013 15:46:36 +0000 (11:46 -0400)]
pot/po file updates caused by waf i18n

10 years agofix confusion about whether flip_mode in the Mackie support code is a bool or an...
Paul Davis [Sat, 24 Aug 2013 15:45:31 +0000 (11:45 -0400)]
fix confusion about whether flip_mode in the Mackie support code is a bool or an enum

10 years agoexport: add support for CAF
Tim Blechmann [Sat, 24 Aug 2013 12:23:25 +0000 (14:23 +0200)]
export: add support for CAF

10 years agodon't run meter in import-dialog if the dialog is not visible
Robin Gareus [Fri, 23 Aug 2013 19:26:02 +0000 (21:26 +0200)]
don't run meter in import-dialog if the dialog is not visible

10 years agoundo the hiding of SR-dependent LV2 ports
Paul Davis [Thu, 22 Aug 2013 21:46:19 +0000 (17:46 -0400)]
undo the hiding of SR-dependent LV2 ports

10 years agoupdate czech translations from pavel fric, part 2
Paul Davis [Thu, 15 Aug 2013 18:55:57 +0000 (14:55 -0400)]
update czech translations from pavel fric, part 2

10 years agoupdate czech translations from pavel fric
Paul Davis [Thu, 15 Aug 2013 18:55:10 +0000 (14:55 -0400)]
update czech translations from pavel fric

10 years agofix newly-appearing crash-at-close caused by muddled thinking in pbd/pthread_utils
Paul Davis [Thu, 15 Aug 2013 15:44:47 +0000 (11:44 -0400)]
fix newly-appearing crash-at-close caused by muddled thinking in pbd/pthread_utils

threads created with this code can now just return a value as they normally would, and the
infrastructure will ensure cleanup. there is no longer any reason to call pthread_exit_pbd()
and so that has been removed.

10 years agocheck master sources when determining whether a region uses a source. should fix...
Paul Davis [Thu, 15 Aug 2013 15:43:37 +0000 (11:43 -0400)]
check master sources when determining whether a region uses a source. should fix #5618

10 years agoMove curve test file handling in main() until after ARDOUR::init is called
Tim Mayberry [Sat, 10 Aug 2013 02:08:45 +0000 (12:08 +1000)]
Move curve test file handling in main() until after ARDOUR::init is called

This means it doesn't need to call PBD::ID::init directly, which it now
shouldn't be doing

10 years agoRemove call to PBD::ID::init as it is now done via ARDOUR::init
Tim Mayberry [Sat, 10 Aug 2013 02:07:39 +0000 (12:07 +1000)]
Remove call to PBD::ID::init as it is now done via ARDOUR::init

10 years agoCall setup_libpbd_enums in PBD::init for portability
Tim Mayberry [Fri, 26 Jul 2013 02:04:40 +0000 (12:04 +1000)]
Call setup_libpbd_enums in PBD::init for portability

10 years agoCall Gio::init from PBD::init instead of ARDOUR::init
Tim Mayberry [Fri, 9 Aug 2013 12:13:50 +0000 (22:13 +1000)]
Call Gio::init from PBD::init instead of ARDOUR::init

PBD needs Gio for PBD::copy_file and perhaps others

10 years agoCall PBD::init in ARDOUR::init and PBD::cleanup in ARDOUR::cleanup
Tim Mayberry [Fri, 9 Aug 2013 12:11:44 +0000 (22:11 +1000)]
Call PBD::init in ARDOUR::init and PBD::cleanup in ARDOUR::cleanup

10 years agoAdd PBD::init and PBD::cleanup
Tim Mayberry [Fri, 9 Aug 2013 12:03:39 +0000 (22:03 +1000)]
Add PBD::init and PBD::cleanup

A bit of refactoring to move initialization of libpbd into libpbd
rather than rely on "client" code(ui,libardour,tests etc) to do it

10 years agoMove initialization of libardour from ARDOUR_UI class into main()
Tim Mayberry [Fri, 9 Aug 2013 11:47:16 +0000 (21:47 +1000)]
Move initialization of libardour from ARDOUR_UI class into main()

10 years agoPrevent libardour from being initialized more than once
Tim Mayberry [Thu, 25 Jul 2013 11:38:59 +0000 (21:38 +1000)]
Prevent libardour from being initialized more than once

This is not thread safe of course, it is not intended to be.

This was implemented as at one stage ARDOUR::init was being called multiple
times in the testsuite which was causing a subtle bug that took some
time to track down.

10 years agoChange ARDOUR::init return type to bool type for success/failure
Tim Mayberry [Fri, 9 Aug 2013 10:41:58 +0000 (20:41 +1000)]
Change ARDOUR::init return type to bool type for success/failure

10 years agofix thinko in 5dee49e19
Robin Gareus [Sun, 11 Aug 2013 15:26:34 +0000 (17:26 +0200)]
fix thinko in 5dee49e19

10 years agofix 5dee49e19 (32/64 bit unsigned int compatibility)
Robin Gareus [Sun, 11 Aug 2013 15:19:04 +0000 (17:19 +0200)]
fix 5dee49e19 (32/64 bit unsigned int compatibility)

10 years agomake LV2 communication buffers independent from jack-midi buffer-size
Robin Gareus [Sun, 11 Aug 2013 13:10:41 +0000 (15:10 +0200)]
make LV2 communication buffers independent from jack-midi buffer-size

fixes issues with plugin communication that are common with
jack1 use due to its very small midi-buffers.

10 years agofix typos
Robin Gareus [Fri, 9 Aug 2013 17:35:27 +0000 (19:35 +0200)]
fix typos

10 years agoupdated monitor modes doc (new version from Chris with IDs)
Robin Gareus [Fri, 9 Aug 2013 17:34:32 +0000 (19:34 +0200)]
updated monitor modes doc (new version from Chris with IDs)

10 years agoMerge branch 'windows' of git.ardour.org:ardour/ardour into windows
John Emmas [Fri, 9 Aug 2013 17:04:04 +0000 (18:04 +0100)]
Merge branch 'windows' of git.ardour.org:ardour/ardour into windows

10 years ago'libs/ardour' - If the platform is Windows, prevent lengthy caching by flushing impor...
John Emmas [Fri, 9 Aug 2013 16:56:14 +0000 (17:56 +0100)]
'libs/ardour' - If the platform is Windows, prevent lengthy caching by flushing imported files on completion of the import

10 years ago'libs/ardour' - New files and changes needed for 'msvc_libardour'
John Emmas [Fri, 9 Aug 2013 16:53:37 +0000 (17:53 +0100)]
'libs/ardour' - New files and changes needed for 'msvc_libardour'

10 years ago'libs/ardour' - Correct an invalid buffer address (io.cc)
John Emmas [Fri, 9 Aug 2013 16:48:15 +0000 (17:48 +0100)]
'libs/ardour' - Correct an invalid buffer address (io.cc)

10 years ago'libs/ardour' - Minor change to an included header file (audiofile_tagger.cc)
John Emmas [Fri, 9 Aug 2013 16:46:51 +0000 (17:46 +0100)]
'libs/ardour' - Minor change to an included header file (audiofile_tagger.cc)

10 years agochanges to allow window branch to build on OS X
Paul Davis [Fri, 9 Aug 2013 13:17:03 +0000 (09:17 -0400)]
changes to allow window branch to build on OS X

10 years agoremove --no-freesound option. fixes #5640
Robin Gareus [Thu, 8 Aug 2013 18:08:20 +0000 (20:08 +0200)]
remove --no-freesound option. fixes #5640

10 years agonew Mackie Control device file for Qcon controller (from #5634)
Paul Davis [Thu, 8 Aug 2013 03:06:25 +0000 (23:06 -0400)]
new Mackie Control device file for Qcon controller (from #5634)

10 years agofix compiler warning
Robin Gareus [Wed, 7 Aug 2013 13:57:29 +0000 (15:57 +0200)]
fix compiler warning

10 years agouse std::numeric_limits<float>::infinity() rather than INFINITY to try to get compile...
Paul Davis [Wed, 7 Aug 2013 12:40:21 +0000 (08:40 -0400)]
use std::numeric_limits<float>::infinity() rather than INFINITY to try to get compilers to agree on the type

10 years agoMerge branch 'windows' of git.ardour.org:ardour/ardour into windows
John Emmas [Tue, 6 Aug 2013 14:18:27 +0000 (15:18 +0100)]
Merge branch 'windows' of git.ardour.org:ardour/ardour into windows

10 years agofix taglib header paths so linked headers are not necessary
ben [Tue, 6 Aug 2013 13:50:26 +0000 (08:50 -0500)]
fix taglib header paths so linked headers are not necessary

10 years ago'libs/ardour' - Platform specific changes and includes
John Emmas [Sun, 4 Aug 2013 18:03:32 +0000 (19:03 +0100)]
'libs/ardour' - Platform specific changes and includes

10 years agofix meter-background highlight when peaking. (> vs >=)
Robin Gareus [Sun, 4 Aug 2013 16:50:51 +0000 (18:50 +0200)]
fix meter-background highlight when peaking. (> vs >=)

10 years agofix rounding issue when dragging video with fractional fps
Robin Gareus [Sun, 4 Aug 2013 16:49:28 +0000 (18:49 +0200)]
fix rounding issue when dragging video with fractional fps

10 years ago'libs/ardour' - Compiler specific includes and includes
John Emmas [Sun, 4 Aug 2013 16:01:37 +0000 (17:01 +0100)]
'libs/ardour' - Compiler specific includes and includes

10 years agovtl: import audio at video-offset, forget offset on "Remove Video"
Robin Gareus [Sun, 4 Aug 2013 15:23:58 +0000 (17:23 +0200)]
vtl: import audio at video-offset, forget offset on "Remove Video"

10 years ago'libs/ardour' - Main body of changes required for building with MSVC
John Emmas [Sun, 4 Aug 2013 14:36:07 +0000 (15:36 +0100)]
'libs/ardour' - Main body of changes required for building with MSVC

10 years agoTimecode: fix subframe rounding
Robin Gareus [Sun, 4 Aug 2013 14:22:00 +0000 (16:22 +0200)]
Timecode: fix subframe rounding

if sub-frames are used, frames are rounded up for the later half of
a sub-frame.  e.g. @48KSPS, 25fps, 100 subframes per frame
audio-samples >=1910 already yield 00:00:00:01

10 years ago'libs/ardour' - Use 'std::vector' instead of dynamically sized arrays (required to...
John Emmas [Sun, 4 Aug 2013 14:17:19 +0000 (15:17 +0100)]
'libs/ardour' - Use 'std::vector' instead of dynamically sized arrays (required to be buildable with MSVC)

10 years agofix no-roll LTC encoder, honor locates when transport is stopped
Robin Gareus [Sun, 4 Aug 2013 14:13:43 +0000 (16:13 +0200)]
fix no-roll LTC encoder, honor locates when transport is stopped

10 years ago'libs/ardour' - Use 'const_iterator' where appropriate (required to be buildable...
John Emmas [Sun, 4 Aug 2013 14:06:10 +0000 (15:06 +0100)]
'libs/ardour' - Use 'const_iterator' where appropriate (required to be buildable with MSVC)

10 years agomake master-meter in toolbar optional
Robin Gareus [Sat, 3 Aug 2013 22:06:29 +0000 (00:06 +0200)]
make master-meter in toolbar optional

10 years agoadvance track's play-position even if processing is locked
Robin Gareus [Sat, 3 Aug 2013 19:35:19 +0000 (21:35 +0200)]
advance track's play-position even if processing is locked

fixes
  * http://tracker.ardour.org/view.php?id=5628
  * http://tracker.ardour.org/view.php?id=5561

10 years agodedicated namespace for video-utils
Robin Gareus [Sat, 3 Aug 2013 14:54:57 +0000 (16:54 +0200)]
dedicated namespace for video-utils

conflicting symbol prophylaxis

10 years agoremove strtok_r() from video_query_info()
Robin Gareus [Sat, 3 Aug 2013 14:41:25 +0000 (16:41 +0200)]
remove strtok_r() from video_query_info()

for minGW compatibility

10 years agoadd a peak reset button to the editor meter
Robin Gareus [Sat, 3 Aug 2013 11:59:22 +0000 (13:59 +0200)]
add a peak reset button to the editor meter

see http://tracker.ardour.org/view.php?id=5601

10 years agofix gtk "child->parent == NULL" asserts
Robin Gareus [Sat, 3 Aug 2013 11:45:27 +0000 (13:45 +0200)]
fix gtk "child->parent == NULL" asserts

10 years agoproperly handle port removal in route.
Robin Gareus [Sat, 3 Aug 2013 01:44:51 +0000 (03:44 +0200)]
properly handle port removal in route.

bug:
 - add midi track
 - add additional midi port
 - remove additional midi port
 - press play
 -> crash

because..

ARDOUR::MidiTrack::roll's route_buffer still has 2 midi-channels. This is
because processor_max_streams was not updated (no plugins added/removed)
fill_buffers_with_input() eventually asserts when trying to get the 2nd
(nonexistant) midi port via ARDOUR::PortSet::nth_midi_port() in
 ARDOUR::PortSet::port().

10 years agofix "other" port-group tab
Robin Gareus [Sat, 3 Aug 2013 00:46:08 +0000 (02:46 +0200)]
fix "other" port-group tab

Separate port-bundles for each jack client in the connection manager.

Previously, apps were only listed as separate bundles if the
ports were gathered at different times. ie one app shows up after
the other (and if no complete re-scan was triggered)

Fixes issue reported by Fons Adriaensen.

10 years agoMerge branch 'midiclock' of https://github.com/axetota/ardour
Robin Gareus [Fri, 2 Aug 2013 23:37:25 +0000 (01:37 +0200)]
Merge branch 'midiclock' of https://github.com/axetota/ardour

10 years agoSend and Read MIDI Positions the right way
Michael Fisher [Fri, 2 Aug 2013 23:23:36 +0000 (18:23 -0500)]
Send and Read MIDI Positions the right way

10 years agoon session-load: skip output-change-handler until IOs are restored
Robin Gareus [Fri, 2 Aug 2013 22:50:09 +0000 (00:50 +0200)]
on session-load: skip output-change-handler until IOs are restored

fixes loading a session with tracks that have more input-ports
than output-ports.

the problem:

input -ports are added first, when added, IO::ensure_port() emits
IOChange::ConfigurationChanged which in turn triggers the route to
allocate corresponding output ports.

Due to this callback the output-ports were created before the actual
output-port-configuration and plugin-configuration from the
session-state was parsed and set.

10 years agodisallow invalid port-removal
Robin Gareus [Fri, 2 Aug 2013 21:02:13 +0000 (23:02 +0200)]
disallow invalid port-removal

do not allow port-removal if the port would be re-added immediately
after that again because the main-delivery actually needs it.

As a side effect this prevents this crash:

 * create a stereo-track, then remove one output
  -> unhandled exception "AudioEngine::PortRegistrationFailure&"

 The problem:
 - the port is removed from the RCU ports list,
   but Port::drop() (which calls jack_port_unregister) is only called
   from the Port's destructor at some later time.
   (because a reference to the port still exists elsewhere)
 - the jack-port is not yet removed.
 - meanwhile Delivery::configure_io comes along and notices that
   there are more audio-buffers than ports and tries to re-register the port.
 - but the port still exists in jack, so it fails and throws an exception
   ...which is not handled.

10 years agoMerge branch 'master' into windows
Paul Davis [Fri, 2 Aug 2013 16:51:24 +0000 (12:51 -0400)]
Merge branch 'master' into windows

10 years agofix typos in display of error message about an LV2 plugin preset
Paul Davis [Fri, 2 Aug 2013 16:50:52 +0000 (12:50 -0400)]
fix typos in display of error message about an LV2 plugin preset