Remove Automatable::value_as_string API from libardour

Keep Pannable::value_as_string() for now. That is another inconsistency
which needs cleaning up. GUI StereoPanner and MonoPanner print
the value as they see fit, the panner-plugin provided formatting
is not used.

diff --git a/libs/ardour/amp.cc b/libs/ardour/amp.cc
index d7b901434069f3a221af9ae4c4a1d96b2cb1f6f1..8760c2d42663991993ca073bbb1140eb678a00b6 100644 (file)
--- a/libs/ardour/amp.cc
+++ b/libs/ardour/amp.cc
@@ -411,18 +411,6 @@ Amp::visible() const
        return true;
 }
 
-std::string
-Amp::value_as_string (boost::shared_ptr<const AutomationControl> ac) const
-{
-       if (ac == _gain_control) {
-               char buffer[32];
-               snprintf (buffer, sizeof (buffer), _("%.2fdB"), ac->internal_to_user (ac->get_value ()));
-               return buffer;
-       }
-
-       return Automatable::value_as_string (ac);
-}
-
 /** Sets up the buffer that setup_gain_automation and ::run will use for
  *  gain automationc curves.  Must be called before setup_gain_automation,
  *  and must be called with process lock held.

diff --git a/libs/ardour/ardour/amp.h b/libs/ardour/ardour/amp.h
index 820e2a85e1e9e80f1ce4468900f8a278e0d8e463..d07f860599218081af726c6620a104526d09c490 100644 (file)
--- a/libs/ardour/ardour/amp.h
+++ b/libs/ardour/ardour/amp.h
@@ -79,8 +79,6 @@ public:
                return _gain_control;
        }
 
-       std::string value_as_string (boost::shared_ptr<const AutomationControl>) const;
-
 private:
        bool   _denormal_protection;
        bool   _apply_gain;

diff --git a/libs/ardour/ardour/automatable.h b/libs/ardour/ardour/automatable.h
index 4e7c11d51c5e37d46cacfc0b8b64970cd5c33eaa..f23948412f768404d6090cfb8345f3bf06031014 100644 (file)
--- a/libs/ardour/ardour/automatable.h
+++ b/libs/ardour/ardour/automatable.h
@@ -87,7 +87,6 @@ public:
        virtual void transport_stopped (framepos_t now);
 
        virtual std::string describe_parameter(Evoral::Parameter param);
-       virtual std::string value_as_string (boost::shared_ptr<const AutomationControl>) const;
 
        AutoState get_parameter_automation_state (Evoral::Parameter param);
        virtual void set_parameter_automation_state (Evoral::Parameter param, AutoState);

diff --git a/libs/ardour/ardour/send.h b/libs/ardour/ardour/send.h
index f70f09b6ead3af518c376366aa2da867c180d2ba..002397f0cd139ac3500ee9a2f636f0c854982272 100644 (file)
--- a/libs/ardour/ardour/send.h
+++ b/libs/ardour/ardour/send.h
@@ -77,8 +77,6 @@ class LIBARDOUR_API Send : public Delivery
 
        bool set_name (const std::string& str);
 
-       std::string value_as_string (boost::shared_ptr<const AutomationControl>) const;
-
        static uint32_t how_many_sends();
        static std::string name_and_id_new_send (Session&, Delivery::Role r, uint32_t&, bool);
 

diff --git a/libs/ardour/automatable.cc b/libs/ardour/automatable.cc
index 462f4f29748065fcce4bcfb4ecb39237e86245f9..d10fafdeb142cdd61392b7a8ca1d868bc3471d1e 100644 (file)
--- a/libs/ardour/automatable.cc
+++ b/libs/ardour/automatable.cc
@@ -542,12 +542,6 @@ Automatable::clear_controls ()
        ControlSet::clear_controls ();
 }
 
-string
-Automatable::value_as_string (boost::shared_ptr<const AutomationControl> ac) const
-{
-       return ARDOUR::value_as_string(ac->desc(), ac->get_value());
-}
-
 bool
 Automatable::find_next_event (double now, double end, Evoral::ControlEvent& next_event, bool only_active) const
 {

diff --git a/libs/ardour/send.cc b/libs/ardour/send.cc
index 13d8056d6d2a047e34e1e5903a373b591d787bb8..b9b3efa8b1a58de3674c56fe2d7ebc953077b278 100644 (file)
--- a/libs/ardour/send.cc
+++ b/libs/ardour/send.cc
@@ -404,12 +404,6 @@ Send::display_to_user () const
        return true;
 }
 
-string
-Send::value_as_string (boost::shared_ptr<const AutomationControl> ac) const
-{
-       return _amp->value_as_string (ac);
-}
-
 void
 Send::snd_output_changed (IOChange change, void* /*src*/)
 {