Remove unnecessary 0 checks before delete; see http://www.parashift.com/c++-faq-lite...
authorCarl Hetherington <carl@carlh.net>
Thu, 18 Dec 2008 19:31:00 +0000 (19:31 +0000)
committerCarl Hetherington <carl@carlh.net>
Thu, 18 Dec 2008 19:31:00 +0000 (19:31 +0000)
git-svn-id: svn://localhost/ardour2/branches/3.0@4332 d708f5d6-7413-0410-9779-e7cbd77b26cf

54 files changed:
gtk2_ardour/ardour_ui.cc
gtk2_ardour/audio_region_view.cc
gtk2_ardour/canvas-flag.cc
gtk2_ardour/canvas-note-event.cc
gtk2_ardour/editor.cc
gtk2_ardour/editor_markers.cc
gtk2_ardour/editor_mixer.cc
gtk2_ardour/editor_ops.cc
gtk2_ardour/editor_tempodisplay.cc
gtk2_ardour/editor_timefx.cc
gtk2_ardour/imageframe_time_axis.cc
gtk2_ardour/imageframe_view.cc
gtk2_ardour/level_meter.cc
gtk2_ardour/marker.cc
gtk2_ardour/marker_time_axis_view.cc
gtk2_ardour/mixer_strip.cc
gtk2_ardour/panner_ui.cc
gtk2_ardour/plugin_eq_gui.cc
gtk2_ardour/port_matrix.cc
gtk2_ardour/region_view.cc
gtk2_ardour/rhythm_ferret.cc
gtk2_ardour/route_time_axis.cc
gtk2_ardour/route_ui.cc
gtk2_ardour/sfdb_ui.cc
gtk2_ardour/time_axis_view.cc
libs/ardour/audio_diskstream.cc
libs/ardour/audio_port.cc
libs/ardour/audioanalyser.cc
libs/ardour/audiosource.cc
libs/ardour/base_audio_port.cc
libs/ardour/base_midi_port.cc
libs/ardour/crossfade.cc
libs/ardour/export_channel.cc
libs/ardour/export_preset.cc
libs/ardour/export_utilities.cc
libs/ardour/ladspa_plugin.cc
libs/ardour/location_importer.cc
libs/ardour/lv2_plugin.cc
libs/ardour/midi_port.cc
libs/ardour/rb_effect.cc
libs/ardour/region.cc
libs/ardour/reverse.cc
libs/ardour/route.cc
libs/ardour/session.cc
libs/ardour/session_click.cc
libs/ardour/session_state.cc
libs/ardour/session_transport.cc
libs/ardour/sndfilesource.cc
libs/ardour/st_stretch.cc
libs/pbd/pool.cc
libs/pbd/stateful.cc
libs/pbd/xml++.cc
libs/surfaces/generic_midi/generic_midi_control_protocol.cc
libs/surfaces/mackie/mackie_control_protocol_poll.cc

index 3376d1c8da6b004d1b4cc31a2bf95c8f3e9552c8..c1cab8d55103900e1c13d6756786aa29c5e57c2a 100644 (file)
@@ -396,26 +396,11 @@ ARDOUR_UI::~ARDOUR_UI ()
 {
        save_ardour_state ();
 
-       if (keyboard) {
-               delete keyboard;
-       }
-
-       if (editor) {
-               delete editor;
-       }
-
-       if (mixer) {
-               delete mixer;
-       }
-
-       if (add_route_dialog) {
-               delete add_route_dialog;
-       }
-
-
-       if (new_session_dialog) {
-               delete new_session_dialog;
-       }
+       delete keyboard;
+       delete editor;
+       delete mixer;
+       delete add_route_dialog;
+       delete new_session_dialog;
 }
 
 void
index e3dd980eee93f8b3d4e4b94aa8c3de086eeaa3bc..35407603fe97d454da611c9d725d3fcadc96571f 100644 (file)
@@ -251,9 +251,7 @@ AudioRegionView::~AudioRegionView ()
 
        /* all waveviews etc will be destroyed when the group is destroyed */
 
-       if (gain_line) {
-               delete gain_line;
-       }
+       delete gain_line;
 }
 
 boost::shared_ptr<ARDOUR::AudioRegion>
index a4eee41227f5d17e4be195a0bc51f8976fbe8ca5..df23b83d714111cda745b0e93f8370cb36521c21 100644 (file)
@@ -9,20 +9,14 @@ using namespace std;
 void 
 CanvasFlag::delete_allocated_objects()
 {
-       if (_text) {
-               delete _text;
-               _text = 0;
-       }
-       
-       if (_line) {
-               delete _line;
-               _line = 0;
-       }
-       
-       if (_rect) {
-               delete _rect;
-               _rect = 0;
-       }
+       delete _text;
+       _text = 0;
+
+       delete _line;
+       _line = 0;
+
+       delete _rect;
+       _rect = 0;
 }
 
 void 
index 2ea18315f570a04369fcb7b305f2a7d91e64cff2..85740063694d476561a024454603fe8ed07f4e68 100644 (file)
@@ -50,8 +50,7 @@ CanvasNoteEvent::~CanvasNoteEvent()
                delete _text;
        }
        
-       if (_channel_selector_widget)
-               delete _channel_selector_widget;
+       delete _channel_selector_widget;
 }
 
 void 
index 6f7a5eb13294338b0161f37bea82cacbd35defc5..634f1fd2be4d880fefc7c64bf7ed9d48cca4c2ef 100644 (file)
@@ -885,10 +885,8 @@ Editor::~Editor()
        }
 #endif
 
-       if (track_canvas) {
-               delete track_canvas;
-               track_canvas = 0;
-       }
+       delete track_canvas;
+       track_canvas = 0;
 }
 
 void
@@ -5141,9 +5139,7 @@ Editor::first_idle ()
        // first idle adds route children (automation tracks), so we need to redisplay here
        redisplay_route_list();
        
-       if (dialog) {
-               delete dialog;
-       }
+       delete dialog;
 
        _have_idled = true;
 }
index 352eb260408b7d8a0442e297e260b90086e714df..0504c08095a52cab0a917a1f6c6625721e38e2d5 100644 (file)
@@ -247,13 +247,8 @@ void Editor::ensure_cd_marker_updated (LocationMarkers * lam, Location * locatio
 
 Editor::LocationMarkers::~LocationMarkers ()
 {
-       if (start) {
-               delete start;
-       }
-
-       if (end) {
-               delete end;
-       }
+       delete start;
+       delete end;
 }
 
 Editor::LocationMarkers *
index bf8aca105ef4da5aa7af236972e0a871cbeddc2b..7f6031ed92fa6fabb8444f0c55a2bf1af24f15d2 100644 (file)
@@ -400,10 +400,8 @@ Editor::session_going_away ()
        hide_measures ();
        clear_marker_display ();
 
-       if (current_bbt_points) {
-               delete current_bbt_points;
-               current_bbt_points = 0;
-       }
+       delete current_bbt_points;
+       current_bbt_points = 0;
 
        /* mixer strip will be deleted all by itself 
           when its route is deleted.
index a5dfb6b08e4f6c116c9722f0907d1922d8c279e8..3634d468a17b9273ba58ef10aed111bdeabe02f3 100644 (file)
@@ -6280,9 +6280,7 @@ Editor::save_visual_state (uint32_t n)
                visual_states.push_back (0);
        }
 
-       if (visual_states[n] != 0) {
-               delete visual_states[n];
-       }
+       delete visual_states[n];
 
        visual_states[n] = current_visual_state (true);
        gdk_beep ();
index ec3cf30b4500e25112d76be90b5964f631ba3bf6..9bef055b57aec7e3e33d8c0f3b4c756fdd270969 100644 (file)
@@ -160,10 +160,8 @@ Editor::compute_current_bbt_points (nframes_t leftmost, nframes_t rightmost)
        }
        next_beat.ticks = 0;
        
-       if (current_bbt_points) {
-               delete current_bbt_points;
-               current_bbt_points = 0;
-       }
+       delete current_bbt_points;
+       current_bbt_points = 0;
 
        current_bbt_points = session->tempo_map().get_points (session->tempo_map().frame_time (previous_beat), session->tempo_map().frame_time (next_beat) + 1);
 }
index 3dda9e87e9dff431d1aa1a7feacaf31a3dae78cc..8192085e96222a9288a5663702d862b8316d75d7 100644 (file)
@@ -227,9 +227,7 @@ Editor::pitch_shift (RegionSelection& regions, float fraction)
 int
 Editor::time_fx (RegionSelection& regions, float val, bool pitching)
 {
-       if (current_timefx != 0) {
-               delete current_timefx;
-       }
+       delete current_timefx;
 
        current_timefx = new TimeFXDialog (*this, pitching);
 
index f3630e715262830ff877b0fc2e8a1cee2a0164c0..735855421fd347c0c6de3569741efbe992725228 100644 (file)
@@ -107,24 +107,15 @@ ImageFrameTimeAxis::~ImageFrameTimeAxis ()
                iter = next ;
        }
        
-       if(image_action_menu)
-       {
-               delete image_action_menu ;
-               image_action_menu = 0 ;
-       }
+       delete image_action_menu ;
+       image_action_menu = 0 ;
        
-       if (selection_group)
-       {
-               delete selection_group;
-               selection_group = 0 ;
-       }
+       delete selection_group;
+       selection_group = 0 ;
        
        // Destroy our Axis View helper
-       if(view)
-       {
-               delete view ;
-               view = 0 ;
-       }
+       delete view ;
+       view = 0 ;
 }
 
 //---------------------------------------------------------------------------------------//
index f35381301e238d4bf43228ff5fd935581b285fcd..27e75e27331c469bd8af2f1e9b65fe35744335f5 100644 (file)
@@ -152,11 +152,8 @@ ImageFrameView::~ImageFrameView()
                }
        }
 
-       if(imageframe)
-       {
-delete imageframe;
-               imageframe = 0 ;
-       }
+       delete imageframe;
+       imageframe = 0 ;
 }
 
 
index cd7308cfa26111205f4bbdf39167dacc3ef1e9b8..f7b44d1b0861778bb57a9834f45a086200486900 100644 (file)
@@ -78,9 +78,7 @@ LevelMeter::on_theme_changed()
 LevelMeter::~LevelMeter ()
 {
        for (vector<MeterInfo>::iterator i = meters.begin(); i != meters.end(); i++) {
-               if ((*i).meter) {
-                       delete (*i).meter;
-               }
+               delete (*i).meter;
        }
 }
 
index 9e77d0c9e733e10c24021ab2827de3b8edd80ecd..e3330c41fb8b5bae0756d3472c26c564d2b08d06 100644 (file)
@@ -283,10 +283,8 @@ Marker::~Marker ()
        delete mark;
        delete points;
 
-       if (line) {
-               delete line;
-               line = 0;
-       }
+       delete line;
+       line = 0;
 }
 
 void Marker::reparent(ArdourCanvas::Group & parent)
index d10ec4dae91fdc658ba231b4ec01d05649a402be..e9a15fb5a5c732a4dd771b3be35fbe1220217f32 100644 (file)
@@ -91,17 +91,11 @@ MarkerTimeAxisView::~MarkerTimeAxisView()
                iter = next ;
        }
        
-       if(canvas_rect)
-       {
-               delete canvas_rect;
-               canvas_rect = 0 ;
-       }
-       
-       if(canvas_group)
-       {
-               delete canvas_group;
-               canvas_group = 0 ;
-       }
+       delete canvas_rect;
+       canvas_rect = 0 ;
+
+       delete canvas_group;
+       canvas_group = 0 ;
 }
 
 
index 68b53da86c32f5025bb8009a6f695232fe82d574..6c006d7e249e3b0e752ffb71daccf551d4a62a77 100644 (file)
@@ -323,15 +323,11 @@ MixerStrip::set_route (boost::shared_ptr<Route> rt)
 
        RouteUI::set_route (rt);
 
-       if (input_selector) {
-               delete input_selector;
-               input_selector = 0;
-       }
+       delete input_selector;
+       input_selector = 0;
 
-       if (output_selector) {
-               delete output_selector;
-               output_selector = 0;
-       }
+       delete output_selector;
+       output_selector = 0;
 
        panners.set_io (rt);
        gpm.set_io (rt);
index ed1e84f29bc58d967aabdc11de649b9a7f003c6a..728dfcbcfe246b66abf359ab4e92c67f07782b88 100644 (file)
@@ -134,15 +134,11 @@ PannerUI::set_io (boost::shared_ptr<IO> io)
 {
        connections.clear ();
        
-       if (pan_astyle_menu) {
-               delete pan_astyle_menu;
-               pan_astyle_menu = 0;
-       }
-       if (pan_astate_menu) {
-               delete pan_astate_menu;
-               pan_astate_menu = 0;
-       }
+       delete pan_astyle_menu;
+       pan_astyle_menu = 0;
+
+       delete pan_astate_menu;
+       pan_astate_menu = 0;
                        
        _io = io;
  
@@ -150,10 +146,8 @@ PannerUI::set_io (boost::shared_ptr<IO> io)
        connections.push_back (_io->panner().LinkStateChanged.connect (mem_fun(*this, &PannerUI::update_pan_linkage)));
        connections.push_back (_io->panner().StateChanged.connect (mem_fun(*this, &PannerUI::update_pan_state)));
  
-       if (panner) {
-               delete panner;
-               panner = 0;
-       }
+       delete panner;
+       panner = 0;
  
        setup_pan ();
 
@@ -305,25 +299,11 @@ PannerUI::~PannerUI ()
                delete (*i);
        }
 
-       if (panner) {
-               delete panner;
-       }
-
-       if (big_window) {
-               delete big_window;
-       }
-       
-       if (pan_menu) {
-               delete pan_menu;
-       }
-       
-       if (pan_astyle_menu) {
-               delete pan_astyle_menu;
-       }
-       
-       if (pan_astate_menu) {
-               delete pan_astate_menu;
-       }
+       delete panner;
+       delete big_window;
+       delete pan_menu;
+       delete pan_astyle_menu;
+       delete pan_astate_menu;
 }
 
 
index 307503fc8bff650313fc86e826ffd3874ad17ac2..34b77888194ae7088aa0cc51f536b8b7ef6d20b3 100644 (file)
@@ -231,9 +231,9 @@ PluginEqGui::set_buffer_size(uint32_t size, uint32_t signal_size)
                throw;
        }
 
-       if (tmp1) delete tmp1;
-       if (tmp2) delete tmp1;
-       if (tmp3) delete tmp1;
+       delete tmp1;
+       delete tmp2;
+       delete tmp3;
                
        _buffer_size = size;
        _signal_buffer_size = signal_size;
index c2bb01691b2008588e06db99bf391e70c484fce4..5b259e79cfb4a37deddfefbc145d2c4133452d4d 100644 (file)
@@ -169,10 +169,8 @@ PortMatrix::clear ()
        
        _side_vbox.children().clear ();
 
-       if (_side_vbox_pad) {
-               delete _side_vbox_pad;
-               _side_vbox_pad = 0;
-       }
+       delete _side_vbox_pad;
+       _side_vbox_pad = 0;
 
        for (std::vector<PortGroupUI*>::iterator i = _port_group_ui.begin(); i != _port_group_ui.end(); ++i) {
                _visibility_checkbutton_box.remove ((*i)->get_visibility_checkbutton());
index ec6d0dcefc1c3a8c41514ae8229398360cd68ebe..419ee9b606ccf2bed016f18cae64e42cb3c65cde 100644 (file)
@@ -179,9 +179,7 @@ RegionView::~RegionView ()
                delete *g;
        }
 
-       if (editor) {
-               delete editor;
-       }
+       delete editor;
 }
 
 gint
index 4a4f3d4ec477a367cdf2497c40c53c73c7856485..6c0ee05fd92bdc98c91ac25cb6015035def6f5a2 100644 (file)
@@ -181,9 +181,7 @@ RhythmFerret::RhythmFerret (PublicEditor& e)
 
 RhythmFerret::~RhythmFerret()
 {
-       if (logo) {
-               delete logo;
-       }
+       delete logo;
 }
 
 void
index 431017aff981978e4c9713c5bdbf3f98d45498e5..09683f314c6bdad4c93b98ee2503f6b947ec8f8d 100644 (file)
@@ -256,20 +256,14 @@ RouteTimeAxisView::~RouteTimeAxisView ()
                delete *i;
        }
 
-       if (playlist_menu) {
-               delete playlist_menu;
-               playlist_menu = 0;
-       }
+       delete playlist_menu;
+       playlist_menu = 0;
   
-       if (playlist_action_menu) {
-               delete playlist_action_menu;
-               playlist_action_menu = 0;
-       }
+       delete playlist_action_menu;
+       playlist_action_menu = 0;
 
-       if (_view) {
-               delete _view;
-               _view = 0;
-       }
+       delete _view;
+       _view = 0;
 
        for (AutomationTracks::iterator i = _automation_tracks.begin(); i != _automation_tracks.end(); ++i) {
                delete i->second;
@@ -395,10 +389,8 @@ void
 RouteTimeAxisView::playlist_click ()
 {
        // always build a new action menu
-       
-       if (playlist_action_menu != 0) {
-               delete playlist_action_menu;
-       } 
+  
+       delete playlist_action_menu;
 
        playlist_action_menu = new Menu;
        playlist_action_menu->set_name ("ArdourContextMenu");
@@ -473,8 +465,7 @@ RouteTimeAxisView::build_automation_action_menu ()
 
                automation_items.push_back (SeparatorElem());
 
-               if (i->second->menu_item)
-                       delete i->second->menu_item;
+               delete i->second->menu_item;
 
                automation_items.push_back(CheckMenuElem (_route->describe_parameter(i->second->param), 
                                bind (mem_fun(*this, &RouteTimeAxisView::toggle_automation_track), i->second->param)));
@@ -1477,9 +1468,7 @@ RouteTimeAxisView::build_playlist_menu (Gtk::Menu * menu)
        menu->set_name ("ArdourContextMenu");
        playlist_items.clear();
 
-       if (playlist_menu) {
-               delete playlist_menu;
-       }
+       delete playlist_menu;
 
        playlist_menu = new Menu;
        playlist_menu->set_name ("ArdourContextMenu");
index c53e205b495041491f820a276815f48cdc1aeb24..cefe2ac517e4c84b72c860ef8021de5e735f4a47 100644 (file)
@@ -120,15 +120,11 @@ RouteUI::reset ()
 {
        connections.clear ();
 
-       if (solo_menu) {
-               delete solo_menu;
-               solo_menu = 0;
-       }
+       delete solo_menu;
+       solo_menu = 0;
 
-       if (mute_menu) {
-               delete mute_menu;
-               mute_menu = 0;
-       }
+       delete mute_menu;
+       mute_menu = 0;
        
        if (xml_node) {
                /* do not delete the node - its owned by the route */
index 799e74898b413c316bf219f500de613a6d2a545e..a3b3a52925659bd84f594a21a5fe79a185644e47 100644 (file)
@@ -592,9 +592,7 @@ SoundFileBrowser::set_session (Session* s)
 void
 SoundFileBrowser::add_gain_meter ()
 {
-       if (gm) {
-               delete gm;
-       }
+       delete gm;
 
        gm = new GainMeter (*session);
        gm->set_io (session->the_auditioner());
index 7da878b9f358818e5f3730bd7e775948e0bf1b1a..97758765b6558242b606f3c18b38e8084d8a8cfc 100644 (file)
                 delete (*i);
         }
 
-        if (selection_group) {
-                delete selection_group;
-                selection_group = 0;
-        }
+        delete selection_group;
+        selection_group = 0;
 
-        if (canvas_background) {
-                delete canvas_background;
-                canvas_background = 0;
-        }
+        delete canvas_background;
+        canvas_background = 0;
 
-        if (canvas_display) {
-                delete canvas_display;
-                canvas_display = 0;
-        }
+        delete canvas_display;
+        canvas_display = 0;
 
-        if (display_menu) {
-                delete display_menu;
-                display_menu = 0;
-        }
+        delete display_menu;
+        display_menu = 0;
  }
 
  guint32
index 4cf834b5c14deb86198373ef1d0ad2298aeb1557..8ba1825759de5ba8f59cf83427625e2843655e20 100644 (file)
@@ -2470,33 +2470,21 @@ AudioDiskstream::ChannelInfo::~ChannelInfo ()
                write_source.reset ();
        }
                
-       if (speed_buffer) {
-               delete [] speed_buffer;
-               speed_buffer = 0;
-       }
+       delete [] speed_buffer;
+       speed_buffer = 0;
 
-       if (playback_wrap_buffer) {
-               delete [] playback_wrap_buffer;
-               playback_wrap_buffer = 0;
-       }
+       delete [] playback_wrap_buffer;
+       playback_wrap_buffer = 0;
 
-       if (capture_wrap_buffer) {
-               delete [] capture_wrap_buffer;
-               capture_wrap_buffer = 0;
-       }
+       delete [] capture_wrap_buffer;
+       capture_wrap_buffer = 0;
        
-       if (playback_buf) {
-               delete playback_buf;
-               playback_buf = 0;
-       }
+       delete playback_buf;
+       playback_buf = 0;
 
-       if (capture_buf) {
-               delete capture_buf;
-               capture_buf = 0;
-       }
+       delete capture_buf;
+       capture_buf = 0;
 
-       if (capture_transition_buf) {
-               delete capture_transition_buf;
-               capture_transition_buf = 0;
-       }
+       delete capture_transition_buf;
+       capture_transition_buf = 0;
 }
index 0e37313d018a175f42a5c37c13d7f870a35617a5..7e57a734b8cf60e3d28a257c410cb2944572a233 100644 (file)
@@ -68,10 +68,8 @@ AudioPort::AudioPort (const std::string& name, Flags flags, bool external, nfram
 
 AudioPort::~AudioPort()
 {
-       if (_ext_port) {
-               delete _ext_port;
-               _ext_port = 0;
-       }
+       delete _ext_port;
+       _ext_port = 0;
 }
 
 void
index ab3691d8d15b98f9bc6a60993859677332e3068a..dcbd2847feafd5bda68a2d2b718f04e58739dba2 100644 (file)
@@ -159,9 +159,7 @@ AudioAnalyser::analyse (const string& path, Readable* src, uint32_t channel)
                g_rename (tmp_path.c_str(), path.c_str());
        }
 
-       if (data) {
-               delete [] data;
-       }
+       delete [] data;
 
        return ret;
 }
index 8e68b315877e0b87e0499db9f6bcc5e8113a947e..b8366e0ac038a70e1d92e8fed326b57ed7a93cde 100644 (file)
@@ -97,9 +97,7 @@ AudioSource::~AudioSource ()
                ::close (peakfile);
        }
 
-       if (peak_leftovers) {
-               delete [] peak_leftovers;
-       }
+       delete [] peak_leftovers;
 }
 
 XMLNode&
@@ -573,13 +571,8 @@ AudioSource::read_peaks_with_fpp (PeakData *peaks, nframes_t npeaks, nframes_t s
                close (_peakfile);
        }
 
-       if (staging) {
-               delete [] staging;
-       } 
-
-       if (raw_staging) {
-               delete [] raw_staging;
-       }
+       delete [] staging;
+       delete [] raw_staging;
 
 #ifdef DEBUG_READ_PEAKS
        cerr << "RP DONE\n";
@@ -656,9 +649,7 @@ AudioSource::build_peaks_from_scratch ()
                unlink (peakpath.c_str());
        }
 
-       if (buf) {
-               delete [] buf;
-       }
+       delete [] buf;
 
        return ret;
 }
@@ -862,9 +853,8 @@ AudioSource::compute_and_write_peaks (Sample* buf, nframes_t first_frame, nframe
 
   out:
        delete [] peakbuf;
-       if (buf2) {
-               delete [] buf2;
-       }
+       delete [] buf2;
+
        return ret;
 }
 
index 0675a4c99288f5b2410c8a64be1897f423e03eb2..7110102db3da47e7de300db9ae8e715f932a30c6 100644 (file)
@@ -39,7 +39,7 @@ BaseAudioPort::BaseAudioPort (const std::string& name, Flags flgs)
 
 BaseAudioPort::~BaseAudioPort ()
 {
-       if (_own_buffer && _buffer) {
+       if (_own_buffer) {
                delete _buffer;
        }
 }
index d679c7c04f7e66fc6845ea02aff9100e967c172a..0ba4b7c7b25c2ccac6cd26c6284b147fa6b5bc1c 100644 (file)
@@ -36,7 +36,7 @@ BaseMidiPort::BaseMidiPort (const std::string& name, Flags flags)
 
 BaseMidiPort::~BaseMidiPort()
 {
-       if (_own_buffer && _buffer) {
+       if (_own_buffer) {
                delete _buffer;
        }
 }
index 3a7b525db6ab48c367d314b8263b659c75f9e371..70790787c36b36241b36385bfe586c96e6d7c973 100644 (file)
@@ -51,15 +51,11 @@ Sample* Crossfade::crossfade_buffer_in = 0;
 void
 Crossfade::set_buffer_size (nframes_t sz)
 {
-       if (crossfade_buffer_out) {
-               delete [] crossfade_buffer_out;
-               crossfade_buffer_out = 0;
-       }
+       delete [] crossfade_buffer_out;
+       crossfade_buffer_out = 0;
 
-       if (crossfade_buffer_in) {
-               delete [] crossfade_buffer_in;
-               crossfade_buffer_in = 0;
-       }
+       delete [] crossfade_buffer_in;
+       crossfade_buffer_in = 0;
 
        if (sz) {
                crossfade_buffer_out = new Sample[sz];
index 094d6f910409ac783412bddfb4112c1334355bde..865c8fbf3b50353cdc049a405200d2be45af2170 100644 (file)
@@ -113,13 +113,8 @@ RegionExportChannelFactory::RegionExportChannelFactory (Session * session, Audio
 
 RegionExportChannelFactory::~RegionExportChannelFactory ()
 {
-       if (mixdown_buffer) {
-               delete[] mixdown_buffer;
-       }
-       
-       if (gain_buffer) {
-               delete[] gain_buffer;
-       }
+       delete[] mixdown_buffer;
+       delete[] gain_buffer;
 }
 
 ExportChannelPtr
index 1c19cae513314ad32d396b6f86a35eb4942ea764..69c5775d121b0a9ac06084282763ee58a4119138 100644 (file)
@@ -47,9 +47,7 @@ ExportPreset::ExportPreset (string filename, Session & s) :
 
 ExportPreset::~ExportPreset ()
 {
-       if (local) {
-               delete local;
-       }
+       delete local;
 }
 
 void
index aee5fa21ac785a1c1bbef5560987eb9855669bfe..a15a1107310e89660da816bd2906b756a755d090 100644 (file)
@@ -84,9 +84,9 @@ SampleRateConverter::~SampleRateConverter ()
        if (src_state) {
                src_delete (src_state);
        }
-       if (data_out) {
-               delete [] data_out;
-       }
+
+       delete [] data_out;
+
        if (leftover_data) {
                free (leftover_data);
        }
@@ -105,9 +105,8 @@ SampleRateConverter::process (float * data, nframes_t frames)
        nframes_t out_samples_max = (nframes_t) ceil (frames * src_data.src_ratio * channels);
        if (data_out_size < out_samples_max) {
 
-               if (data_out) {
-                       delete[] data_out;
-               }
+               delete[] data_out;
+
                data_out = new float[out_samples_max];
                src_data.data_out = data_out;
                
@@ -233,9 +232,8 @@ SampleFormatConverter<TOut>::~SampleFormatConverter ()
        if (dither) {
                gdither_free (dither);
        }
-       if (data_out) {
-               delete[] data_out;
-       }
+
+       delete[] data_out;
 }
 
 template <typename TOut>
@@ -246,9 +244,9 @@ SampleFormatConverter<TOut>::process (float * data, nframes_t frames)
        
        size_t data_size = channels * frames * sizeof (TOut);
        if (data_size  > data_out_size) {
-               if (data_out) {
-                       delete[] data_out;
-               }
+
+               delete[] data_out;
+
                data_out = new TOut[data_size];
                data_out_size = data_size;
        }
index 66c6be871b52543afa63c79f6e0d0db47ab6b545..07bb5ceada7a7e70d4afece7f9a0fc6a03ae4332 100644 (file)
@@ -149,13 +149,8 @@ LadspaPlugin::~LadspaPlugin ()
 
         // dlclose (module);
 
-       if (_control_data) {
-               delete [] _control_data;
-       }
-
-       if (_shadow_data) {
-               delete [] _shadow_data;
-       }
+       delete [] _control_data;
+       delete [] _shadow_data;
 }
 
 string
index f321c1d2cb12bf02e894ebf309a5ec5eea185e18..58a6e72f16e05a37d853f92b470d657c8545cf58 100644 (file)
@@ -95,7 +95,7 @@ LocationImporter::LocationImporter (XMLTree const & source, Session & session, L
 
 LocationImporter::~LocationImporter ()
 {
-       if (!queued() && location) {
+       if (!queued()) {
                delete location;
        }
 }
@@ -178,10 +178,8 @@ LocationImporter::_prepare_move ()
 void
 LocationImporter::_cancel_move ()
 {      
-       if (location) {
-               delete location;
-               location = 0;
-       }
+       delete location;
+       location = 0;
 }
 
 void
index 3b0a61b4f0c184d84ec319bc0e93f9711d2ce03e..4d6938fc01dfbf9e31d00dc2469e44575eb66740 100644 (file)
@@ -165,13 +165,8 @@ LV2Plugin::~LV2Plugin ()
        slv2_value_free(_name);
        slv2_value_free(_author);
 
-       if (_control_data) {
-               delete [] _control_data;
-       }
-
-       if (_shadow_data) {
-               delete [] _shadow_data;
-       }
+       delete [] _control_data;
+       delete [] _shadow_data;
 }
 
 string
index 779d31724760b345867f9b833899014332bf0269..93ea3b7c60bcf8b7d96105619f76cfa9431fd8d5 100644 (file)
@@ -52,10 +52,8 @@ MidiPort::MidiPort (const std::string& name, Flags flags, bool external, nframes
 
 MidiPort::~MidiPort()
 {
-       if (_ext_port) {
-               delete _ext_port;
-               _ext_port = 0;
-       }
+       delete _ext_port;
+       _ext_port = 0;
 }
 
 void
index a1dce0497f916831ae6078a1b83f8571b371c7f4..063821e8964189f54d464fbc9261d9e385bb0178 100644 (file)
@@ -358,9 +358,7 @@ RBEffect::run (boost::shared_ptr<Region> r)
 
   out:
 
-       if (gain_buffer) {
-               delete [] gain_buffer;
-       }
+       delete [] gain_buffer;
 
        if (buffers) {
                for (uint32_t i = 0; i < channels; ++i) {
index 637552766438df48334d72a422cd74a1ea20a6c9..da3564552a397f1e0391729a912fe8a97de1995f 100644 (file)
@@ -1338,10 +1338,8 @@ Region::set_live_state (const XMLNode& node, Change& what_changed, bool send)
 
        /* note: derived classes set flags */
 
-       if (_extra_xml) {
-               delete _extra_xml;
-               _extra_xml = 0;
-       }
+       delete _extra_xml;
+       _extra_xml = 0;
 
        for (XMLNodeConstIterator niter = nlist.begin(); niter != nlist.end(); ++niter) {
                
index 9c15b1e4d970f99c8749bbdfcbd99c12316e7282..6d838bf9120558f739645a21eeb308a050b09100 100644 (file)
@@ -116,9 +116,7 @@ Reverse::run (boost::shared_ptr<Region> r)
 
   out:
 
-       if (buf) {
-               delete [] buf;
-       }
+       delete [] buf;
 
        if (ret) {
                for (si = nsrcs.begin(); si != nsrcs.end(); ++si) {
index 4b96dc8a93a0750c5fd05ea320125e4e513760f1..26dde851c6e44e7edaa21b642069d00ff4a6cfd4 100644 (file)
@@ -2274,10 +2274,7 @@ Route::_set_state (const XMLNode& node, bool call_base)
 
        nlist = node.children();
 
-       if (deferred_state) {
-               delete deferred_state;
-       }
-
+       delete deferred_state;
        deferred_state = new XMLNode(X_("deferred state"));
 
        /* set parent class properties before anything else */
@@ -2521,10 +2518,8 @@ Route::set_control_outs (const vector<string>& ports)
        vector<string>::const_iterator i;
        size_t limit;
        
-       if (_control_outs) {
-               delete _control_outs;
-               _control_outs = 0;
-       }
+       delete _control_outs;
+       _control_outs = 0;
 
        if (is_control() || is_master()) {
                /* no control outs for these two special busses */
index 875b3179365678d1459d3532a559c121596d9262..8efef136d1e1abf1802f7bcc70a646aa0c80179a 100644 (file)
@@ -1336,9 +1336,7 @@ Session::set_block_size (nframes_t nframes)
 
                ensure_buffers(_scratch_buffers->available());
 
-               if (_gain_automation_buffer) {
-                       delete [] _gain_automation_buffer;
-               }
+               delete [] _gain_automation_buffer;
                _gain_automation_buffer = new gain_t[nframes];
 
                allocate_pan_automation_buffers (nframes, _npan_buffers, true);
index 7161de6d78fa6d2f84c6b823702ce79ebad3be40..fcbf1e1b039024f776c33f0ab6e45dfc6124120c 100644 (file)
@@ -139,7 +139,7 @@ Session::setup_click_sounds (int which)
 
        if ((which == 0 || which == 1)) {
                
-               if (click_data && click_data != default_click) {
+               if (click_data != default_click) {
                        delete [] click_data;
                        click_data = 0;
                }
@@ -178,7 +178,7 @@ Session::setup_click_sounds (int which)
                
        if ((which == 0 || which == -1)) {
 
-               if (click_emphasis_data && click_emphasis_data != default_click_emphasis) {
+               if (click_emphasis_data != default_click_emphasis) {
                        delete [] click_emphasis_data;
                        click_emphasis_data = 0;
                }
index cb4a9e5813f25b61c7592b24ca4e513b82031797..560143db97293689cf5cac524ced4abad6f4f220 100644 (file)
@@ -768,10 +768,8 @@ Session::restore_state (string snapshot_name)
 int
 Session::load_state (string snapshot_name)
 {
-       if (state_tree) {
-               delete state_tree;
-               state_tree = 0;
-       }
+       delete state_tree;
+       state_tree = 0;
 
        state_was_pending = false;
 
index 5612429d0d279a6212bd6b67bd39cf6d24f0353f..c8630514616ed414a7684347a050e9e8bc4b50ec 100644 (file)
@@ -1062,10 +1062,8 @@ Session::set_slave_source (SlaveSource src)
 //             return;
 //     }
 
-       if (_slave) {
-               delete _slave;
-               _slave = 0;
-       }
+       delete _slave;
+       _slave = 0;
 
        if (_transport_speed < 0.0) {
                reverse = true;
index 6a4b5e325d60b3010588c9d3ecd87a992d5ca898..b35d36a71333664e49b0992c51f737df24196f3a 100644 (file)
@@ -259,13 +259,8 @@ SndFileSource::~SndFileSource ()
                touch_peakfile ();
        }
 
-       if (_broadcast_info) {
-               delete _broadcast_info;
-       }
-
-       if (xfade_buf) {
-               delete [] xfade_buf;
-       }
+       delete _broadcast_info;
+       delete [] xfade_buf;
 }
 
 float
@@ -782,13 +777,8 @@ SndFileSource::setup_standard_crossfades (nframes_t rate)
 
        xfade_frames = (nframes_t) floor ((Config->get_destructive_xfade_msecs () / 1000.0) * rate);
 
-       if (out_coefficient) {
-               delete [] out_coefficient;
-       }
-
-       if (in_coefficient) {
-               delete [] in_coefficient;
-       }
+       delete [] out_coefficient;
+       delete [] in_coefficient;
 
        out_coefficient = new gain_t[xfade_frames];
        in_coefficient = new gain_t[xfade_frames];
index e96cd79f2dc6f592d2998e4cee4e5101925c6454..36af40e929ce815378f837d997c69600eca19717 100644 (file)
@@ -195,13 +195,8 @@ Stretch::run (boost::shared_ptr<Region> a_region)
 
   out:
 
-       if (gain_buffer) {
-               delete [] gain_buffer;
-       }
-
-       if (buffer) {
-               delete [] buffer;
-       }
+       delete [] gain_buffer;
+       delete [] buffer;
 
        if (ret || tsr.cancel) {
                for (SourceList::iterator si = nsrcs.begin(); si != nsrcs.end(); ++si) {
index 46de65153e070a3a6e3b727cad155e9eebf63ba3..6d41f14f7ec0d8d9d3e4cf91027ce07b81bb51b5 100644 (file)
@@ -91,7 +91,7 @@ MultiAllocSingleReleasePool::MultiAllocSingleReleasePool (string n, unsigned lon
 
 MultiAllocSingleReleasePool::~MultiAllocSingleReleasePool ()
 {
-    if(m_lock) delete m_lock;
+    delete m_lock;
 }
 
 SingleAllocMultiReleasePool::SingleAllocMultiReleasePool (string n, unsigned long isize, unsigned long nitems) 
@@ -102,7 +102,7 @@ SingleAllocMultiReleasePool::SingleAllocMultiReleasePool (string n, unsigned lon
 
 SingleAllocMultiReleasePool::~SingleAllocMultiReleasePool ()
 {
-    if(m_lock) delete m_lock;
+    delete m_lock;
 }
 
 void*
index da014d738f15d2aa8ee8131933a0ec375085014d..a7cd3bdb236c2c4674bf31a167dc7ce6fec00eb6 100644 (file)
@@ -40,9 +40,7 @@ Stateful::~Stateful ()
        // Do not delete _extra_xml.  The use of add_child_nocopy() 
        // means it needs to live on indefinately.
 
-       if (_instant_xml) {
-               delete _instant_xml;
-       }
+       delete _instant_xml;
 }
 
 void
index a42923132bc3042eef8d12fef9a5f32e04dc56a1..7d406d6c30a61663d26734adf38af057f21cbd21 100644 (file)
@@ -39,9 +39,7 @@ XMLTree::XMLTree(const XMLTree * from)
 
 XMLTree::~XMLTree()
 {
-       if (_root) {
-               delete _root;
-       }
+       delete _root;
 }
 
 int 
@@ -63,10 +61,9 @@ XMLTree::read_internal(bool validate)
 {
        //shouldnt be used anywhere ATM, remove if so!
        assert(!validate);
-       if (_root) {
-               delete _root;
-               _root = 0;
-       }
+
+       delete _root;
+       _root = 0;
        
        xmlParserCtxtPtr ctxt; /* the parser context */
        xmlDocPtr doc; /* the resulting document tree */
@@ -119,10 +116,8 @@ XMLTree::read_buffer(const string & buffer)
        
        _filename = "";
        
-       if (_root) {
-               delete _root;
-               _root = 0;
-       }
+       delete _root;
+       _root = 0;
        
        doc = xmlParseMemory((char *) buffer.c_str(), buffer.length());
        if (!doc) {
index cd8c724e75f5c1f6d22def36d79d659150613172..9f6441eb4be58e065838b6b0e91ce5158d963353 100644 (file)
@@ -232,9 +232,7 @@ GenericMidiControlProtocol::stop_learning (Controllable* c)
                }
        }
        
-       if (dptr) {
-               delete dptr;
-       }
+       delete dptr;
 }
 
 void
index 88c00ed6eb225dd0d99685bbb675d94a52234aef..2bf992f1b7f78bdb3f74c9409f352c17cebdf985 100644 (file)
@@ -93,11 +93,7 @@ void MackieControlProtocol::update_ports()
                if ( _ports_changed )
                {
                        // create new pollfd structures
-                       if ( pfd != 0 )
-                       {
-                               delete[] pfd;
-                               pfd = 0;
-                       }
+                       delete[] pfd;
                        pfd = new pollfd[_ports.size()];
 #ifdef DEBUG
                        cout << "pfd: " << pfd << endl;