projects
/
ardour.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(from parent 1:
0aaf2d1
)
leave a comment about port reconnection
author
Paul Davis
<paul@linuxaudiosystems.com>
Fri, 23 Sep 2016 18:57:29 +0000
(13:57 -0500)
committer
Paul Davis
<paul@linuxaudiosystems.com>
Tue, 27 Sep 2016 19:59:32 +0000
(14:59 -0500)
libs/surfaces/push2/push2.cc
patch
|
blob
|
history
diff --git
a/libs/surfaces/push2/push2.cc
b/libs/surfaces/push2/push2.cc
index a9498ee38379660b69801b5b412d2f25dd0eeb43..ec234be7128b4c7cf92fb756c36804a5a3e41e9d 100644
(file)
--- a/
libs/surfaces/push2/push2.cc
+++ b/
libs/surfaces/push2/push2.cc
@@
-1537,6
+1537,14
@@
Push2::stripable_selection_change (StripableNotificationListPtr selected)
/* disconnect from pad port, if appropriate */
if (current_midi_track && pad_port) {
+
+ /* XXX this could possibly leave dangling MIDI notes.
+ *
+ * A general libardour fix is required. It isn't obvious
+ * how note resolution can be done unless disconnecting
+ * becomes "slow" (i.e. deferred for as long as it takes
+ * to resolve notes).
+ */
current_midi_track->input()->disconnect (current_midi_track->input()->nth(0), pad_port->name(), this);
}