fix some static-analysis warnings

diff --git a/gtk2_ardour/selection.cc b/gtk2_ardour/selection.cc
index 2cf79a3c4b0b74e7ffe6f3ea8765290b13401682..309e4239fb09bd7dded471af69ba2f655b32b832 100644 (file)
--- a/gtk2_ardour/selection.cc
+++ b/gtk2_ardour/selection.cc
@@ -1241,6 +1241,7 @@ Selection::get_state () const
        }
        list<pair<PBD::ID, std::set<boost::shared_ptr<Evoral::Note<Evoral::Beats> > > > >::iterator rn_it;
        for (rn_it = rid_notes.begin(); rn_it != rid_notes.end(); ++rn_it) {
+               assert(n); // hint for clang static analysis
                n->add_property (X_("region_id"), atoi((*rn_it).first.to_s().c_str()));
 
                for (std::set<boost::shared_ptr<Evoral::Note<Evoral::Beats> > >::iterator i = (*rn_it).second.begin(); i != (*rn_it).second.end(); ++i) {

diff --git a/libs/ardour/io.cc b/libs/ardour/io.cc
index 5e9e5aa0c1a9accb7c9a48b3004e6a9deebc3095..69f7c9053ee4c6ffe6db10f10d32435709584eb6 100644 (file)
--- a/libs/ardour/io.cc
+++ b/libs/ardour/io.cc
@@ -1176,7 +1176,6 @@ IO::parse_gain_string (const string& str, vector<string>& ports)
 {
        string::size_type pos, opos;
 
-       pos = 0;
        opos = 0;
        ports.clear ();