copy VST state on copy construction

This fixes issues with replicate instances & plugin-analysis instances
not using the same set of parameters.

diff --git a/libs/ardour/lxvst_plugin.cc b/libs/ardour/lxvst_plugin.cc
index 3939048ad443e7ceca3ccaebb7227b7db66c6e3b..91ae75788340989ac4ea1ca4c15205fc38abcb4b 100644 (file)
--- a/libs/ardour/lxvst_plugin.cc
+++ b/libs/ardour/lxvst_plugin.cc
@@ -58,7 +58,11 @@ LXVSTPlugin::LXVSTPlugin (const LXVSTPlugin &other)
 
        _plugin = _state->plugin;
 
-       // Plugin::setup_controls ();
+       XMLNode* root = new XMLNode (other.state_node_name ());
+       LocaleGuard lg;
+       other.add_state (root);
+       set_state (*root, Stateful::loading_state_version);
+       delete root;
 }
 
 LXVSTPlugin::~LXVSTPlugin ()

diff --git a/libs/ardour/mac_vst_plugin.cc b/libs/ardour/mac_vst_plugin.cc
index 08c39b1d354b31f55ee2f7a957aaf484bcfb5d85..2cb7301ce800116699daf653a57344929c4dfb18 100644 (file)
--- a/libs/ardour/mac_vst_plugin.cc
+++ b/libs/ardour/mac_vst_plugin.cc
@@ -58,7 +58,11 @@ MacVSTPlugin::MacVSTPlugin (const MacVSTPlugin &other)
 
        _plugin = _state->plugin;
 
-       // Plugin::setup_controls ();
+       XMLNode* root = new XMLNode (other.state_node_name ());
+       LocaleGuard lg;
+       other.add_state (root);
+       set_state (*root, Stateful::loading_state_version);
+       delete root;
 }
 
 MacVSTPlugin::~MacVSTPlugin ()

diff --git a/libs/ardour/windows_vst_plugin.cc b/libs/ardour/windows_vst_plugin.cc
index 17cfa1eed7c4120f2070ba3080b21ceabf536ca5..256d7f89a8bb13ee2fbf17bc4cbb0c81fbef1b55 100644 (file)
--- a/libs/ardour/windows_vst_plugin.cc
+++ b/libs/ardour/windows_vst_plugin.cc
@@ -56,6 +56,12 @@ WindowsVSTPlugin::WindowsVSTPlugin (const WindowsVSTPlugin &other)
        Session::vst_current_loading_id = 0;
 
        _plugin = _state->plugin;
+
+       XMLNode* root = new XMLNode (other.state_node_name ());
+       LocaleGuard lg;
+       other.add_state (root);
+       set_state (*root, Stateful::loading_state_version);
+       delete root;
 }
 
 WindowsVSTPlugin::~WindowsVSTPlugin ()