ardour.git
8 years agofix implicit mute display
Robin Gareus [Tue, 6 Oct 2015 10:19:58 +0000 (12:19 +0200)]
fix implicit mute display

8 years ago"Solo Lock" only locks explicit solo (not implicit).
Robin Gareus [Tue, 6 Oct 2015 10:03:20 +0000 (12:03 +0200)]
"Solo Lock" only locks explicit solo (not implicit).

fixes issue:

Track -> Bus
1) solo track -> implicit Bus solo
2) Solo-Lock Bus
3) un-solo track -> Bus is stuck w/implicit solo on

8 years agoSolo-Isolate has no effect on solo propagation.
Robin Gareus [Tue, 6 Oct 2015 09:57:16 +0000 (11:57 +0200)]
Solo-Isolate has no effect on solo propagation.

'Isolate' means that when another track is solo'd the isolated
track won't mute.

8 years agoFix WinMME midi driver shutdown with sysex enabled
Tim Mayberry [Tue, 6 Oct 2015 03:24:53 +0000 (13:24 +1000)]
Fix WinMME midi driver shutdown with sysex enabled

midiInReset triggers the sysex callback to tell the application that it has
finished with the buffer. Calling midiInAddBuffer results in an infinite loop
so just return during shutdown.

8 years agoInclude button number in canvas button press/release debug info
Tim Mayberry [Sat, 3 Oct 2015 11:54:50 +0000 (21:54 +1000)]
Include button number in canvas button press/release debug info

8 years agoRemove an unnecessary boolean argument in jack utils
Tim Mayberry [Sat, 3 Oct 2015 06:22:19 +0000 (16:22 +1000)]
Remove an unnecessary boolean argument in jack utils

Specify latency in JackCommandLineOptions instead

8 years agoStop engine when clicking back button in latency measurement tab of EngineControl...
Tim Mayberry [Sat, 3 Oct 2015 05:49:55 +0000 (15:49 +1000)]
Stop engine when clicking back button in latency measurement tab of EngineControl dialog

The engine is started when you switch to latency measurement tab but it isn't
stopped if you just click the back button without measuring for latency.

8 years agoRemove unused methods in ARDOUR_UI for starting/stopping engine
Tim Mayberry [Sat, 3 Oct 2015 04:38:34 +0000 (14:38 +1000)]
Remove unused methods in ARDOUR_UI for starting/stopping engine

8 years agoAdd EngineControl::stop_engine method to show errors when stopping engine
Tim Mayberry [Sat, 3 Oct 2015 04:09:45 +0000 (14:09 +1000)]
Add EngineControl::stop_engine method to show errors when stopping engine

This replaces using ARDOUR_UI::disconnect_from_session which is only used by the
EngineControl class. ARDOUR_UI::disconnect_from_session also disconnects from
the AudioEngine::Halted signal which seems unnecessary as Halted is not emitted
when stopping the engine and calling update_sample_rate() which is already
handled when the AudioEngine::Stopped signal is emitted.

8 years agoHandle all errors when starting backend in EngineDialog
Tim Mayberry [Sat, 3 Oct 2015 01:40:34 +0000 (11:40 +1000)]
Handle all errors when starting backend in EngineDialog

8 years agoAlign switch statement with case labels to reduce indentation in EngineDialog
Tim Mayberry [Fri, 2 Oct 2015 12:25:04 +0000 (22:25 +1000)]
Align switch statement with case labels to reduce indentation in EngineDialog

8 years agoInitialize AudioEngine::last_backend_error() to the default error string
Tim Mayberry [Sat, 3 Oct 2015 01:22:58 +0000 (11:22 +1000)]
Initialize AudioEngine::last_backend_error() to the default error string

Currently the last backend error string is only set when calling
AudioBackend::start. Errors that occur when calling other AudioBackend methods
like AudioBackend::set_buffer_size do not set the last backend error string.
So until all the required AudioBackend methods return an ErrorCode and
last_backend_error() can be removed just set it to a default string.

Until all errors that occur are correctly indicated by returning an error code
there will still be situations where last_backend_error() is not indicative of
the true error. For instance AudioEngine::start is called and it fails but
returns a valid error code so last_backend_error() is set, then some other
engine/backend method is called that fails and as last_backend_error is not
set the GUI will display the incorrect error message.

8 years agoUpdate sample rate and CPU load in status bar when AudioEngine stopped
Tim Mayberry [Sat, 3 Oct 2015 01:20:37 +0000 (11:20 +1000)]
Update sample rate and CPU load in status bar when AudioEngine stopped

8 years agoShow DSP/CPU load of 0.0% when AudioEngine isn't running
Tim Mayberry [Sat, 3 Oct 2015 01:18:51 +0000 (11:18 +1000)]
Show DSP/CPU load of 0.0% when AudioEngine isn't running

8 years agofix implicit solo on disconnect - fixes #6308
Robin Gareus [Tue, 6 Oct 2015 00:53:06 +0000 (02:53 +0200)]
fix implicit solo on disconnect - fixes #6308

8 years agoforward "disconnect all", partial fix for #6308
Robin Gareus [Mon, 5 Oct 2015 23:28:33 +0000 (01:28 +0200)]
forward "disconnect all", partial fix for #6308

8 years agofix typo in prev. commit
Robin Gareus [Mon, 5 Oct 2015 20:41:37 +0000 (22:41 +0200)]
fix typo in prev. commit

8 years agofix typo
Robin Gareus [Mon, 5 Oct 2015 20:37:41 +0000 (22:37 +0200)]
fix typo

8 years agouse quotes for in-tree pbd/glib wrapper include
Robin Gareus [Mon, 5 Oct 2015 20:10:58 +0000 (22:10 +0200)]
use quotes for in-tree pbd/glib wrapper include

8 years agoremove unused fstream includes
Robin Gareus [Mon, 5 Oct 2015 20:01:30 +0000 (22:01 +0200)]
remove unused fstream includes

8 years agoremove ofstream from gtk2ardour
Robin Gareus [Mon, 5 Oct 2015 19:51:52 +0000 (21:51 +0200)]
remove ofstream from gtk2ardour

8 years agoremove i/ofstream from libardour
Robin Gareus [Mon, 5 Oct 2015 19:43:44 +0000 (21:43 +0200)]
remove i/ofstream from libardour

except:
 * audio-unit (ifstream is known to work on OSX)
 * evoral curve algorithm debugger
 * cycle-timer debug code
 * export_handler's CDMarker  -> TODO

8 years agoreplace i/ofstream for plugin statues
Robin Gareus [Mon, 5 Oct 2015 19:14:54 +0000 (21:14 +0200)]
replace i/ofstream for plugin statues

8 years agoremove unused API (and ifstream)
Robin Gareus [Mon, 5 Oct 2015 19:14:37 +0000 (21:14 +0200)]
remove unused API (and ifstream)

8 years agotry enabling windows MME MIDI sysex support
Paul Davis [Mon, 5 Oct 2015 16:24:08 +0000 (12:24 -0400)]
try enabling windows MME MIDI sysex support

8 years agoonly use HUI heartbeat with HUI devices
Paul Davis [Mon, 5 Oct 2015 16:23:51 +0000 (12:23 -0400)]
only use HUI heartbeat with HUI devices

8 years agofix case where NORM_USER (su) changes dirs.
Robin Gareus [Mon, 5 Oct 2015 15:12:13 +0000 (17:12 +0200)]
fix case where NORM_USER (su) changes dirs.

8 years agoNOOP, remove trailing tabs/whitespace.
Robin Gareus [Mon, 5 Oct 2015 14:17:49 +0000 (16:17 +0200)]
NOOP, remove trailing tabs/whitespace.

8 years agoSiP and "solo overrides mutes" tweak:
Robin Gareus [Mon, 5 Oct 2015 12:19:32 +0000 (14:19 +0200)]
SiP and "solo overrides mutes" tweak:

Only Explicit solos should override mutes.

8 years agotweak linux package debug-symbol stripping
Robin Gareus [Mon, 5 Oct 2015 11:27:22 +0000 (13:27 +0200)]
tweak linux package debug-symbol stripping

8 years agoallow grouped AFL/PFL with excl. solo
Robin Gareus [Sun, 4 Oct 2015 22:27:48 +0000 (00:27 +0200)]
allow grouped AFL/PFL with excl. solo

8 years agofix various stuck-solo cases:
Robin Gareus [Sun, 4 Oct 2015 22:08:55 +0000 (00:08 +0200)]
fix various stuck-solo cases:

* solo groups
* cancel-solo
* SIP <> AFL/PFL changes

The optimized plural-form route_solo_changed() relied on the false
premise that solo-groups and port-connections are disjoint sets.

-=-

e.g. "cancel all solo" calls set_solo(get_routes(), false);
Since All routes are affected, the "non_solo_change" set is empty, and
no changes were propagated up/downstream.

Routes that indirectly change state as group-members, wrongly end up in
the "non_solo_change" list instead of the "solo_change" list.

If a route feeds another in the same group, no changes were propagated.

8 years agofix AFL/PFL/SIP "stuck solo" - fixes #5803
Robin Gareus [Sun, 4 Oct 2015 19:47:35 +0000 (21:47 +0200)]
fix AFL/PFL/SIP "stuck solo" - fixes #5803

monitor_send are only active when listening (AFL, PFL).
don't activate them when re-configuring processors.

8 years agoupdate NSM executable name - fixes #6620
Robin Gareus [Sun, 4 Oct 2015 19:16:32 +0000 (21:16 +0200)]
update NSM executable name - fixes #6620

NSM requires an executable in $PATH, not full path

8 years agoglobally remove all trailing whitespace from .cpp and .hpp files missed by previous...
Paul Davis [Sun, 4 Oct 2015 19:11:15 +0000 (15:11 -0400)]
globally remove all trailing whitespace from .cpp and .hpp files missed by previous commit

8 years agoglobally remove all trailing whitespace from ardour code base.
Paul Davis [Sun, 4 Oct 2015 18:51:05 +0000 (14:51 -0400)]
globally remove all trailing whitespace from ardour code base.

Paul Davis was responsible for introducing almost all of this.

8 years agoattempt to stop transport, finish butler work, and close all files as part of Session...
Paul Davis [Sun, 4 Oct 2015 18:17:52 +0000 (14:17 -0400)]
attempt to stop transport, finish butler work, and close all files as part of Session > Cleanup

8 years agoNOOP: delete trailing whitespace
Paul Davis [Sun, 4 Oct 2015 16:46:27 +0000 (12:46 -0400)]
NOOP: delete trailing whitespace

8 years agoadd a hidden option to show hidden processors
Robin Gareus [Sun, 4 Oct 2015 17:39:53 +0000 (19:39 +0200)]
add a hidden option to show hidden processors

simplify debugging solo, monitor-processors, etc

8 years agonamespace fix.
Robin Gareus [Sun, 4 Oct 2015 16:43:27 +0000 (18:43 +0200)]
namespace fix.

8 years agochange wording of autosave option to be more clear
Paul Davis [Sun, 4 Oct 2015 16:25:33 +0000 (12:25 -0400)]
change wording of autosave option to be more clear

8 years agoreplace std::ifstream with g_fopen for portability
Robin Gareus [Sun, 4 Oct 2015 16:23:21 +0000 (18:23 +0200)]
replace std::ifstream with g_fopen for portability

8 years agogcc ABI check happens before unpacking
Robin Gareus [Sun, 4 Oct 2015 15:52:29 +0000 (17:52 +0200)]
gcc ABI check happens before unpacking

8 years agocorrect error message
Robin Gareus [Sun, 4 Oct 2015 13:35:14 +0000 (15:35 +0200)]
correct error message

8 years agoremove unused function
Robin Gareus [Sun, 4 Oct 2015 13:35:00 +0000 (15:35 +0200)]
remove unused function

8 years agoChange a few instances of 'stat()' to use 'g_stat()' (for UTF8 compatibility on Windows)
John Emmas [Sun, 4 Oct 2015 13:18:54 +0000 (14:18 +0100)]
Change a few instances of 'stat()' to use 'g_stat()' (for UTF8 compatibility on Windows)

8 years agoalways use session rt-event to un/set solo
Robin Gareus [Sun, 4 Oct 2015 00:03:49 +0000 (02:03 +0200)]
always use session rt-event to un/set solo

8 years agodon't export video-frame request function
Robin Gareus [Sun, 4 Oct 2015 00:02:46 +0000 (02:02 +0200)]
don't export video-frame request function

8 years agoInitialize variable every loop so MCP devices don't accumulate too.
Len Ovens [Sat, 3 Oct 2015 20:15:18 +0000 (13:15 -0700)]
Initialize variable every loop so MCP devices don't accumulate too.

8 years agoInitialize variable every loop so MCP profiles don't accumulate.
Len Ovens [Sat, 3 Oct 2015 20:06:34 +0000 (13:06 -0700)]
Initialize variable every loop so MCP profiles don't accumulate.

8 years agoNOOP: delete trailing whitespace
Paul Davis [Sat, 3 Oct 2015 18:03:29 +0000 (14:03 -0400)]
NOOP: delete trailing whitespace

8 years agoreset IP MIDI port when deleting a mackie surface port
Paul Davis [Sat, 3 Oct 2015 17:51:17 +0000 (13:51 -0400)]
reset IP MIDI port when deleting a mackie surface port

8 years agoreset shared_ptr to master surface when clearing surfaces, to ensure Surface destruct...
Paul Davis [Sat, 3 Oct 2015 17:50:59 +0000 (13:50 -0400)]
reset shared_ptr to master surface when clearing surfaces, to ensure Surface destructor is called

8 years agoMerge branch 'zamaudio-click-level'
Paul Davis [Sat, 3 Oct 2015 17:14:37 +0000 (13:14 -0400)]
Merge branch 'zamaudio-click-level'

8 years agoClick: Normalized then dropped by 6dB
Damien Zammit [Sat, 3 Oct 2015 16:02:04 +0000 (03:02 +1100)]
Click: Normalized then dropped by 6dB

Applied gain to both emph click and default click using sox.
This results in louder click sound by default and user is
able to boost click to 0dBFS using the fader on the pref pane.

Signed-off-by: Damien Zammit <damien@zamaudio.com>
8 years agomake a start on providing direct choice of MIDI ports where an MCP device can be...
Paul Davis [Sat, 3 Oct 2015 17:13:52 +0000 (13:13 -0400)]
make a start on providing direct choice of MIDI ports where an MCP device can be reached

8 years agoNOOP: reformat indentation
Paul Davis [Sat, 3 Oct 2015 16:37:13 +0000 (12:37 -0400)]
NOOP: reformat indentation

8 years agoNOOP: reformat indentation
Paul Davis [Sat, 3 Oct 2015 16:11:32 +0000 (12:11 -0400)]
NOOP: reformat indentation

8 years agomore code-control when laying out Mackie Control GUI panel
Paul Davis [Sat, 3 Oct 2015 16:11:04 +0000 (12:11 -0400)]
more code-control when laying out Mackie Control GUI panel

8 years agoadd basic support for HUI heartbeat, only used for HUI devices
Paul Davis [Sat, 3 Oct 2015 16:03:07 +0000 (12:03 -0400)]
add basic support for HUI heartbeat, only used for HUI devices

8 years agoadd DeviceType specifier for mackie devices.
Paul Davis [Sat, 3 Oct 2015 15:39:36 +0000 (11:39 -0400)]
add DeviceType specifier for mackie devices.

Incomplete, because we need a way to handle multiple devices of different types

8 years agoNOOP: reformat indentation
Paul Davis [Sat, 3 Oct 2015 15:31:46 +0000 (11:31 -0400)]
NOOP: reformat indentation

8 years agoadd device type to Mackie device info
Paul Davis [Sat, 3 Oct 2015 15:31:17 +0000 (11:31 -0400)]
add device type to Mackie device info

8 years agoadd support to display and set key aliases in mackie GUI
Paul Davis [Sat, 3 Oct 2015 15:08:47 +0000 (11:08 -0400)]
add support to display and set key aliases in mackie GUI

8 years agoadditional check for DSP falloff.
Robin Gareus [Sat, 3 Oct 2015 15:46:55 +0000 (17:46 +0200)]
additional check for DSP falloff.

8 years agoless verbose unit-tests
Robin Gareus [Sat, 3 Oct 2015 15:46:39 +0000 (17:46 +0200)]
less verbose unit-tests

8 years agoDSP load fall-off from 100%.
Robin Gareus [Sat, 3 Oct 2015 15:46:19 +0000 (17:46 +0200)]
DSP load fall-off from 100%.

get_dsp_load_unbound() will return large values >100% for testing,
but actual fall-off is from 100%.

8 years agofix float calc:
Robin Gareus [Sat, 3 Oct 2015 15:44:56 +0000 (17:44 +0200)]
fix float calc:

divide large number. not multiply a small.

8 years agofix windows compilation
Robin Gareus [Sat, 3 Oct 2015 09:20:15 +0000 (11:20 +0200)]
fix windows compilation

8 years agoinitial pass at a profile (key bindings) for MCU Pro surface.
Paul Davis [Sat, 3 Oct 2015 02:10:28 +0000 (22:10 -0400)]
initial pass at a profile (key bindings) for MCU Pro surface.

Lots more work to do here

8 years agoremove undefined and unused method declaration
Paul Davis [Sat, 3 Oct 2015 02:08:05 +0000 (22:08 -0400)]
remove undefined and unused method declaration

8 years agoanother change from modifier_state() to main_modifier_state()
Paul Davis [Sat, 3 Oct 2015 02:07:49 +0000 (22:07 -0400)]
another change from modifier_state() to main_modifier_state()

8 years agoavoid handling pitchbend (fader) messages while SHIFT modifier is active.
Paul Davis [Sat, 3 Oct 2015 02:07:24 +0000 (22:07 -0400)]
avoid handling pitchbend (fader) messages while SHIFT modifier is active.

See comment in code for more detail

8 years agono longer call ::zero_all() when deleting an MCP surface object.
Paul Davis [Sat, 3 Oct 2015 02:06:24 +0000 (22:06 -0400)]
no longer call ::zero_all() when deleting an MCP surface object.

The ports required may no longer exist, and it requires a lot of messages. A reset is sent instead

8 years agouse ::main_modifier_state() in some more places
Paul Davis [Sat, 3 Oct 2015 02:06:02 +0000 (22:06 -0400)]
use ::main_modifier_state() in some more places

8 years agonecessary header changes for new redisplay code in MCP
Paul Davis [Sat, 3 Oct 2015 02:04:02 +0000 (22:04 -0400)]
necessary header changes for new redisplay code in MCP

8 years agoadd new (fast) redisplay timer that pushes parameter display text to MCP device.
Paul Davis [Sat, 3 Oct 2015 02:03:17 +0000 (22:03 -0400)]
add new (fast) redisplay timer that pushes parameter display text to MCP device.

Changes are queued in a FIFO, and pulled when a timeout in the MCP event loop fires.

8 years agofix comment spelling
Paul Davis [Sat, 3 Oct 2015 01:59:05 +0000 (21:59 -0400)]
fix comment spelling

8 years agouse Surface::reset() when deleting MackieControlProtocol, rather than sending lots...
Paul Davis [Sat, 3 Oct 2015 01:57:12 +0000 (21:57 -0400)]
use Surface::reset() when deleting MackieControlProtocol, rather than sending lots of messages.

This may be a bit "strong" because on the MCU Pro (at least) it causes a fader recalibration.

8 years agoimplement backlight, fader touch sensitivity and recalibrate fader functions for...
Paul Davis [Sat, 3 Oct 2015 01:54:40 +0000 (21:54 -0400)]
implement backlight, fader touch sensitivity and recalibrate fader functions for MCP GUI

8 years agoavoid sending replicated fader set position messages
Paul Davis [Fri, 2 Oct 2015 23:24:04 +0000 (19:24 -0400)]
avoid sending replicated fader set position messages

8 years agoexplicitly drop control surface protocols before disconnecting from engine.
Paul Davis [Fri, 2 Oct 2015 23:22:16 +0000 (19:22 -0400)]
explicitly drop control surface protocols before disconnecting from engine.

This is not bomb/thread proof yet, because it still requires at least one process callback to function

8 years agoadd missing "fi" to stage2.run script used for linux install
Paul Davis [Fri, 2 Oct 2015 23:19:21 +0000 (19:19 -0400)]
add missing "fi" to stage2.run script used for linux install

8 years agoremove debug output
Paul Davis [Fri, 2 Oct 2015 20:31:30 +0000 (16:31 -0400)]
remove debug output

8 years agothe return of the 1 second fade out at session close
Paul Davis [Fri, 2 Oct 2015 20:29:58 +0000 (16:29 -0400)]
the return of the 1 second fade out at session close

8 years agofix unbound DSP calc.
Robin Gareus [Fri, 2 Oct 2015 20:28:03 +0000 (22:28 +0200)]
fix unbound DSP calc.

8 years agoescape markup in region list
Robin Gareus [Fri, 2 Oct 2015 17:38:32 +0000 (19:38 +0200)]
escape markup in region list

8 years agoadd missing markup escape
Robin Gareus [Fri, 2 Oct 2015 17:14:24 +0000 (19:14 +0200)]
add missing markup escape

(e.g. import file with ampersand)

8 years agouse new error-messages
Robin Gareus [Fri, 2 Oct 2015 15:51:17 +0000 (17:51 +0200)]
use new error-messages

8 years agodefine more backend error-messages.
Robin Gareus [Fri, 2 Oct 2015 15:49:31 +0000 (17:49 +0200)]
define more backend error-messages.

8 years agoimprove CoreAudio error reporting
Robin Gareus [Fri, 2 Oct 2015 15:28:16 +0000 (17:28 +0200)]
improve CoreAudio error reporting

8 years agofix handler of fader (pitchbend) messages in Mackie Control so that the outbound...
Paul Davis [Fri, 2 Oct 2015 14:22:00 +0000 (10:22 -0400)]
fix handler of fader (pitchbend) messages in Mackie Control so that the outbound messages match the inbound ones

Pitch bend values really can span 0 to 16384, not 16383

8 years agoallow aliasing Mackie Control buttons to other buttons
Paul Davis [Fri, 2 Oct 2015 14:21:20 +0000 (10:21 -0400)]
allow aliasing Mackie Control buttons to other buttons

8 years agoprovide Main/cancel-solo as an action and make rude solo button(s) use it
Paul Davis [Fri, 2 Oct 2015 11:32:49 +0000 (07:32 -0400)]
provide Main/cancel-solo as an action and make rude solo button(s) use it

8 years agocatch changes in click status and alter LED appropriately
Paul Davis [Fri, 2 Oct 2015 11:31:48 +0000 (07:31 -0400)]
catch changes in click status and alter LED appropriately

8 years agochange zoom and scrub handling to use modifier bits
Paul Davis [Fri, 2 Oct 2015 11:31:31 +0000 (07:31 -0400)]
change zoom and scrub handling to use modifier bits

8 years agospelling correction in error message
Paul Davis [Fri, 2 Oct 2015 11:29:51 +0000 (07:29 -0400)]
spelling correction in error message

8 years agoadd a proper license to the GCC ABI check tool
Robin Gareus [Fri, 2 Oct 2015 11:17:45 +0000 (13:17 +0200)]
add a proper license to the GCC ABI check tool

8 years agore-apply roll-delay after seek - fixes #5781
Robin Gareus [Thu, 1 Oct 2015 21:17:01 +0000 (23:17 +0200)]
re-apply roll-delay after seek - fixes #5781

8 years agoremove ancient doxyfile
Robin Gareus [Thu, 1 Oct 2015 19:58:00 +0000 (21:58 +0200)]
remove ancient doxyfile