ardour.git
7 years agoMRV handles an alt key press even if nothing happened.
nick_m [Sun, 20 Nov 2016 14:17:24 +0000 (01:17 +1100)]
MRV handles an alt key press even if nothing happened.

- nothing else treats a modifier press as
  a key press event, so don't pass it on.
  amends 0af9fb0d

7 years agofix for short notes being displayed as infinitely long.
nick_m [Sun, 20 Nov 2016 13:17:31 +0000 (00:17 +1100)]
fix for short notes being displayed as infinitely long.

7 years agoAdd a Lua script snippet processing region data from the editor
Robin Gareus [Sat, 19 Nov 2016 20:58:03 +0000 (21:58 +0100)]
Add a Lua script snippet processing region data from the editor

7 years agoAllow to call ARDOUR.DSP Lua functions from UI scripts
Robin Gareus [Sat, 19 Nov 2016 20:18:15 +0000 (21:18 +0100)]
Allow to call ARDOUR.DSP Lua functions from UI scripts

7 years agomake it clear that there is no drag threshold for NoteCreateDrag.
nick_m [Sat, 19 Nov 2016 17:55:34 +0000 (04:55 +1100)]
make it clear that there is no drag threshold for NoteCreateDrag.

7 years agopressing alt while creating a note (snap modifier) keeps mouse_state.
nick_m [Sat, 19 Nov 2016 17:54:20 +0000 (04:54 +1100)]
pressing alt while creating a note (snap modifier) keeps mouse_state.

7 years agoafter creating a note, don't add the ghost note until next motion.
nick_m [Sat, 19 Nov 2016 17:51:38 +0000 (04:51 +1100)]
after creating a note, don't add the ghost note until next motion.

7 years agoNoteCreateDrag starts on button press.
nick_m [Sat, 19 Nov 2016 17:49:18 +0000 (04:49 +1100)]
NoteCreateDrag starts on button press.

- removes the separation between click and
  drag-creation of notes noth now handled by the drag code).

7 years agoNoteCreateDrag::grid_frames works over a tempo change.
nick_m [Sat, 19 Nov 2016 17:42:20 +0000 (04:42 +1100)]
NoteCreateDrag::grid_frames works over a tempo change.

7 years agoremove unused variable.
nick_m [Sat, 19 Nov 2016 10:42:50 +0000 (21:42 +1100)]
remove unused variable.

7 years agofurther to 1a6a72b57, handle deleting a note while a non-selected one is entered.
nick_m [Sat, 19 Nov 2016 10:40:41 +0000 (21:40 +1100)]
further to 1a6a72b57, handle deleting a note while a non-selected one is entered.

7 years agoFix for widget visibility with detached preferences window
Tim Mayberry [Sat, 19 Nov 2016 03:51:32 +0000 (13:51 +1000)]
Fix for widget visibility with detached preferences window

Should finally resolve bug #7002

The reason 95e3f766 didn't resolve this is because OptionEditorContainer ctor
is called before adding all the widgets in RCOptionEditor so they will still be
hidden.

7 years agoDon't allow recursive calls to EngineDialog
Robin Gareus [Sat, 19 Nov 2016 03:54:36 +0000 (04:54 +0100)]
Don't allow recursive calls to EngineDialog

OK -> start_engine() can eg. trigger an interactive plugin scan,
which in turn leaves the EngineDialog responsive. changing settings
or clicking OK again can lead to undefined behavior.

7 years agofix ambiguity
Robin Gareus [Sat, 19 Nov 2016 00:36:34 +0000 (01:36 +0100)]
fix ambiguity

7 years agoDisable OSX 10.5/PPC support (MacVST is Cocoa UI only)
Robin Gareus [Fri, 18 Nov 2016 23:45:13 +0000 (00:45 +0100)]
Disable OSX 10.5/PPC support (MacVST is Cocoa UI only)

7 years agoGenerally speaking we use Glib::usleep() now in preference to standard ::usleep()
John Emmas [Fri, 18 Nov 2016 20:01:43 +0000 (20:01 +0000)]
Generally speaking we use Glib::usleep() now in preference to standard ::usleep()

7 years agoRemove the MSVC 'poll()' emulation now that Ardour's stopped using poll()
John Emmas [Fri, 18 Nov 2016 18:17:39 +0000 (18:17 +0000)]
Remove the MSVC 'poll()' emulation now that Ardour's stopped using poll()

7 years agoOSC: mark session dirty if setup changes
Len Ovens [Fri, 18 Nov 2016 16:43:58 +0000 (08:43 -0800)]
OSC: mark session dirty if setup changes

7 years agofix for ghost note becoming stuck after note selection deleted.
nick_m [Fri, 18 Nov 2016 16:03:20 +0000 (03:03 +1100)]
fix for ghost note becoming stuck after note selection deleted.

- thanks ristic for the report

7 years agoOSC: issue 7116 fix send enable not working
Len Ovens [Fri, 18 Nov 2016 15:53:40 +0000 (07:53 -0800)]
OSC: issue 7116 fix send enable not working

7 years agoRecursively scan for MacVSTs
Robin Gareus [Fri, 18 Nov 2016 01:36:04 +0000 (02:36 +0100)]
Recursively scan for MacVSTs

7 years agoremove thinko in MidiRegion::post_set().
nick_m [Thu, 17 Nov 2016 19:48:44 +0000 (06:48 +1100)]
remove thinko in MidiRegion::post_set().

- should fix incorrect midi region length on split.

7 years agoFix track-templates with sidechains -- closes #7117
Robin Gareus [Thu, 17 Nov 2016 15:29:08 +0000 (16:29 +0100)]
Fix track-templates with sidechains -- closes #7117

7 years agofix incorrect subdivision when dragging/trimming regions using magnetic snap.
nick_m [Thu, 17 Nov 2016 14:04:30 +0000 (01:04 +1100)]
fix incorrect subdivision when dragging/trimming regions using magnetic snap.

- amends d2d2308588e84

7 years agofix type in prev. commit
Robin Gareus [Thu, 17 Nov 2016 13:08:26 +0000 (14:08 +0100)]
fix type in prev. commit

7 years agoGUI to disable MacVST at runtime
Robin Gareus [Thu, 17 Nov 2016 13:06:29 +0000 (14:06 +0100)]
GUI to disable MacVST at runtime

7 years agoAdd runtime option to disable MacVST
Robin Gareus [Thu, 17 Nov 2016 13:06:03 +0000 (14:06 +0100)]
Add runtime option to disable MacVST

7 years agoAllow to migrate sessions with VST plugins
Robin Gareus [Thu, 17 Nov 2016 13:05:40 +0000 (14:05 +0100)]
Allow to migrate sessions with VST plugins

7 years agotry VST2.4's VSTPluginMain first
Robin Gareus [Thu, 17 Nov 2016 12:03:36 +0000 (13:03 +0100)]
try VST2.4's VSTPluginMain first

This fixes a crash with loading u-he Diva on windows.

7 years agofix mingw64 debug build
Robin Gareus [Thu, 17 Nov 2016 11:58:28 +0000 (12:58 +0100)]
fix mingw64 debug build

7 years agoAdd example script to modulate parmaters globally
Robin Gareus [Wed, 16 Nov 2016 17:55:40 +0000 (18:55 +0100)]
Add example script to modulate parmaters globally

7 years agomagnetic snap uses note divisor appropriately.
nick_m [Wed, 16 Nov 2016 17:08:13 +0000 (04:08 +1100)]
magnetic snap uses note divisor appropriately.

- also looks nicer when resizing MIDI regions.

7 years agofix 32bit+PPC OSX builds
Robin Gareus [Wed, 16 Nov 2016 16:24:08 +0000 (17:24 +0100)]
fix 32bit+PPC OSX builds

7 years agofix incorrect return type for Editor::get_grid_music_divisions().
nick_m [Wed, 16 Nov 2016 16:13:16 +0000 (03:13 +1100)]
fix incorrect return type for Editor::get_grid_music_divisions().

7 years agoFix crash when fanning out from editor mixer
Robin Gareus [Wed, 16 Nov 2016 04:24:01 +0000 (05:24 +0100)]
Fix crash when fanning out from editor mixer

when creating a new track or bus editor-selection changes and the
editor-mixer's _route changes.

7 years agoRevert "disable MacVST support (until it's ready)"
Robin Gareus [Wed, 16 Nov 2016 00:25:29 +0000 (01:25 +0100)]
Revert "disable MacVST support (until it's ready)"

This reverts commit e0766e8f74e740cd24645f3712873a1b669e4995.

7 years agofix library depends for OSX vst scanner
Robin Gareus [Wed, 16 Nov 2016 00:23:21 +0000 (01:23 +0100)]
fix library depends for OSX vst scanner

7 years agoupdate MSVC project in the wake of cf1651e6
Robin Gareus [Tue, 15 Nov 2016 22:11:50 +0000 (23:11 +0100)]
update MSVC project in the wake of cf1651e6

7 years agoa better fix for 6ed8c113a25 (scope)
nick_m [Tue, 15 Nov 2016 18:18:35 +0000 (05:18 +1100)]
a better fix for 6ed8c113a25 (scope)

7 years agoRegion:;set_state() should always set quarter_note.
nick_m [Tue, 15 Nov 2016 18:03:14 +0000 (05:03 +1100)]
Region:;set_state() should always set quarter_note.

- fix for 4.x sessions showing notes stacked at session start.

7 years agoMacVST UI resizing
Robin Gareus [Tue, 15 Nov 2016 16:20:34 +0000 (17:20 +0100)]
MacVST UI resizing

7 years agoconsolidate VST UI code
Robin Gareus [Tue, 15 Nov 2016 16:07:55 +0000 (17:07 +0100)]
consolidate VST UI code

7 years agoconsolidate VSTState functions
Robin Gareus [Tue, 15 Nov 2016 16:07:04 +0000 (17:07 +0100)]
consolidate VSTState functions

7 years agoAccommodate a newly introduced source file in our MSVC project (libardour)
John Emmas [Tue, 15 Nov 2016 11:12:25 +0000 (11:12 +0000)]
Accommodate a newly introduced source file in our MSVC project (libardour)

(although I'm not sure if it's actually used yet in the Windows build).

7 years agoreally fix windows compilation.
Robin Gareus [Tue, 15 Nov 2016 02:25:32 +0000 (03:25 +0100)]
really fix windows compilation.

7 years agoamend 5dc24971009 ...get the windows version to compile.
Robin Gareus [Tue, 15 Nov 2016 02:21:02 +0000 (03:21 +0100)]
amend 5dc24971009 ...get the windows version to compile.

eventually vststate_init() needs cleaning up, but not tonight.

7 years agoFrench translation update
Olivier Humbert [Tue, 15 Nov 2016 01:03:35 +0000 (02:03 +0100)]
French translation update

more translations

7 years agoAdding myself
Olivier Humbert [Tue, 15 Nov 2016 00:35:28 +0000 (01:35 +0100)]
Adding myself

adding my name

7 years agoFrench translation update
Olivier Humbert [Tue, 15 Nov 2016 00:32:04 +0000 (01:32 +0100)]
French translation update

one small fix

7 years agoFrench translation update
Olivier Humbert [Tue, 15 Nov 2016 00:24:56 +0000 (01:24 +0100)]
French translation update

A few more translations and fixes for French.

7 years agoFrench translation update
Olivier Humbert [Thu, 10 Nov 2016 01:26:55 +0000 (02:26 +0100)]
French translation update

This one:
* adds a French translation for a string
* adds myself on the header

7 years agoFrench translation update
Olivier Humbert [Thu, 10 Nov 2016 00:17:01 +0000 (01:17 +0100)]
French translation update

This translates one string.

7 years agorework 8e3b6c9ac (fstwin is C code, not C++)
Robin Gareus [Tue, 15 Nov 2016 01:49:30 +0000 (02:49 +0100)]
rework 8e3b6c9ac (fstwin is C code, not C++)

7 years agofix another typo (f30fbcaaf)
Robin Gareus [Tue, 15 Nov 2016 00:17:47 +0000 (01:17 +0100)]
fix another typo (f30fbcaaf)

7 years agoAdd missing #include
Robin Gareus [Mon, 14 Nov 2016 23:43:28 +0000 (00:43 +0100)]
Add missing #include

7 years agoFix some typo.
Robin Gareus [Mon, 14 Nov 2016 23:43:17 +0000 (00:43 +0100)]
Fix some typo.

7 years agoFix intermittent hang when stopping PortaudioBackend
Tim Mayberry [Mon, 14 Nov 2016 23:19:24 +0000 (09:19 +1000)]
Fix intermittent hang when stopping PortaudioBackend

This issue is not always reproducible but when it does occur it happens
somewhat consistently on both 32bit and 64bit builds(Tested on Windows 7).

The midiOutReset call does not return (or it takes so long that it might as
well be indefinite) and as it is not strictly necessary just remove it.

Resolves: http://tracker.ardour.org/view.php?id=7095

7 years agoshow VST preset clean/dirty state
Robin Gareus [Mon, 14 Nov 2016 23:32:19 +0000 (00:32 +0100)]
show VST preset clean/dirty state

7 years agoMacVST Program/Preset support
Robin Gareus [Mon, 14 Nov 2016 23:01:27 +0000 (00:01 +0100)]
MacVST Program/Preset support

7 years agoadd signal for VST state load
Robin Gareus [Mon, 14 Nov 2016 23:01:12 +0000 (00:01 +0100)]
add signal for VST state load

MacVST has no dedicated VST event-loop to directly handle this.

7 years agoFix crash when selecting MIDI note
Tim Mayberry [Mon, 14 Nov 2016 22:16:31 +0000 (08:16 +1000)]
Fix crash when selecting MIDI note

Replace now always invalid assertion with initialization

Related to #7110

7 years agoFix VST state-lock SNAFU (effSetChunk and process are exclusive)
Robin Gareus [Mon, 14 Nov 2016 20:05:36 +0000 (21:05 +0100)]
Fix VST state-lock SNAFU (effSetChunk and process are exclusive)

7 years agoconsolidate VSTState initialization
Robin Gareus [Mon, 14 Nov 2016 20:04:01 +0000 (21:04 +0100)]
consolidate VSTState initialization

7 years agoPass const references to plugin-list
Robin Gareus [Mon, 14 Nov 2016 18:39:00 +0000 (19:39 +0100)]
Pass const references to plugin-list

7 years agochange note selection node name - should fix 7110
nick_m [Mon, 14 Nov 2016 16:48:20 +0000 (03:48 +1100)]
change note selection node name - should fix 7110

7 years agoLater code depends on prev_t not being NULL, use an assert()
Robin Gareus [Mon, 14 Nov 2016 15:47:09 +0000 (16:47 +0100)]
Later code depends on prev_t not being NULL, use an assert()

7 years agotempo map cannot be empty (help static analyzer)
Robin Gareus [Mon, 14 Nov 2016 15:45:25 +0000 (16:45 +0100)]
tempo map cannot be empty (help static analyzer)

7 years agopotential fix for #7110 (older sessions have no id)
Robin Gareus [Mon, 14 Nov 2016 03:12:58 +0000 (04:12 +0100)]
potential fix for #7110 (older sessions have no id)

7 years agofix LV2 state versioning with session-templates
Robin Gareus [Mon, 14 Nov 2016 00:40:57 +0000 (01:40 +0100)]
fix LV2 state versioning with session-templates

7 years agoSuffix plugin type in instrument-list to avoid ambiguities
Robin Gareus [Mon, 14 Nov 2016 00:14:52 +0000 (01:14 +0100)]
Suffix plugin type in instrument-list to avoid ambiguities

7 years agoconst'ness FTW
Robin Gareus [Mon, 14 Nov 2016 00:13:48 +0000 (01:13 +0100)]
const'ness FTW

7 years agoregister some missing enums
Robin Gareus [Sun, 13 Nov 2016 23:26:56 +0000 (00:26 +0100)]
register some missing enums

7 years agoVST set defaults only once (initially)
Robin Gareus [Sun, 13 Nov 2016 17:48:33 +0000 (18:48 +0100)]
VST set defaults only once (initially)

Opening the generic plugin UI or re-opening the GUI will call
get_parameter_descriptor() again, and replace the defaults with
current values.

7 years agofix MacVST UI idle calls
Robin Gareus [Sun, 13 Nov 2016 17:47:08 +0000 (18:47 +0100)]
fix MacVST UI idle calls

7 years agocopy VST state on copy construction
Robin Gareus [Sun, 13 Nov 2016 15:34:27 +0000 (16:34 +0100)]
copy VST state on copy construction

This fixes issues with replicate instances & plugin-analysis instances
not using the same set of parameters.

7 years agodisable MacVST support (until it's ready)
Robin Gareus [Sun, 13 Nov 2016 15:33:18 +0000 (16:33 +0100)]
disable MacVST support (until it's ready)

7 years agobasic Mac VST Cocoa UI support
Robin Gareus [Sun, 13 Nov 2016 15:32:30 +0000 (16:32 +0100)]
basic Mac VST Cocoa UI support

7 years agoMac VST-2.x support
Robin Gareus [Sun, 13 Nov 2016 15:31:15 +0000 (16:31 +0100)]
Mac VST-2.x support

7 years agofix const-cast
Robin Gareus [Sat, 12 Nov 2016 15:20:43 +0000 (16:20 +0100)]
fix const-cast

7 years agofix typo in example script
Robin Gareus [Sat, 12 Nov 2016 15:19:36 +0000 (16:19 +0100)]
fix typo in example script

7 years agofix buffer overflow printing tempo/meter
Robin Gareus [Sat, 12 Nov 2016 15:19:27 +0000 (16:19 +0100)]
fix buffer overflow printing tempo/meter

7 years agoVST buffer paranoia
Robin Gareus [Fri, 11 Nov 2016 15:19:59 +0000 (16:19 +0100)]
VST buffer paranoia

7 years agofix compilation on osx
nick_m [Fri, 11 Nov 2016 10:35:13 +0000 (21:35 +1100)]
fix compilation on osx

7 years agoRefine instrument fan-out:
Robin Gareus [Fri, 11 Nov 2016 09:48:33 +0000 (10:48 +0100)]
Refine instrument fan-out:

* prefix (rather than suffix) portgroup-name
* check if group already exists
* disconnect targets (when autoconnect preference is enabled)
* expose tracks/busses option

7 years agoAdd option to zoom using button press in the time rulers and dragging vertically
Tim Mayberry [Tue, 9 Feb 2016 10:39:27 +0000 (20:39 +1000)]
Add option to zoom using button press in the time rulers and dragging vertically

This is a common operation used for zooming in other DAWs like Ableton Live and
Cubase. To support such a usage pattern without changing the existing behaviour
of the ruler area I've made it an option that is false by default.

The behaviour of RulerDragZoom is intentionally different than a CursorDrag
that occurs in the rest of the ruler area in that it doesn't follow the snap to
grid setting and no locate related stuff occurs until button release.

There are some issues with responsiveness with more than a few hundred regions
or a large amount of MIDI events/notes.

Implements feature #6768

7 years agoUse the frame corresponding to the current mouse position when zoom dragging
Tim Mayberry [Wed, 7 Sep 2016 03:06:33 +0000 (13:06 +1000)]
Use the frame corresponding to the current mouse position when zoom dragging

Editor::mouse_frame only works within the track canvas. If a zoom drag is
initiated and the mouse cursor goes outside of the track canvas the zoom
position should still based on the current x position of the cursor.

7 years agoChange Editor temporal zoom methods to be able to use different scale for the zoom
Tim Mayberry [Tue, 9 Feb 2016 10:37:53 +0000 (20:37 +1000)]
Change Editor temporal zoom methods to be able to use different scale for the zoom

7 years agostatic MonitorSection Action -- fixes #7098
Robin Gareus [Fri, 11 Nov 2016 02:54:50 +0000 (03:54 +0100)]
static MonitorSection Action -- fixes #7098

ActionManager registered actions are static global and cannot reference
an instance (this) directly.

7 years agokeep meterbridge on top
Robin Gareus [Fri, 11 Nov 2016 00:14:18 +0000 (01:14 +0100)]
keep meterbridge on top

7 years agoRemove a group when the last track in the group is removed
Robin Gareus [Thu, 10 Nov 2016 22:57:47 +0000 (23:57 +0100)]
Remove a group when the last track in the group is removed

7 years agoprevent crash during track-deletion (un-selecting deleted tracks)
Robin Gareus [Thu, 10 Nov 2016 22:04:12 +0000 (23:04 +0100)]
prevent crash during track-deletion (un-selecting deleted tracks)

7 years agoImplement instrument fan-out options (group, track/bus)
Robin Gareus [Thu, 10 Nov 2016 20:35:40 +0000 (21:35 +0100)]
Implement instrument fan-out options (group, track/bus)

7 years agoCorrect the #includes for 'ardour/midi_cursor.h' (see commit #ec12fccf08)
John Emmas [Thu, 10 Nov 2016 19:31:26 +0000 (19:31 +0000)]
Correct the #includes for 'ardour/midi_cursor.h' (see commit #ec12fccf08)

There are a couple of header files where we use a reference to class ARDOUR::MidiCursor (rather than a pointer). To keep MSVC happy we need to #include its header file, rather than simply using a forward reference.

7 years agoupdate lua script to follow Region API change.
nick_m [Thu, 10 Nov 2016 17:02:17 +0000 (04:02 +1100)]
update lua script to follow Region API change.

7 years agoremove debugging output
nick_m [Thu, 10 Nov 2016 16:26:21 +0000 (03:26 +1100)]
remove debugging output

7 years agoremove unused variable and debugging.
nick_m [Thu, 10 Nov 2016 16:16:09 +0000 (03:16 +1100)]
remove unused variable and debugging.

7 years agorename Region pos_beats -> quarter_note
nick_m [Tue, 8 Nov 2016 17:51:19 +0000 (04:51 +1100)]
rename Region pos_beats -> quarter_note

7 years agomore tempo documentation.
nick_m [Tue, 8 Nov 2016 15:23:43 +0000 (02:23 +1100)]
more tempo documentation.

7 years agoensure non-zero midi region length when tempo map changes.
nick_m [Tue, 8 Nov 2016 15:01:22 +0000 (02:01 +1100)]
ensure non-zero midi region length when tempo map changes.

7 years agoTempoSection note-types-per-minute node name goes back to beats-per-minute for now.
nick_m [Tue, 8 Nov 2016 14:42:33 +0000 (01:42 +1100)]
TempoSection note-types-per-minute node name goes back to beats-per-minute for now.