ardour.git
9 years agoremove ugly and unnecessary debugging output
Paul Davis [Wed, 10 Dec 2014 18:37:03 +0000 (13:37 -0500)]
remove ugly and unnecessary debugging output

9 years agoadd support for O_DIRECT/F_NOCACHE to check impact of buffer cache avoidance
Paul Davis [Wed, 10 Dec 2014 18:35:57 +0000 (13:35 -0500)]
add support for O_DIRECT/F_NOCACHE to check impact of buffer cache avoidance

9 years agoUse DEBUG_THREAD_SELF when using DEBUG_TRACE with pthread IDs
John Emmas [Wed, 10 Dec 2014 16:53:47 +0000 (16:53 +0000)]
Use DEBUG_THREAD_SELF when using DEBUG_TRACE with pthread IDs

(supports both normal pthreads usage and PTW32)

9 years agoremove unnecessary sleep
Paul Davis [Wed, 10 Dec 2014 16:46:28 +0000 (11:46 -0500)]
remove unnecessary sleep

9 years agoadd sndfile I/O test application, used for testing disk bandwidth for writing audio...
Paul Davis [Wed, 10 Dec 2014 16:44:55 +0000 (11:44 -0500)]
add sndfile I/O test application, used for testing disk bandwidth for writing audio files

9 years agouse correct conditional to choose between different DEBUG_THREAD_SELF macros
Paul Davis [Wed, 10 Dec 2014 16:07:18 +0000 (11:07 -0500)]
use correct conditional to choose between different DEBUG_THREAD_SELF macros

9 years agoadd DEBUG_THREAD_SELF to allow use of DEBUG_TRACE with thread IDs on both normal...
Paul Davis [Wed, 10 Dec 2014 14:32:25 +0000 (09:32 -0500)]
add DEBUG_THREAD_SELF to allow use of DEBUG_TRACE with thread IDs on both normal pthreads platforms and PTW32

9 years agoupdate_time_selection_display should work when in smart mode
Ben Loftis [Tue, 9 Dec 2014 22:18:30 +0000 (16:18 -0600)]
update_time_selection_display should work when in smart mode

9 years agoadd set-session-extents-from-edit-range
Ben Loftis [Tue, 9 Dec 2014 22:17:47 +0000 (16:17 -0600)]
add set-session-extents-from-edit-range

9 years agomore DEBUG::Butler output, formatting corrections, and a warning on cerr if capture...
Paul Davis [Tue, 9 Dec 2014 21:36:37 +0000 (16:36 -0500)]
more DEBUG::Butler output, formatting corrections, and a warning on cerr if capture/playback buffers are too full/empty

9 years agofix meter scale colors (meterbridge)
Robin Gareus [Tue, 9 Dec 2014 18:39:44 +0000 (19:39 +0100)]
fix meter scale colors (meterbridge)

9 years agoremove superfluous PBD/ARDOUR:: init calls
Robin Gareus [Tue, 9 Dec 2014 14:45:06 +0000 (15:45 +0100)]
remove superfluous PBD/ARDOUR:: init calls

this reverts 339670b

9 years agoadd DEBUG::Butler and use it
Paul Davis [Tue, 9 Dec 2014 15:18:29 +0000 (10:18 -0500)]
add DEBUG::Butler and use it

9 years agocorrect install location for .mo files (i18n) and cleanup LOCALEDIR use a bit
Paul Davis [Tue, 9 Dec 2014 13:19:11 +0000 (08:19 -0500)]
correct install location for .mo files (i18n) and cleanup LOCALEDIR use a bit

9 years agoinstall single color theme file during waf install
Paul Davis [Tue, 9 Dec 2014 03:18:50 +0000 (22:18 -0500)]
install single color theme file during waf install

9 years agoremove debug output
Paul Davis [Tue, 9 Dec 2014 03:09:37 +0000 (22:09 -0500)]
remove debug output

9 years agomore tweaking of color management.
Paul Davis [Tue, 9 Dec 2014 03:02:32 +0000 (22:02 -0500)]
more tweaking of color management.

User's own modification to NAME.colors are stored in $CONFIG/my-NAME.colors now.

9 years agoanother metric ton of color work
Paul Davis [Mon, 8 Dec 2014 23:19:11 +0000 (18:19 -0500)]
another metric ton of color work

9 years agolots more color work, closer and closer to being ready for ... being taken apart...
Paul Davis [Mon, 8 Dec 2014 20:52:18 +0000 (15:52 -0500)]
lots more color work, closer and closer to being ready for ... being taken apart again

9 years agochange packaging of GTK rc file for OS X and Linux.
Paul Davis [Mon, 8 Dec 2014 16:03:47 +0000 (11:03 -0500)]
change packaging of GTK rc file for OS X and Linux.

I cannot find the equivalent location for Windows

9 years agochange GTK rc file system to use just a single file, which is color-neutral.
Paul Davis [Mon, 8 Dec 2014 16:00:00 +0000 (11:00 -0500)]
change GTK rc file system to use just a single file, which is color-neutral.

* packaging scripts need modification
* light theme file left in place to help with possible generation of alternate theme

9 years agomore color work, including removing rgba{_p_}_from_style()
Paul Davis [Mon, 8 Dec 2014 15:13:27 +0000 (10:13 -0500)]
more color work, including removing rgba{_p_}_from_style()

9 years agonoop, simplify code.
Robin Gareus [Mon, 8 Dec 2014 17:46:54 +0000 (18:46 +0100)]
noop, simplify code.

(!mixer || !editor) are checked at the top of the funtion
and also used without checks further down.

9 years agoWhen we pass an integer clarify which overloaded version of sqrt() to call
John Emmas [Mon, 8 Dec 2014 10:29:45 +0000 (10:29 +0000)]
When we pass an integer clarify which overloaded version of sqrt() to call

9 years agoDon't switch to internal when switching to draw.
David Robillard [Mon, 8 Dec 2014 04:59:07 +0000 (23:59 -0500)]
Don't switch to internal when switching to draw.

9 years agoFix alignment of automation paste.
David Robillard [Mon, 8 Dec 2014 04:16:42 +0000 (23:16 -0500)]
Fix alignment of automation paste.

Preserve alignment between notes and control points when doing an internal
copy/paste of both.

Relative alignment between points on multi-paste is still not preserved.  Both
behaviours here are actually useful, perhaps a modifier...

9 years agoFix uninitialized value in note create drag.
David Robillard [Mon, 8 Dec 2014 01:36:32 +0000 (20:36 -0500)]
Fix uninitialized value in note create drag.

9 years agoDraw region automation with draw in either mode.
David Robillard [Mon, 8 Dec 2014 00:54:47 +0000 (19:54 -0500)]
Draw region automation with draw in either mode.

Perhaps debatable if contents should be edited when not in internal mode
whatsoever, but consistent with audio region gain and track automation.  It's
less of a problem with the draw tool than, say, object since drawing stuff is
its entire purpose.

9 years agoUnify gain and draw tools.
David Robillard [Mon, 8 Dec 2014 00:53:46 +0000 (19:53 -0500)]
Unify gain and draw tools.

There might be a few special cases lingering around from attempts at magic tool
business, but this seems to work fine as far as I can tell.

9 years agoFix and simplify step_mouse_mode.
David Robillard [Mon, 8 Dec 2014 00:04:33 +0000 (19:04 -0500)]
Fix and simplify step_mouse_mode.

9 years agoFix shift-rect-select with MIDI notes.
David Robillard [Sun, 7 Dec 2014 22:29:48 +0000 (17:29 -0500)]
Fix shift-rect-select with MIDI notes.

9 years agonew code-level defaults for audio peak meter colors
Paul Davis [Sun, 7 Dec 2014 21:11:09 +0000 (16:11 -0500)]
new code-level defaults for audio peak meter colors

9 years agoRevert "new code-level defaults for audio peak meter colors"
Paul Davis [Sun, 7 Dec 2014 21:10:39 +0000 (16:10 -0500)]
Revert "new code-level defaults for audio peak meter colors"

This reverts commit 564d2860f85340ea091cfa4d92cb5f84d2a40fb1.

9 years agonew code-level defaults for audio peak meter colors
Paul Davis [Sun, 7 Dec 2014 21:09:52 +0000 (16:09 -0500)]
new code-level defaults for audio peak meter colors

9 years agosane audio meter default colors
Robin Gareus [Sun, 7 Dec 2014 21:01:26 +0000 (22:01 +0100)]
sane audio meter default colors

9 years agoremove old alias names for meter fills from default_ui_config
Paul Davis [Sun, 7 Dec 2014 20:12:28 +0000 (15:12 -0500)]
remove old alias names for meter fills from default_ui_config

9 years agothe return of correct audio meter colors
Paul Davis [Sun, 7 Dec 2014 20:06:33 +0000 (15:06 -0500)]
the return of correct audio meter colors

9 years agoremove stacktrace
Paul Davis [Sun, 7 Dec 2014 19:23:24 +0000 (14:23 -0500)]
remove stacktrace

9 years agofix up various issues with UIConfiguration, saving state, RC file loading etc.
Paul Davis [Sun, 7 Dec 2014 19:20:17 +0000 (14:20 -0500)]
fix up various issues with UIConfiguration, saving state, RC file loading etc.

9 years agoremove all explicit button text colors; use contrasting_text_color() instead.
Paul Davis [Sun, 7 Dec 2014 18:55:40 +0000 (13:55 -0500)]
remove all explicit button text colors; use contrasting_text_color() instead.

Also, use a slightly off-white rather than pure white, which should really be configurable

9 years agofix up a logic problem when editing palette colors
Paul Davis [Sun, 7 Dec 2014 18:44:12 +0000 (13:44 -0500)]
fix up a logic problem when editing palette colors

9 years agoremove debug output
Paul Davis [Sun, 7 Dec 2014 18:44:00 +0000 (13:44 -0500)]
remove debug output

9 years agofix default gtk background color
Paul Davis [Sun, 7 Dec 2014 18:43:40 +0000 (13:43 -0500)]
fix default gtk background color

9 years agobig strides in color management
Paul Davis [Sun, 7 Dec 2014 18:12:36 +0000 (13:12 -0500)]
big strides in color management

9 years agorevert UIConfiguration back to a normal member of ARDOUR_UI
Paul Davis [Sun, 7 Dec 2014 18:12:21 +0000 (13:12 -0500)]
revert UIConfiguration back to a normal member of ARDOUR_UI

9 years agofirst mostly-working build supporting GTK rethemeing via the Theme Manager
Paul Davis [Sat, 6 Dec 2014 20:27:18 +0000 (15:27 -0500)]
first mostly-working build supporting GTK rethemeing via the Theme Manager

9 years agoAdd a newly introduced header file to our MSVC project (gtk2_ardour)
John Emmas [Sun, 7 Dec 2014 13:32:50 +0000 (13:32 +0000)]
Add a newly introduced header file to our MSVC project (gtk2_ardour)

9 years agoAdd some newly introduced source files to our MSVC project (libardour)
John Emmas [Sun, 7 Dec 2014 13:31:41 +0000 (13:31 +0000)]
Add some newly introduced source files to our MSVC project (libardour)

9 years agoMake draw tool add points to track automation.
David Robillard [Sun, 7 Dec 2014 05:26:00 +0000 (00:26 -0500)]
Make draw tool add points to track automation.

9 years agoAdd legatize and remove overlap MIDI operations.
David Robillard [Sun, 7 Dec 2014 04:42:11 +0000 (23:42 -0500)]
Add legatize and remove overlap MIDI operations.

We're going to need the ability to apply MIDI edit operations to a note/control
selection soon...

9 years agoSupport keyboard shift-click to select many notes.
David Robillard [Sun, 7 Dec 2014 03:02:25 +0000 (22:02 -0500)]
Support keyboard shift-click to select many notes.

Also support selecting with button 1 if shift is held, more discoverable.

9 years agoNudge notes by 1 bar if secondary modifier active.
David Robillard [Sun, 7 Dec 2014 02:29:48 +0000 (21:29 -0500)]
Nudge notes by 1 bar if secondary modifier active.

Similar to how transpose moves an octave if the same modifier is active.

9 years agoRemove unnecessary includes.
David Robillard [Sun, 7 Dec 2014 01:58:58 +0000 (20:58 -0500)]
Remove unnecessary includes.

9 years agoAllow creation of MIDI control points object tool.
David Robillard [Sun, 7 Dec 2014 01:01:06 +0000 (20:01 -0500)]
Allow creation of MIDI control points object tool.

9 years agoGrab keyboard only with note selection.
David Robillard [Sun, 7 Dec 2014 00:56:36 +0000 (19:56 -0500)]
Grab keyboard only with note selection.

When entered, the keyboard is grabbed when the selection becomes non-empty, and
ungrabbed if it becomes empty again or the region is left or the user switches
out of internal mode.

This fixes scroll in internal mode and note moving with arrow keys.  Also frees
up useful keybindings when there is no note selection, which is much nicer than
the "nothing works in edit mode at all" greedy grab approach used previously.

Attempt #874327892 of getting this damned grabbing right.

9 years agoFix crash on quit when in a non-route time axis.
David Robillard [Sat, 6 Dec 2014 23:42:35 +0000 (18:42 -0500)]
Fix crash on quit when in a non-route time axis.

9 years agoInvalidate iterator whenever model changes.
David Robillard [Sat, 6 Dec 2014 23:04:30 +0000 (18:04 -0500)]
Invalidate iterator whenever model changes.

I suspect this is an underlying cause of several tricky to reproduce bugs, but
we'll have to wait around and see...

9 years agoFix crash on shift+rclick of region to remove.
David Robillard [Sat, 6 Dec 2014 23:02:36 +0000 (18:02 -0500)]
Fix crash on shift+rclick of region to remove.

This doesn't seem to have been touched for years, and I don't see how such an
obvious bug could possibly have been around for so long, but, well, this fixes
it as far as I can tell.

9 years agoFix crash when resizing a track quickly.
David Robillard [Sat, 6 Dec 2014 22:46:12 +0000 (17:46 -0500)]
Fix crash when resizing a track quickly.

Triggered by resize drag an automation track very quickly upwards to shrink it
to the minimum.  Caused by unsigned integer underflow.

9 years agomidnam test: don't clutter up output.
Robin Gareus [Sat, 6 Dec 2014 22:51:33 +0000 (23:51 +0100)]
midnam test: don't clutter up output.

9 years agoFix crash when showing MIDI regions we shouldn't.
David Robillard [Sat, 6 Dec 2014 21:46:00 +0000 (16:46 -0500)]
Fix crash when showing MIDI regions we shouldn't.

I am not sure what causes this, but it can happen when finishing a record
sometimes.  Probably MidiSource::_writing isn't updated in the right order with
whatever triggers the redisplay, but at least not crashing is better...

9 years agoFix inappropriately massive flag font.
David Robillard [Sat, 6 Dec 2014 21:07:32 +0000 (16:07 -0500)]
Fix inappropriately massive flag font.

9 years agoFix patch flag scroll theft when in normal mode.
David Robillard [Sat, 6 Dec 2014 21:05:47 +0000 (16:05 -0500)]
Fix patch flag scroll theft when in normal mode.

9 years agoFix seek in linearly interpolated control lists.
David Robillard [Sat, 6 Dec 2014 20:44:10 +0000 (15:44 -0500)]
Fix seek in linearly interpolated control lists.

9 years agoAdapt range when copying between automation types.
David Robillard [Sat, 6 Dec 2014 18:37:08 +0000 (13:37 -0500)]
Adapt range when copying between automation types.

For things like copying from pitch bender to a CC.

Also things like fader to pan, but that seems a bit funny.  The conversion
probably needs to be a bit smarter here, perhaps taking the normal into
consideration...

9 years agoRestore an accidentally deleted #include
John Emmas [Sat, 6 Dec 2014 17:47:53 +0000 (17:47 +0000)]
Restore an accidentally deleted #include

9 years agoSupport paste between automation lanes.
David Robillard [Sat, 6 Dec 2014 17:20:52 +0000 (12:20 -0500)]
Support paste between automation lanes.

Also push the increasingly unwieldly paste parameters into a context object.

As with othe things, currently it is only possible to do "cross-type paste" by
explicitly selecting the target track.  We will need to get automation region
view selection working to do better here, but at least for now it's possible to
get the data over.

9 years agoFix wacky return type.
David Robillard [Sat, 6 Dec 2014 17:19:52 +0000 (12:19 -0500)]
Fix wacky return type.

9 years agoFix uninitialized members.
David Robillard [Sat, 6 Dec 2014 17:06:48 +0000 (12:06 -0500)]
Fix uninitialized members.

9 years agoMore potential SMF crash fixes.
David Robillard [Sat, 6 Dec 2014 16:19:48 +0000 (11:19 -0500)]
More potential SMF crash fixes.

9 years agoPossible half-fix for SMF crash.
David Robillard [Sat, 6 Dec 2014 15:37:08 +0000 (10:37 -0500)]
Possible half-fix for SMF crash.

9 years agoUse source-relative time converter directly.
David Robillard [Sat, 6 Dec 2014 15:27:18 +0000 (10:27 -0500)]
Use source-relative time converter directly.

9 years agoFix internal paste when selection has only points.
David Robillard [Sat, 6 Dec 2014 15:26:25 +0000 (10:26 -0500)]
Fix internal paste when selection has only points.

9 years agoAdd a newly introduced header file to our MSVC project (gtk2_ardour)
John Emmas [Sat, 6 Dec 2014 11:02:37 +0000 (11:02 +0000)]
Add a newly introduced header file to our MSVC project (gtk2_ardour)

9 years agofix/amend pre commit
Robin Gareus [Sat, 6 Dec 2014 07:24:21 +0000 (08:24 +0100)]
fix/amend pre commit

9 years agofix another ambiguity, this time: WINAPI Rectangle
Robin Gareus [Sat, 6 Dec 2014 06:40:17 +0000 (07:40 +0100)]
fix another ambiguity, this time: WINAPI Rectangle

9 years agofix ambiguous reference.
Robin Gareus [Sat, 6 Dec 2014 04:52:31 +0000 (05:52 +0100)]
fix ambiguous reference.

OSX CoreServices typedef's struct Rect

9 years agofix typo in wscript
Robin Gareus [Sat, 6 Dec 2014 01:42:14 +0000 (02:42 +0100)]
fix typo in wscript

9 years agoMake scroll work on MIDI regions when internal.
David Robillard [Fri, 5 Dec 2014 21:54:29 +0000 (16:54 -0500)]
Make scroll work on MIDI regions when internal.

For some reason, grabbing the magic keyboard focus makes scroll stop working
regardless of what MRV::canvas_group_event() returns.  I can't figure out any
reason to grab the keyboard in this case anyway, so I just removed it.

Also simlify MRV event handling code in general.

9 years agoexperimental drawing optimization.
Robin Gareus [Fri, 5 Dec 2014 21:40:26 +0000 (22:40 +0100)]
experimental drawing optimization.

Q: is bounding_box(); etc more complex than queuing draw?

either way, canvas should eventually switch to
use an optimized OptimizingLookupTable.

9 years agoFix stuck faders on very fine adjustments.
David Robillard [Fri, 5 Dec 2014 20:16:54 +0000 (15:16 -0500)]
Fix stuck faders on very fine adjustments.

I attempted to preserve the "don't draw unless different" by ditching rounding for more
precise display_span, but that didn't work.  An alternative solution would be
to draw on adjustment change if there's text, since then we need to redraw
regardless of slider position, but it seemed weird even just with respect to
the slider, so I opted for this, which really definitely redraws when the
adjustment changes, period.

If this proves to be a performance issue we'll have to figure that out.

9 years agofix small memory leak in the tests
Robin Gareus [Fri, 5 Dec 2014 19:50:32 +0000 (20:50 +0100)]
fix small memory leak in the tests

9 years agoupdate to 'new' ControlList API
Robin Gareus [Fri, 5 Dec 2014 19:50:09 +0000 (20:50 +0100)]
update to 'new' ControlList API

add (double when, double value, bool with_guards=true, bool with_default=true);

9 years agoif a Route's processor lock cannot be taken, fill buffers with silence (causing click...
Paul Davis [Fri, 5 Dec 2014 19:49:21 +0000 (14:49 -0500)]
if a Route's processor lock cannot be taken, fill buffers with silence (causing click) rather than abort()

9 years agofix "expected" <> "actual" semantics in test-util
Robin Gareus [Fri, 5 Dec 2014 17:17:21 +0000 (18:17 +0100)]
fix "expected" <> "actual" semantics in test-util

9 years agosave and restore color aliases
Paul Davis [Fri, 5 Dec 2014 16:17:56 +0000 (11:17 -0500)]
save and restore color aliases

9 years agoadd default (for now) color aliases to default_ui_config
Paul Davis [Fri, 5 Dec 2014 16:17:43 +0000 (11:17 -0500)]
add default (for now) color aliases to default_ui_config

9 years agoadded new header file for color aliases
Paul Davis [Fri, 5 Dec 2014 14:36:55 +0000 (09:36 -0500)]
added new header file for color aliases

9 years agopart two of remove CANVAS_STRING_VARIABLE (it was replaced by CANVAS_FONT_VARIABLE
Paul Davis [Fri, 5 Dec 2014 14:26:12 +0000 (09:26 -0500)]
part two of remove CANVAS_STRING_VARIABLE (it was replaced by CANVAS_FONT_VARIABLE

9 years agoremove CANVAS_STRING_VARIABLE (it was replaced by CANVAS_FONT_VARIABLE
Paul Davis [Fri, 5 Dec 2014 14:25:34 +0000 (09:25 -0500)]
remove CANVAS_STRING_VARIABLE (it was replaced by CANVAS_FONT_VARIABLE

9 years agoseveral steps closer to more sane color system
Paul Davis [Fri, 5 Dec 2014 14:01:49 +0000 (09:01 -0500)]
several steps closer to more sane color system

9 years agoinclude alpha-delta computation in HSV::delta()
Paul Davis [Fri, 5 Dec 2014 14:00:36 +0000 (09:00 -0500)]
include alpha-delta computation in HSV::delta()

9 years agocorrect alias definitions in default derived color list
Paul Davis [Fri, 5 Dec 2014 14:00:01 +0000 (09:00 -0500)]
correct alias definitions in default derived color list

9 years agomake new color aliases actually work
Paul Davis [Tue, 2 Dec 2014 12:05:14 +0000 (07:05 -0500)]
make new color aliases actually work

9 years agoworking compilation for new color code
Paul Davis [Mon, 1 Dec 2014 14:16:30 +0000 (09:16 -0500)]
working compilation for new color code

9 years agoAdd 'pbd/crossthread.cc' to the MSVC build
John Emmas [Fri, 5 Dec 2014 08:40:47 +0000 (08:40 +0000)]
Add 'pbd/crossthread.cc' to the MSVC build

9 years agoMake recorded MIDI controls discrete, take 2.
David Robillard [Fri, 5 Dec 2014 05:15:40 +0000 (00:15 -0500)]
Make recorded MIDI controls discrete, take 2.

Hopefully-desired behaviour is that controls created in the GUI are linear, so
clicking in stuff works like other automation, but controls that originated
from recording are set to discrete so Ardour plays back the input exactly,
instead of doing crazy things like linear interpolation of already high-rate
user input, hold pedals, and so on.

Hopefully that remains the desired behaviour, because we're basically screwed
for ever making any control discrete by default, since we only save the mode to
XML at all if it's not the default, which is currently linear.

9 years agoRevert "Create discrete lists for recorded MIDI controls."
David Robillard [Fri, 5 Dec 2014 05:03:47 +0000 (00:03 -0500)]
Revert "Create discrete lists for recorded MIDI controls."

This broke saving/restoring interpolation style.

This reverts commit 07a381a8f5572ae7550c60e5b1bd18c3dcdc7369.

9 years agoAdd MIDI control points only in internal/pencil.
David Robillard [Fri, 5 Dec 2014 03:40:39 +0000 (22:40 -0500)]
Add MIDI control points only in internal/pencil.

9 years agoFix crash when twiddling MIDI controllers (#6050).
David Robillard [Fri, 5 Dec 2014 03:23:16 +0000 (22:23 -0500)]
Fix crash when twiddling MIDI controllers (#6050).