Copy .id files back to output for .dmg builds.
[cdist.git] / cdist
diff --git a/cdist b/cdist
index 2354e643151950c92c4e57c3efa96db0f73f428a..f1322fb3cb1dde713049433abdaf2791874469a2 100755 (executable)
--- a/cdist
+++ b/cdist
@@ -115,6 +115,7 @@ class Config:
                          Option('osx_sdk'),
                          Option('osx_intel_deployment'),
                          Option('osx_arm_deployment'),
+                         Option('osx_old_deployment'),
                          Option('osx_keychain_file'),
                          Option('osx_keychain_password'),
                          Option('apple_id'),
@@ -748,6 +749,14 @@ def notarize_dmg(dmg, bundle_id):
                 return lines[i+1].strip().replace('<string>', '').replace('</string>', '')
 
     request_uuid = string_after(p, "RequestUUID")
+    if request_uuid is None:
+        print("Looking for upload ID")
+        message = string_after(p, "message")
+        print("Looking in %s" % message)
+        if message:
+            m = re.match('.*The upload ID is ([0-9a-f\-]*)', message)
+            if m:
+                request_uuid = m.groups()[0]
     if request_uuid is None:
         print("Response: %s" % p)
         raise Error('No RequestUUID found in response from Apple')
@@ -797,35 +806,47 @@ class OSXTarget(Target):
             if notarize:
                 notarize_dmg(x[0], x[1])
             else:
-                with f as f.open(dmg + '.id', 'w'):
-                    print(out=f, x[1])
+                with open(x[0] + '.id', 'w') as f:
+                    print(x[1], file=f)
         return [x[0] for x in p]
 
 
 class OSXSingleTarget(OSXTarget):
-    def __init__(self, arch, sdk, deployment, directory=None):
+    def __init__(self, arch, sdk, deployment, directory=None, can_notarize=True):
         super(OSXSingleTarget, self).__init__(directory)
         self.arch = arch
         self.sdk = sdk
         self.deployment = deployment
+        self.can_notarize = can_notarize
+        self.sub_targets = [self]
 
         flags = '-isysroot %s/MacOSX%s.sdk -arch %s' % (self.sdk_prefix, sdk, arch)
-        host_enviro = '%s/x86_64' % config.get('osx_environment_prefix')
-        target_enviro = '%s/%s' % (config.get('osx_environment_prefix'), arch)
+        if arch == 'x86_64':
+            host_enviro = '%s/x86_64/%s' % (config.get('osx_environment_prefix'), deployment)
+        else:
+            host_enviro = '%s/x86_64/10.10' % config.get('osx_environment_prefix')
+        target_enviro = '%s/%s/%s' % (config.get('osx_environment_prefix'), arch, deployment)
 
         self.bin = '%s/bin' % target_enviro
 
         # Environment variables
         self.set('CFLAGS', '"-I%s/include -I%s/include %s"' % (self.directory, target_enviro, flags))
         self.set('CPPFLAGS', '')
-        self.set('CXXFLAGS', '"-I%s/include -I%s/include %s"' % (self.directory, target_enviro, flags))
-        self.set('LDFLAGS', '"-L%s/lib -L%s/lib %s"' % (self.directory, target_enviro, flags))
+        self.set('CXXFLAGS', '"-I%s/include -I%s/include -stdlib=libc++ %s"' % (self.directory, target_enviro, flags))
+        self.set('LDFLAGS', '"-L%s/lib -L%s/lib -stdlib=libc++ %s"' % (self.directory, target_enviro, flags))
         self.set('LINKFLAGS', '"-L%s/lib -L%s/lib %s"' % (self.directory, target_enviro, flags))
         self.set('PKG_CONFIG_PATH', '%s/lib/pkgconfig:%s/lib/pkgconfig:/usr/lib/pkgconfig' % (self.directory, target_enviro))
         self.set('PATH', '$PATH:/usr/bin:/sbin:/usr/local/bin:%s/bin' % host_enviro)
         self.set('MACOSX_DEPLOYMENT_TARGET', self.deployment)
         self.set('CCACHE_BASEDIR', self.directory)
 
+    def _copy_packages(self, tree, packages, output_dir):
+        for p in packages:
+            dest = os.path.join(output_dir, os.path.basename(devel_to_git(tree.git_commit, p)))
+            copyfile(p, dest)
+            if os.path.exists(p + ".id"):
+                copyfile(p + ".id", dest + ".id")
+
     @Target.ccache.setter
     def ccache(self, v):
         Target.ccache.fset(self, v)
@@ -837,7 +858,7 @@ class OSXSingleTarget(OSXTarget):
         tree = self.build(project, checkout, options)
         tree.add_defaults(options)
         self.unlock_keychain()
-        p = self._cscript_package_and_notarize(tree, options, notarize)
+        p = self._cscript_package_and_notarize(tree, options, self.can_notarize and notarize)
         self._copy_packages(tree, p, output_dir)
 
 
@@ -845,11 +866,14 @@ class OSXUniversalTarget(OSXTarget):
     def __init__(self, directory=None):
         super(OSXUniversalTarget, self).__init__(directory)
         self.sdk = config.get('osx_sdk')
-
-    def package(self, project, checkout, output_dir, options, notarize):
+        self.sub_targets = []
         for arch, deployment in (('x86_64', config.get('osx_intel_deployment')), ('arm64', config.get('osx_arm_deployment'))):
-            target = OSXSingleTarget(arch, self.sdk, deployment, os.path.join(self.directory, arch))
+            target = OSXSingleTarget(arch, self.sdk, deployment, os.path.join(self.directory, arch, deployment))
             target.ccache = self.ccache
+            self.sub_targets.append(target)
+
+    def package(self, project, checkout, output_dir, options, notarize):
+        for target in self.sub_targets:
             tree = globals.trees.get(project, checkout, target)
             tree.build_dependencies(options)
             tree.build(options)
@@ -857,8 +881,8 @@ class OSXUniversalTarget(OSXTarget):
         self.unlock_keychain()
         tree = globals.trees.get(project, checkout, self)
         with TreeDirectory(tree):
-            for p in self._cscript_package_and_notarize(tree, options, notarize):
-                copyfile(p, os.path.join(output_dir, os.path.basename(devel_to_git(tree.git_commit, p))))
+            p = self._cscript_package_and_notarize(tree, options, notarize)
+            self._copy_packages(tree, p, output_dir)
 
 class SourceTarget(Target):
     """Build a source .tar.bz2"""
@@ -922,6 +946,8 @@ def target_factory(args):
         target = OSXUniversalTarget(args.work)
     elif s == 'osx-intel':
         target = OSXSingleTarget('x86_64', config.get('osx_sdk'), config.get('osx_intel_deployment'), args.work)
+    elif s == 'osx-old':
+        target = OSXSingleTarget('x86_64', config.get('osx_sdk'), config.get('osx_old_deployment'), args.work, False)
     elif s == 'source':
         target = SourceTarget()
     elif s == 'flatpak':
@@ -1205,7 +1231,7 @@ def main():
         if not os.path.exists(args.work):
             os.makedirs(args.work)
 
-    if args.project is None and args.command != 'shell':
+    if args.project is None and not args.command in ['shell', 'notarize']:
         raise Error('you must specify -p or --project')
 
     globals.quiet = args.quiet
@@ -1388,15 +1414,13 @@ def main():
     elif args.command == 'notarize':
         if args.dmgs is None:
             raise Error('you must specify ---dmgs')
-        if args.no_notarize:
-            raise Error('it makes no sense to pass --no-notarize with the notarize command')
 
-        for dmg in Path(args.dmgs).iter():
+        for dmg in Path(args.dmgs).glob('*.dmg'):
             id = None
             try:
-                with open(dmg + '.id') as f:
-                    id = f.getline().strip()
-            catch OSError:
+                with open(str(dmg) + '.id') as f:
+                    id = f.readline().strip()
+            except OSError:
                 raise Error('could not find ID file for %s' % dmg)
             notarize_dmg(dmg, id)