Fix various bugs in subtitle/ccap verification.
authorCarl Hetherington <cth@carlh.net>
Mon, 15 Mar 2021 00:36:51 +0000 (01:36 +0100)
committerCarl Hetherington <cth@carlh.net>
Mon, 15 Mar 2021 00:36:51 +0000 (01:36 +0100)
commit2c1faeb15715794525f48110c2b8a9df96b387c1
treec03b560ca0302d3d51fc0a9252f2574100e01f0b
parentf80f5f533ab09f64a022314380b2969b6ef88ec3
Fix various bugs in subtitle/ccap verification.

Check that subtitles don't overlap reel boundaries, and fix a few
tests that trip this check.

Fix confusion when calculating subtitle timings during verification
where the picture asset frame rate was being used rather than the
subtitle asset's edit rate.

Do the subtitle timing verification for Interop as well as SMPTE
subtitles.

Take <StartTime> tags into account when checking subtitles, even
though Bv2.1 says they should be set to 0.

Rename Time::as_editable_units to Time::as_editable_units_ceil
and add a _floor variant, then use that to round down when checking
reel boundary overlaps.
src/dcp_time.cc
src/dcp_time.h
src/reel_markers_asset.cc
src/smpte_subtitle_asset.cc
src/subtitle_asset_internal.cc
src/verify.cc
src/verify.h
test/verify_test.cc