libdcp.git
20 months agoTolerate missing FullContentTitleText (DoM bug #2295). 2295-tolerate-missing-full-content-title v1.8.25
Carl Hetherington [Mon, 15 Aug 2022 15:34:29 +0000 (17:34 +0200)]
Tolerate missing FullContentTitleText (DoM bug #2295).

20 months agoStop assuming that the presence of FullContentTitleText means that there was CPL...
Carl Hetherington [Mon, 15 Aug 2022 14:54:40 +0000 (16:54 +0200)]
Stop assuming that the presence of FullContentTitleText means that there was CPL metadata.

20 months agoFix undefined memory warning during tests.
Carl Hetherington [Wed, 10 Aug 2022 20:14:07 +0000 (22:14 +0200)]
Fix undefined memory warning during tests.

20 months agoFix script for Fedora.
Carl Hetherington [Wed, 10 Aug 2022 20:13:58 +0000 (22:13 +0200)]
Fix script for Fedora.

21 months agoFix thinko in previous commit. v1.8.24
Carl Hetherington [Fri, 15 Jul 2022 08:57:02 +0000 (10:57 +0200)]
Fix thinko in previous commit.

21 months agoClose assets on destruction even if finalize() is not called. v1.8.23
Carl Hetherington [Thu, 14 Jul 2022 21:51:21 +0000 (23:51 +0200)]
Close assets on destruction even if finalize() is not called.

21 months agoAllow tests to be run on Fedora.
Carl Hetherington [Thu, 14 Jul 2022 21:50:56 +0000 (23:50 +0200)]
Allow tests to be run on Fedora.

21 months agoUpdate comment to reflect strange aspects of subtitle alignment standards.
Carl Hetherington [Thu, 14 Jul 2022 21:30:47 +0000 (23:30 +0200)]
Update comment to reflect strange aspects of subtitle alignment standards.

22 months agoAdd another warning to LIBDCP_DISABLE_WARNINGS mac-warning v1.8.22
Carl Hetherington [Tue, 21 Jun 2022 09:45:13 +0000 (11:45 +0200)]
Add another warning to LIBDCP_DISABLE_WARNINGS

22 months agoBump asdcplib for build fix. v1.8.21
Carl Hetherington [Mon, 20 Jun 2022 11:02:43 +0000 (13:02 +0200)]
Bump asdcplib for build fix.

22 months agoMake an error a little more detailed.
Carl Hetherington [Fri, 3 Jun 2022 13:11:50 +0000 (15:11 +0200)]
Make an error a little more detailed.

22 months agoBump asdcplib for some more logging.
Carl Hetherington [Mon, 13 Jun 2022 22:33:31 +0000 (00:33 +0200)]
Bump asdcplib for some more logging.

22 months agoMake size_in_pixels() more accurate. v1.8.20
Carl Hetherington [Sun, 5 Jun 2022 21:46:37 +0000 (23:46 +0200)]
Make size_in_pixels() more accurate.

23 months agoMissing install of a header. v1.8.19
Carl Hetherington [Sun, 8 May 2022 22:57:19 +0000 (00:57 +0200)]
Missing install of a header.

23 months agoExtract, test and slightly adjust the piecewise LUT for inverse gamma.
Carl Hetherington [Sun, 8 May 2022 21:47:12 +0000 (23:47 +0200)]
Extract, test and slightly adjust the piecewise LUT for inverse gamma.

23 months agoAnother missing include.
Carl Hetherington [Fri, 6 May 2022 21:52:04 +0000 (23:52 +0200)]
Another missing include.

23 months agoFix scaling ranges to be the same as they used to be.
Carl Hetherington [Fri, 6 May 2022 08:32:02 +0000 (10:32 +0200)]
Fix scaling ranges to be the same as they used to be.

23 months agoTypo in function name.
Carl Hetherington [Fri, 6 May 2022 21:43:06 +0000 (23:43 +0200)]
Typo in function name.

23 months agoMissing includes.
Carl Hetherington [Thu, 5 May 2022 22:33:57 +0000 (00:33 +0200)]
Missing includes.

23 months agoTweak whitespace. file-class-in-dom
Carl Hetherington [Fri, 15 Apr 2022 20:41:23 +0000 (22:41 +0200)]
Tweak whitespace.

23 months agoAdd ::puts().
Carl Hetherington [Fri, 15 Apr 2022 20:40:52 +0000 (22:40 +0200)]
Add ::puts().

23 months agoAdd ::tell().
Carl Hetherington [Fri, 15 Apr 2022 20:33:43 +0000 (22:33 +0200)]
Add ::tell().

23 months agoMove fix_long_path tests over from DoM.
Carl Hetherington [Wed, 13 Apr 2022 22:36:24 +0000 (00:36 +0200)]
Move fix_long_path tests over from DoM.

23 months agoAdd accessor for use with things like fprintf().
Carl Hetherington [Wed, 13 Apr 2022 22:19:55 +0000 (00:19 +0200)]
Add accessor for use with things like fprintf().

23 months agoAdd move constructor.
Carl Hetherington [Wed, 13 Apr 2022 22:02:42 +0000 (00:02 +0200)]
Add move constructor.

23 months agoAdd header guard.
Carl Hetherington [Wed, 13 Apr 2022 21:59:19 +0000 (23:59 +0200)]
Add header guard.

23 months agoAdd ::seek().
Carl Hetherington [Wed, 13 Apr 2022 21:37:19 +0000 (23:37 +0200)]
Add ::seek().

23 months agoAdd ::take().
Carl Hetherington [Wed, 13 Apr 2022 21:30:26 +0000 (23:30 +0200)]
Add ::take().

23 months agoAdd checked_{read,write} from DoM.
Carl Hetherington [Wed, 13 Apr 2022 21:19:17 +0000 (23:19 +0200)]
Add checked_{read,write} from DoM.

23 months agoCopy and use fix_long_path from DoM.
Carl Hetherington [Wed, 13 Apr 2022 21:05:39 +0000 (23:05 +0200)]
Copy and use fix_long_path from DoM.

23 months agoRemove unnecessary using inaccurate-gamma2
Carl Hetherington [Thu, 5 May 2022 19:25:37 +0000 (21:25 +0200)]
Remove unnecessary using

23 months agoUse 2 LUTs for output gamma to improve accuracy (DoM #2242).
Carl Hetherington [Thu, 5 May 2022 19:02:40 +0000 (21:02 +0200)]
Use 2 LUTs for output gamma to improve accuracy (DoM #2242).

23 months agoAllow LUTs to be created with a particular range.
Carl Hetherington [Thu, 5 May 2022 18:56:14 +0000 (20:56 +0200)]
Allow LUTs to be created with a particular range.

23 months agoUse std::vector for LUTs.
Carl Hetherington [Thu, 5 May 2022 18:31:26 +0000 (20:31 +0200)]
Use std::vector for LUTs.

23 months agoAdd a new (failing) test which exposes inaccuracies in inverse gamma.
Carl Hetherington [Thu, 5 May 2022 13:35:51 +0000 (15:35 +0200)]
Add a new (failing) test which exposes inaccuracies in inverse gamma.

23 months agoTidying.
Carl Hetherington [Thu, 5 May 2022 13:35:03 +0000 (15:35 +0200)]
Tidying.

23 months agoWrite subtitle files in binary mode. tests-on-all-platforms
Carl Hetherington [Mon, 2 May 2022 23:13:34 +0000 (01:13 +0200)]
Write subtitle files in binary mode.

23 months agoMissing finalize() on a writer in a test.
Carl Hetherington [Mon, 2 May 2022 22:37:38 +0000 (00:37 +0200)]
Missing finalize() on a writer in a test.

23 months agoMissing DYLD_LIBRARY_PATH for macOS.
Carl Hetherington [Mon, 2 May 2022 20:25:21 +0000 (22:25 +0200)]
Missing DYLD_LIBRARY_PATH for macOS.

23 months agoFix run/tests for macOS sed.
Carl Hetherington [Mon, 2 May 2022 20:06:43 +0000 (22:06 +0200)]
Fix run/tests for macOS sed.

23 months agoC++11 tidying.
Carl Hetherington [Mon, 2 May 2022 17:31:50 +0000 (19:31 +0200)]
C++11 tidying.

23 months agoMake some tests repeatable across platforms.
Carl Hetherington [Mon, 2 May 2022 15:49:32 +0000 (17:49 +0200)]
Make some tests repeatable across platforms.

23 months agoRemove deprecation warning from cdist.
Carl Hetherington [Wed, 20 Apr 2022 21:42:10 +0000 (23:42 +0200)]
Remove deprecation warning from cdist.

23 months agoTidying.
Carl Hetherington [Wed, 20 Apr 2022 19:32:52 +0000 (21:32 +0200)]
Tidying.

23 months agoFix test runner on macOS.
Carl Hetherington [Wed, 20 Apr 2022 18:50:13 +0000 (20:50 +0200)]
Fix test runner on macOS.

23 months agoAllow tests to be run on Windows.
Carl Hetherington [Wed, 20 Apr 2022 18:49:04 +0000 (20:49 +0200)]
Allow tests to be run on Windows.

2 years agoBump asdcplib to a version with some better Win32 error logging.
Carl Hetherington [Sun, 1 May 2022 18:48:13 +0000 (20:48 +0200)]
Bump asdcplib to a version with some better Win32 error logging.

2 years agoDon't talk about suggest-override on very old GCCs. v1.8.18
Carl Hetherington [Sat, 30 Apr 2022 21:32:52 +0000 (23:32 +0200)]
Don't talk about suggest-override on very old GCCs.

2 years agoRename PKL::write to PKL::write_xml for consistency. v1.8.17
Carl Hetherington [Sat, 30 Apr 2022 18:33:01 +0000 (20:33 +0200)]
Rename PKL::write to PKL::write_xml for consistency.

2 years agoAdd move constructor/operator=. dcp-editor3
Carl Hetherington [Mon, 25 Apr 2022 22:32:29 +0000 (00:32 +0200)]
Add move constructor/operator=.

2 years agoAdd CPL::set().
Carl Hetherington [Mon, 25 Apr 2022 22:32:21 +0000 (00:32 +0200)]
Add CPL::set().

2 years agoAdd AssetList to extract some boilerplate from AssetMap and PKL.
Carl Hetherington [Mon, 25 Apr 2022 21:49:00 +0000 (23:49 +0200)]
Add AssetList to extract some boilerplate from AssetMap and PKL.

2 years agoTidy up write_xml() API a little.
Carl Hetherington [Mon, 25 Apr 2022 21:31:13 +0000 (23:31 +0200)]
Tidy up write_xml() API a little.

2 years agoAdd a test for reading, changing, then writing a DCP.
Carl Hetherington [Mon, 25 Apr 2022 20:53:25 +0000 (22:53 +0200)]
Add a test for reading, changing, then writing a DCP.

2 years agoImprove an exception's description.
Carl Hetherington [Mon, 25 Apr 2022 20:53:14 +0000 (22:53 +0200)]
Improve an exception's description.

2 years agoUpdate PKL assets before writing it.
Carl Hetherington [Mon, 25 Apr 2022 19:59:26 +0000 (21:59 +0200)]
Update PKL assets before writing it.

2 years agoMove AssetMap handling out to a separate class.
Carl Hetherington [Mon, 25 Apr 2022 08:26:11 +0000 (10:26 +0200)]
Move AssetMap handling out to a separate class.

2 years agoAdd copy constructor for Object.
Carl Hetherington [Sun, 24 Apr 2022 19:29:02 +0000 (21:29 +0200)]
Add copy constructor for Object.

2 years agoTidying.
Carl Hetherington [Sun, 24 Apr 2022 19:27:08 +0000 (21:27 +0200)]
Tidying.

2 years agoFix some incorrect comments.
Carl Hetherington [Sun, 24 Apr 2022 19:29:15 +0000 (21:29 +0200)]
Fix some incorrect comments.

2 years agoHide some more warnings from asdcplib on clang. v1.8.16
Carl Hetherington [Fri, 22 Apr 2022 10:07:31 +0000 (12:07 +0200)]
Hide some more warnings from asdcplib on clang.

2 years agoC++11 tidying.
Carl Hetherington [Fri, 22 Apr 2022 09:54:15 +0000 (11:54 +0200)]
C++11 tidying.

2 years agoFix some class/struct warnings on macOS.
Carl Hetherington [Fri, 22 Apr 2022 09:33:54 +0000 (11:33 +0200)]
Fix some class/struct warnings on macOS.

2 years agoDon't specify no-default-inline on clang as it's not supported.
Carl Hetherington [Fri, 22 Apr 2022 09:26:59 +0000 (11:26 +0200)]
Don't specify no-default-inline on clang as it's not supported.

2 years agoFix some macOS signed/unsigned warnings.
Carl Hetherington [Fri, 22 Apr 2022 09:08:54 +0000 (11:08 +0200)]
Fix some macOS signed/unsigned warnings.

2 years agoDon't try to ignore a non-existent warning on clang.
Carl Hetherington [Fri, 22 Apr 2022 08:50:20 +0000 (10:50 +0200)]
Don't try to ignore a non-existent warning on clang.

2 years agoMissing warning ignore with older GCCs. more-warning-fixes v1.8.15
Carl Hetherington [Thu, 21 Apr 2022 22:19:57 +0000 (00:19 +0200)]
Missing warning ignore with older GCCs.

2 years agoFix unsigned/signed warning on macOS.
Carl Hetherington [Thu, 21 Apr 2022 14:18:45 +0000 (16:18 +0200)]
Fix unsigned/signed warning on macOS.

2 years agoFix cscript after change to gcov flag. v1.8.14
Carl Hetherington [Wed, 20 Apr 2022 18:35:28 +0000 (20:35 +0200)]
Fix cscript after change to gcov flag.

2 years agoInvert the sense of the gcov flag.
Carl Hetherington [Wed, 20 Apr 2022 18:20:26 +0000 (20:20 +0200)]
Invert the sense of the gcov flag.

2 years agoFix failure to find_and_resolve_all_cpls() in some cases.
Carl Hetherington [Tue, 4 Jan 2022 20:54:24 +0000 (20:54 +0000)]
Fix failure to find_and_resolve_all_cpls() in some cases.

It seems to me that we need to ignore as-yet-unresolved assets
otherwise if we see them in the wrong order we'll throw an exception.

2 years agoSimplify the implementation of DCP::add.
Carl Hetherington [Mon, 3 Jan 2022 23:27:45 +0000 (23:27 +0000)]
Simplify the implementation of DCP::add.

2 years agoAdd a test for DCP::add() for KDMs.
Carl Hetherington [Mon, 3 Jan 2022 23:27:37 +0000 (23:27 +0000)]
Add a test for DCP::add() for KDMs.

2 years agoMove code to find CPLs in directories out of DCP-o-matic.
Carl Hetherington [Mon, 3 Jan 2022 23:26:49 +0000 (23:26 +0000)]
Move code to find CPLs in directories out of DCP-o-matic.

This adds find_and_resolve_cpls().

2 years agoAdd and use new File class. merged-to-main
Carl Hetherington [Tue, 12 Apr 2022 20:34:04 +0000 (22:34 +0200)]
Add and use new File class.

It was always a bit troubling that fopen_boost wasn't exception safe,
and this also fixes a leak where load_ratings_list would never close
the ratings file.

2 years agoSome more detailed notes in dcpdiff.
Carl Hetherington [Thu, 24 Mar 2022 19:02:37 +0000 (20:02 +0100)]
Some more detailed notes in dcpdiff.

2 years agoAdd verify test to check for erroneous <EntryPoint> and <Duration> 2215-markers v1.8.13
Carl Hetherington [Thu, 24 Mar 2022 00:28:16 +0000 (01:28 +0100)]
Add verify test to check for erroneous <EntryPoint> and <Duration>
tags inside <MainMarkers>

2 years agoRemove <EntryPoint> and <Duration> from <ReelMarkerAsset> tags.
Carl Hetherington [Wed, 23 Mar 2022 23:41:32 +0000 (00:41 +0100)]
Remove <EntryPoint> and <Duration> from <ReelMarkerAsset> tags.

They should not be there:
"EntryPoint" ... "This element shall only be present when the
Asset refers to an external resource such as a Track File".

Fixes DoM bug #2215.

2 years agoNearly pretty-print subtitle XML (though not in <Text> nodes). v1.8.12
Carl Hetherington [Tue, 15 Mar 2022 14:32:49 +0000 (15:32 +0100)]
Nearly pretty-print subtitle XML (though not in <Text> nodes).

This is an attempt to fix DoM bug #2205.

2 years agoC++11 tidying.
Carl Hetherington [Tue, 15 Mar 2022 10:28:05 +0000 (11:28 +0100)]
C++11 tidying.

2 years agoAdd string converters for KDM formulations. v1.8.11
Carl Hetherington [Sat, 19 Mar 2022 20:39:58 +0000 (21:39 +0100)]
Add string converters for KDM formulations.

2 years agoRemove old MODIFIED_TRANSITIONAL_TEST.
Carl Hetherington [Sat, 19 Mar 2022 20:24:54 +0000 (21:24 +0100)]
Remove old MODIFIED_TRANSITIONAL_TEST.

2 years agoSome small documentation tweaks.
Carl Hetherington [Mon, 7 Mar 2022 22:10:45 +0000 (23:10 +0100)]
Some small documentation tweaks.

2 years agoTidy some includes.
Carl Hetherington [Mon, 7 Mar 2022 21:16:41 +0000 (22:16 +0100)]
Tidy some includes.

2 years agoHide another warning (from ImageMagick in the examples).
Carl Hetherington [Mon, 7 Mar 2022 21:16:37 +0000 (22:16 +0100)]
Hide another warning (from ImageMagick in the examples).

2 years agoTweak path in the example.
Carl Hetherington [Mon, 7 Mar 2022 20:52:21 +0000 (21:52 +0100)]
Tweak path in the example.

2 years agoRemove unused capture.
Carl Hetherington [Thu, 3 Mar 2022 23:05:31 +0000 (00:05 +0100)]
Remove unused capture.

2 years agoFix slightly extended libxml++ dependency. v1.8.10
Carl Hetherington [Thu, 3 Mar 2022 21:28:01 +0000 (22:28 +0100)]
Fix slightly extended libxml++ dependency.

2 years agoAdd lists of ratings. v1.8.9
Carl Hetherington [Tue, 1 Mar 2022 16:06:26 +0000 (17:06 +0100)]
Add lists of ratings.

2 years agoMake dcp::init() take a general resources directory rather than specifically tags.
Carl Hetherington [Tue, 1 Mar 2022 19:29:13 +0000 (20:29 +0100)]
Make dcp::init() take a general resources directory rather than specifically tags.

2 years agoMove Rating out to a separate file.
Carl Hetherington [Tue, 1 Mar 2022 15:27:59 +0000 (16:27 +0100)]
Move Rating out to a separate file.

2 years agoAdd -x32/-x64 suffix to boost libraries when building for Windows. v1.8.8
Carl Hetherington [Tue, 22 Feb 2022 21:56:48 +0000 (22:56 +0100)]
Add -x32/-x64 suffix to boost libraries when building for Windows.

2 years agoDon't look for ImageMagick/GraphicsMagick if not building examples.
Carl Hetherington [Sat, 19 Feb 2022 22:27:37 +0000 (23:27 +0100)]
Don't look for ImageMagick/GraphicsMagick if not building examples.

2 years agoPass certificate validity length into the constructor. v1.8.7
Carl Hetherington [Sat, 12 Feb 2022 20:22:40 +0000 (21:22 +0100)]
Pass certificate validity length into the constructor.

2 years agoCleanup: use dcp::LocalTime for certificate validity times.
Carl Hetherington [Sat, 12 Feb 2022 20:15:03 +0000 (21:15 +0100)]
Cleanup: use dcp::LocalTime for certificate validity times.

Before we were using struct tm but not filling it all in, which
seems quite unpleasant.

2 years agoUse optional for ReelAsset _annotation_text. v1.8.6
Carl Hetherington [Mon, 17 Jan 2022 17:45:19 +0000 (18:45 +0100)]
Use optional for ReelAsset _annotation_text.

Not only is this tag optional in Interop and SMPTE, but it would
appear that if it is present but empty a DCP will not play back
on Sony SRX320 / LMT3000 systems (DoM bug #2124).

Here we use optional<>, as seems to make sense, and also refuse
to write empty tags (instead omitting the tag entirely).

2 years agoFix off-by-one in verification of closed caption line length. v1.8.5
Carl Hetherington [Tue, 9 Nov 2021 22:43:46 +0000 (23:43 +0100)]
Fix off-by-one in verification of closed caption line length.

2 years agoMessage tweak.
Carl Hetherington [Sun, 24 Oct 2021 23:13:07 +0000 (01:13 +0200)]
Message tweak.

2 years agoOrder subtitles in the XML according to their vertical position (DoM bug #2106). v1.8.4
Carl Hetherington [Mon, 18 Oct 2021 06:55:27 +0000 (08:55 +0200)]
Order subtitles in the XML according to their vertical position (DoM bug #2106).

2 years agoAllow specification of valign when writing verify tests.
Carl Hetherington [Sat, 23 Oct 2021 21:51:49 +0000 (23:51 +0200)]
Allow specification of valign when writing verify tests.