libdcp.git
3 years agoPrevent DCP::assets() from returning duplicates. combine
Carl Hetherington [Thu, 17 Sep 2020 12:00:21 +0000 (14:00 +0200)]
Prevent DCP::assets() from returning duplicates.

3 years agoAdd dcp::combine().
Carl Hetherington [Wed, 9 Sep 2020 21:55:49 +0000 (23:55 +0200)]
Add dcp::combine().

3 years agoFix crash with one verification error and no notes list.
Carl Hetherington [Thu, 10 Sep 2020 23:01:07 +0000 (01:01 +0200)]
Fix crash with one verification error and no notes list.

3 years agoAdd Interop closed caption XSD for verification.
Carl Hetherington [Thu, 10 Sep 2020 22:36:00 +0000 (00:36 +0200)]
Add Interop closed caption XSD for verification.

3 years agoAdd set_font_file()
Carl Hetherington [Thu, 10 Sep 2020 21:37:32 +0000 (23:37 +0200)]
Add set_font_file()

3 years agoAdd font_filenames()
Carl Hetherington [Thu, 10 Sep 2020 21:37:23 +0000 (23:37 +0200)]
Add font_filenames()

3 years agoAdd EqualityOptions option to ignore differences in LoadFont nodes.
Carl Hetherington [Thu, 10 Sep 2020 21:37:16 +0000 (23:37 +0200)]
Add EqualityOptions option to ignore differences in LoadFont nodes.

3 years agoUse Data::write() to clean things up slightly.
Carl Hetherington [Thu, 10 Sep 2020 20:16:43 +0000 (22:16 +0200)]
Use Data::write() to clean things up slightly.

3 years agoRename fonts_with_load_ids() -> font_data()
Carl Hetherington [Thu, 10 Sep 2020 20:08:27 +0000 (22:08 +0200)]
Rename fonts_with_load_ids() -> font_data()

3 years agoMessage formatting tweaks.
Carl Hetherington [Wed, 9 Sep 2020 21:54:21 +0000 (23:54 +0200)]
Message formatting tweaks.

3 years agoMissing namespace.
Carl Hetherington [Wed, 9 Sep 2020 21:54:09 +0000 (23:54 +0200)]
Missing namespace.

3 years agoAdd some detail to a verification warning.
Carl Hetherington [Wed, 9 Sep 2020 21:54:05 +0000 (23:54 +0200)]
Add some detail to a verification warning.

3 years agoMove make_simple() into test.{cc,h}
Carl Hetherington [Wed, 9 Sep 2020 21:18:28 +0000 (23:18 +0200)]
Move make_simple() into test.{cc,h}

3 years agoFix comment typo.
Carl Hetherington [Wed, 9 Sep 2020 21:10:38 +0000 (23:10 +0200)]
Fix comment typo.

3 years agoUse the <Id> read in when the Reel was created from XML (if appropriate)
Carl Hetherington [Wed, 9 Sep 2020 20:41:52 +0000 (22:41 +0200)]
Use the <Id> read in when the Reel was created from XML (if appropriate)
when writing it out again, rather than creating a new one each time.

Also there is the associated test churn here from removing a call
to make_uuid().

3 years agoAdd SubtitleString::unset_font.
Carl Hetherington [Tue, 25 Aug 2020 21:12:22 +0000 (23:12 +0200)]
Add SubtitleString::unset_font.

3 years agoSlightly nicer errors from dcpkdm.
Carl Hetherington [Wed, 12 Aug 2020 22:45:42 +0000 (00:45 +0200)]
Slightly nicer errors from dcpkdm.

3 years agoFix off-by-one in display of month numbers in dcpkdm.
Carl Hetherington [Wed, 12 Aug 2020 22:25:54 +0000 (00:25 +0200)]
Fix off-by-one in display of month numbers in dcpkdm.

3 years agoBump libcxml.
Carl Hetherington [Tue, 28 Jul 2020 11:02:51 +0000 (13:02 +0200)]
Bump libcxml.

3 years agoFix some unused variable warnings.
Carl Hetherington [Mon, 27 Jul 2020 09:04:34 +0000 (11:04 +0200)]
Fix some unused variable warnings.

3 years agoFix up some tests.
Carl Hetherington [Sun, 12 Jul 2020 13:37:13 +0000 (15:37 +0200)]
Fix up some tests.

3 years agoMove atmos_pcm.mxf in the test repo.
Carl Hetherington [Sun, 12 Jul 2020 13:17:17 +0000 (15:17 +0200)]
Move atmos_pcm.mxf in the test repo.

3 years agoAllow creation of ATMOS sync on channel 14.
Carl Hetherington [Fri, 10 Jul 2020 22:12:50 +0000 (00:12 +0200)]
Allow creation of ATMOS sync on channel 14.

3 years agoFix parameters when running tests with valgrind.
Carl Hetherington [Fri, 10 Jul 2020 22:12:02 +0000 (00:12 +0200)]
Fix parameters when running tests with valgrind.

3 years agoHopefully make all tests stable enough to be run with --random,
Carl Hetherington [Sat, 11 Jul 2020 19:11:48 +0000 (21:11 +0200)]
Hopefully make all tests stable enough to be run with --random,
stopping test reference churn.

3 years agoAdd xmllint to the tools check.
Carl Hetherington [Fri, 3 Jul 2020 20:54:44 +0000 (22:54 +0200)]
Add xmllint to the tools check.

3 years agoShow CPL IDs in dcpinfo.
Carl Hetherington [Fri, 19 Jun 2020 18:42:17 +0000 (20:42 +0200)]
Show CPL IDs in dcpinfo.

3 years agoFormatting fix.
Carl Hetherington [Fri, 19 Jun 2020 18:42:13 +0000 (20:42 +0200)]
Formatting fix.

3 years agoFix test now that Atmos asset ID is correctly read from the MXF.
Carl Hetherington [Fri, 19 Jun 2020 11:28:21 +0000 (11:28 +0000)]
Fix test now that Atmos asset ID is correctly read from the MXF.

3 years agoFix missing Key ID when writing details of encrypted Atmos assets to CPL.
Carl Hetherington [Fri, 19 Jun 2020 11:15:13 +0000 (13:15 +0200)]
Fix missing Key ID when writing details of encrypted Atmos assets to CPL.

3 years agoAdd and use new write_to_cpl_mxf().
Carl Hetherington [Fri, 19 Jun 2020 11:14:38 +0000 (13:14 +0200)]
Add and use new write_to_cpl_mxf().

3 years agoRename write_to_cpl_base -> write_to_cpl_asset.
Carl Hetherington [Fri, 19 Jun 2020 11:14:03 +0000 (13:14 +0200)]
Rename write_to_cpl_base -> write_to_cpl_asset.

3 years agoHeader guard.
Carl Hetherington [Fri, 19 Jun 2020 11:12:16 +0000 (13:12 +0200)]
Header guard.

3 years agoMissing set up of AtmosVersion when writing Atmos assets.
Carl Hetherington [Fri, 19 Jun 2020 11:12:12 +0000 (13:12 +0200)]
Missing set up of AtmosVersion when writing Atmos assets.

3 years agoAdd wrapper for AtmosAssetWriter::write to write a frame.
Carl Hetherington [Fri, 19 Jun 2020 11:11:49 +0000 (13:11 +0200)]
Add wrapper for AtmosAssetWriter::write to write a frame.

3 years agoFix a whole load of missing setup for AtmosAssets, most notably
Carl Hetherington [Fri, 19 Jun 2020 11:10:45 +0000 (13:10 +0200)]
Fix a whole load of missing setup for AtmosAssets, most notably
the ID.

3 years agoI believe atmos_id is a unique identifier, so create it in the
Carl Hetherington [Fri, 19 Jun 2020 11:09:09 +0000 (13:09 +0200)]
I believe atmos_id is a unique identifier, so create it in the
same way that all the others are created.

3 years agoAllow specification of the JPEG2000 comment string.
Carl Hetherington [Tue, 16 Jun 2020 23:04:05 +0000 (01:04 +0200)]
Allow specification of the JPEG2000 comment string.

3 years agoTidy up and fix some small memory leaks.
Carl Hetherington [Tue, 16 Jun 2020 22:58:04 +0000 (00:58 +0200)]
Tidy up and fix some small memory leaks.

3 years agoClean up strange use of c_str().
Carl Hetherington [Tue, 16 Jun 2020 22:55:58 +0000 (00:55 +0200)]
Clean up strange use of c_str().

3 years agoRun verification tests with a space in the XSD path to trigger an old bug.
Carl Hetherington [Thu, 11 Jun 2020 17:21:16 +0000 (19:21 +0200)]
Run verification tests with a space in the XSD path to trigger an old bug.

3 years agoFix failure to verify when the XSD/DTD path has a space in it.
Carl Hetherington [Thu, 11 Jun 2020 14:49:33 +0000 (16:49 +0200)]
Fix failure to verify when the XSD/DTD path has a space in it.

With spaces in the path we ended up with spaces in the string
passed to setExternalSchemaLocation which screws everything up.
It turns out we can remove the URIs from that string, which seems
to move the resolution between file and URI to the LocalFileResolver,
which may now be asked to resolve either a file or a URI.

Maybe I've missed something obvious here.

3 years agoAdd some missing .xsd files to the install target.
Carl Hetherington [Thu, 11 Jun 2020 09:19:17 +0000 (11:19 +0200)]
Add some missing .xsd files to the install target.

3 years agoBump openjpeg for Windows ccache build fixes.
Carl Hetherington [Thu, 11 Jun 2020 08:51:09 +0000 (10:51 +0200)]
Bump openjpeg for Windows ccache build fixes.

3 years agoDon't build benchmarks with cdist.
Carl Hetherington [Mon, 1 Jun 2020 22:17:44 +0000 (00:17 +0200)]
Don't build benchmarks with cdist.

3 years agoAdd very simple benchmark for rgb_to_xyz.
Carl Hetherington [Sun, 31 May 2020 19:49:41 +0000 (21:49 +0200)]
Add very simple benchmark for rgb_to_xyz.

3 years agoAdd add_days to LocalTime.
Carl Hetherington [Wed, 20 May 2020 20:09:55 +0000 (22:09 +0200)]
Add add_days to LocalTime.

3 years agoMake add_minutes() work correctly with milliseconds.
Carl Hetherington [Tue, 12 May 2020 10:41:23 +0000 (12:41 +0200)]
Make add_minutes() work correctly with milliseconds.

3 years agoMove some tests and rename one set.
Carl Hetherington [Tue, 12 May 2020 10:38:33 +0000 (12:38 +0200)]
Move some tests and rename one set.

3 years agoAdd a proper implementation of add_months() and a test for the
Carl Hetherington [Tue, 12 May 2020 10:35:41 +0000 (12:35 +0200)]
Add a proper implementation of add_months() and a test for the
case when it fails by giving erroneous dates like 30th February.

3 years agoAdd a note when verifying if the DCP refers to assets
Carl Hetherington [Tue, 12 May 2020 10:35:07 +0000 (12:35 +0200)]
Add a note when verifying if the DCP refers to assets
that are not mentioned in its ASSETMAP (i.e. a VF).

3 years agoComment typo.
Carl Hetherington [Tue, 12 May 2020 10:34:03 +0000 (12:34 +0200)]
Comment typo.

3 years agoImprove comment.
Carl Hetherington [Tue, 12 May 2020 10:33:48 +0000 (12:33 +0200)]
Improve comment.

3 years agoVerify the XML of subtitle files.
Carl Hetherington [Fri, 8 May 2020 22:33:51 +0000 (00:33 +0200)]
Verify the XML of subtitle files.

3 years agoComment typo.
Carl Hetherington [Fri, 8 May 2020 22:32:32 +0000 (00:32 +0200)]
Comment typo.

3 years agoMake J2K frame size tests more robust.
Carl Hetherington [Fri, 8 May 2020 20:46:03 +0000 (22:46 +0200)]
Make J2K frame size tests more robust.

3 years agoStore and allow access to the raw XML that is read in from
Carl Hetherington [Fri, 8 May 2020 20:44:50 +0000 (22:44 +0200)]
Store and allow access to the raw XML that is read in from
subtitle assets so that it cab be verified without any
interference from being passed through libdcp.

3 years agoFactor some code out into methods.
Carl Hetherington [Thu, 7 May 2020 21:23:09 +0000 (23:23 +0200)]
Factor some code out into methods.

3 years agoCheck that JPEG2000 frames aren't too big (i.e. too
Carl Hetherington [Wed, 6 May 2020 23:08:51 +0000 (01:08 +0200)]
Check that JPEG2000 frames aren't too big (i.e. too
many bytes).

3 years agoResult is specific to verify_asset().
Carl Hetherington [Wed, 6 May 2020 22:34:11 +0000 (00:34 +0200)]
Result is specific to verify_asset().

3 years agoAllow ignoring of specifications in NameFormat.
Carl Hetherington [Tue, 5 May 2020 22:50:37 +0000 (00:50 +0200)]
Allow ignoring of specifications in NameFormat.

4 years agoTry to fix Centos 6 build.
Carl Hetherington [Sun, 26 Apr 2020 21:11:15 +0000 (23:11 +0200)]
Try to fix Centos 6 build.

4 years agoMissing #include.
Carl Hetherington [Sat, 25 Apr 2020 10:15:20 +0000 (12:15 +0200)]
Missing #include.

4 years agoFix build on some (older?) GCCs.
Carl Hetherington [Mon, 20 Apr 2020 21:15:54 +0000 (23:15 +0200)]
Fix build on some (older?) GCCs.

4 years agoAdd an explicit exception for J2K decompression failures.
Carl Hetherington [Tue, 14 Apr 2020 21:11:33 +0000 (23:11 +0200)]
Add an explicit exception for J2K decompression failures.

4 years agos/DCPReadError/ReadError/g
Carl Hetherington [Tue, 14 Apr 2020 18:16:44 +0000 (20:16 +0200)]
s/DCPReadError/ReadError/g

4 years agoAdd a special exception for the case when opj_start_compress fails.
Carl Hetherington [Mon, 13 Apr 2020 20:55:53 +0000 (22:55 +0200)]
Add a special exception for the case when opj_start_compress fails.

4 years agoBump libcxml for new force-cpp stuff.
Carl Hetherington [Thu, 2 Apr 2020 19:50:01 +0000 (21:50 +0200)]
Bump libcxml for new force-cpp stuff.

4 years agoCleanup.
Carl Hetherington [Thu, 2 Apr 2020 12:34:18 +0000 (14:34 +0200)]
Cleanup.

4 years agoPass force-cpp11 down to libcxml.
Carl Hetherington [Thu, 2 Apr 2020 12:28:12 +0000 (14:28 +0200)]
Pass force-cpp11 down to libcxml.

4 years agoTidy up by using option_defaults.
Carl Hetherington [Thu, 2 Apr 2020 12:17:38 +0000 (14:17 +0200)]
Tidy up by using option_defaults.

4 years agoFix misformatting of dcpinfo output.
Carl Hetherington [Mon, 16 Mar 2020 10:18:15 +0000 (11:18 +0100)]
Fix misformatting of dcpinfo output.

4 years agoFix getopt string.
Carl Hetherington [Sun, 15 Mar 2020 21:09:16 +0000 (22:09 +0100)]
Fix getopt string.

4 years agoAllow general restriction of what is output.
Carl Hetherington [Sun, 15 Mar 2020 21:07:50 +0000 (22:07 +0100)]
Allow general restriction of what is output.

4 years agoFix ::add_minutes to not alter the timezone of the time it's called on.
Carl Hetherington [Wed, 11 Mar 2020 09:49:16 +0000 (10:49 +0100)]
Fix ::add_minutes to not alter the timezone of the time it's called on.

4 years agoBe more cautious in CertificateChain::private_key_valid.
Carl Hetherington [Tue, 10 Mar 2020 21:24:46 +0000 (22:24 +0100)]
Be more cautious in CertificateChain::private_key_valid.

4 years agoAdd LocalTime::add_minutes.
Carl Hetherington [Tue, 10 Mar 2020 16:17:45 +0000 (17:17 +0100)]
Add LocalTime::add_minutes.

4 years agoFix build following merge.
Carl Hetherington [Mon, 9 Mar 2020 20:08:51 +0000 (21:08 +0100)]
Fix build following merge.

4 years agoMerge.
Carl Hetherington [Mon, 9 Mar 2020 20:07:30 +0000 (21:07 +0100)]
Merge.

4 years agoGive an error if there is no asset map.
Carl Hetherington [Mon, 9 Mar 2020 20:06:53 +0000 (21:06 +0100)]
Give an error if there is no asset map.

4 years agoAdd test data missing from previous.
Carl Hetherington [Sun, 8 Mar 2020 22:16:24 +0000 (23:16 +0100)]
Add test data missing from previous.

4 years agoAdd verification checks too see if reel assets' Duration or IntrinsicDuration are...
Carl Hetherington [Sun, 8 Mar 2020 21:47:33 +0000 (22:47 +0100)]
Add verification checks too see if reel assets' Duration or IntrinsicDuration are too small.

4 years agoAdd Reel::assets().
Carl Hetherington [Sun, 8 Mar 2020 21:47:09 +0000 (22:47 +0100)]
Add Reel::assets().

4 years agoFix interop verification and add some tests for it.
Carl Hetherington [Tue, 3 Mar 2020 21:02:03 +0000 (22:02 +0100)]
Fix interop verification and add some tests for it.

4 years agoAnother build fix.
Carl Hetherington [Mon, 3 Feb 2020 16:15:49 +0000 (17:15 +0100)]
Another build fix.

4 years agoTry always loading the openssl crypto module, not the default one.
Carl Hetherington [Mon, 3 Feb 2020 16:08:17 +0000 (17:08 +0100)]
Try always loading the openssl crypto module, not the default one.

4 years agoTry again to fix Windows build of previous.
Carl Hetherington [Mon, 3 Feb 2020 15:51:49 +0000 (16:51 +0100)]
Try again to fix Windows build of previous.

4 years agoTry to fix build of previous.
Carl Hetherington [Mon, 3 Feb 2020 15:43:01 +0000 (16:43 +0100)]
Try to fix build of previous.

4 years agoProvide more details on failure to load xmlsec-crypto.
Carl Hetherington [Mon, 3 Feb 2020 15:22:38 +0000 (16:22 +0100)]
Provide more details on failure to load xmlsec-crypto.

4 years agoTidy up previous slightly.
Carl Hetherington [Sun, 2 Feb 2020 23:44:39 +0000 (00:44 +0100)]
Tidy up previous slightly.

4 years agoAllow force-cpp11 via cdist options.
Carl Hetherington [Sun, 2 Feb 2020 23:43:04 +0000 (00:43 +0100)]
Allow force-cpp11 via cdist options.

4 years agoAdd struct tm constructor for LocalTime, use it to tidy up
Carl Hetherington [Mon, 23 Dec 2019 00:05:49 +0000 (01:05 +0100)]
Add struct tm constructor for LocalTime, use it to tidy up
day_{greater,less}_than_or_equal and add add_months() method.

4 years agoA reel should be the length of its main picture, or the shortest other thing if there...
Carl Hetherington [Thu, 19 Dec 2019 23:08:20 +0000 (00:08 +0100)]
A reel should be the length of its main picture, or the shortest other thing if there is no picture.

4 years agoAdd accessors.
Carl Hetherington [Thu, 19 Dec 2019 23:07:45 +0000 (00:07 +0100)]
Add accessors.

4 years agoFix openjpeg commit hash for XP build.
Carl Hetherington [Tue, 17 Dec 2019 22:09:25 +0000 (23:09 +0100)]
Fix openjpeg commit hash for XP build.

4 years agoAdd fix_empty_font_ids() to replace empty Font ids with a dummy string.
Carl Hetherington [Sun, 15 Dec 2019 21:58:21 +0000 (22:58 +0100)]
Add fix_empty_font_ids() to replace empty Font ids with a dummy string.

4 years agoxerces-c will be a dynamic library, not a static one.
Carl Hetherington [Sun, 15 Dec 2019 10:03:59 +0000 (11:03 +0100)]
xerces-c will be a dynamic library, not a static one.

4 years agoWindows build fix.
Carl Hetherington [Sat, 14 Dec 2019 23:40:50 +0000 (00:40 +0100)]
Windows build fix.

4 years agoMore adventures in the art of enum namespacing.
Carl Hetherington [Sat, 14 Dec 2019 23:09:57 +0000 (00:09 +0100)]
More adventures in the art of enum namespacing.

4 years agoFix bad implementation of bad hack.
Carl Hetherington [Sat, 14 Dec 2019 22:16:44 +0000 (23:16 +0100)]
Fix bad implementation of bad hack.