libdcp.git
7 months agoMore debugging. gh-21-open
Carl Hetherington [Tue, 19 Sep 2023 20:53:28 +0000 (22:53 +0200)]
More debugging.

7 months agoDebugging for GH #21.
Carl Hetherington [Mon, 18 Sep 2023 23:14:42 +0000 (01:14 +0200)]
Debugging for GH #21.

7 months agoRemove odd assertion stopping TZ minutes being more than 30 or less than -30 (DoM... v1.8.82
Carl Hetherington [Wed, 13 Sep 2023 19:37:15 +0000 (21:37 +0200)]
Remove odd assertion stopping TZ minutes being more than 30 or less than -30 (DoM/GH #20).

7 months agoReport failures to read resources from MXF files. v1.8.81
Carl Hetherington [Wed, 6 Sep 2023 20:46:27 +0000 (22:46 +0200)]
Report failures to read resources from MXF files.

7 months agoBump the PNG subtitle / font buffer a little.
Carl Hetherington [Wed, 6 Sep 2023 20:46:14 +0000 (22:46 +0200)]
Bump the PNG subtitle / font buffer a little.

7 months agoFix build when there is no {Image,Graphics}Magick v1.8.80
Carl Hetherington [Thu, 31 Aug 2023 21:41:23 +0000 (23:41 +0200)]
Fix build when there is no {Image,Graphics}Magick

7 months agoDon't build dcpdumpimage unless we have {Image,Graphics}Magick
Carl Hetherington [Thu, 31 Aug 2023 21:40:32 +0000 (23:40 +0200)]
Don't build dcpdumpimage unless we have {Image,Graphics}Magick

7 months agoCleanup: use a loop.
Carl Hetherington [Thu, 31 Aug 2023 21:40:12 +0000 (23:40 +0200)]
Cleanup: use a loop.

8 months agoAdd dcpdumpimage tool.
Carl Hetherington [Sun, 27 Aug 2023 21:13:34 +0000 (23:13 +0200)]
Add dcpdumpimage tool.

8 months agoCheck for missing font files referred from Interop closed captions (as well as subs).
Carl Hetherington [Thu, 24 Aug 2023 21:19:44 +0000 (23:19 +0200)]
Check for missing font files referred from Interop closed captions (as well as subs).

8 months agoFix Windows build failure. v1.8.79
Carl Hetherington [Tue, 22 Aug 2023 22:05:42 +0000 (00:05 +0200)]
Fix Windows build failure.

8 months agoAccept any case for subtitle alignment specifiers (#2602). v1.8.78
Carl Hetherington [Tue, 22 Aug 2023 21:45:13 +0000 (23:45 +0200)]
Accept any case for subtitle alignment specifiers (#2602).

SMPTE seems pretty clear to me that these should be lower case, but
counterexamples have been seen in the wild and it seems to make
sense to allow them.

Perhaps the verifier should raise an error with non-lower-case
examples.

8 months agoAdd some tests.
Carl Hetherington [Tue, 22 Aug 2023 21:35:32 +0000 (23:35 +0200)]
Add some tests.

8 months agoCleanup: extract HAlign to its own files.
Carl Hetherington [Tue, 22 Aug 2023 21:18:20 +0000 (23:18 +0200)]
Cleanup: extract HAlign to its own files.

8 months agoCleanup: extract VAlign to its own files.
Carl Hetherington [Tue, 22 Aug 2023 21:11:18 +0000 (23:11 +0200)]
Cleanup: extract VAlign to its own files.

8 months agoCleanup: header ordering.
Carl Hetherington [Tue, 22 Aug 2023 21:11:04 +0000 (23:11 +0200)]
Cleanup: header ordering.

8 months agoBump asdcplib for probably-unimportant undefined variable use fix. v1.8.77
Carl Hetherington [Tue, 15 Aug 2023 16:33:26 +0000 (18:33 +0200)]
Bump asdcplib for probably-unimportant undefined variable use fix.

8 months agoFix use-after-free in error case.
Carl Hetherington [Tue, 15 Aug 2023 10:33:33 +0000 (12:33 +0200)]
Fix use-after-free in error case.

8 months agoFix dcp::LocalTime constructor to cope with longer fractional second parts (DoM ...
Carl Hetherington [Tue, 15 Aug 2023 10:28:21 +0000 (12:28 +0200)]
Fix dcp::LocalTime constructor to cope with longer fractional second parts (DoM #2597).

8 months agoAdd check for empty <LabelText> in <ContentVersion> v1.8.76
Carl Hetherington [Fri, 11 Aug 2023 18:51:21 +0000 (20:51 +0200)]
Add check for empty <LabelText> in <ContentVersion>

We have a report of Deluxe failing a DCP because of this.

8 months agoCleanup: comment formatting for auto-generated docs.
Carl Hetherington [Fri, 11 Aug 2023 18:39:19 +0000 (20:39 +0200)]
Cleanup: comment formatting for auto-generated docs.

8 months agoCleanup: make some default constructors more consistent. v1.8.75
Carl Hetherington [Tue, 8 Aug 2023 16:21:24 +0000 (18:21 +0200)]
Cleanup: make some default constructors more consistent.

8 months agoFix boost bind placeholder warnings.
Carl Hetherington [Tue, 8 Aug 2023 12:38:47 +0000 (14:38 +0200)]
Fix boost bind placeholder warnings.

8 months agoCleanup: header ordering.
Carl Hetherington [Tue, 8 Aug 2023 12:38:39 +0000 (14:38 +0200)]
Cleanup: header ordering.

8 months agoRemove unused method.
Carl Hetherington [Tue, 8 Aug 2023 12:38:13 +0000 (14:38 +0200)]
Remove unused method.

8 months agoIgnore some ASDCP warnings.
Carl Hetherington [Tue, 8 Aug 2023 12:38:09 +0000 (14:38 +0200)]
Ignore some ASDCP warnings.

9 months agoAdd equality option sound_assets_can_differ.
Carl Hetherington [Sat, 29 Jul 2023 00:25:32 +0000 (02:25 +0200)]
Add equality option sound_assets_can_differ.

9 months agoRationalise #undef-ing of ERROR. tidy-eq-options
Carl Hetherington [Tue, 25 Jul 2023 20:00:47 +0000 (22:00 +0200)]
Rationalise #undef-ing of ERROR.

9 months agoInclude trimming.
Carl Hetherington [Tue, 25 Jul 2023 13:38:50 +0000 (15:38 +0200)]
Include trimming.

9 months agoCleanup: move EqualityOptions into its own file.
Carl Hetherington [Tue, 25 Jul 2023 13:28:11 +0000 (15:28 +0200)]
Cleanup: move EqualityOptions into its own file.

9 months agoCleanup: forward declaration sorting.
Carl Hetherington [Tue, 25 Jul 2023 13:05:37 +0000 (15:05 +0200)]
Cleanup: forward declaration sorting.

9 months agoCleanup: include sorting.
Carl Hetherington [Tue, 25 Jul 2023 12:58:02 +0000 (14:58 +0200)]
Cleanup: include sorting.

9 months agoCleanup: pass EqualityOptions as const&
Carl Hetherington [Tue, 25 Jul 2023 12:51:23 +0000 (14:51 +0200)]
Cleanup: pass EqualityOptions as const&

This exposes a useless assignment of export_differing_subtitles,
which I've removed (and altered the comment accordingly).

9 months agoCleanup: use = default.
Carl Hetherington [Tue, 25 Jul 2023 12:41:57 +0000 (14:41 +0200)]
Cleanup: use = default.

9 months agoMake EqualityOptions into a class.
Carl Hetherington [Tue, 25 Jul 2023 12:40:19 +0000 (14:40 +0200)]
Make EqualityOptions into a class.

9 months agoCleanup: fix typo in comment.
Carl Hetherington [Tue, 25 Jul 2023 12:31:43 +0000 (14:31 +0200)]
Cleanup: fix typo in comment.

9 months agoAdd asset_hashes_can_differ option to the equality checks. v1.8.74
Carl Hetherington [Wed, 28 Jun 2023 21:00:57 +0000 (23:00 +0200)]
Add asset_hashes_can_differ option to the equality checks.

Before recent changes Asset::_hash would be empty when the equality
checks were run (and Asset::equals() compares them directly).

This mean that differences in asset hash were being ignored, but
are no longer; so now we need this option to restore that behaviour
where required.

9 months agoWhen reading a DCP set up asset hashes from the CPL/PKL, not by digesting the actual...
Carl Hetherington [Mon, 26 Jun 2023 22:11:43 +0000 (00:11 +0200)]
When reading a DCP set up asset hashes from the CPL/PKL, not by digesting the actual asset.

Previously when reading a DCP we would recalculate asset hashes.  This meant that corrupted
DCPs could be loaded in and their hashes re-written (if nobody checked the new hashes against
the ones in the PKL/CPL).

It seems better to take the hashes from the metadata.  Then if the assets are corrupted
and the DCP is re-written the PKL/CPL hashes will be preserved, showing rather than hiding
the corruption.

10 months agoAdd Asset::unset_hash().
Carl Hetherington [Mon, 26 Jun 2023 22:06:14 +0000 (00:06 +0200)]
Add Asset::unset_hash().

10 months agoCleanup: remove unnecessary namespace.
Carl Hetherington [Mon, 26 Jun 2023 22:05:55 +0000 (00:05 +0200)]
Cleanup: remove unnecessary namespace.

10 months agoFix tests that were writing assets with the same filename to different reels.
Carl Hetherington [Mon, 26 Jun 2023 22:05:38 +0000 (00:05 +0200)]
Fix tests that were writing assets with the same filename to different reels.

10 months agoCleanup: sorting.
Carl Hetherington [Mon, 26 Jun 2023 00:13:22 +0000 (02:13 +0200)]
Cleanup: sorting.

10 months agoMove Editor class from verify_test.cc to test.cc
Carl Hetherington [Sun, 25 Jun 2023 23:56:07 +0000 (01:56 +0200)]
Move Editor class from verify_test.cc to test.cc

10 months agoAdd verifier check for the actual asset file's ID not being the same as the one in...
Carl Hetherington [Sun, 25 Jun 2023 23:45:17 +0000 (01:45 +0200)]
Add verifier check for the actual asset file's ID not being the same as the one in the asset map.

10 months agoCleanup: better variable names.
Carl Hetherington [Sun, 25 Jun 2023 23:20:34 +0000 (01:20 +0200)]
Cleanup: better variable names.

10 months agoCleanup: const.
Carl Hetherington [Sun, 25 Jun 2023 23:18:06 +0000 (01:18 +0200)]
Cleanup: const.

10 months agoAdd Asset::set_file_preserving_hash().
Carl Hetherington [Tue, 20 Jun 2023 20:06:02 +0000 (22:06 +0200)]
Add Asset::set_file_preserving_hash().

10 months agoCleanup: set annotation text in make_simple().
Carl Hetherington [Tue, 20 Jun 2023 20:05:20 +0000 (22:05 +0200)]
Cleanup: set annotation text in make_simple().

10 months agoVerify error if SMPTE subtitle asset has <Text> but no <LoadFont>. v1.8.73
Carl Hetherington [Tue, 30 May 2023 23:36:49 +0000 (01:36 +0200)]
Verify error if SMPTE subtitle asset has <Text> but no <LoadFont>.

10 months agoCleanup: replace a nasty try/catch.
Carl Hetherington [Tue, 30 May 2023 23:35:49 +0000 (01:35 +0200)]
Cleanup: replace a nasty try/catch.

10 months agoCleanup: formatting.
Carl Hetherington [Tue, 30 May 2023 23:20:09 +0000 (01:20 +0200)]
Cleanup: formatting.

10 months agoCleanup: remove some unpleasant (and I think unnecessary) casting.
Carl Hetherington [Tue, 30 May 2023 23:18:01 +0000 (01:18 +0200)]
Cleanup: remove some unpleasant (and I think unnecessary) casting.

10 months agoRename MISSING_LOAD_FONT -> MISSING_LOAD_FONT_FOR_FONT.
Carl Hetherington [Tue, 30 May 2023 23:13:08 +0000 (01:13 +0200)]
Rename MISSING_LOAD_FONT -> MISSING_LOAD_FONT_FOR_FONT.

10 months agoCleanup: comment typo fix.
Carl Hetherington [Tue, 30 May 2023 23:12:13 +0000 (01:12 +0200)]
Cleanup: comment typo fix.

11 months agoAdd SoundAsset::active_channels(). v1.8.72
Carl Hetherington [Sun, 28 May 2023 21:01:32 +0000 (23:01 +0200)]
Add SoundAsset::active_channels().

11 months agoFix stupid mistake introduced in 1e010ab5. v1.8.71
Carl Hetherington [Sun, 28 May 2023 21:00:58 +0000 (23:00 +0200)]
Fix stupid mistake introduced in 1e010ab5.

11 months agoDon't unconditionally clear _fonts when inspecting assets (DoM #2536). v1.8.70
Carl Hetherington [Sun, 28 May 2023 00:12:39 +0000 (02:12 +0200)]
Don't unconditionally clear _fonts when inspecting assets (DoM #2536).

resolve_fonts() is sometimes called for the same asset with different
lists of things to check.  If it is called first with a font, and
then without one, we want to keep the font from the first call.

11 months agoCleanup: use find_if().
Carl Hetherington [Sun, 28 May 2023 00:12:03 +0000 (02:12 +0200)]
Cleanup: use find_if().

11 months agoCleanup: reduce some scopes.
Carl Hetherington [Sun, 28 May 2023 18:07:32 +0000 (20:07 +0200)]
Cleanup: reduce some scopes.

11 months agoMore detailed error message.
Carl Hetherington [Wed, 24 May 2023 21:46:57 +0000 (23:46 +0200)]
More detailed error message.

11 months agoRemove unnecessary initializers.
Carl Hetherington [Sun, 21 May 2023 20:03:23 +0000 (22:03 +0200)]
Remove unnecessary initializers.

11 months agoFormatting tidying; use vector instead of scoped_array.
Carl Hetherington [Sun, 14 May 2023 22:46:43 +0000 (00:46 +0200)]
Formatting tidying; use vector instead of scoped_array.

11 months agoStyle/formatting tweaks.
Carl Hetherington [Sun, 14 May 2023 22:41:40 +0000 (00:41 +0200)]
Style/formatting tweaks.

11 months agoAdd SubtitleAsset::ensure_font(). v1.8.69
Carl Hetherington [Thu, 11 May 2023 23:35:26 +0000 (01:35 +0200)]
Add SubtitleAsset::ensure_font().

11 months agoCleanup: ues BOOST_CHECK_EQUAL. v1.8.68
Carl Hetherington [Thu, 11 May 2023 18:06:14 +0000 (20:06 +0200)]
Cleanup: ues BOOST_CHECK_EQUAL.

11 months agoRemove some debugging prints.
Carl Hetherington [Thu, 11 May 2023 12:57:41 +0000 (14:57 +0200)]
Remove some debugging prints.

11 months agoCheck that all <Font> tags have a corresponding <LoadFont> in the verifier.
Carl Hetherington [Thu, 11 May 2023 12:47:52 +0000 (14:47 +0200)]
Check that all <Font> tags have a corresponding <LoadFont> in the verifier.

11 months agoAdd ID member to verification note.
Carl Hetherington [Thu, 11 May 2023 12:47:19 +0000 (14:47 +0200)]
Add ID member to verification note.

12 months agoGive better errors when invalid urn:uuid: strings are found (DoM #2521).
Carl Hetherington [Wed, 26 Apr 2023 14:42:43 +0000 (16:42 +0200)]
Give better errors when invalid urn:uuid: strings are found (DoM #2521).

12 months agoFix crash when trying to verify an encrypted SMPTE subtitle asset. v1.8.67
Carl Hetherington [Thu, 20 Apr 2023 12:56:30 +0000 (14:56 +0200)]
Fix crash when trying to verify an encrypted SMPTE subtitle asset.

12 months agoAdd test for too many subtitle namespaces.
Carl Hetherington [Fri, 7 Apr 2023 18:59:44 +0000 (20:59 +0200)]
Add test for too many subtitle namespaces.

12 months agoAdd missing operator case.
Carl Hetherington [Fri, 7 Apr 2023 18:59:33 +0000 (20:59 +0200)]
Add missing operator case.

12 months agoRemove xmlns:xs namespace from subtitle XML (DoM #2498).
Carl Hetherington [Thu, 6 Apr 2023 20:32:14 +0000 (22:32 +0200)]
Remove xmlns:xs namespace from subtitle XML (DoM #2498).

12 months agoFix build.
Carl Hetherington [Sun, 16 Apr 2023 21:43:21 +0000 (23:43 +0200)]
Fix build.

12 months agoCheck for tile parts being too big in the verifier (DoM #2450).
Carl Hetherington [Sun, 16 Apr 2023 21:34:42 +0000 (23:34 +0200)]
Check for tile parts being too big in the verifier (DoM #2450).

12 months agoBump openjpeg to allow higher than 250Mbit/s data rates for J2K (DoM #1665).
Carl Hetherington [Sun, 16 Apr 2023 21:34:15 +0000 (23:34 +0200)]
Bump openjpeg to allow higher than 250Mbit/s data rates for J2K (DoM #1665).

12 months agoCleanup: include ordering and white space.
Carl Hetherington [Sun, 16 Apr 2023 20:17:26 +0000 (22:17 +0200)]
Cleanup: include ordering and white space.

12 months agoUse a map and boost::any to make it a little neater to add more metadata to Verificat...
Carl Hetherington [Sat, 15 Apr 2023 20:27:01 +0000 (22:27 +0200)]
Use a map and boost::any to make it a little neater to add more metadata to VerificationNote.

12 months agoUse a shared_ptr<vector> for ArrayData rather than a shared_array.
Carl Hetherington [Sun, 16 Apr 2023 20:07:10 +0000 (22:07 +0200)]
Use a shared_ptr<vector> for ArrayData rather than a shared_array.

This is simpler and allows us to remove the hack of allocating some
"maximum" buffer for incoming JPEG2000 data.

It does mean that the buffer is zero-initialized before being written
to, but hopefully that doesn't matter too much.

12 months agoCleanup: remove a couple of unnecessary namespace qualifiers.
Carl Hetherington [Sat, 15 Apr 2023 13:42:55 +0000 (15:42 +0200)]
Cleanup: remove a couple of unnecessary namespace qualifiers.

12 months agoReplace slightly weird add_font_assets() API.
Carl Hetherington [Fri, 14 Apr 2023 14:05:59 +0000 (16:05 +0200)]
Replace slightly weird add_font_assets() API.

12 months agoCleanup: use a find_if().
Carl Hetherington [Fri, 14 Apr 2023 14:05:23 +0000 (16:05 +0200)]
Cleanup: use a find_if().

12 months agoFix resolve_fonts() if it is called twice.
Carl Hetherington [Thu, 13 Apr 2023 21:40:25 +0000 (23:40 +0200)]
Fix resolve_fonts() if it is called twice.

12 months agoAdd const version of add_font_assets().
Carl Hetherington [Thu, 13 Apr 2023 21:39:59 +0000 (23:39 +0200)]
Add const version of add_font_assets().

12 months agoAdd check for Interop font assets being present (in the ASSETMAP and on disk).
Carl Hetherington [Thu, 13 Apr 2023 21:39:40 +0000 (23:39 +0200)]
Add check for Interop font assets being present (in the ASSETMAP and on disk).

12 months agoAdd some missing full stops.
Carl Hetherington [Thu, 13 Apr 2023 21:38:01 +0000 (23:38 +0200)]
Add some missing full stops.

12 months agoAdd font assets to combined DCPs; otherwise the fonts don't show up in the ASSETMAP.
Carl Hetherington [Thu, 13 Apr 2023 21:37:29 +0000 (23:37 +0200)]
Add font assets to combined DCPs; otherwise the fonts don't show up in the ASSETMAP.

12 months agoFix typos in variable names.
Carl Hetherington [Tue, 11 Apr 2023 20:57:11 +0000 (22:57 +0200)]
Fix typos in variable names.

12 months agoFix typos in exceptions.
Carl Hetherington [Tue, 11 Apr 2023 20:56:50 +0000 (22:56 +0200)]
Fix typos in exceptions.

12 months agoFix typos in comments.
Carl Hetherington [Tue, 11 Apr 2023 20:53:05 +0000 (22:53 +0200)]
Fix typos in comments.

12 months agoClarify success message from dcpverify a little.
Carl Hetherington [Fri, 7 Apr 2023 19:09:45 +0000 (21:09 +0200)]
Clarify success message from dcpverify a little.

12 months agoAdd check for mismatch between sound asset and MainSoundConfiguration. v1.8.66
Carl Hetherington [Tue, 4 Apr 2023 21:09:29 +0000 (23:09 +0200)]
Add check for mismatch between sound asset and MainSoundConfiguration.

12 months agoAdd check for mismatched sound channel counts.
Carl Hetherington [Sun, 2 Apr 2023 21:10:39 +0000 (23:10 +0200)]
Add check for mismatched sound channel counts.

12 months agoPass MainSoundConfiguration object rather than a string.
Carl Hetherington [Sun, 2 Apr 2023 21:10:24 +0000 (23:10 +0200)]
Pass MainSoundConfiguration object rather than a string.

I guess originally it was a string mostly because it's not very well defined,
and Interop seemingly does whatever it wants.  This basic change also means
that things are checked more carefully, and so we must be more relaxed with
some things seen in the wild that I can't find contradictions for in the
standard (and also with the case of channel IDs, which does seem to be
mentioned in the standard).

12 months agoAdd some missing sound field specifiers to tests.
Carl Hetherington [Tue, 4 Apr 2023 21:05:27 +0000 (23:05 +0200)]
Add some missing sound field specifiers to tests.

13 months agoRemove now-redundant test. v1.8.65
Carl Hetherington [Mon, 20 Mar 2023 15:55:09 +0000 (16:55 +0100)]
Remove now-redundant test.

13 months agoAllow specification of channels that need a MCASubDescriptor.
Carl Hetherington [Mon, 20 Mar 2023 23:37:12 +0000 (00:37 +0100)]
Allow specification of channels that need a MCASubDescriptor.

13 months agoRemove now-presumed-wrong 2.0 MCA sound field.
Carl Hetherington [Fri, 17 Mar 2023 13:54:40 +0000 (14:54 +0100)]
Remove now-presumed-wrong 2.0 MCA sound field.

13 months agoUse an enum instead of a bool in PictureAsset::start_write().
Carl Hetherington [Fri, 17 Mar 2023 13:11:34 +0000 (14:11 +0100)]
Use an enum instead of a bool in PictureAsset::start_write().

13 months agoRemove the bools and default parameters from SoundAsset::start_write().
Carl Hetherington [Fri, 17 Mar 2023 12:33:08 +0000 (13:33 +0100)]
Remove the bools and default parameters from SoundAsset::start_write().

They were more confusing than they were worth.