+ make_and_verify_dcp (
+ film2,
+ {
+ dcp::VerificationNote::Code::MISSING_SUBTITLE_LANGUAGE,
+ dcp::VerificationNote::Code::INVALID_SUBTITLE_FIRST_TEXT_TIME
+ });
+}
+
+
+/** Another reels-related error; make_dcp() would raise a ProgrammingError
+ * in AudioBuffers::allocate due to an attempt to allocate a negatively-sized buffer.
+ * This was triggered by a VF where there are referenced audio reels followed by
+ * VF audio. When the VF audio arrives the Writer did not correctly skip over the
+ * referenced reels.
+ */
+BOOST_AUTO_TEST_CASE (reels_test10)
+{
+ /* Make the OV */
+ auto A = make_shared<FFmpegContent>("test/data/flat_red.png");
+ auto B = make_shared<FFmpegContent>("test/data/flat_red.png");
+ auto ov = new_test_film2("reels_test10_ov", {A, B});
+ A->video->set_length (5 * 24);
+ B->video->set_length (5 * 24);
+
+ ov->set_reel_type (ReelType::BY_VIDEO_CONTENT);
+ make_and_verify_dcp (ov);
+ ov->write_metadata ();
+
+ /* Now try to make the VF; this used to fail */
+ auto ov_dcp = make_shared<DCPContent>(ov->dir(ov->dcp_name()));
+ auto vf = new_test_film2("reels_test10_vf", {ov_dcp, content_factory("test/data/15s.srt").front()});
+ vf->set_reel_type (ReelType::BY_VIDEO_CONTENT);
+ ov_dcp->set_reference_video (true);
+ ov_dcp->set_reference_audio (true);
+
+ make_and_verify_dcp (
+ vf,
+ {
+ dcp::VerificationNote::Code::EXTERNAL_ASSET,
+ dcp::VerificationNote::Code::MISSING_SUBTITLE_LANGUAGE,
+ dcp::VerificationNote::Code::INVALID_SUBTITLE_FIRST_TEXT_TIME
+ });
+}
+
+
+/** Another reels error; ReelType::BY_VIDEO_CONTENT when the first content is not
+ * at time 0.
+ */
+BOOST_AUTO_TEST_CASE (reels_test11)
+{
+ auto A = make_shared<FFmpegContent>("test/data/flat_red.png");
+ auto film = new_test_film2 ("reels_test11", {A});
+ film->set_video_frame_rate (24);
+ A->video->set_length (240);
+ A->set_video_frame_rate (24);
+ A->set_position (film, DCPTime::from_seconds(1));
+ film->set_reel_type (ReelType::BY_VIDEO_CONTENT);
+ make_and_verify_dcp (film);
+ BOOST_CHECK_EQUAL (A->position().get(), DCPTime::from_seconds(1).get());
+ BOOST_CHECK_EQUAL (A->end(film).get(), DCPTime::from_seconds(1 + 10).get());
+
+ auto r = film->reels ();
+ BOOST_CHECK_EQUAL (r.size(), 2U);
+ BOOST_CHECK_EQUAL (r.front().from.get(), 0);
+ BOOST_CHECK_EQUAL (r.front().to.get(), DCPTime::from_seconds(1).get());
+ BOOST_CHECK_EQUAL (r.back().from.get(), DCPTime::from_seconds(1).get());
+ BOOST_CHECK_EQUAL (r.back().to.get(), DCPTime::from_seconds(1 + 10).get());
+}
+
+
+/** For VFs to work right we have to make separate reels for empty bits between
+ * video content.
+ */
+BOOST_AUTO_TEST_CASE (reels_test12)
+{
+ auto A = make_shared<FFmpegContent>("test/data/flat_red.png");
+ auto B = make_shared<FFmpegContent>("test/data/flat_red.png");
+ auto film = new_test_film2 ("reels_test12", {A, B});
+ film->set_video_frame_rate (24);
+ film->set_reel_type (ReelType::BY_VIDEO_CONTENT);
+ film->set_sequence (false);
+
+ A->video->set_length (240);
+ A->set_video_frame_rate (24);
+ A->set_position (film, DCPTime::from_seconds(1));
+
+ B->video->set_length (120);
+ B->set_video_frame_rate (24);
+ B->set_position (film, DCPTime::from_seconds(14));
+
+ auto r = film->reels ();
+ BOOST_REQUIRE_EQUAL (r.size(), 4U);
+ auto i = r.begin ();
+
+ BOOST_CHECK_EQUAL (i->from.get(), 0);
+ BOOST_CHECK_EQUAL (i->to.get(), DCPTime::from_seconds(1).get());
+ ++i;
+ BOOST_CHECK_EQUAL (i->from.get(), DCPTime::from_seconds(1).get());
+ BOOST_CHECK_EQUAL (i->to.get(), DCPTime::from_seconds(11).get());
+ ++i;
+ BOOST_CHECK_EQUAL (i->from.get(), DCPTime::from_seconds(11).get());
+ BOOST_CHECK_EQUAL (i->to.get(), DCPTime::from_seconds(14).get());
+ ++i;
+ BOOST_CHECK_EQUAL (i->from.get(), DCPTime::from_seconds(14).get());
+ BOOST_CHECK_EQUAL (i->to.get(), DCPTime::from_seconds(19).get());
+}
+
+
+static void
+no_op ()
+{
+
+}
+
+static void
+dump_notes (vector<dcp::VerificationNote> const & notes)
+{
+ for (auto i: notes) {
+ std::cout << dcp::note_to_string(i) << "\n";
+ }
+}
+
+
+/** Using less than 1 second's worth of content should not result in a reel
+ * of less than 1 second's duration.
+ */
+BOOST_AUTO_TEST_CASE (reels_should_not_be_short1)
+{
+ auto A = make_shared<FFmpegContent>("test/data/flat_red.png");
+ auto B = make_shared<FFmpegContent>("test/data/flat_red.png");
+ auto film = new_test_film2 ("reels_should_not_be_short1", {A, B});
+ film->set_video_frame_rate (24);
+
+ A->video->set_length (23);
+
+ B->video->set_length (23);
+ B->set_position (film, DCPTime::from_frames(23, 24));
+
+ make_and_verify_dcp (film);
+
+ vector<boost::filesystem::path> dirs = { film->dir(film->dcp_name(false)) };
+ auto notes = dcp::verify(dirs, boost::bind(&no_op), boost::bind(&no_op), TestPaths::xsd());
+ dump_notes (notes);
+ BOOST_REQUIRE (notes.empty());
+}
+
+
+/** Leaving less than 1 second's gap between two pieces of content with
+ * ReelType::BY_VIDEO_CONTENT should not make a <1s reel.
+ */
+BOOST_AUTO_TEST_CASE (reels_should_not_be_short2)
+{
+ auto A = make_shared<FFmpegContent>("test/data/flat_red.png");
+ auto B = make_shared<FFmpegContent>("test/data/flat_red.png");
+ auto film = new_test_film2 ("reels_should_not_be_short2", {A, B});
+ film->set_video_frame_rate (24);
+ film->set_reel_type (ReelType::BY_VIDEO_CONTENT);
+
+ A->video->set_length (240);
+
+ B->video->set_length (240);
+ B->set_position (film, DCPTime::from_seconds(10.2));
+
+ make_and_verify_dcp (film);
+
+ vector<boost::filesystem::path> dirs = { film->dir(film->dcp_name(false)) };
+ auto const notes = dcp::verify(dirs, boost::bind(&no_op), boost::bind(&no_op), TestPaths::xsd());
+ dump_notes (notes);
+ BOOST_REQUIRE (notes.empty());
+}
+
+
+/** Setting ReelType::BY_LENGTH and using a small length value should not make
+ * <1s reels.
+ */
+BOOST_AUTO_TEST_CASE (reels_should_not_be_short3)
+{
+ auto A = make_shared<FFmpegContent>("test/data/flat_red.png");
+ auto film = new_test_film2 ("reels_should_not_be_short3", {A});
+ film->set_video_frame_rate (24);
+ film->set_reel_type (ReelType::BY_LENGTH);
+ film->set_reel_length (1024 * 1024 * 10);
+
+ A->video->set_length (240);
+
+ make_and_verify_dcp (film);
+
+ auto const notes = dcp::verify({}, boost::bind(&no_op), boost::bind(&no_op), TestPaths::xsd());
+ dump_notes (notes);
+ BOOST_REQUIRE (notes.empty());
+}
+
+
+/** Having one piece of content less than 1s long in ReelType::BY_VIDEO_CONTENT
+ * should not make a reel less than 1s long.
+ */
+BOOST_AUTO_TEST_CASE (reels_should_not_be_short4)
+{
+ auto A = make_shared<FFmpegContent>("test/data/flat_red.png");
+ auto B = make_shared<FFmpegContent>("test/data/flat_red.png");
+ auto film = new_test_film2 ("reels_should_not_be_short4", {A, B});
+ film->set_video_frame_rate (24);
+ film->set_reel_type (ReelType::BY_VIDEO_CONTENT);
+
+ A->video->set_length (240);
+
+ B->video->set_length (23);
+ B->set_position (film, DCPTime::from_frames(240, 24));
+
+ BOOST_CHECK_EQUAL (film->reels().size(), 1U);
+ BOOST_CHECK (film->reels().front() == dcpomatic::DCPTimePeriod(dcpomatic::DCPTime(), dcpomatic::DCPTime::from_frames(263, 24)));
+
+ film->write_metadata ();
+ film->make_dcp ();
+ BOOST_REQUIRE (!wait_for_jobs());
+
+ vector<boost::filesystem::path> dirs = { film->dir(film->dcp_name(false)) };
+ auto const notes = dcp::verify(dirs, boost::bind(&no_op), boost::bind(&no_op), TestPaths::xsd());
+ dump_notes (notes);
+ BOOST_REQUIRE (notes.empty());