dcpomatic.git
30 hours agoAdd some new pixfmts. main
Carl Hetherington [Sun, 24 Sep 2023 21:30:19 +0000 (23:30 +0200)]
Add some new pixfmts.

3 days agoClean up and add Ubuntu 23.10
Carl Hetherington [Thu, 21 Sep 2023 21:58:49 +0000 (23:58 +0200)]
Clean up and add Ubuntu 23.10

5 days agoSupporters update. v2.16.65
Carl Hetherington [Wed, 20 Sep 2023 23:10:14 +0000 (01:10 +0200)]
Supporters update.

5 days agoFix example names in prefs (#2612).
Carl Hetherington [Wed, 20 Sep 2023 21:59:20 +0000 (23:59 +0200)]
Fix example names in prefs (#2612).

5 days agoBetter error message.
Carl Hetherington [Wed, 20 Sep 2023 20:57:03 +0000 (22:57 +0200)]
Better error message.

10 days agoUpdated zh_CN translation from poppinzhang.
Carl Hetherington [Fri, 15 Sep 2023 08:53:33 +0000 (10:53 +0200)]
Updated zh_CN translation from poppinzhang.

11 days agoUpdated sl_SI translation from Martin Srebotnjak.
Carl Hetherington [Thu, 14 Sep 2023 21:12:19 +0000 (23:12 +0200)]
Updated sl_SI translation from Martin Srebotnjak.

11 days agoSupporters update.
Carl Hetherington [Thu, 14 Sep 2023 08:57:18 +0000 (10:57 +0200)]
Supporters update.

12 days agoSupporters update. v2.16.64
Carl Hetherington [Wed, 13 Sep 2023 21:27:39 +0000 (23:27 +0200)]
Supporters update.

12 days agoBump libdcp for fix to GH #20, a spurious rejection of a KDM.
Carl Hetherington [Wed, 13 Sep 2023 20:29:04 +0000 (22:29 +0200)]
Bump libdcp for fix to GH #20, a spurious rejection of a KDM.

13 days agoUpdate ISDCF name when DCP track changes.
Carl Hetherington [Tue, 12 Sep 2023 21:14:42 +0000 (23:14 +0200)]
Update ISDCF name when DCP track changes.

13 days agoSomewhat fix inclusion of CCAP language in ISDCF name (#2610).
Carl Hetherington [Tue, 12 Sep 2023 21:14:35 +0000 (23:14 +0200)]
Somewhat fix inclusion of CCAP language in ISDCF name (#2610).

13 days agoAdd Film::closed_caption_languages().
Carl Hetherington [Tue, 12 Sep 2023 21:14:06 +0000 (23:14 +0200)]
Add Film::closed_caption_languages().

2 weeks agoUpdate DCP name when some text changes from subtitle to ccap.
Carl Hetherington [Mon, 11 Sep 2023 22:36:05 +0000 (00:36 +0200)]
Update DCP name when some text changes from subtitle to ccap.

2 weeks agoAlways add -CCAP to ISDCF names if there are ccaps.
Carl Hetherington [Mon, 11 Sep 2023 22:35:39 +0000 (00:35 +0200)]
Always add -CCAP to ISDCF names if there are ccaps.

2 weeks agoCleanup: use some stack allocation and shared_ptr.
Carl Hetherington [Sun, 10 Sep 2023 20:14:58 +0000 (22:14 +0200)]
Cleanup: use some stack allocation and shared_ptr.

2 weeks agoAlways call AddCatalog("wxstd") as it appears to be necessary to
Carl Hetherington [Fri, 8 Sep 2023 22:01:35 +0000 (00:01 +0200)]
Always call AddCatalog("wxstd") as it appears to be necessary to
get wxWidgets' translations to appear (at least on Windows) (#2606).

2 weeks agoOpen Windows console earlier in startup.
Carl Hetherington [Fri, 8 Sep 2023 22:00:26 +0000 (00:00 +0200)]
Open Windows console earlier in startup.

2 weeks agoFix hints test now that subtitle reader gives an error on large fonts.
Carl Hetherington [Fri, 8 Sep 2023 05:47:41 +0000 (07:47 +0200)]
Fix hints test now that subtitle reader gives an error on large fonts.

2 weeks agoSanitise asset names after potentially failed %-based substitutions (#945).
Carl Hetherington [Thu, 7 Sep 2023 21:24:06 +0000 (23:24 +0200)]
Sanitise asset names after potentially failed %-based substitutions (#945).

If there's a %x in the format string, where %x is not recognised, we
should at least remove the %.

2 weeks agoDisallow % from asset names as it seems to awake some XML character-encoding
Carl Hetherington [Thu, 7 Sep 2023 21:22:54 +0000 (23:22 +0200)]
Disallow % from asset names as it seems to awake some XML character-encoding
demons.

2 weeks agoCleanup: use ConfigRestorer instead of Keep class.
Carl Hetherington [Thu, 7 Sep 2023 20:59:40 +0000 (22:59 +0200)]
Cleanup: use ConfigRestorer instead of Keep class.

2 weeks agoUpdated nl_NL translation from Rob van Nieuwkerk.
Carl Hetherington [Thu, 7 Sep 2023 12:37:34 +0000 (14:37 +0200)]
Updated nl_NL translation from Rob van Nieuwkerk.

2 weeks agoTry to allow staged and non-staged i18n updates.
Carl Hetherington [Thu, 7 Sep 2023 12:37:27 +0000 (14:37 +0200)]
Try to allow staged and non-staged i18n updates.

2 weeks agoBump libdcp to fix errors when loading DCPs with very big fonts.
Carl Hetherington [Wed, 6 Sep 2023 21:10:49 +0000 (23:10 +0200)]
Bump libdcp to fix errors when loading DCPs with very big fonts.

2 weeks agopot/merge.
Carl Hetherington [Tue, 5 Sep 2023 12:07:35 +0000 (14:07 +0200)]
pot/merge.

3 weeks agoUse configured issuer/creator for DCPs made by map (#2585).
Carl Hetherington [Mon, 4 Sep 2023 18:08:03 +0000 (20:08 +0200)]
Use configured issuer/creator for DCPs made by map (#2585).

3 weeks agoIgnore newlines in subtitle text (#2341).
Carl Hetherington [Fri, 16 Jun 2023 22:03:51 +0000 (00:03 +0200)]
Ignore newlines in subtitle text (#2341).

3 weeks agoFix rendering of italic fonts during tests on Windows.
Carl Hetherington [Sat, 2 Sep 2023 16:44:03 +0000 (18:44 +0200)]
Fix rendering of italic fonts during tests on Windows.

3 weeks agoFix crash when pressing Ctrl+{C,V} at the wrong time.
Carl Hetherington [Sat, 2 Sep 2023 20:32:06 +0000 (22:32 +0200)]
Fix crash when pressing Ctrl+{C,V} at the wrong time.

3 weeks agoSupporters update. v2.16.63
Carl Hetherington [Fri, 1 Sep 2023 17:32:46 +0000 (19:32 +0200)]
Supporters update.

3 weeks agoMissing #ifdef for Windows references.
Carl Hetherington [Fri, 1 Sep 2023 07:01:12 +0000 (09:01 +0200)]
Missing #ifdef for Windows references.

3 weeks agoSupporters update.
Carl Hetherington [Thu, 31 Aug 2023 22:09:47 +0000 (00:09 +0200)]
Supporters update.

3 weeks agoBump libdcp to release version.
Carl Hetherington [Thu, 31 Aug 2023 22:09:31 +0000 (00:09 +0200)]
Bump libdcp to release version.

3 weeks agoFix vertical alignment of subtitles in some cases (#2569).
Carl Hetherington [Sat, 26 Aug 2023 18:17:17 +0000 (20:17 +0200)]
Fix vertical alignment of subtitles in some cases (#2569).

3 weeks agoGive a more useful error when check_dcp() fails.
Carl Hetherington [Sat, 26 Aug 2023 18:16:47 +0000 (20:16 +0200)]
Give a more useful error when check_dcp() fails.

3 weeks agoFix incorrect horizontal positions when different HPositions are used with one VPosition.
Carl Hetherington [Sat, 26 Aug 2023 17:51:51 +0000 (19:51 +0200)]
Fix incorrect horizontal positions when different HPositions are used with one VPosition.

Previously if HPosition changed we would still use a single "line" (i.e. Pango layout)
for all the text, meaning that HPosition would not be respected.

3 weeks agoRestore burnt subtitle tests.
Carl Hetherington [Sat, 26 Aug 2023 17:49:25 +0000 (19:49 +0200)]
Restore burnt subtitle tests.

3 weeks agoCleanup: use some more vector instead of list.
Carl Hetherington [Sat, 26 Aug 2023 12:29:06 +0000 (14:29 +0200)]
Cleanup: use some more vector instead of list.

4 weeks agoFix tests when changing the cinemas file.
Carl Hetherington [Sat, 26 Aug 2023 17:45:02 +0000 (19:45 +0200)]
Fix tests when changing the cinemas file.

4 weeks agoHandle fonts/subdirs correctly for CCAPs with _map (#2584).
Carl Hetherington [Thu, 24 Aug 2023 21:50:18 +0000 (23:50 +0200)]
Handle fonts/subdirs correctly for CCAPs with _map (#2584).

4 weeks agoBump libdcp to properly check for missing fonts in CCAP LoadFont tags.
Carl Hetherington [Thu, 24 Aug 2023 21:51:16 +0000 (23:51 +0200)]
Bump libdcp to properly check for missing fonts in CCAP LoadFont tags.

4 weeks agoFix refusal to reference overlapping but different text content (#2599).
Carl Hetherington [Sat, 26 Aug 2023 22:17:58 +0000 (00:17 +0200)]
Fix refusal to reference overlapping but different text content (#2599).

4 weeks agoTweak a message to be more grammatically correct.
Carl Hetherington [Sat, 26 Aug 2023 22:14:14 +0000 (00:14 +0200)]
Tweak a message to be more grammatically correct.

4 weeks agoCleanup: use some lambdas.
Carl Hetherington [Sat, 26 Aug 2023 21:34:19 +0000 (23:34 +0200)]
Cleanup: use some lambdas.

4 weeks agoUpdate test/data for missing test reference.
Carl Hetherington [Sat, 26 Aug 2023 11:10:34 +0000 (13:10 +0200)]
Update test/data for missing test reference.

4 weeks agoSet up packet duration correctly when encoding using FFmpeg (#2588).
Carl Hetherington [Thu, 24 Aug 2023 13:44:32 +0000 (15:44 +0200)]
Set up packet duration correctly when encoding using FFmpeg (#2588).

It seems strange that this is necessary (maybe I'm missing some
other way that the packet duration is supposed to be set up).

Without this, when the mov muxer writes the trak tags it uses an
incorrect length value because the length value is calculated
from trk->end_pts, which in turn is calculated from the last-seen
pts + the duration of the last packet.  If that packet is marked
as length 0 the length of the track is 1 frame short, so the export
is missing a frame.

4 weeks agoCheck a return value for error.
Carl Hetherington [Thu, 24 Aug 2023 13:44:11 +0000 (15:44 +0200)]
Check a return value for error.

4 weeks agoSpeculative fix to ensure correct freeing.
Carl Hetherington [Thu, 24 Aug 2023 13:43:54 +0000 (15:43 +0200)]
Speculative fix to ensure correct freeing.

4 weeks agoExtend run_ffprobe to allow arguments and capture of stdout.
Carl Hetherington [Thu, 24 Aug 2023 13:43:06 +0000 (15:43 +0200)]
Extend run_ffprobe to allow arguments and capture of stdout.

4 weeks agoTry to capture ffmpeg logs during tests.
Carl Hetherington [Thu, 24 Aug 2023 09:33:07 +0000 (11:33 +0200)]
Try to capture ffmpeg logs during tests.

4 weeks agoCleanup: extract TranscodeJob::frames_per_second().
Carl Hetherington [Fri, 25 Aug 2023 23:43:22 +0000 (01:43 +0200)]
Cleanup: extract TranscodeJob::frames_per_second().

4 weeks agoDon't bother reporting job durations less than 10s.
Carl Hetherington [Fri, 25 Aug 2023 23:32:13 +0000 (01:32 +0200)]
Don't bother reporting job durations less than 10s.

4 weeks agoUse _{start,finish}_time in TranscodeJob.
Carl Hetherington [Fri, 25 Aug 2023 23:14:20 +0000 (01:14 +0200)]
Use _{start,finish}_time in TranscodeJob.

4 weeks agoGive more details when jobs finish (#2572).
Carl Hetherington [Fri, 25 Aug 2023 22:38:17 +0000 (00:38 +0200)]
Give more details when jobs finish (#2572).

4 weeks agoAdd --cinemas-file option to KDM CLI.
Carl Hetherington [Thu, 24 Aug 2023 15:55:39 +0000 (17:55 +0200)]
Add --cinemas-file option to KDM CLI.

4 weeks agoReplace a couple of erroneous calls to exit() in kdm_cli.cc.
Carl Hetherington [Thu, 24 Aug 2023 15:55:24 +0000 (17:55 +0200)]
Replace a couple of erroneous calls to exit() in kdm_cli.cc.

4 weeks agoAdd some more detail to the KDM CLI help.
Carl Hetherington [Thu, 24 Aug 2023 15:54:57 +0000 (17:54 +0200)]
Add some more detail to the KDM CLI help.

4 weeks agoBump libdcp for subtitle alignment parsing fix (#2602).
Carl Hetherington [Tue, 22 Aug 2023 22:03:16 +0000 (00:03 +0200)]
Bump libdcp for subtitle alignment parsing fix (#2602).

4 weeks agoFixed libdcp reference to be a release.
Carl Hetherington [Tue, 22 Aug 2023 14:17:40 +0000 (16:17 +0200)]
Fixed libdcp reference to be a release.

5 weeks agoSupporters update. v2.16.62
Carl Hetherington [Sun, 20 Aug 2023 19:51:25 +0000 (21:51 +0200)]
Supporters update.

5 weeks agoAnother signed/unsigned mismatch.
Carl Hetherington [Sun, 20 Aug 2023 12:07:10 +0000 (14:07 +0200)]
Another signed/unsigned mismatch.

5 weeks agoFix unsigned/signed mismatch.
Carl Hetherington [Sat, 19 Aug 2023 23:53:19 +0000 (01:53 +0200)]
Fix unsigned/signed mismatch.

5 weeks agoYet more private file fixing.
Carl Hetherington [Sat, 19 Aug 2023 20:48:00 +0000 (22:48 +0200)]
Yet more private file fixing.

5 weeks agoMore private test files tinkering.
Carl Hetherington [Sat, 19 Aug 2023 18:35:07 +0000 (20:35 +0200)]
More private test files tinkering.

5 weeks agoPrivate test files repo change.
Carl Hetherington [Sat, 19 Aug 2023 16:18:46 +0000 (18:18 +0200)]
Private test files repo change.

5 weeks agoSupporters update.
Carl Hetherington [Sat, 19 Aug 2023 12:22:33 +0000 (14:22 +0200)]
Supporters update.

5 weeks agoBump libdcp for dcp::LocalTime format fix.
Carl Hetherington [Tue, 15 Aug 2023 16:33:52 +0000 (18:33 +0200)]
Bump libdcp for dcp::LocalTime format fix.

5 weeks agoCope with unexpected channel counts in data coming from audio decoders.
Carl Hetherington [Tue, 15 Aug 2023 13:46:41 +0000 (15:46 +0200)]
Cope with unexpected channel counts in data coming from audio decoders.

5 weeks agoAdd Resampler::channels().
Carl Hetherington [Tue, 15 Aug 2023 13:46:30 +0000 (15:46 +0200)]
Add Resampler::channels().

5 weeks agoAdd Audiobuffers::set_channels().
Carl Hetherington [Tue, 15 Aug 2023 13:46:19 +0000 (15:46 +0200)]
Add Audiobuffers::set_channels().

5 weeks agoCleanup: remove unused variable.
Carl Hetherington [Tue, 15 Aug 2023 13:11:49 +0000 (15:11 +0200)]
Cleanup: remove unused variable.

5 weeks agoRemove now-unnecessary assertion.
Carl Hetherington [Tue, 15 Aug 2023 13:02:29 +0000 (15:02 +0200)]
Remove now-unnecessary assertion.

Since e29ce33a36c2e20444d57196defc86d5072bce81 channels is the
number of channels in the frame, and also the number in data,
so we don't need to check this any more.

6 weeks agoBump ffmpeg to fix build on binutils >= 2.41 (currently in Debian unstable).
Carl Hetherington [Mon, 14 Aug 2023 20:55:44 +0000 (22:55 +0200)]
Bump ffmpeg to fix build on binutils >= 2.41 (currently in Debian unstable).

6 weeks agoAdd missing GUI message. v2.16.61
Carl Hetherington [Fri, 11 Aug 2023 23:06:15 +0000 (01:06 +0200)]
Add missing GUI message.

6 weeks agoBump ffmpeg for fix to EXR parsing with non-multiple-of-8 image sizes (#2508).
Carl Hetherington [Sun, 2 Jul 2023 21:24:24 +0000 (23:24 +0200)]
Bump ffmpeg for fix to EXR parsing with non-multiple-of-8 image sizes (#2508).

6 weeks agoSupporters update.
Carl Hetherington [Fri, 11 Aug 2023 22:49:29 +0000 (00:49 +0200)]
Supporters update.

6 weeks agoBump libdcp for verification of <LabelText> in <ContentVersion>
Carl Hetherington [Fri, 11 Aug 2023 22:22:14 +0000 (00:22 +0200)]
Bump libdcp for verification of <LabelText> in <ContentVersion>

6 weeks agoPrevent empty <LabelText> in <ContentVersion> (#2594).
Carl Hetherington [Fri, 11 Aug 2023 22:13:08 +0000 (00:13 +0200)]
Prevent empty <LabelText> in <ContentVersion> (#2594).

6 weeks agoFix tests on Windows.
Carl Hetherington [Thu, 10 Aug 2023 21:12:09 +0000 (23:12 +0200)]
Fix tests on Windows.

6 weeks agoBump libdcp to a release version.
Carl Hetherington [Wed, 9 Aug 2023 08:17:21 +0000 (10:17 +0200)]
Bump libdcp to a release version.

6 weeks agoCleanup: tidy Playlist::move_later().
Carl Hetherington [Tue, 8 Aug 2023 21:53:52 +0000 (23:53 +0200)]
Cleanup: tidy Playlist::move_later().

6 weeks agoAdd some tests.
Carl Hetherington [Tue, 8 Aug 2023 21:53:42 +0000 (23:53 +0200)]
Add some tests.

6 weeks agoFix some missed includes of the old boost bind header.
Carl Hetherington [Tue, 8 Aug 2023 16:32:14 +0000 (18:32 +0200)]
Fix some missed includes of the old boost bind header.

6 weeks agoMove ContentSorter out of the header, and use a default constructor.
Carl Hetherington [Tue, 8 Aug 2023 16:32:03 +0000 (18:32 +0200)]
Move ContentSorter out of the header, and use a default constructor.

6 weeks agoExtract Film::Property to its own header to (maybe) increase compilation speed.
Carl Hetherington [Tue, 8 Aug 2023 16:11:11 +0000 (18:11 +0200)]
Extract Film::Property to its own header to (maybe) increase compilation speed.

6 weeks agoCleanup: use some better variable names and tidy ifs.
Carl Hetherington [Tue, 8 Aug 2023 13:26:05 +0000 (15:26 +0200)]
Cleanup: use some better variable names and tidy ifs.

6 weeks agoCleanup: use nullptr.
Carl Hetherington [Tue, 8 Aug 2023 13:25:47 +0000 (15:25 +0200)]
Cleanup: use nullptr.

6 weeks agoCleanup: use a better loop variable name.
Carl Hetherington [Tue, 8 Aug 2023 13:25:42 +0000 (15:25 +0200)]
Cleanup: use a better loop variable name.

6 weeks agoCleanup: use a std::find_if().
Carl Hetherington [Tue, 8 Aug 2023 13:17:46 +0000 (15:17 +0200)]
Cleanup: use a std::find_if().

6 weeks agoAdd a test.
Carl Hetherington [Tue, 8 Aug 2023 13:16:35 +0000 (15:16 +0200)]
Add a test.

6 weeks agoCleanup: use a default constructor.
Carl Hetherington [Tue, 8 Aug 2023 13:06:56 +0000 (15:06 +0200)]
Cleanup: use a default constructor.

6 weeks agoCleanup: use a lambda.
Carl Hetherington [Tue, 8 Aug 2023 13:06:49 +0000 (15:06 +0200)]
Cleanup: use a lambda.

6 weeks agoCleanup: use some better loop variable names.
Carl Hetherington [Tue, 8 Aug 2023 13:06:39 +0000 (15:06 +0200)]
Cleanup: use some better loop variable names.

7 weeks agoAdd new hack.
Carl Hetherington [Wed, 2 Aug 2023 15:28:39 +0000 (17:28 +0200)]
Add new hack.

7 weeks agoAdd hint about audio channel count.
Carl Hetherington [Sun, 30 Jul 2023 22:34:22 +0000 (00:34 +0200)]
Add hint about audio channel count.

7 weeks agoDefault to writing 8 audio channels in DCPs (#2443).
Carl Hetherington [Tue, 25 Jul 2023 09:09:46 +0000 (11:09 +0200)]
Default to writing 8 audio channels in DCPs (#2443).

It seems likely that 8 channels is slightly less likely to trip validation
warnings from some distributors, and so it seems worth accepting the potential
waste of 2 channels.  Users can always set this back to 6 again (once,
and it will be saved) and those upgrading from old versions won't be affected
anyway.

7 weeks agoGo back to respecting the user's choice for the number of audio channels in the MXF.
Carl Hetherington [Tue, 25 Jul 2023 09:04:30 +0000 (11:04 +0200)]
Go back to respecting the user's choice for the number of audio channels in the MXF.

8 weeks agoOnly warn about a missing text language for subtitles (not closed captions).
Carl Hetherington [Sun, 30 Jul 2023 22:51:11 +0000 (00:51 +0200)]
Only warn about a missing text language for subtitles (not closed captions).

I haven't properly checked that closed captions shouldn't have some
language metadata, but the existing GUI code explicitly disallows
setup of a closed caption language.

8 weeks agoCheck channel count when comparing audio MXFs.
Carl Hetherington [Sat, 29 Jul 2023 00:27:02 +0000 (02:27 +0200)]
Check channel count when comparing audio MXFs.