Cleanup: handle Filter objects by value rather than by reference.

[dcpomatic.git] / src / lib / dcp_examiner.cc

diff --git a/src/lib/dcp_examiner.cc b/src/lib/dcp_examiner.cc
index a9a6dee5eb20920b9071a6ee78959afa7bfadf9d..ca77f2db3bdaedfc560206e8937a9df9889ef4a0 100644 (file)
--- a/src/lib/dcp_examiner.cc
+++ b/src/lib/dcp_examiner.cc
@@ -83,7 +83,7 @@ DCPExaminer::DCPExaminer (shared_ptr<const DCPContent> content, bool tolerant)
 
                for (auto cpl: cpls) {
                        int unsatisfied = 0;
-                       for (auto reel: cpl->reels()) {
+                       for (auto const& reel: cpl->reels()) {
                                if (reel->main_picture() && !reel->main_picture()->asset_ref().resolved()) {
                                        ++unsatisfied;
                                }
@@ -211,9 +211,7 @@ DCPExaminer::DCPExaminer (shared_ptr<const DCPContent> content, bool tolerant)
                        for (auto const& font: asset->font_data()) {
                                _fonts.push_back({reel_index, asset->id(), make_shared<dcpomatic::Font>(font.first, font.second)});
                        }
-                       if (asset->font_data().empty()) {
-                               _fonts.push_back({reel_index, asset->id(), make_shared<dcpomatic::Font>("")});
-                       }
+                       _fonts.push_back({reel_index, asset->id(), make_shared<dcpomatic::Font>("")});
                }
 
                _text_count[TextType::CLOSED_CAPTION] = std::max(_text_count[TextType::CLOSED_CAPTION], static_cast<int>(reel->closed_captions().size()));