Debugging for encode decisions.

[dcpomatic.git] / src / lib / hints.cc

diff --git a/src/lib/hints.cc b/src/lib/hints.cc
index bf0f440961c313a39a776e8f2f68661e0fc18fc6..219b5139cda492b479af68ff76fd2c7ae6b18e76 100644 (file)
--- a/src/lib/hints.cc
+++ b/src/lib/hints.cc
@@ -28,6 +28,8 @@
 #include "ratio.h"
 #include "audio_analysis.h"
 #include "compose.hpp"
+#include "util.h"
+#include <dcp/raw_convert.h>
 #include <boost/foreach.hpp>
 #include <boost/algorithm/string.hpp>
 
@@ -83,14 +85,20 @@ get_hints (shared_ptr<const Film> film)
                }
        }
 
-       if (scope && !flat_or_narrower && film->container()->id() == "185") {
+       string const film_container = film->container()->id();
+
+       if (scope && !flat_or_narrower && film_container == "185") {
                hints.push_back (_("All of your content is in Scope (2.39:1) but your DCP's container is Flat (1.85:1).  This will letter-box your content inside a Flat (1.85:1) frame.  You may prefer to set your DCP's container to Scope (2.39:1) in the \"DCP\" tab."));
        }
 
-       if (!scope && flat_or_narrower && film->container()->id() == "239") {
+       if (!scope && flat_or_narrower && film_container == "239") {
                hints.push_back (_("All of your content is at 1.85:1 or narrower but your DCP's container is Scope (2.39:1).  This will pillar-box your content inside a Flat (1.85:1) frame.  You may prefer to set your DCP's container to Flat (1.85:1) in the \"DCP\" tab."));
        }
 
+       if (film_container != "185" && film_container != "239" && film_container != "full-frame") {
+               hints.push_back (_("Your DCP uses an unusual container ratio.  This may cause problems on some projectors.  If possible, use Flat or Scope for the DCP container ratio"));
+       }
+
        if (film->video_frame_rate() != 24 && film->video_frame_rate() != 48) {
                hints.push_back (String::compose (_("Your DCP frame rate (%1 fps) may cause problems in a few (mostly older) projectors.  Use 24 or 48 frames per second to be on the safe side."), film->video_frame_rate()));
        }
@@ -127,15 +135,36 @@ get_hints (shared_ptr<const Film> film)
 
        boost::filesystem::path path = film->audio_analysis_path (film->playlist ());
        if (boost::filesystem::exists (path)) {
-               shared_ptr<AudioAnalysis> an (new AudioAnalysis (path));
-               if (an->sample_peak() || an->true_peak()) {
-                       float const peak = max (an->sample_peak().get_value_or(0), an->true_peak().get_value_or(0));
-                       float const peak_dB = 20 * log10 (peak) + an->gain_correction (film->playlist ());
-                       if (peak_dB > -3 && peak_dB < -0.5) {
-                               hints.push_back (_("Your audio level is very high.  You should reduce the gain of your audio content."));
-                       } else if (peak_dB > -0.5) {
-                               hints.push_back (_("Your audio level is very close to clipping.  You should reduce the gain of your audio content."));
+               try {
+                       shared_ptr<AudioAnalysis> an (new AudioAnalysis (path));
+
+                       string ch;
+
+                       vector<AudioAnalysis::PeakTime> sample_peak = an->sample_peak ();
+                       vector<float> true_peak = an->true_peak ();
+
+                       for (size_t i = 0; i < sample_peak.size(); ++i) {
+                               float const peak = max (sample_peak[i].peak, true_peak.empty() ? 0 : true_peak[i]);
+                               float const peak_dB = 20 * log10 (peak) + an->gain_correction (film->playlist ());
+                               if (peak_dB > -3) {
+                                       ch += dcp::raw_convert<string> (short_audio_channel_name (i)) + ", ";
+                               }
+                       }
+
+                       ch = ch.substr (0, ch.length() - 2);
+
+                       if (!ch.empty ()) {
+                               hints.push_back (
+                                       String::compose (
+                                               _("Your audio level is very high (on %1).  You should reduce the gain of your audio content."),
+                                               ch
+                                               )
+                                       );
                        }
+               } catch (OldFormatError& e) {
+                       /* The audio analysis is too old to load in; just skip this hint as if
+                          it had never been run.
+                       */
                }
        }