void
SubtitleDecoder::emit_text_start (ContentTime from, list<dcp::SubtitleString> s)
{
- /* We must escape < and > in strings, otherwise they might confuse our subtitle
- renderer (which uses some HTML-esque markup to do bold/italic etc.)
- */
BOOST_FOREACH (dcp::SubtitleString& i, s) {
+ /* We must escape < and > in strings, otherwise they might confuse our subtitle
+ renderer (which uses some HTML-esque markup to do bold/italic etc.)
+ */
string t = i.text ();
boost::algorithm::replace_all (t, "<", "<");
boost::algorithm::replace_all (t, ">", ">");
i.set_text (t);
+
+ /* Set any forced appearance */
+ if (content()->colour()) {
+ i.set_colour (*content()->colour());
+ }
+ if (content()->effect_colour()) {
+ i.set_effect_colour (*content()->effect_colour());
+ }
+ if (content()->effect()) {
+ i.set_effect (*content()->effect());
+ }
+ if (content()->fade_in()) {
+ i.set_fade_up_time (dcp::Time(content()->fade_in()->seconds(), 1000));
+ }
+ if (content()->fade_out()) {
+ i.set_fade_down_time (dcp::Time(content()->fade_out()->seconds(), 1000));
+ }
}
TextStart (ContentTextSubtitle (from, s));
}
}
- dcp::Effect effect = dcp::NONE;
- if (content()->outline()) {
- effect = dcp::BORDER;
- } else if (content()->shadow()) {
- effect = dcp::SHADOW;
- }
-
dcp::HAlign h_align;
switch (i.horizontal_position.reference) {
case sub::LEFT_OF_SCREEN:
break;
}
+ /* The idea here (rightly or wrongly) is that we set the appearance based on the
+ values in the libsub objects, and these are overridden with values from the
+ content by the other emit_text_start() above.
+ */
+
out.push_back (
dcp::SubtitleString (
string(TEXT_FONT_ID),
j.italic,
j.bold,
j.underline,
- /* force the colour to whatever is configured */
- content()->colour(),
+ j.colour.dcp(),
j.font_size.points (72 * 11),
1.0,
dcp::Time (from.seconds(), 1000),
v_align,
dcp::DIRECTION_LTR,
j.text,
- effect,
- content()->effect_colour(),
- dcp::Time (content()->fade_in().seconds(), 1000),
- dcp::Time (content()->fade_out().seconds(), 1000)
+ dcp::NONE,
+ j.effect_colour.get_value_or(sub::Colour(0, 0, 0)).dcp(),
+ /* Hack: we should use subtitle.fade_up and subtitle.fade_down here
+ but the times of these often don't have a frame rate associated
+ with them so the sub::Time won't convert them to milliseconds without
+ throwing an exception. Since only DCP subs fill those in (and we don't
+ use libsub for DCP subs) we can cheat by just putting 0 in here.
+ */
+ dcp::Time (),
+ dcp::Time ()
)
);
}