ardour.git
10 years agoModified nesting to ensure that 'vst_search_path()' shouldn't return NULL if the...
John Emmas [Sun, 9 Mar 2014 11:48:09 +0000 (11:48 +0000)]
Modified nesting to ensure that 'vst_search_path()' shouldn't return NULL if the first test fails

10 years agofix reading VST shell-plugin .fsi cache
Robin Gareus [Sat, 8 Mar 2014 23:36:13 +0000 (00:36 +0100)]
fix reading VST shell-plugin .fsi cache

10 years agoVST? yes, we can do.
Robin Gareus [Sat, 8 Mar 2014 22:34:49 +0000 (23:34 +0100)]
VST? yes, we can do.

10 years agopaths dialog: use selection as default when adding new dirs
Robin Gareus [Sat, 8 Mar 2014 17:28:16 +0000 (18:28 +0100)]
paths dialog: use selection as default when adding new dirs

10 years agofix double-free() when scanning VST shell plugins
Robin Gareus [Sat, 8 Mar 2014 17:27:30 +0000 (18:27 +0100)]
fix double-free() when scanning VST shell plugins

10 years agoVST scanner: fix Ardour type IDs
Robin Gareus [Sat, 8 Mar 2014 16:24:42 +0000 (17:24 +0100)]
VST scanner: fix Ardour type IDs

10 years agoAdd a couple of visibility specifiers that were missing
John Emmas [Sat, 8 Mar 2014 11:29:52 +0000 (11:29 +0000)]
Add a couple of visibility specifiers that were missing

10 years agoUse LIBPBD_TEMPLATE_API and LIBPBD_TEMPLATE_MEMBER_API where appropriate
John Emmas [Sat, 8 Mar 2014 11:28:54 +0000 (11:28 +0000)]
Use LIBPBD_TEMPLATE_API and LIBPBD_TEMPLATE_MEMBER_API where appropriate

10 years agouse fill transparency detection to avoid rendering transparent (invisible) rectangle...
Paul Davis [Fri, 7 Mar 2014 17:29:26 +0000 (12:29 -0500)]
use fill transparency detection to avoid rendering transparent (invisible) rectangle fill area

10 years agoif a Fill object is given a zero-alpha (transparent) color, note that
Paul Davis [Fri, 7 Mar 2014 17:28:52 +0000 (12:28 -0500)]
if a Fill object is given a zero-alpha (transparent) color, note that

10 years agodon't show frame trim handles when in internal editing mode
Paul Davis [Fri, 7 Mar 2014 17:27:48 +0000 (12:27 -0500)]
don't show frame trim handles when in internal editing mode

10 years agoalter ArdourCanvas::Rect::expand() to not clamp to all-positive values because we...
Paul Davis [Fri, 7 Mar 2014 16:26:27 +0000 (11:26 -0500)]
alter ArdourCanvas::Rect::expand() to not clamp to all-positive values because we now definitely have items that have negative coordinates.

This could have drastic consequences but I think the all-positive was a hack to fix a problem that was solved separately by means currently unknown.

10 years agoslightly optimize bounding box computation for ArdourCanvas::PolyItem by avoiding...
Paul Davis [Fri, 7 Mar 2014 16:24:51 +0000 (11:24 -0500)]
slightly optimize bounding box computation for ArdourCanvas::PolyItem by avoiding inner conditional

10 years agothird part of the logic fix for percussive note trimming
Paul Davis [Fri, 7 Mar 2014 16:24:06 +0000 (11:24 -0500)]
third part of the logic fix for percussive note trimming

10 years agosecond part of the logic fix for percussive note trimming
Paul Davis [Fri, 7 Mar 2014 16:23:48 +0000 (11:23 -0500)]
second part of the logic fix for percussive note trimming

10 years agomove an assert to cover only cases where it is needed
Paul Davis [Fri, 7 Mar 2014 16:23:22 +0000 (11:23 -0500)]
move an assert to cover only cases where it is needed

10 years agofix up some logic that allowed hits (percussive note display) to be trimmed with...
Paul Davis [Fri, 7 Mar 2014 16:22:49 +0000 (11:22 -0500)]
fix up some logic that allowed hits (percussive note display) to be trimmed with the mouse, which was not intended

10 years agoremove irrelevant comment
Paul Davis [Fri, 7 Mar 2014 14:25:18 +0000 (09:25 -0500)]
remove irrelevant comment

10 years agofix missing Hit destructor, which left polygons all over the canvas after deleting...
Paul Davis [Fri, 7 Mar 2014 04:17:04 +0000 (23:17 -0500)]
fix missing Hit destructor, which left polygons all over the canvas after deleting the Hit object(s)

10 years agofix apparent logic error for MidiRegionView when redisplaying note model
Paul Davis [Fri, 7 Mar 2014 04:16:42 +0000 (23:16 -0500)]
fix apparent logic error for MidiRegionView when redisplaying note model

10 years agotweak Polygon::render() to work whether or not fill or outline are unset
Paul Davis [Fri, 7 Mar 2014 04:15:59 +0000 (23:15 -0500)]
tweak Polygon::render() to work whether or not fill or outline are unset

10 years agotrivial API change for MidiRegionView::update_hit()
Paul Davis [Thu, 6 Mar 2014 18:27:51 +0000 (13:27 -0500)]
trivial API change for MidiRegionView::update_hit()

10 years agocomment edit
Paul Davis [Thu, 6 Mar 2014 18:27:26 +0000 (13:27 -0500)]
comment edit

10 years agouse CANVAS_DEBUG_NAME instead of explicit #ifdef to set canvas item name
Paul Davis [Thu, 6 Mar 2014 18:26:55 +0000 (13:26 -0500)]
use CANVAS_DEBUG_NAME instead of explicit #ifdef to set canvas item name

10 years agomake Hit (percussive note display item) actually draw something and fix up its coordi...
Paul Davis [Thu, 6 Mar 2014 18:26:36 +0000 (13:26 -0500)]
make Hit (percussive note display item) actually draw something and fix up its coordinates

10 years agowhen in smart mode, context-click on a region item should behave as if in object...
Paul Davis [Thu, 6 Mar 2014 15:40:31 +0000 (10:40 -0500)]
when in smart mode, context-click on a region item should behave as if in object mode.

Specifically, select the region before displaying the context menu

10 years agoseparate ArdourButton::set_colors() and ArdourButton::build_patterns()
Paul Davis [Thu, 6 Mar 2014 14:53:38 +0000 (09:53 -0500)]
separate ArdourButton::set_colors() and ArdourButton::build_patterns()

10 years agoadd ::on_name_changed() to ArdourButton, to use recently added ::on_name_changed...
Paul Davis [Thu, 6 Mar 2014 14:49:00 +0000 (09:49 -0500)]
add ::on_name_changed() to ArdourButton, to use recently added ::on_name_changed() in CairoWidget

10 years agoadd on_name_changed() virtual method to CairoWidget
Paul Davis [Thu, 6 Mar 2014 14:44:33 +0000 (09:44 -0500)]
add on_name_changed() virtual method to CairoWidget

If a CairoWidget does not a GtkRC-defined style, then changing its name does not trigger on_style_changed(). Since we want to use CairoWidget::set_name()
to trigger changes in the rendering of a widget, this is ... bad. Adding on_name_changed() provides a workaround for that.

10 years agoAdd ArdourButton::set_fixed_colors() (equivalent to ::set_bg_colors() in Valeriy...
Paul Davis [Thu, 6 Mar 2014 13:05:33 +0000 (08:05 -0500)]
Add ArdourButton::set_fixed_colors() (equivalent to ::set_bg_colors() in Valeriy's original changes)

10 years agorevert 29b1e706ddaeaec5a330cf6643816ec43024b545 and then redo separation of ArdourBut...
Paul Davis [Wed, 5 Mar 2014 22:51:51 +0000 (17:51 -0500)]
revert 29b1e706ddaeaec5a330cf6643816ec43024b545 and then redo separation of ArdourButton::set_colors() from ArdourButton::build_patterns.

More to come

10 years agodo not show region trim handles unless in (effective) object mouse mode
Paul Davis [Wed, 5 Mar 2014 19:33:27 +0000 (14:33 -0500)]
do not show region trim handles unless in (effective) object mouse mode

10 years agowhen an automation/region gain line is hidden, so are its points
Paul Davis [Wed, 5 Mar 2014 19:33:06 +0000 (14:33 -0500)]
when an automation/region gain line is hidden, so are its points

10 years agono dot prefix for VST cache files on windows.
Robin Gareus [Wed, 5 Mar 2014 18:44:01 +0000 (19:44 +0100)]
no dot prefix for VST cache files on windows.

10 years agomanually revert change to canvas expose handling in fee026c5ef7107d5d594159f5ece59170...
Paul Davis [Wed, 5 Mar 2014 18:12:18 +0000 (13:12 -0500)]
manually revert change to canvas expose handling in fee026c5ef7107d5d594159f5ece5917041591f7

Breaking out the rectangles implies a z-axis ordering of drawing,because the rect drawn last will implicitly be "on top".
But redraw areas are not submitted with any z-axis information, and so drawing like this breaks canvas layering. It
would be more efficient to draw the rects separately, but we don't have any ordering information and so we cannot do it
correctly.

10 years agoalter name of AutomationLine::show() to much more sensibly named ::update_visibility()
Paul Davis [Wed, 5 Mar 2014 17:11:22 +0000 (12:11 -0500)]
alter name of AutomationLine::show() to much more sensibly named ::update_visibility()

10 years agoremove debugging output
Paul Davis [Wed, 5 Mar 2014 16:47:58 +0000 (11:47 -0500)]
remove debugging output

10 years agouse a centripetal catmull-rom curve to smooth ArdourCanvas::Curve
Paul Davis [Wed, 5 Mar 2014 16:37:13 +0000 (11:37 -0500)]
use a centripetal catmull-rom curve to smooth ArdourCanvas::Curve

See http://en.wikipedia.org/wiki/Centripetal_Catmull-Rom to understand the benefits of this.

10 years agomove vst detection code into ARDOUR namespace
Robin Gareus [Wed, 5 Mar 2014 07:47:54 +0000 (08:47 +0100)]
move vst detection code into ARDOUR namespace

10 years agoclean up and document VST scanner src, add error logging to file
Robin Gareus [Wed, 5 Mar 2014 07:41:29 +0000 (08:41 +0100)]
clean up and document VST scanner src, add error logging to file

10 years ago"correct" curve drawing (no artifacts during redraw)
Paul Davis [Wed, 5 Mar 2014 02:58:07 +0000 (21:58 -0500)]
"correct" curve drawing (no artifacts during redraw)

Interpolation errors still need addressing.

10 years agotentative intermediate state for ArdourCanvas::Curve
Paul Davis [Tue, 4 Mar 2014 15:04:49 +0000 (10:04 -0500)]
tentative intermediate state for ArdourCanvas::Curve

10 years agoonly queue an item redraw from Item::show() or Item::Hide() if the call changes the...
Paul Davis [Tue, 4 Mar 2014 15:04:21 +0000 (10:04 -0500)]
only queue an item redraw from Item::show() or Item::Hide() if the call changes the visibility status of the item (i.e. make no-ops really be no-ops)

10 years agofix/adjust logic used to display automation lines
Paul Davis [Tue, 4 Mar 2014 15:03:14 +0000 (10:03 -0500)]
fix/adjust logic used to display automation lines

10 years agoreduce number of points used to define x-fade curves
Paul Davis [Tue, 4 Mar 2014 15:02:43 +0000 (10:02 -0500)]
reduce number of points used to define x-fade curves

10 years agobreak down GdkEventExpose into distinct rectangles for canvas expose rather than...
Paul Davis [Tue, 4 Mar 2014 13:15:35 +0000 (08:15 -0500)]
break down GdkEventExpose into distinct rectangles for canvas expose rather than drawing the entire region as a single rect

10 years agosome more mingw x-compile fixes
Robin Gareus [Tue, 4 Mar 2014 17:53:43 +0000 (18:53 +0100)]
some more mingw x-compile fixes

10 years agomingw build fixes (tested with i686-w64-mingw32 on linux-x86_64)
Robin Gareus [Tue, 4 Mar 2014 14:25:58 +0000 (15:25 +0100)]
mingw build fixes (tested with i686-w64-mingw32 on linux-x86_64)

10 years agoeven more small mingw/win fixes
Robin Gareus [Mon, 3 Mar 2014 17:44:30 +0000 (18:44 +0100)]
even more small mingw/win fixes

10 years agoyet another mingw/win fix
Robin Gareus [Mon, 3 Mar 2014 17:38:30 +0000 (18:38 +0100)]
yet another mingw/win fix

10 years agominor fix for libpbd wscript on windows
Paul Davis [Mon, 3 Mar 2014 15:27:06 +0000 (10:27 -0500)]
minor fix for libpbd wscript on windows

10 years agosome windows build fixes
Paul Davis [Mon, 3 Mar 2014 02:14:54 +0000 (21:14 -0500)]
some windows build fixes

10 years agosome mingw related tweaks to the build-environment.
Robin Gareus [Mon, 3 Mar 2014 15:09:14 +0000 (16:09 +0100)]
some mingw related tweaks to the build-environment.

10 years agodetect VST midi-in/midi-out ports separately.
Robin Gareus [Mon, 3 Mar 2014 12:35:09 +0000 (13:35 +0100)]
detect VST midi-in/midi-out ports separately.

10 years agopaths-dialog gtkmm-2.20 compatibility (part two)
Robin Gareus [Sun, 2 Mar 2014 21:51:04 +0000 (22:51 +0100)]
paths-dialog gtkmm-2.20 compatibility (part two)

10 years agopaths-dialog gtkmm-2.20 compatibility
Robin Gareus [Sun, 2 Mar 2014 21:38:29 +0000 (22:38 +0100)]
paths-dialog gtkmm-2.20 compatibility

10 years agoimplement VST midi-output
Robin Gareus [Sun, 2 Mar 2014 20:12:25 +0000 (21:12 +0100)]
implement VST midi-output

10 years agoremove recently added conflation of mingw64 and msvc with respect to symbol export
Paul Davis [Sun, 2 Mar 2014 19:59:08 +0000 (14:59 -0500)]
remove recently added conflation of mingw64 and msvc with respect to symbol export

10 years agofix missing const for windows vst_search_path()
Paul Davis [Sun, 2 Mar 2014 17:46:33 +0000 (12:46 -0500)]
fix missing const for windows vst_search_path()

10 years agoinstall small-splash image
Paul Davis [Sun, 2 Mar 2014 17:24:16 +0000 (12:24 -0500)]
install small-splash image

10 years agoadd missing extra file
Paul Davis [Sun, 2 Mar 2014 16:33:35 +0000 (11:33 -0500)]
add missing extra file

10 years agomove fixup_bundle_environment() code into per-platform files
Paul Davis [Sun, 2 Mar 2014 16:30:51 +0000 (11:30 -0500)]
move fixup_bundle_environment() code into per-platform files

10 years agomove export_search_path(), previously in gtk2_ardour/main.cc, into libs/pbd
Paul Davis [Sun, 2 Mar 2014 16:25:54 +0000 (11:25 -0500)]
move export_search_path(), previously in gtk2_ardour/main.cc, into libs/pbd

10 years agouse "new" VST search path code and adjust build system to reflect new source files
Paul Davis [Sun, 2 Mar 2014 15:53:25 +0000 (10:53 -0500)]
use "new" VST search path code and adjust build system to reflect new source files

10 years agoremove fallback_folders code, add simpler more focused get_vst_search_path() and...
Paul Davis [Sun, 2 Mar 2014 15:52:52 +0000 (10:52 -0500)]
remove fallback_folders code, add simpler more focused get_vst_search_path() and breakout get_win_special_folder() into its own file

10 years agofor windows build, add fallback_folders.cc to libpbd source list
Paul Davis [Sun, 2 Mar 2014 03:47:19 +0000 (22:47 -0500)]
for windows build, add fallback_folders.cc to libpbd source list

10 years agoadd likely stub code for adding linkage to libole when building libpbd on windows.
Paul Davis [Sun, 2 Mar 2014 03:44:56 +0000 (22:44 -0500)]
add likely stub code for adding linkage to libole when building libpbd on windows.

I may have gotten the precise linkflags string incorrect, but this my best guess.

10 years agoadd -DPROGRAM_NAME to libpbd compile flags
Paul Davis [Sun, 2 Mar 2014 03:43:46 +0000 (22:43 -0500)]
add -DPROGRAM_NAME to libpbd compile flags

10 years agoREALLY REALLY CORRECT template export macros for libpbd
Paul Davis [Sun, 2 Mar 2014 03:31:47 +0000 (22:31 -0500)]
REALLY REALLY CORRECT template export macros for libpbd

10 years agoREALLY CORRECT template export macros for libpbd
Paul Davis [Sat, 1 Mar 2014 23:59:44 +0000 (18:59 -0500)]
REALLY CORRECT template export macros for libpbd

10 years agouse template export forms for MemementoCommand
Paul Davis [Sat, 1 Mar 2014 23:59:37 +0000 (18:59 -0500)]
use template export forms for MemementoCommand

10 years agoCORRECT template export macros for libpbd
Paul Davis [Sat, 1 Mar 2014 23:58:41 +0000 (18:58 -0500)]
CORRECT template export macros for libpbd

10 years agoremove mingw64 special case from evoral visibility header (might be appropriate every...
Paul Davis [Sat, 1 Mar 2014 23:58:12 +0000 (18:58 -0500)]
remove mingw64 special case from evoral visibility header (might be appropriate everywhere, needs testing)

10 years agoadd template export macros for libpbd
Paul Davis [Sat, 1 Mar 2014 23:57:36 +0000 (18:57 -0500)]
add template export macros for libpbd

10 years agofix use of export macros to work with mingw(64). Template issues with msvc will requi...
Paul Davis [Sat, 1 Mar 2014 23:53:55 +0000 (18:53 -0500)]
fix use of export macros to work with mingw(64). Template issues with msvc will require a different solution (if they exist)

10 years agofix use of export macros to work with mingw(64)
Paul Davis [Sat, 1 Mar 2014 23:53:26 +0000 (18:53 -0500)]
fix use of export macros to work with mingw(64)

10 years agofix correct export macro guard in libpbd for mingw64
Paul Davis [Sat, 1 Mar 2014 23:33:31 +0000 (18:33 -0500)]
fix correct export macro guard in libpbd for mingw64

10 years agofix a related-to-last-commit problem in build script for OSC support
Paul Davis [Sat, 1 Mar 2014 21:58:22 +0000 (16:58 -0500)]
fix a related-to-last-commit problem in build script for OSC support

This would have had the effect of hiding -DPACKAGE="ardour_osc" but since there is no i18n stuff in our OSC support,
it really had no effect.

10 years agofix compilation of libcanvas so that when built as a shared lib (the default), -DLIBC...
Paul Davis [Sat, 1 Mar 2014 21:52:08 +0000 (16:52 -0500)]
fix compilation of libcanvas so that when built as a shared lib (the default), -DLIBCANVAS_DLL_EXPORTS=1 is not lost

10 years agoallow hardour to build even when --exports-hidden is used with waf configure
Paul Davis [Sat, 1 Mar 2014 21:17:58 +0000 (16:17 -0500)]
allow hardour to build even when --exports-hidden is used with waf configure

10 years agoardour now requires export visibility macros for all added classes
Paul Davis [Sat, 1 Mar 2014 21:17:33 +0000 (16:17 -0500)]
ardour now requires export visibility macros for all added classes

10 years agowhen mingw is mingw64, it appears that we need to use __declspec() and not __attribut...
Paul Davis [Sat, 1 Mar 2014 20:16:39 +0000 (15:16 -0500)]
when mingw is mingw64, it appears that we need to use __declspec() and not __attribute__((visibility)) for export control

10 years agore-work VST paths configuration.
Robin Gareus [Fri, 28 Feb 2014 23:56:24 +0000 (00:56 +0100)]
re-work VST paths configuration.

environment vars provide the "default", but are no longer
relevant once ardour-internal paths are configured.

10 years agochange code that is never used into assert()s.
Robin Gareus [Fri, 28 Feb 2014 21:28:57 +0000 (22:28 +0100)]
change code that is never used into assert()s.

plugin-scan should always happen explicitly (either on start
or by user request).

10 years agofix semantics of button press -> leave button -> button release, to match typical...
Paul Davis [Fri, 28 Feb 2014 22:17:23 +0000 (17:17 -0500)]
fix semantics of button press -> leave button -> button release, to match typical GUI toolkits

10 years agoremove debug messages, for now
Paul Davis [Fri, 28 Feb 2014 22:17:00 +0000 (17:17 -0500)]
remove debug messages, for now

10 years agochange implementation of ArdourCanvas::Curve to use GIMP-inspired ideas.
Paul Davis [Fri, 28 Feb 2014 22:00:19 +0000 (17:00 -0500)]
change implementation of ArdourCanvas::Curve to use GIMP-inspired ideas.

Presmooth with quadratic bezier, then interpolate when rendering. Not finished yet

10 years agochange latency calibration button from "record enable button" to "generic button"
Paul Davis [Fri, 28 Feb 2014 21:58:30 +0000 (16:58 -0500)]
change latency calibration button from "record enable button" to "generic button"

10 years agoadd generic button style for ArdourButtons
Paul Davis [Fri, 28 Feb 2014 21:58:05 +0000 (16:58 -0500)]
add generic button style for ArdourButtons

10 years agofix problem with splash window on OS X: requesting a redraw of a hidden window doesn...
Paul Davis [Fri, 28 Feb 2014 21:40:01 +0000 (16:40 -0500)]
fix problem with splash window on OS X: requesting a redraw of a hidden window doesn't result in an expose event being delivered.

The splash window was being hidden by default on OS X as soon as someone called Splash::pop_back_for(), because of window layering issues on OS X. But then
the next call to ::message() would not return because a recursive event loop was started that waits for the expose event, which never comes. So, (a) show the
window when ::message() is called AND (b) remove the recursive event loop because (b.1) we don't seem to need it (b.2) recursive event loops are generally evil.

10 years agoremove splash message/window at shutdown - it is just irritating and unnecessary...
Paul Davis [Fri, 28 Feb 2014 21:36:43 +0000 (16:36 -0500)]
remove splash message/window at shutdown - it is just irritating and unnecessary (or ought to be)

10 years agofix typo in doc
Robin Gareus [Fri, 28 Feb 2014 16:35:43 +0000 (17:35 +0100)]
fix typo in doc

10 years agomake custom lxvst path work..
Robin Gareus [Fri, 28 Feb 2014 16:35:26 +0000 (17:35 +0100)]
make custom lxvst path work..

10 years agochange default value for plugin scan progress window
Robin Gareus [Fri, 28 Feb 2014 16:34:57 +0000 (17:34 +0100)]
change default value for plugin scan progress window

goes with b8e4c446374

10 years agopath-dialogue: check for and disallow duplicates
Robin Gareus [Fri, 28 Feb 2014 16:32:57 +0000 (17:32 +0100)]
path-dialogue: check for and disallow duplicates

10 years agobreak out ARDOUR::PluginType
Robin Gareus [Fri, 28 Feb 2014 16:32:22 +0000 (17:32 +0100)]
break out ARDOUR::PluginType

10 years ago(backport from cairocanvas branch) do not crash when considering a directory called...
Paul Davis [Fri, 28 Feb 2014 01:37:17 +0000 (20:37 -0500)]
(backport from cairocanvas branch) do not crash when considering a directory called midi (with any case) as an apparent MIDI file

10 years agodo not crash when considering a directory called midi (with any case) as an apparent...
Paul Davis [Fri, 28 Feb 2014 01:35:23 +0000 (20:35 -0500)]
do not crash when considering a directory called midi (with any case) as an apparent MIDI file

10 years agodisplay policy of plugin-scan progress popup-window
Robin Gareus [Thu, 27 Feb 2014 22:41:48 +0000 (23:41 +0100)]
display policy of plugin-scan progress popup-window

Only show scan-progress when discovering new plugins
(discovery can be cancelled) and optionally also show
it during 'scanning index only'
(with insensitive cancel button)

10 years agomove Paths Dialog to libgtkmm2ext
Robin Gareus [Thu, 27 Feb 2014 00:35:57 +0000 (01:35 +0100)]
move Paths Dialog to libgtkmm2ext