Carl Hetherington [Mon, 12 Feb 2024 21:56:33 +0000 (22:56 +0100)]
Merge branch 'main' into v2.17.x
Carl Hetherington [Mon, 12 Feb 2024 19:53:42 +0000 (20:53 +0100)]
Fix message for high bitrate frames during verify.
Carl Hetherington [Sun, 11 Feb 2024 23:06:13 +0000 (00:06 +0100)]
Merge branch 'main' into v2.17.x
Carl Hetherington [Sun, 11 Feb 2024 19:13:04 +0000 (20:13 +0100)]
Don't add a font with an empty ID for ccaps either (#2762).
Previously this was all changed so that for subs we add the default
font in a cleaner way (in
db22f81ccce9e1a5f205e6d8b3c0631fc039a173).
I can't see why we shouldn't treat ccaps the same way, and indeed
not doing it causes an error as shown by the included test.
Carl Hetherington [Sun, 11 Feb 2024 21:58:25 +0000 (22:58 +0100)]
Supporters update.
Carl Hetherington [Sun, 11 Feb 2024 12:10:48 +0000 (13:10 +0100)]
Fix apparently ineffective processors when analysing audio (#2671).
A whole film ("DCP side") analysis would behave the same as a
single piece of content analysis if the film only had one piece
of content.
Here we also clarify that audio analysis of the whole film is different
to that for a single piece of content; for the whole film we use processors,
and for single pieces of content we do not.
Carl Hetherington [Sun, 11 Feb 2024 12:09:30 +0000 (13:09 +0100)]
Add option to stop the player using any audio processor.
Carl Hetherington [Sun, 11 Feb 2024 12:08:58 +0000 (13:08 +0100)]
Add comment about AudioDialog.
Carl Hetherington [Sun, 11 Feb 2024 13:36:33 +0000 (14:36 +0100)]
Fix totally missing saving of DKDM recipients.
Carl Hetherington [Sun, 11 Feb 2024 13:15:44 +0000 (14:15 +0100)]
Remove orphaned label.
Carl Hetherington [Sun, 11 Feb 2024 13:14:01 +0000 (14:14 +0100)]
Extend the only column in the editable email address list.
Carl Hetherington [Sat, 10 Feb 2024 22:46:07 +0000 (23:46 +0100)]
Updated sl_SI translation from Martin Srebotnjak.
Carl Hetherington [Sat, 10 Feb 2024 21:40:16 +0000 (22:40 +0100)]
Also remove now-redundant UTC offset from DKDMRecipient.
Carl Hetherington [Sat, 10 Feb 2024 15:49:35 +0000 (16:49 +0100)]
Add missing call to get_offsets().
Carl Hetherington [Fri, 9 Feb 2024 12:07:43 +0000 (13:07 +0100)]
Supporters update.
Carl Hetherington [Fri, 9 Feb 2024 01:50:09 +0000 (02:50 +0100)]
Bump libdcp to fix time/date format bug.
Carl Hetherington [Wed, 7 Feb 2024 23:36:52 +0000 (00:36 +0100)]
Fix erroneously-moved warning removal (needed for Windows).
Carl Hetherington [Tue, 6 Feb 2024 10:33:12 +0000 (11:33 +0100)]
Don't give confusing errors about WEBVTT when there are errors in a Subrip file (#2733).
Carl Hetherington [Tue, 6 Feb 2024 10:07:53 +0000 (11:07 +0100)]
Remove apparently out-of-date comment.
Carl Hetherington [Tue, 6 Feb 2024 10:02:00 +0000 (11:02 +0100)]
Remove unused header.
Carl Hetherington [Tue, 30 Jan 2024 00:27:25 +0000 (01:27 +0100)]
Simplify and improve performance of credits list.
Carl Hetherington [Tue, 30 Jan 2024 00:11:31 +0000 (01:11 +0100)]
3 columns in the about box looks better (especially on macOS).
Carl Hetherington [Mon, 5 Feb 2024 17:52:41 +0000 (18:52 +0100)]
Some new warning-disable flags are not allowed with the 2.16.x Xcode.
Carl Hetherington [Mon, 5 Feb 2024 12:11:09 +0000 (13:11 +0100)]
Add Benno Zwanenburg as a tester.
Carl Hetherington [Tue, 30 Jan 2024 13:42:35 +0000 (14:42 +0100)]
Add com.apple.security.cs.allow-unsigned-executable-memory (#2735).
Tobi pointed out that the crashing thread crashes when trying to
execute the first instruction in the page
VM_ALLOCATE
119af0000-
119af1000 [ 4K] r-x/rwx SM=PRV
which is dynamically allocated with VM_ALLOCATE (as opposed to being
a memory-mapped binary). Its protections (r-x/rwx) suggest that its
being used for JIT, so this code isn't signed, so the process
is killed by the hardened runtime.
We suspect FFmpeg is doing some JIT but perhaps only on x86_64
(as I couldn't reproduce the crash on arm64).
Carl Hetherington [Sat, 3 Feb 2024 00:20:08 +0000 (01:20 +0100)]
Make default Disk Writer window a little narrower.
Carl Hetherington [Sat, 3 Feb 2024 00:08:17 +0000 (01:08 +0100)]
Tweak labels: DCP -> DCPs.
Carl Hetherington [Fri, 2 Feb 2024 23:22:22 +0000 (00:22 +0100)]
Tweak vertical spacing of wxChoice on macOS (#2747).
Carl Hetherington [Sat, 3 Feb 2024 20:11:46 +0000 (21:11 +0100)]
Use a simpler way to decide what devices we could write to on macOS.
This basically involves the kDADiskDescriptionDeviceInternalKey,
kDADiskDescriptionMediaRemovableKey and kDADiskDescriptionMediaWritableKey
keys revealed by looking in
https://github.com/balena-io-modules/drivelist.git
Carl Hetherington [Sun, 4 Feb 2024 12:17:18 +0000 (13:17 +0100)]
Look for drives for 3 seconds on startup (#2748).
Carl Hetherington [Sun, 4 Feb 2024 12:03:45 +0000 (13:03 +0100)]
Merge branch 'main' into v2.17.x
Carl Hetherington [Sun, 4 Feb 2024 11:51:17 +0000 (12:51 +0100)]
Suppress some warnings when building with Xcode 15.
Carl Hetherington [Sun, 4 Feb 2024 11:51:06 +0000 (12:51 +0100)]
Tweak how lzma is linked.
Carl Hetherington [Sun, 4 Feb 2024 11:39:38 +0000 (12:39 +0100)]
Allow setting paths for a build with a workspace directory and a provided SDK, or the local default.
Carl Hetherington [Sun, 4 Feb 2024 11:33:36 +0000 (12:33 +0100)]
Detect arch in set_paths.sh.
Carl Hetherington [Sun, 4 Feb 2024 11:26:56 +0000 (12:26 +0100)]
Fix disk_writer startup script (I think) for mac.
Carl Hetherington [Sun, 4 Feb 2024 11:25:41 +0000 (12:25 +0100)]
Add DYLD_LIBRARY_PATH to dcpomatic_disk.
Carl Hetherington [Sun, 4 Feb 2024 11:24:57 +0000 (12:24 +0100)]
Use lldb on macOS.
Carl Hetherington [Sun, 4 Feb 2024 11:23:44 +0000 (12:23 +0100)]
Add example ASAN_OPTIONS to script.
Carl Hetherington [Sun, 4 Feb 2024 11:23:37 +0000 (12:23 +0100)]
Add DYLD_LIBRARY_PATH to run/dcpomatic
Carl Hetherington [Sun, 4 Feb 2024 11:21:06 +0000 (12:21 +0100)]
Make set_paths.sh work on x86_64 and arm64.
Carl Hetherington [Sat, 3 Feb 2024 21:13:13 +0000 (22:13 +0100)]
Merge branch 'main' into v2.17.x
Carl Hetherington [Sat, 3 Feb 2024 09:19:22 +0000 (10:19 +0100)]
Supporters update.
Carl Hetherington [Fri, 2 Feb 2024 14:42:49 +0000 (15:42 +0100)]
Remove unused variable.
Carl Hetherington [Thu, 1 Feb 2024 12:29:53 +0000 (13:29 +0100)]
Don't emit subtitle images that have a zero dimension (#2743).
They cause problems later when trying to blend them into the image.
Carl Hetherington [Thu, 1 Feb 2024 12:28:49 +0000 (13:28 +0100)]
Add an assert to check that sws_getContext() succeeded.
Carl Hetherington [Thu, 1 Feb 2024 12:28:38 +0000 (13:28 +0100)]
Add some asserts; sws_getContext() will fail if the image width or height are 0.
Carl Hetherington [Mon, 29 Jan 2024 11:43:08 +0000 (12:43 +0100)]
Support alpha blend onto YUV444P9LE and YUV444P10LE (68 and 70).
Carl Hetherington [Mon, 29 Jan 2024 11:41:48 +0000 (12:41 +0100)]
Fix incorrect pixel formats for tests.
Carl Hetherington [Mon, 29 Jan 2024 11:41:29 +0000 (12:41 +0100)]
Fix flipped red and blue with rgba64_onto_* tests.
Carl Hetherington [Mon, 29 Jan 2024 11:16:55 +0000 (12:16 +0100)]
Fix incorrect alpha channel scaling with RGBA64.
Carl Hetherington [Mon, 29 Jan 2024 10:38:39 +0000 (11:38 +0100)]
Fix incorrect alpha step used for RGBA64 sources.
Carl Hetherington [Mon, 29 Jan 2024 10:36:10 +0000 (11:36 +0100)]
Put alpha_{data,stride} into OtherYUVParams.
Carl Hetherington [Mon, 29 Jan 2024 10:31:30 +0000 (11:31 +0100)]
Separate out OtherParams into Other{RGB,YUV}Params.
Carl Hetherington [Fri, 2 Feb 2024 23:09:14 +0000 (00:09 +0100)]
OSX -> macOS
Carl Hetherington [Thu, 1 Feb 2024 11:28:39 +0000 (12:28 +0100)]
Fix error when opening the right-click content menu.
Carl Hetherington [Thu, 1 Feb 2024 00:09:04 +0000 (01:09 +0100)]
Add --enable-asan option to configure.
Carl Hetherington [Thu, 1 Feb 2024 00:03:13 +0000 (01:03 +0100)]
Add some more space for macOS preferences icons.
Carl Hetherington [Wed, 31 Jan 2024 23:58:48 +0000 (00:58 +0100)]
Tweak macOS preferences icons (#2746).
Carl Hetherington [Tue, 30 Jan 2024 09:42:52 +0000 (10:42 +0100)]
Add yet more missing DLLs to the Windows installer.
Carl Hetherington [Tue, 30 Jan 2024 18:31:13 +0000 (19:31 +0100)]
Open macOS prefs with Mac-, not Mac-P (#2745).
Carl Hetherington [Tue, 30 Jan 2024 09:22:57 +0000 (10:22 +0100)]
Another missing libpangoft2-1.0-0 to Windows installer.
Carl Hetherington [Tue, 30 Jan 2024 09:01:49 +0000 (10:01 +0100)]
Add missing libbrotlidec to Windows installer.
Carl Hetherington [Tue, 30 Jan 2024 00:32:45 +0000 (01:32 +0100)]
Add missing boost library to macOS .dmg.
Carl Hetherington [Thu, 25 Jan 2024 19:15:27 +0000 (20:15 +0100)]
Bump FFmpeg to 6.1.
Carl Hetherington [Fri, 26 Jan 2024 08:50:14 +0000 (09:50 +0100)]
Dump addr2line command before running it.
Carl Hetherington [Tue, 23 Jan 2024 23:04:31 +0000 (00:04 +0100)]
Use v2.17.x's mxe dependencies when running tests.
Carl Hetherington [Mon, 22 Jan 2024 09:14:28 +0000 (10:14 +0100)]
Remove unused variables.
Carl Hetherington [Sun, 21 Jan 2024 12:02:37 +0000 (13:02 +0100)]
Update for new wxWidgets version on macOS.
Carl Hetherington [Sat, 20 Jan 2024 01:57:30 +0000 (02:57 +0100)]
Update for new mxe.
Carl Hetherington [Wed, 3 Jan 2024 00:58:11 +0000 (01:58 +0100)]
Move audio language setting to DCP audio tab (#2682).
Carl Hetherington [Fri, 22 Dec 2023 16:02:43 +0000 (17:02 +0100)]
Remember whether Content or DCP is selected in a new ui.xml state file.
Carl Hetherington [Fri, 22 Dec 2023 16:01:09 +0000 (17:01 +0100)]
Cleanup: forward declaration sorting.
Carl Hetherington [Sat, 16 Dec 2023 19:19:18 +0000 (20:19 +0100)]
Fix time parsing in KDM CLI to be a bit more lenient.
Carl Hetherington [Wed, 22 Nov 2023 23:47:57 +0000 (00:47 +0100)]
Fix crash when there is no LD_LIBRARY_PATH
Carl Hetherington [Wed, 22 Nov 2023 23:04:57 +0000 (00:04 +0100)]
Setup grok LD_LIBRARY_PATH when required (#2657).
Carl Hetherington [Wed, 22 Nov 2023 23:04:33 +0000 (00:04 +0100)]
Cleanup: whitespace.
Carl Hetherington [Wed, 22 Nov 2023 23:04:18 +0000 (00:04 +0100)]
Add method to setup LD_LIBRARY_PATH for grok.
Carl Hetherington [Wed, 22 Nov 2023 23:04:04 +0000 (00:04 +0100)]
Give GROK its own config changed category.
Carl Hetherington [Wed, 22 Nov 2023 08:24:03 +0000 (09:24 +0100)]
Set CUDA_MODULE_LOADING=EAGER for grok (#2638).
Carl Hetherington [Sun, 14 May 2023 22:03:44 +0000 (00:03 +0200)]
Remove reference checkboxes from video/audio/text tabs.
Carl Hetherington [Sun, 14 May 2023 21:42:27 +0000 (23:42 +0200)]
Add Version File dialog.
Carl Hetherington [Sun, 14 May 2023 21:42:11 +0000 (23:42 +0200)]
Add set().
Carl Hetherington [Sun, 14 May 2023 21:08:37 +0000 (23:08 +0200)]
Make can_reference_anything public.
Carl Hetherington [Sun, 14 May 2023 21:04:32 +0000 (23:04 +0200)]
Rename can_reference -> can_reference_anything.
Carl Hetherington [Sun, 14 May 2023 21:01:34 +0000 (23:01 +0200)]
Cleanup: rearrange how overlap checking is done in can_reference().
Carl Hetherington [Sun, 14 May 2023 21:01:06 +0000 (23:01 +0200)]
Put overlaps() into the dcpomatic namespace.
Carl Hetherington [Wed, 18 Oct 2023 20:59:30 +0000 (22:59 +0200)]
Fix missing grok log setup in dcpomatic_cli.
Carl Hetherington [Wed, 18 Oct 2023 20:59:19 +0000 (22:59 +0200)]
Swap a log for a more informative one.
Carl Hetherington [Sun, 8 Oct 2023 13:48:58 +0000 (15:48 +0200)]
Make stop() private and use drop() instead.
This avoids confusing situations where we call stop(), then try
to restart the finder (unsuccessfully, because once it's stop()ped
it will stay around, never to be restarted).
Carl Hetherington [Fri, 6 Oct 2023 20:42:44 +0000 (22:42 +0200)]
Clean up grok's presence in the config file and make sure it's optional.
It should be allowed to not have any grok stuff in the config file,
and we should generally call it grok rather than GPU in case
other non-grok GPU stuff arrives in the future.
Carl Hetherington [Fri, 6 Oct 2023 20:42:15 +0000 (22:42 +0200)]
Remove a directory created by the config machinery to avoid confusion.
Carl Hetherington [Fri, 6 Oct 2023 19:38:50 +0000 (21:38 +0200)]
Add another manual dependency.
Carl Hetherington [Fri, 6 Oct 2023 19:27:39 +0000 (21:27 +0200)]
Cleanup: whitespace / coding style.
Carl Hetherington [Wed, 4 Oct 2023 17:51:54 +0000 (19:51 +0200)]
Cleanup: whitespace to reduce the diff.
Carl Hetherington [Wed, 4 Oct 2023 17:51:45 +0000 (19:51 +0200)]
Cleanup: include ordering.
Carl Hetherington [Wed, 4 Oct 2023 17:47:32 +0000 (19:47 +0200)]
Don't pollute the global namespace with a namespace called fs.
Carl Hetherington [Wed, 4 Oct 2023 17:11:45 +0000 (19:11 +0200)]
Another patch from Aaron.
Carl Hetherington [Tue, 26 Sep 2023 18:59:39 +0000 (20:59 +0200)]
Cleanup: coding style.
Carl Hetherington [Tue, 26 Sep 2023 18:56:19 +0000 (20:56 +0200)]
Looks like we also need an explicit dep on messenger.h