Carl Hetherington [Wed, 4 Oct 2023 17:47:32 +0000 (19:47 +0200)]
Don't pollute the global namespace with a namespace called fs.
Carl Hetherington [Wed, 4 Oct 2023 17:11:45 +0000 (19:11 +0200)]
Another patch from Aaron.
Carl Hetherington [Tue, 26 Sep 2023 18:59:39 +0000 (20:59 +0200)]
Cleanup: coding style.
Carl Hetherington [Tue, 26 Sep 2023 18:56:19 +0000 (20:56 +0200)]
Looks like we also need an explicit dep on messenger.h
Carl Hetherington [Tue, 26 Sep 2023 18:53:43 +0000 (20:53 +0200)]
Cleanup: coding style.
Carl Hetherington [Tue, 26 Sep 2023 18:46:08 +0000 (20:46 +0200)]
Hack to make sure the right things are rebuilt when grok headers change.
Carl Hetherington [Tue, 26 Sep 2023 11:32:00 +0000 (13:32 +0200)]
Forward-declare grk_plugin stuff.
Carl Hetherington [Tue, 26 Sep 2023 11:29:59 +0000 (13:29 +0200)]
Create a single DcpomaticContext for all GrokContexts, rather than copying them.
I think this makes sense, and also allows us to forward-declare the
contexts in a forthcoming commit.
Carl Hetherington [Tue, 26 Sep 2023 11:11:36 +0000 (13:11 +0200)]
Cleanup: reformat and rename dcpomaticContext_ -> _dcpomatic_context
Carl Hetherington [Tue, 26 Sep 2023 11:00:16 +0000 (13:00 +0200)]
Cleanup: sorting.
Carl Hetherington [Sun, 24 Sep 2023 15:26:31 +0000 (17:26 +0200)]
Use GPU not Gpu for config element names.
Carl Hetherington [Sun, 24 Sep 2023 15:23:57 +0000 (17:23 +0200)]
Use boost::filesystem::path for gpu_binary_location().
Carl Hetherington [Sun, 24 Sep 2023 15:04:34 +0000 (17:04 +0200)]
Cleanup: use dcp::ArrayData instead of home-grown version.
Carl Hetherington [Sun, 24 Sep 2023 15:04:21 +0000 (17:04 +0200)]
Cleanup: remove unnecessary forward declaration.
Carl Hetherington [Sun, 24 Sep 2023 14:54:11 +0000 (16:54 +0200)]
Add missing copyright banner.
Carl Hetherington [Sun, 24 Sep 2023 14:44:27 +0000 (16:44 +0200)]
Remove C++17-ism.
Carl Hetherington [Sun, 24 Sep 2023 14:41:57 +0000 (16:41 +0200)]
Copy-edit GUI strings.
Carl Hetherington [Sun, 24 Sep 2023 14:39:27 +0000 (16:39 +0200)]
Check for errors when calling the GPU lister.
Carl Hetherington [Sun, 24 Sep 2023 11:13:40 +0000 (13:13 +0200)]
Hide compiler warning.
In file included from ../src/lib/grok/context.h:29,
from ../src/lib/j2k_encoder.h:36,
from ../src/lib/grok_j2k_encoder_thread.cc:5:
In member function ‘void grk_plugin::Synch::unlink()’,
inlined from ‘grk_plugin::Synch::Synch(const string&, const string&)’ at ../src/lib/grok/messenger.h:200:10:
../src/lib/grok/messenger.h:247:52: error: ‘this’ pointer is null [-Werror=nonnull]
247 | getMessengerLogger()->error("Error unlinking semaphore %s: %s", sentSemName_.c_str(),
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
248 | strerror(errno));
on Ubuntu 22.04.
Carl Hetherington [Sun, 24 Sep 2023 10:09:16 +0000 (12:09 +0200)]
Only build grok for Ubuntu 22.04.
Carl Hetherington [Sun, 24 Sep 2023 10:02:19 +0000 (12:02 +0200)]
Explicitly set up Grok logger rather than relying on a static variable.
Carl Hetherington [Sun, 24 Sep 2023 10:01:54 +0000 (12:01 +0200)]
Remove unnecessary using statements.
Carl Hetherington [Sat, 23 Sep 2023 22:34:15 +0000 (00:34 +0200)]
Rearrange encoder threading.
Soon we'll add a new encoder type, and the existing structure was
already creaking a bit at the seams while handling local and remote
encodes. Here we split out an encoder thread and introduce the concept
of a "sync" thread (which blocks while the encoding is happening).
Later we'll have another type which submits the encode request to a
GPU and receives the reply back later.
Carl Hetherington [Sun, 10 Sep 2023 21:46:19 +0000 (23:46 +0200)]
Remove check for _threads being null, as I think it should not happen.
Carl Hetherington [Sun, 10 Sep 2023 21:45:56 +0000 (23:45 +0200)]
Cleanup: white space.
Carl Hetherington [Sun, 3 Sep 2023 22:58:19 +0000 (00:58 +0200)]
Further patch from Aaron.
Carl Hetherington [Sun, 9 Jul 2023 21:25:36 +0000 (23:25 +0200)]
Tidy up some includes / forward declarations.
Carl Hetherington [Sun, 9 Jul 2023 21:22:20 +0000 (23:22 +0200)]
Cleanup: white space tidying.
Carl Hetherington [Sun, 9 Jul 2023 21:18:40 +0000 (23:18 +0200)]
Change end() to only do one thing, and copy the required stuff into pause()
Carl Hetherington [Fri, 7 Jul 2023 23:13:04 +0000 (01:13 +0200)]
Remove default constructor from DCPVideo.
Carl Hetherington [Fri, 7 Jul 2023 22:20:15 +0000 (00:20 +0200)]
Formatting, variable name tidying and some const correctness.
Carl Hetherington [Fri, 7 Jul 2023 21:42:08 +0000 (23:42 +0200)]
Move grok headers into src/wx/grok
Carl Hetherington [Fri, 7 Jul 2023 21:24:45 +0000 (23:24 +0200)]
Move grok headers into src/lib/grok
Carl Hetherington [Thu, 6 Jul 2023 21:09:08 +0000 (23:09 +0200)]
Patch from Aaron Boxer adding initial support for GPU-powered J2K encoding via his tool "grok".
Carl Hetherington [Fri, 15 Sep 2023 15:20:22 +0000 (17:20 +0200)]
Bump ffmpeg to get some fixes that were on dcpomatic-14 but not dcpomatic-16.
Carl Hetherington [Thu, 1 Dec 2022 21:30:58 +0000 (22:30 +0100)]
Move UTC offset for KDMs from the cinema to the point of KDM creation (#2300).
Carl Hetherington [Thu, 29 Sep 2022 08:17:50 +0000 (10:17 +0200)]
Change how video timing is done.
This commit changes the approach with video timing. Previously,
we would (more-or-less) try to use every video frame from the content
in the output, hoping that they come at a constant frame rate.
This is not always the case, however. Here we preserve the PTS
of video frames, and then when one arrives we output whatever
DCP video frames we can (at the regular DCP frame rate).
Hopefully this will solve a range of sync problems, but it
could also introduce new ones.
Carl Hetherington [Wed, 28 Sep 2022 23:03:43 +0000 (01:03 +0200)]
Add operator* for Time and int.
Carl Hetherington [Wed, 28 Sep 2022 21:59:06 +0000 (23:59 +0200)]
Write player debug logs from tests on -- --log=debug-player
Carl Hetherington [Sun, 2 Oct 2022 19:55:55 +0000 (21:55 +0200)]
Cleanup: fix name of film to match test.
Carl Hetherington [Sat, 1 Oct 2022 10:05:33 +0000 (12:05 +0200)]
Fix FFmpegExaminer termination condition when there is no video;
it's hard to see how this ever worked.
Carl Hetherington [Fri, 30 Sep 2022 20:46:33 +0000 (22:46 +0200)]
Bump ffmpeg to 5.1.2 "Riemann"
Carl Hetherington [Sat, 10 Sep 2022 22:10:22 +0000 (00:10 +0200)]
Normalise XML attribute names to be camelCase (#2241).
Carl Hetherington [Mon, 26 Sep 2022 18:20:16 +0000 (20:20 +0200)]
Use 2.18.x subdirectory for configuration.
Carl Hetherington [Sat, 27 Jan 2024 23:30:00 +0000 (00:30 +0100)]
Supporters update.
Carl Hetherington [Fri, 26 Jan 2024 22:46:57 +0000 (23:46 +0100)]
Fix assertion on trying to select a file (#2737).
Carl Hetherington [Tue, 23 Jan 2024 20:04:41 +0000 (21:04 +0100)]
Add supporters.
Carl Hetherington [Sun, 21 Jan 2024 01:23:58 +0000 (02:23 +0100)]
Remove unused variables.
Carl Hetherington [Sat, 20 Jan 2024 15:50:38 +0000 (16:50 +0100)]
Explicitly link zlib to keep new macOS environment happy.
Carl Hetherington [Sat, 20 Jan 2024 15:20:50 +0000 (16:20 +0100)]
Build fix for HAVE_AVSUBTITLERECT_PICT case.
Carl Hetherington [Sat, 20 Jan 2024 14:50:33 +0000 (15:50 +0100)]
Remove unused variable.
Carl Hetherington [Thu, 18 Jan 2024 09:05:31 +0000 (10:05 +0100)]
macOS build fix.
Carl Hetherington [Wed, 17 Jan 2024 23:58:51 +0000 (00:58 +0100)]
Allow specification of KDM annotation text (#296).
Carl Hetherington [Wed, 17 Jan 2024 23:05:28 +0000 (00:05 +0100)]
Tweak layout.
Carl Hetherington [Wed, 17 Jan 2024 22:46:26 +0000 (23:46 +0100)]
Fix ISDCF name when referring to OVs with subs (#2703).
Carl Hetherington [Wed, 17 Jan 2024 22:41:23 +0000 (23:41 +0100)]
Move burnt subtitle checks into ::subtitle_languages().
Carl Hetherington [Wed, 17 Jan 2024 22:34:08 +0000 (23:34 +0100)]
Cleanup: forward declaration sorting.
Carl Hetherington [Tue, 16 Jan 2024 21:00:29 +0000 (22:00 +0100)]
Bump libsub for Arch build fix (#2731).
Carl Hetherington [Tue, 16 Jan 2024 00:44:49 +0000 (01:44 +0100)]
Remember some more paths when selecting files (#2728).
* export subtitles
* export video
* debug log
* cinema database
* config file
Carl Hetherington [Tue, 16 Jan 2024 20:28:37 +0000 (21:28 +0100)]
Cleanup: remove some make_wx<> that aren't needed.
Carl Hetherington [Mon, 15 Jan 2024 23:47:39 +0000 (00:47 +0100)]
Add some comments.
Carl Hetherington [Mon, 15 Jan 2024 23:33:05 +0000 (00:33 +0100)]
Cleanup: rename some methods in FilePickerCtrl and use boost::filesystem::path more.
Carl Hetherington [Tue, 16 Jan 2024 15:50:23 +0000 (16:50 +0100)]
Missing include.
Carl Hetherington [Fri, 12 Jan 2024 14:29:12 +0000 (15:29 +0100)]
Inspect most DCPs made during tests with ClairMeta (#76).
Carl Hetherington [Thu, 11 Jan 2024 15:24:38 +0000 (16:24 +0100)]
Inspect most DCPs made during tests with dcp_inspect (#76).
Carl Hetherington [Mon, 15 Jan 2024 09:25:14 +0000 (10:25 +0100)]
Missing PRIVATE_GIT update from previous.
Carl Hetherington [Sat, 13 Jan 2024 22:34:35 +0000 (23:34 +0100)]
Fix handling of empty font IDs and default DCP fonts (#2721) (part of #2722).
Previously we used an empty font ID as the default for when a subtitle
has no Font, but in #2721 we saw a DCP with an empty font ID which
raised an assertion (because we'd already added our default font with
the empty ID).
Here we try to fix this (and also make the default font correctly be
that from the first <LoadFont>).
Carl Hetherington [Sun, 14 Jan 2024 23:48:43 +0000 (00:48 +0100)]
Increase timeout before pulsing the progress bar for a job.
Carl Hetherington [Sat, 13 Jan 2024 20:52:27 +0000 (21:52 +0100)]
Add an assert.
Carl Hetherington [Sat, 13 Jan 2024 00:01:09 +0000 (01:01 +0100)]
Show hashes when they disagree during verification (#2717).
Carl Hetherington [Fri, 12 Jan 2024 23:13:17 +0000 (00:13 +0100)]
Updated nl_NL translation from Rob van Nieuwkerk.
Carl Hetherington [Fri, 1 Dec 2023 20:25:54 +0000 (21:25 +0100)]
Fix scaling of bitmap subs when the corresponding video is cropped (#2670).
Previously we would scale the bitmap size/position to a proportion
of the original video frame, then scale it back up again to the DCP
container. This didn't take into account some cropped cases where
the picture would end up the same shape but the subtitles would be
stretched.
Carl Hetherington [Thu, 11 Jan 2024 23:55:10 +0000 (00:55 +0100)]
pot/merge.
Carl Hetherington [Thu, 11 Jan 2024 21:51:23 +0000 (22:51 +0100)]
Fix markers view for RTL languages (part of #2696).
Carl Hetherington [Thu, 11 Jan 2024 21:51:00 +0000 (22:51 +0100)]
Fix "add" markers submenu for the last couple of markers.
Carl Hetherington [Thu, 11 Jan 2024 21:50:29 +0000 (22:50 +0100)]
Attempt to rationalise menu IDs and avoid duplicates.
Carl Hetherington [Thu, 11 Jan 2024 21:49:32 +0000 (22:49 +0100)]
Cleanup: using/include sorting.
Carl Hetherington [Thu, 11 Jan 2024 20:02:11 +0000 (21:02 +0100)]
Fix timecode order in RTL languages (part of #2696).
Carl Hetherington [Thu, 11 Jan 2024 19:37:57 +0000 (20:37 +0100)]
Supporters update.
Carl Hetherington [Thu, 11 Jan 2024 19:24:21 +0000 (20:24 +0100)]
Updated fa_IR translation from Soleyman Rahmani.
Carl Hetherington [Thu, 11 Jan 2024 16:08:05 +0000 (17:08 +0100)]
Carl Hetherington [Thu, 11 Jan 2024 11:04:48 +0000 (12:04 +0100)]
Carl Hetherington [Thu, 11 Jan 2024 10:28:24 +0000 (11:28 +0100)]
Reduce minimum "non-standard" ISDCF part name length to 1.
Otherwise on macOS (at least) you can't type in any numbers, seemingly because
it checks on each keypress so e.g. you clear it, enter 1 and a bell rings because
1 is too small. It's fine on Linux (a too-small number is corrected when you
press enter).
Carl Hetherington [Wed, 10 Jan 2024 22:49:18 +0000 (23:49 +0100)]
Fix crash when changing ISDCF name part length (#2690).
Carl Hetherington [Wed, 10 Jan 2024 16:47:32 +0000 (17:47 +0100)]
Mark a VF as having assets, even if they are unresolved (#1024).
This allows them to be displayed in the timeline, hopefully without
any unwanted side-effects.
Carl Hetherington [Tue, 9 Jan 2024 12:02:09 +0000 (13:02 +0100)]
Re-make video after YUV/RGB matrix is changed (#2714).
Carl Hetherington [Tue, 9 Jan 2024 12:01:50 +0000 (13:01 +0100)]
Cleanup: white space.
Carl Hetherington [Mon, 8 Jan 2024 18:01:21 +0000 (19:01 +0100)]
Check for bad DN qualifiers on signer certificates (#2716).
Carl Hetherington [Mon, 8 Jan 2024 15:25:42 +0000 (16:25 +0100)]
Move ScopeGuard into libdcp.
Carl Hetherington [Sun, 7 Jan 2024 23:51:45 +0000 (00:51 +0100)]
Updated fa_IR translation from Soleyman Rahmani.
Carl Hetherington [Fri, 5 Jan 2024 00:38:50 +0000 (01:38 +0100)]
Cleanup: remove unused method.
Carl Hetherington [Thu, 4 Jan 2024 22:58:56 +0000 (23:58 +0100)]
Don't use video streams with AV_DISPOSITION_ATTACHED_PIC (#2349).
These are seen in MP3 files for cover art.
Carl Hetherington [Fri, 5 Jan 2024 00:28:19 +0000 (01:28 +0100)]
Add new "territory type" so that INT-T{D,L} can be chosen (#2704).
Carl Hetherington [Fri, 5 Jan 2024 00:26:58 +0000 (01:26 +0100)]
Add Choice::set_by_data().
Carl Hetherington [Fri, 5 Jan 2024 00:52:47 +0000 (01:52 +0100)]
Remove out-of-date patrons.
Carl Hetherington [Thu, 4 Jan 2024 22:56:04 +0000 (23:56 +0100)]
Cleanup: longer variable name.
Carl Hetherington [Thu, 4 Jan 2024 22:37:15 +0000 (23:37 +0100)]
Merge branch '2694-remove-odd-check'
Allow referring to OVs where not every reel has a subtitle/ccap,
fixing it if required by adding our own reels.
Carl Hetherington [Thu, 28 Dec 2023 23:06:54 +0000 (00:06 +0100)]
Add a test.
Carl Hetherington [Wed, 3 Jan 2024 23:40:03 +0000 (00:40 +0100)]
Add dummy subtitle and closed caption reels even when referencing
other DCPs (in a VF) that themselves might have missing subtitles
for some reels.
Carl Hetherington [Fri, 29 Dec 2023 00:31:47 +0000 (01:31 +0100)]
Fix libdcp to not crash in some VF verification situations.