Carl Hetherington [Mon, 26 Feb 2024 22:18:15 +0000 (23:18 +0100)]
Disallow referring to OV audio unless channel counts match (#2780).
Carl Hetherington [Wed, 21 Feb 2024 09:47:38 +0000 (10:47 +0100)]
Make DCPExaminer::size() optional and deal with the consequences.
This means we can fix the case of a VF having no known size in a nice way,
in turn fixing problems caused by the fix to #2775.
Carl Hetherington [Wed, 21 Feb 2024 00:10:23 +0000 (01:10 +0100)]
Fix failure to examine non-flat-ratio VFs (#2775).
Carl Hetherington [Tue, 20 Feb 2024 13:37:58 +0000 (14:37 +0100)]
Fix build on Centos 7.
Carl Hetherington [Mon, 19 Feb 2024 21:29:53 +0000 (22:29 +0100)]
Supporters update.
Carl Hetherington [Mon, 19 Feb 2024 13:45:38 +0000 (14:45 +0100)]
Supporters update.
Carl Hetherington [Mon, 19 Feb 2024 13:41:49 +0000 (14:41 +0100)]
Fix various preview errors on high-DPI screens (#2774).
The logical scale was previously not taken into account so the outline
rectangle was wrong and the padding was usually missing.
Carl Hetherington [Mon, 19 Feb 2024 13:40:02 +0000 (14:40 +0100)]
Cleanup: use a dcp::Size instead of a wxSize.
Carl Hetherington [Sat, 17 Feb 2024 23:37:47 +0000 (00:37 +0100)]
Fix note about branch handling.
Carl Hetherington [Sat, 17 Feb 2024 23:32:37 +0000 (00:32 +0100)]
Add film duration to --dump output (#1702).
Carl Hetherington [Sat, 17 Feb 2024 23:32:13 +0000 (00:32 +0100)]
Avoid quotation marks around dumped paths.
Carl Hetherington [Thu, 15 Feb 2024 00:05:22 +0000 (01:05 +0100)]
Add option to load prefs from ZIP (#2771).
Carl Hetherington [Sat, 17 Feb 2024 22:45:23 +0000 (23:45 +0100)]
Use FileDialog for saving preferences ZIPs.
Carl Hetherington [Sat, 17 Feb 2024 22:44:55 +0000 (23:44 +0100)]
Cleanup: 0 -> nullptr.
Carl Hetherington [Fri, 16 Feb 2024 22:46:27 +0000 (23:46 +0100)]
Return empty optional rather than asserting.
Carl Hetherington [Thu, 15 Feb 2024 00:05:17 +0000 (01:05 +0100)]
Cleanup: add missing explicit.
Carl Hetherington [Thu, 15 Feb 2024 00:05:12 +0000 (01:05 +0100)]
Add Unzipper.
Carl Hetherington [Thu, 15 Feb 2024 23:36:03 +0000 (00:36 +0100)]
Supporters update.
Carl Hetherington [Thu, 15 Feb 2024 00:06:16 +0000 (01:06 +0100)]
Supporters update.
Carl Hetherington [Wed, 14 Feb 2024 22:52:29 +0000 (23:52 +0100)]
Bump libdcp for fix to error about unknown asset type.
Carl Hetherington [Wed, 14 Feb 2024 22:03:24 +0000 (23:03 +0100)]
Fix conversion of _X to underlined X with GTK (via gtk_label_set_text_with_mnemonic, I think).
Carl Hetherington [Wed, 14 Feb 2024 22:02:53 +0000 (23:02 +0100)]
Cleanup: white space.
Carl Hetherington [Wed, 14 Feb 2024 22:02:48 +0000 (23:02 +0100)]
Cope with loading a film containing a missing DCP which itself contains subtitles.
Carl Hetherington [Wed, 14 Feb 2024 21:42:35 +0000 (22:42 +0100)]
Fix exception when calling resume() without first calling suspend().
Carl Hetherington [Mon, 12 Feb 2024 19:53:42 +0000 (20:53 +0100)]
Fix message for high bitrate frames during verify.
Carl Hetherington [Sun, 11 Feb 2024 19:13:04 +0000 (20:13 +0100)]
Don't add a font with an empty ID for ccaps either (#2762).
Previously this was all changed so that for subs we add the default
font in a cleaner way (in
db22f81ccce9e1a5f205e6d8b3c0631fc039a173).
I can't see why we shouldn't treat ccaps the same way, and indeed
not doing it causes an error as shown by the included test.
Carl Hetherington [Sun, 11 Feb 2024 21:58:25 +0000 (22:58 +0100)]
Supporters update.
Carl Hetherington [Sun, 11 Feb 2024 12:10:48 +0000 (13:10 +0100)]
Fix apparently ineffective processors when analysing audio (#2671).
A whole film ("DCP side") analysis would behave the same as a
single piece of content analysis if the film only had one piece
of content.
Here we also clarify that audio analysis of the whole film is different
to that for a single piece of content; for the whole film we use processors,
and for single pieces of content we do not.
Carl Hetherington [Sun, 11 Feb 2024 12:09:30 +0000 (13:09 +0100)]
Add option to stop the player using any audio processor.
Carl Hetherington [Sun, 11 Feb 2024 12:08:58 +0000 (13:08 +0100)]
Add comment about AudioDialog.
Carl Hetherington [Sun, 11 Feb 2024 13:36:33 +0000 (14:36 +0100)]
Fix totally missing saving of DKDM recipients.
Carl Hetherington [Sun, 11 Feb 2024 13:15:44 +0000 (14:15 +0100)]
Remove orphaned label.
Carl Hetherington [Sun, 11 Feb 2024 13:14:01 +0000 (14:14 +0100)]
Extend the only column in the editable email address list.
Carl Hetherington [Sat, 10 Feb 2024 22:46:07 +0000 (23:46 +0100)]
Updated sl_SI translation from Martin Srebotnjak.
Carl Hetherington [Fri, 9 Feb 2024 12:07:43 +0000 (13:07 +0100)]
Supporters update.
Carl Hetherington [Fri, 9 Feb 2024 01:50:09 +0000 (02:50 +0100)]
Bump libdcp to fix time/date format bug.
Carl Hetherington [Wed, 7 Feb 2024 23:36:52 +0000 (00:36 +0100)]
Fix erroneously-moved warning removal (needed for Windows).
Carl Hetherington [Tue, 6 Feb 2024 10:33:12 +0000 (11:33 +0100)]
Don't give confusing errors about WEBVTT when there are errors in a Subrip file (#2733).
Carl Hetherington [Tue, 6 Feb 2024 10:07:53 +0000 (11:07 +0100)]
Remove apparently out-of-date comment.
Carl Hetherington [Tue, 6 Feb 2024 10:02:00 +0000 (11:02 +0100)]
Remove unused header.
Carl Hetherington [Tue, 30 Jan 2024 00:27:25 +0000 (01:27 +0100)]
Simplify and improve performance of credits list.
Carl Hetherington [Tue, 30 Jan 2024 00:11:31 +0000 (01:11 +0100)]
3 columns in the about box looks better (especially on macOS).
Carl Hetherington [Mon, 5 Feb 2024 17:52:41 +0000 (18:52 +0100)]
Some new warning-disable flags are not allowed with the 2.16.x Xcode.
Carl Hetherington [Mon, 5 Feb 2024 12:11:09 +0000 (13:11 +0100)]
Add Benno Zwanenburg as a tester.
Carl Hetherington [Tue, 30 Jan 2024 13:42:35 +0000 (14:42 +0100)]
Add com.apple.security.cs.allow-unsigned-executable-memory (#2735).
Tobi pointed out that the crashing thread crashes when trying to
execute the first instruction in the page
VM_ALLOCATE
119af0000-
119af1000 [ 4K] r-x/rwx SM=PRV
which is dynamically allocated with VM_ALLOCATE (as opposed to being
a memory-mapped binary). Its protections (r-x/rwx) suggest that its
being used for JIT, so this code isn't signed, so the process
is killed by the hardened runtime.
We suspect FFmpeg is doing some JIT but perhaps only on x86_64
(as I couldn't reproduce the crash on arm64).
Carl Hetherington [Sun, 4 Feb 2024 11:51:17 +0000 (12:51 +0100)]
Suppress some warnings when building with Xcode 15.
Carl Hetherington [Sun, 4 Feb 2024 11:51:06 +0000 (12:51 +0100)]
Tweak how lzma is linked.
Carl Hetherington [Sun, 4 Feb 2024 11:39:38 +0000 (12:39 +0100)]
Allow setting paths for a build with a workspace directory and a provided SDK, or the local default.
Carl Hetherington [Sun, 4 Feb 2024 11:33:36 +0000 (12:33 +0100)]
Detect arch in set_paths.sh.
Carl Hetherington [Sun, 4 Feb 2024 11:26:56 +0000 (12:26 +0100)]
Fix disk_writer startup script (I think) for mac.
Carl Hetherington [Sun, 4 Feb 2024 11:25:41 +0000 (12:25 +0100)]
Add DYLD_LIBRARY_PATH to dcpomatic_disk.
Carl Hetherington [Sun, 4 Feb 2024 11:24:57 +0000 (12:24 +0100)]
Use lldb on macOS.
Carl Hetherington [Sun, 4 Feb 2024 11:23:44 +0000 (12:23 +0100)]
Add example ASAN_OPTIONS to script.
Carl Hetherington [Sun, 4 Feb 2024 11:23:37 +0000 (12:23 +0100)]
Add DYLD_LIBRARY_PATH to run/dcpomatic
Carl Hetherington [Sun, 4 Feb 2024 11:21:06 +0000 (12:21 +0100)]
Make set_paths.sh work on x86_64 and arm64.
Carl Hetherington [Sat, 3 Feb 2024 09:19:22 +0000 (10:19 +0100)]
Supporters update.
Carl Hetherington [Fri, 2 Feb 2024 14:42:49 +0000 (15:42 +0100)]
Remove unused variable.
Carl Hetherington [Thu, 1 Feb 2024 12:29:53 +0000 (13:29 +0100)]
Don't emit subtitle images that have a zero dimension (#2743).
They cause problems later when trying to blend them into the image.
Carl Hetherington [Thu, 1 Feb 2024 12:28:49 +0000 (13:28 +0100)]
Add an assert to check that sws_getContext() succeeded.
Carl Hetherington [Thu, 1 Feb 2024 12:28:38 +0000 (13:28 +0100)]
Add some asserts; sws_getContext() will fail if the image width or height are 0.
Carl Hetherington [Mon, 29 Jan 2024 11:43:08 +0000 (12:43 +0100)]
Support alpha blend onto YUV444P9LE and YUV444P10LE (68 and 70).
Carl Hetherington [Mon, 29 Jan 2024 11:41:48 +0000 (12:41 +0100)]
Fix incorrect pixel formats for tests.
Carl Hetherington [Mon, 29 Jan 2024 11:41:29 +0000 (12:41 +0100)]
Fix flipped red and blue with rgba64_onto_* tests.
Carl Hetherington [Mon, 29 Jan 2024 11:16:55 +0000 (12:16 +0100)]
Fix incorrect alpha channel scaling with RGBA64.
Carl Hetherington [Mon, 29 Jan 2024 10:38:39 +0000 (11:38 +0100)]
Fix incorrect alpha step used for RGBA64 sources.
Carl Hetherington [Mon, 29 Jan 2024 10:36:10 +0000 (11:36 +0100)]
Put alpha_{data,stride} into OtherYUVParams.
Carl Hetherington [Mon, 29 Jan 2024 10:31:30 +0000 (11:31 +0100)]
Separate out OtherParams into Other{RGB,YUV}Params.
Carl Hetherington [Fri, 2 Feb 2024 23:09:14 +0000 (00:09 +0100)]
OSX -> macOS
Carl Hetherington [Thu, 1 Feb 2024 11:28:39 +0000 (12:28 +0100)]
Fix error when opening the right-click content menu.
Carl Hetherington [Thu, 1 Feb 2024 00:09:04 +0000 (01:09 +0100)]
Add --enable-asan option to configure.
Carl Hetherington [Thu, 1 Feb 2024 00:03:13 +0000 (01:03 +0100)]
Add some more space for macOS preferences icons.
Carl Hetherington [Wed, 31 Jan 2024 23:58:48 +0000 (00:58 +0100)]
Tweak macOS preferences icons (#2746).
Carl Hetherington [Tue, 30 Jan 2024 18:31:13 +0000 (19:31 +0100)]
Open macOS prefs with Mac-, not Mac-P (#2745).
Carl Hetherington [Sat, 27 Jan 2024 23:30:00 +0000 (00:30 +0100)]
Supporters update.
Carl Hetherington [Fri, 26 Jan 2024 22:46:57 +0000 (23:46 +0100)]
Fix assertion on trying to select a file (#2737).
Carl Hetherington [Tue, 23 Jan 2024 20:04:41 +0000 (21:04 +0100)]
Add supporters.
Carl Hetherington [Sun, 21 Jan 2024 01:23:58 +0000 (02:23 +0100)]
Remove unused variables.
Carl Hetherington [Sat, 20 Jan 2024 15:50:38 +0000 (16:50 +0100)]
Explicitly link zlib to keep new macOS environment happy.
Carl Hetherington [Sat, 20 Jan 2024 15:20:50 +0000 (16:20 +0100)]
Build fix for HAVE_AVSUBTITLERECT_PICT case.
Carl Hetherington [Sat, 20 Jan 2024 14:50:33 +0000 (15:50 +0100)]
Remove unused variable.
Carl Hetherington [Thu, 18 Jan 2024 09:05:31 +0000 (10:05 +0100)]
macOS build fix.
Carl Hetherington [Wed, 17 Jan 2024 23:58:51 +0000 (00:58 +0100)]
Allow specification of KDM annotation text (#296).
Carl Hetherington [Wed, 17 Jan 2024 23:05:28 +0000 (00:05 +0100)]
Tweak layout.
Carl Hetherington [Wed, 17 Jan 2024 22:46:26 +0000 (23:46 +0100)]
Fix ISDCF name when referring to OVs with subs (#2703).
Carl Hetherington [Wed, 17 Jan 2024 22:41:23 +0000 (23:41 +0100)]
Move burnt subtitle checks into ::subtitle_languages().
Carl Hetherington [Wed, 17 Jan 2024 22:34:08 +0000 (23:34 +0100)]
Cleanup: forward declaration sorting.
Carl Hetherington [Tue, 16 Jan 2024 21:00:29 +0000 (22:00 +0100)]
Bump libsub for Arch build fix (#2731).
Carl Hetherington [Tue, 16 Jan 2024 00:44:49 +0000 (01:44 +0100)]
Remember some more paths when selecting files (#2728).
* export subtitles
* export video
* debug log
* cinema database
* config file
Carl Hetherington [Tue, 16 Jan 2024 20:28:37 +0000 (21:28 +0100)]
Cleanup: remove some make_wx<> that aren't needed.
Carl Hetherington [Mon, 15 Jan 2024 23:47:39 +0000 (00:47 +0100)]
Add some comments.
Carl Hetherington [Mon, 15 Jan 2024 23:33:05 +0000 (00:33 +0100)]
Cleanup: rename some methods in FilePickerCtrl and use boost::filesystem::path more.
Carl Hetherington [Tue, 16 Jan 2024 15:50:23 +0000 (16:50 +0100)]
Missing include.
Carl Hetherington [Fri, 12 Jan 2024 14:29:12 +0000 (15:29 +0100)]
Inspect most DCPs made during tests with ClairMeta (#76).
Carl Hetherington [Thu, 11 Jan 2024 15:24:38 +0000 (16:24 +0100)]
Inspect most DCPs made during tests with dcp_inspect (#76).
Carl Hetherington [Mon, 15 Jan 2024 09:25:14 +0000 (10:25 +0100)]
Missing PRIVATE_GIT update from previous.
Carl Hetherington [Sat, 13 Jan 2024 22:34:35 +0000 (23:34 +0100)]
Fix handling of empty font IDs and default DCP fonts (#2721) (part of #2722).
Previously we used an empty font ID as the default for when a subtitle
has no Font, but in #2721 we saw a DCP with an empty font ID which
raised an assertion (because we'd already added our default font with
the empty ID).
Here we try to fix this (and also make the default font correctly be
that from the first <LoadFont>).
Carl Hetherington [Sun, 14 Jan 2024 23:48:43 +0000 (00:48 +0100)]
Increase timeout before pulsing the progress bar for a job.
Carl Hetherington [Sat, 13 Jan 2024 20:52:27 +0000 (21:52 +0100)]
Add an assert.
Carl Hetherington [Sat, 13 Jan 2024 00:01:09 +0000 (01:01 +0100)]
Show hashes when they disagree during verification (#2717).
Carl Hetherington [Fri, 12 Jan 2024 23:13:17 +0000 (00:13 +0100)]
Updated nl_NL translation from Rob van Nieuwkerk.