GenericUI: remove duplicate connection to signal
authorJulien "_FrnchFrgg_" RIVAUD <frnchfrgg@free.fr>
Thu, 28 Jul 2016 21:07:44 +0000 (23:07 +0200)
committerJulien "_FrnchFrgg_" RIVAUD <frnchfrgg@free.fr>
Thu, 28 Jul 2016 21:21:10 +0000 (23:21 +0200)
Now that there isn't an early return anymore for Dropdowns, the common
path takes care of connecting the display update code to the correct
signal.

gtk2_ardour/generic_pluginui.cc

index 0b85beffca288cf0e10dce1e3254d6a05b53a8cf..ddaba074ce21e7dda13e153d380e9d078e1ef3de 100644 (file)
@@ -723,10 +723,6 @@ GenericPluginUI::build_control_ui (const Evoral::Parameter&             param,
                                                           i->second)));
                        }
 
-                       mcontrol->Changed.connect(control_connections, invalidator(*this),
-                                                 boost::bind(&GenericPluginUI::ui_parameter_changed,
-                                                             this, control_ui),
-                                                 gui_context());
 
                        if (use_knob) {
                                control_ui->knobtable = manage (new Table());
@@ -925,7 +921,10 @@ GenericPluginUI::build_control_ui (const Evoral::Parameter&             param,
        }
 
        if (mcontrol) {
-               mcontrol->Changed.connect (control_connections, invalidator (*this), boost::bind (&GenericPluginUI::ui_parameter_changed, this, control_ui), gui_context());
+               mcontrol->Changed.connect(control_connections, invalidator(*this),
+                                         boost::bind(&GenericPluginUI::ui_parameter_changed,
+                                                     this, control_ui),
+                                         gui_context());
        }
 
        return control_ui;