Make terminate_threads() less likely to leave _threads containing invalid pointers.

[dcpomatic.git] / src / lib / check_content_change_job.cc

diff --git a/src/lib/check_content_change_job.cc b/src/lib/check_content_change_job.cc
index 0862ab085323eaac5966b34358b0760a1d5ebf5b..3d5e4e979fe7745c2837599e7e838471756ac53b 100644 (file)
--- a/src/lib/check_content_change_job.cc
+++ b/src/lib/check_content_change_job.cc
@@ -1,5 +1,5 @@
 /*
-    Copyright (C) 2018 Carl Hetherington <cth@carlh.net>
+    Copyright (C) 2018-2019 Carl Hetherington <cth@carlh.net>
 
     This file is part of DCP-o-matic.
 
@@ -23,6 +23,7 @@
 #include "examine_content_job.h"
 #include "content.h"
 #include "film.h"
+#include "dcpomatic_log.h"
 #include <boost/foreach.hpp>
 #include <iostream>
 
@@ -33,8 +34,9 @@ using std::list;
 using std::cout;
 using boost::shared_ptr;
 
-CheckContentChangeJob::CheckContentChangeJob (shared_ptr<const Film> film)
+CheckContentChangeJob::CheckContentChangeJob (shared_ptr<const Film> film, shared_ptr<Job> following)
        : Job (film)
+       , _following (following)
 {
 
 }
@@ -42,7 +44,7 @@ CheckContentChangeJob::CheckContentChangeJob (shared_ptr<const Film> film)
 string
 CheckContentChangeJob::name () const
 {
-       return _("Check content for changes");
+       return _("Checking content for changes");
 }
 
 string
@@ -61,19 +63,17 @@ CheckContentChangeJob::run ()
        BOOST_FOREACH (shared_ptr<Content> i, _film->content()) {
                bool ic = false;
                for (size_t j = 0; j < i->number_of_paths(); ++j) {
-                       cout << boost::filesystem::last_write_time(i->path(j)) << " " << i->last_write_time(j) << "\n";
                        if (boost::filesystem::last_write_time(i->path(j)) != i->last_write_time(j)) {
-                               cout << "last write differs.\n";
+                               LOG_GENERAL("File %1 changed; last_write_time now %2, was %3", i->path(j).string(), boost::filesystem::last_write_time(i->path(j)), i->last_write_time(j));
                                ic = true;
                                break;
                        }
                }
                if (!ic && i->calculate_digest() != i->digest()) {
-                       cout << "digest differs.\n";
+                       LOG_GENERAL("Content %1 changed; digest now %2, was %3", i->path(0).string(), i->calculate_digest(), i->digest());
                        ic = true;
                }
                if (ic) {
-                       cout << i->path(0) << " changed.\n";
                        changed.push_back (i);
                }
        }
@@ -82,6 +82,23 @@ CheckContentChangeJob::run ()
                JobManager::instance()->add(shared_ptr<Job>(new ExamineContentJob(_film, i)));
        }
 
+       if (!changed.empty()) {
+               string m = _("Some files have been changed since they were added to the project.\n\nThese files will now be re-examined, so you may need to check their settings.");
+               if (_following) {
+                       /* I'm assuming that _following is a make DCP job */
+                       m += "  ";
+                       m += _("Choose 'Make DCP' again when you have done this.");
+               }
+               set_message (m);
+       } else if (_following) {
+               JobManager::instance()->add (_following);
+       }
+
+       /* Only set this job as finished once we have added the following job, otherwise I think
+          it's possible that the tests will sporadically fail if they check for all jobs being
+          complete in the gap between this one finishing and _following being added.
+       */
+
        set_progress (1);
        set_state (FINISHED_OK);
 }