Remove several exception-throwing asserts from destructors.

[dcpomatic.git] / src / lib / encode_server.cc

diff --git a/src/lib/encode_server.cc b/src/lib/encode_server.cc
index f318da03b5c2878dc5be5f3d30e74244ebcdf57e..7e015200370afaff06b5f75b6606274665a359f5 100644 (file)
--- a/src/lib/encode_server.cc
+++ b/src/lib/encode_server.cc
@@ -85,15 +85,23 @@ EncodeServer::~EncodeServer ()
        }
 
        BOOST_FOREACH (boost::thread* i, _worker_threads) {
-               DCPOMATIC_ASSERT (i->joinable ());
-               i->join ();
+               /* Ideally this would be a DCPOMATIC_ASSERT(i->joinable()) but we
+                  can't throw exceptions from a destructor.
+               */
+               if (i->joinable ()) {
+                       i->join ();
+               }
                delete i;
        }
 
        _broadcast.io_service.stop ();
        if (_broadcast.thread) {
-               DCPOMATIC_ASSERT (_broadcast.thread->joinable ());
-               _broadcast.thread->join ();
+               /* Ideally this would be a DCPOMATIC_ASSERT(_broadcast.thread->joinable()) but we
+                  can't throw exceptions from a destructor.
+               */
+               if (_broadcast.thread->joinable ()) {
+                       _broadcast.thread->join ();
+               }
        }
 }