Support more detailed horizontal positioning coming from libsub.
[dcpomatic.git] / src / lib / ffmpeg_decoder.cc
index a0965dcfb81a917eef2e0ba46b1223d536f35cc6..af309cdbe4aa99715eca949e88b1cb934f3699a5 100644 (file)
@@ -81,10 +81,14 @@ using dcp::Size;
 FFmpegDecoder::FFmpegDecoder (shared_ptr<const FFmpegContent> c, shared_ptr<Log> log)
        : FFmpeg (c)
        , _log (log)
+       , _have_current_subtitle (false)
 {
        if (c->video) {
                video.reset (new VideoDecoder (this, c, log));
                _pts_offset = pts_offset (c->ffmpeg_audio_streams(), c->first_video(), c->active_video_frame_rate());
+               /* It doesn't matter what size or pixel format this is, it just needs to be black */
+               _black_image.reset (new Image (AV_PIX_FMT_RGB24, dcp::Size (128, 128), true));
+               _black_image->make_black ();
        } else {
                _pts_offset = ContentTime ();
        }
@@ -94,14 +98,7 @@ FFmpegDecoder::FFmpegDecoder (shared_ptr<const FFmpegContent> c, shared_ptr<Log>
        }
 
        if (c->subtitle) {
-               subtitle.reset (
-                       new SubtitleDecoder (
-                               this,
-                               c->subtitle,
-                               bind (&FFmpegDecoder::image_subtitles_during, this, _1, _2),
-                               bind (&FFmpegDecoder::text_subtitles_during, this, _1, _2)
-                               )
-                       );
+               subtitle.reset (new SubtitleDecoder (this, c->subtitle, log));
        }
 }
 
@@ -119,12 +116,41 @@ FFmpegDecoder::flush ()
 
        if (audio) {
                decode_audio_packet ();
+       }
+
+       /* Make sure all streams are the same length and round up to the next video frame */
+
+       FrameRateChange const frc = _ffmpeg_content->film()->active_frame_rate_change(_ffmpeg_content->position());
+       ContentTime full_length (_ffmpeg_content->full_length(), frc);
+       full_length = full_length.ceil (frc.source);
+       if (video) {
+               double const vfr = _ffmpeg_content->video_frame_rate().get();
+               Frame const f = full_length.frames_round (vfr);
+               Frame v = video->position().frames_round (vfr);
+               while (v < f) {
+                       video->emit (shared_ptr<const ImageProxy> (new RawImageProxy (_black_image)), v);
+                       ++v;
+               }
+       }
+
+       BOOST_FOREACH (shared_ptr<FFmpegAudioStream> i, _ffmpeg_content->ffmpeg_audio_streams ()) {
+               ContentTime a = audio->stream_position(i);
+               while (a < full_length) {
+                       ContentTime to_do = min (full_length - a, ContentTime::from_seconds (0.1));
+                       shared_ptr<AudioBuffers> silence (new AudioBuffers (i->channels(), to_do.frames_ceil (i->frame_rate())));
+                       silence->make_silent ();
+                       audio->emit (i, silence, a);
+                       a += to_do;
+               }
+       }
+
+       if (audio) {
                audio->flush ();
        }
 }
 
 bool
-FFmpegDecoder::pass (PassReason reason, bool accurate)
+FFmpegDecoder::pass ()
 {
        int r = av_read_frame (_format_context, &_packet);
 
@@ -147,11 +173,11 @@ FFmpegDecoder::pass (PassReason reason, bool accurate)
        int const si = _packet.stream_index;
        shared_ptr<const FFmpegContent> fc = _ffmpeg_content;
 
-       if (_video_stream && si == _video_stream.get() && !video->ignore() && (accurate || reason != PASS_REASON_SUBTITLE)) {
+       if (_video_stream && si == _video_stream.get() && !video->ignore()) {
                decode_video_packet ();
-       } else if (fc->subtitle_stream() && fc->subtitle_stream()->uses_index (_format_context, si)) {
+       } else if (fc->subtitle_stream() && fc->subtitle_stream()->uses_index(_format_context, si) && !subtitle->ignore()) {
                decode_subtitle_packet ();
-       } else if (accurate || reason != PASS_REASON_SUBTITLE) {
+       } else {
                decode_audio_packet ();
        }
 
@@ -306,17 +332,7 @@ FFmpegDecoder::bytes_per_audio_sample (shared_ptr<FFmpegAudioStream> stream) con
 void
 FFmpegDecoder::seek (ContentTime time, bool accurate)
 {
-       if (video) {
-               video->seek (time, accurate);
-       }
-
-       if (audio) {
-               audio->seek (time, accurate);
-       }
-
-       if (subtitle) {
-               subtitle->seek (time, accurate);
-       }
+       Decoder::seek (time, accurate);
 
        /* If we are doing an `accurate' seek, we need to use pre-roll, as
           we don't really know what the seek will give us.
@@ -357,11 +373,15 @@ FFmpegDecoder::seek (ContentTime time, bool accurate)
                avcodec_flush_buffers (video_codec_context());
        }
 
-       /* XXX: should be flushing audio buffers? */
+       BOOST_FOREACH (shared_ptr<FFmpegAudioStream> i, ffmpeg_content()->ffmpeg_audio_streams()) {
+               avcodec_flush_buffers (i->stream(_format_context)->codec);
+       }
 
        if (subtitle_codec_context ()) {
                avcodec_flush_buffers (subtitle_codec_context ());
        }
+
+       _have_current_subtitle = false;
 }
 
 void
@@ -416,14 +436,18 @@ FFmpegDecoder::decode_audio_packet ()
                        if (ct < ContentTime ()) {
                                /* Discard audio data that comes before time 0 */
                                Frame const remove = min (int64_t (data->frames()), (-ct).frames_ceil(double((*stream)->frame_rate ())));
-                               data->move (remove, 0, data->frames() - remove);
+                               data->move (data->frames() - remove, remove, 0);
                                data->set_frames (data->frames() - remove);
                                ct += ContentTime::from_frames (remove, (*stream)->frame_rate ());
                        }
 
+                       if (ct < ContentTime()) {
+                               LOG_WARNING ("Crazy timestamp %1", to_string (ct));
+                       }
+
                        /* Give this data provided there is some, and its time is sane */
                        if (ct >= ContentTime() && data->frames() > 0) {
-                               audio->give (*stream, data, ct);
+                               audio->emit (*stream, data, ct);
                        }
                }
 
@@ -468,7 +492,7 @@ FFmpegDecoder::decode_video_packet ()
 
                if (i->second != AV_NOPTS_VALUE) {
                        double const pts = i->second * av_q2d (_format_context->streams[_video_stream.get()]->time_base) + _pts_offset.seconds ();
-                       video->give (
+                       video->emit (
                                shared_ptr<ImageProxy> (new RawImageProxy (image)),
                                llrint (pts * _ffmpeg_content->active_video_frame_rate ())
                                );
@@ -489,10 +513,18 @@ FFmpegDecoder::decode_subtitle_packet ()
                return;
        }
 
+       /* Stop any current subtitle, either at the time it was supposed to stop, or now if now is sooner */
+       if (_have_current_subtitle) {
+               if (_current_subtitle_to) {
+                       subtitle->emit_stop (min(*_current_subtitle_to, subtitle_period(sub).from + _pts_offset));
+               } else {
+                       subtitle->emit_stop (subtitle_period(sub).from + _pts_offset);
+               }
+               _have_current_subtitle = false;
+       }
+
        if (sub.num_rects <= 0) {
-               /* Sometimes we get an empty AVSubtitle, which is used by some codecs to
-                  indicate that the previous subtitle should stop.  We can ignore it here.
-               */
+               /* Nothing new in this subtitle */
                return;
        }
 
@@ -500,14 +532,11 @@ FFmpegDecoder::decode_subtitle_packet ()
           source that we may have chopped off for the DCP).
        */
        FFmpegSubtitlePeriod sub_period = subtitle_period (sub);
-       ContentTimePeriod period;
-       period.from = sub_period.from + _pts_offset;
+       ContentTime from;
+       from = sub_period.from + _pts_offset;
+       _have_current_subtitle = true;
        if (sub_period.to) {
-               /* We already know the subtitle period `to' time */
-               period.to = sub_period.to.get() + _pts_offset;
-       } else {
-               /* We have to look up the `to' time in the stream's records */
-               period.to = ffmpeg_content()->subtitle_stream()->find_subtitle_to (subtitle_id (sub));
+               _current_subtitle_to = *sub_period.to + _pts_offset;
        }
 
        for (unsigned int i = 0; i < sub.num_rects; ++i) {
@@ -517,13 +546,13 @@ FFmpegDecoder::decode_subtitle_packet ()
                case SUBTITLE_NONE:
                        break;
                case SUBTITLE_BITMAP:
-                       decode_bitmap_subtitle (rect, period);
+                       decode_bitmap_subtitle (rect, from);
                        break;
                case SUBTITLE_TEXT:
                        cout << "XXX: SUBTITLE_TEXT " << rect->text << "\n";
                        break;
                case SUBTITLE_ASS:
-                       decode_ass_subtitle (rect->ass, period);
+                       decode_ass_subtitle (rect->ass, from);
                        break;
                }
        }
@@ -531,20 +560,8 @@ FFmpegDecoder::decode_subtitle_packet ()
        avsubtitle_free (&sub);
 }
 
-list<ContentTimePeriod>
-FFmpegDecoder::image_subtitles_during (ContentTimePeriod p, bool starting) const
-{
-       return _ffmpeg_content->image_subtitles_during (p, starting);
-}
-
-list<ContentTimePeriod>
-FFmpegDecoder::text_subtitles_during (ContentTimePeriod p, bool starting) const
-{
-       return _ffmpeg_content->text_subtitles_during (p, starting);
-}
-
 void
-FFmpegDecoder::decode_bitmap_subtitle (AVSubtitleRect const * rect, ContentTimePeriod period)
+FFmpegDecoder::decode_bitmap_subtitle (AVSubtitleRect const * rect, ContentTime from)
 {
        /* Note RGBA is expressed little-endian, so the first byte in the word is R, second
           G, third B, fourth A.
@@ -604,19 +621,20 @@ FFmpegDecoder::decode_bitmap_subtitle (AVSubtitleRect const * rect, ContentTimeP
                out_p += image->stride()[0] / sizeof (uint32_t);
        }
 
-       dcp::Size const vs = _ffmpeg_content->video->size ();
+       int const target_width = subtitle_codec_context()->width;
+       int const target_height = subtitle_codec_context()->height;
        dcpomatic::Rect<double> const scaled_rect (
-               static_cast<double> (rect->x) / vs.width,
-               static_cast<double> (rect->y) / vs.height,
-               static_cast<double> (rect->w) / vs.width,
-               static_cast<double> (rect->h) / vs.height
+               static_cast<double> (rect->x) / target_width,
+               static_cast<double> (rect->y) / target_height,
+               static_cast<double> (rect->w) / target_width,
+               static_cast<double> (rect->h) / target_height
                );
 
-       subtitle->give_image (period, image, scaled_rect);
+       subtitle->emit_image_start (from, image, scaled_rect);
 }
 
 void
-FFmpegDecoder::decode_ass_subtitle (string ass, ContentTimePeriod period)
+FFmpegDecoder::decode_ass_subtitle (string ass, ContentTime from)
 {
        /* We have no styles and no Format: line, so I'm assuming that FFmpeg
           produces a single format of Dialogue: lines...
@@ -629,9 +647,14 @@ FFmpegDecoder::decode_ass_subtitle (string ass, ContentTimePeriod period)
        }
 
        sub::RawSubtitle base;
-       list<sub::RawSubtitle> raw = sub::SSAReader::parse_line (base, bits[9]);
+       list<sub::RawSubtitle> raw = sub::SSAReader::parse_line (
+               base,
+               bits[9],
+               _ffmpeg_content->video->size().width,
+               _ffmpeg_content->video->size().height
+               );
 
        BOOST_FOREACH (sub::Subtitle const & i, sub::collect<list<sub::Subtitle> > (raw)) {
-               subtitle->give_text (period, i);
+               subtitle->emit_text_start (from, i);
        }
 }