Add some asserts; sws_getContext() will fail if the image width or height are 0.

[dcpomatic.git] / src / lib / image.cc

diff --git a/src/lib/image.cc b/src/lib/image.cc
index c6e7b418c5bfe5996101f3c22571b47a8f2ba3f1..4c60fe8886fca9be82a3ea741390049c7f83dbf2 100644 (file)
--- a/src/lib/image.cc
+++ b/src/lib/image.cc
@@ -339,6 +339,10 @@ Image::scale (dcp::Size out_size, dcp::YUVToRGB yuv_to_rgb, AVPixelFormat out_fo
           the input image alignment is not PADDED.
        */
        DCPOMATIC_ASSERT (alignment() == Alignment::PADDED);
+       DCPOMATIC_ASSERT(size().width > 0);
+       DCPOMATIC_ASSERT(size().height > 0);
+       DCPOMATIC_ASSERT(out_size.width > 0);
+       DCPOMATIC_ASSERT(out_size.height > 0);
 
        auto scaled = make_shared<Image>(out_format, out_size, out_alignment);
        auto scale_context = sws_getContext (
@@ -670,6 +674,10 @@ struct OtherYUVParams
        dcp::Size size;
        uint8_t* const* data;
        int const* stride;
+
+       uint8_t* const* alpha_data;
+       int const* alpha_stride;
+       int alpha_bpp;
 };
 
 
@@ -800,7 +808,7 @@ alpha_blend_onto_xyz12le(TargetParams const& target, OtherRGBParams const& other
 
 static
 void
-alpha_blend_onto_yuv420p(TargetParams const& target, OtherYUVParams const& other, uint8_t* const* alpha_data, int const* alpha_stride)
+alpha_blend_onto_yuv420p(TargetParams const& target, OtherYUVParams const& other, std::function<float (uint8_t* data)> get_alpha)
 {
        auto const ts = target.size;
        auto const os = other.size;
@@ -813,9 +821,9 @@ alpha_blend_onto_yuv420p(TargetParams const& target, OtherYUVParams const& other
                uint8_t* oY = other.data[0] + (oy * other.stride[0]) + other.start_x;
                uint8_t* oU = other.data[1] + (hoy * other.stride[1]) + other.start_x / 2;
                uint8_t* oV = other.data[2] + (hoy * other.stride[2]) + other.start_x / 2;
-               uint8_t* alpha = alpha_data[0] + (oy * alpha_stride[0]) + other.start_x * 4;
+               uint8_t* alpha = other.alpha_data[0] + (oy * other.alpha_stride[0]) + other.start_x * other.alpha_bpp;
                for (int tx = target.start_x, ox = other.start_x; tx < ts.width && ox < os.width; ++tx, ++ox) {
-                       float const a = float(alpha[3]) / 255;
+                       float const a = get_alpha(alpha);
                        *tY = *oY * a + *tY * (1 - a);
                        *tU = *oU * a + *tU * (1 - a);
                        *tV = *oV * a + *tV * (1 - a);
@@ -829,7 +837,7 @@ alpha_blend_onto_yuv420p(TargetParams const& target, OtherYUVParams const& other
                                ++oU;
                                ++oV;
                        }
-                       alpha += 4;
+                       alpha += other.alpha_bpp;
                }
        }
 }
@@ -837,7 +845,7 @@ alpha_blend_onto_yuv420p(TargetParams const& target, OtherYUVParams const& other
 
 static
 void
-alpha_blend_onto_yuv420p10(TargetParams const& target, OtherYUVParams const& other, uint8_t* const* alpha_data, int const* alpha_stride)
+alpha_blend_onto_yuv420p10(TargetParams const& target, OtherYUVParams const& other, std::function<float (uint8_t* data)> get_alpha)
 {
        auto const ts = target.size;
        auto const os = other.size;
@@ -850,9 +858,9 @@ alpha_blend_onto_yuv420p10(TargetParams const& target, OtherYUVParams const& oth
                uint16_t* oY = reinterpret_cast<uint16_t*>(other.data[0] + (oy * other.stride[0])) + other.start_x;
                uint16_t* oU = reinterpret_cast<uint16_t*>(other.data[1] + (hoy * other.stride[1])) + other.start_x / 2;
                uint16_t* oV = reinterpret_cast<uint16_t*>(other.data[2] + (hoy * other.stride[2])) + other.start_x / 2;
-               uint8_t* alpha = alpha_data[0] + (oy * alpha_stride[0]) + other.start_x * 4;
+               uint8_t* alpha = other.alpha_data[0] + (oy * other.alpha_stride[0]) + other.start_x * other.alpha_bpp;
                for (int tx = target.start_x, ox = other.start_x; tx < ts.width && ox < os.width; ++tx, ++ox) {
-                       float const a = float(alpha[3]) / 255;
+                       float const a = get_alpha(alpha);
                        *tY = *oY * a + *tY * (1 - a);
                        *tU = *oU * a + *tU * (1 - a);
                        *tV = *oV * a + *tV * (1 - a);
@@ -866,7 +874,7 @@ alpha_blend_onto_yuv420p10(TargetParams const& target, OtherYUVParams const& oth
                                ++oU;
                                ++oV;
                        }
-                       alpha += 4;
+                       alpha += other.alpha_bpp;
                }
        }
 }
@@ -874,7 +882,7 @@ alpha_blend_onto_yuv420p10(TargetParams const& target, OtherYUVParams const& oth
 
 static
 void
-alpha_blend_onto_yuv422p9or10le(TargetParams const& target, OtherYUVParams const& other, uint8_t* const* alpha_data, int const* alpha_stride)
+alpha_blend_onto_yuv422p9or10le(TargetParams const& target, OtherYUVParams const& other, std::function<float (uint8_t* data)> get_alpha)
 {
        auto const ts = target.size;
        auto const os = other.size;
@@ -885,9 +893,9 @@ alpha_blend_onto_yuv422p9or10le(TargetParams const& target, OtherYUVParams const
                uint16_t* oY = reinterpret_cast<uint16_t*>(other.data[0] + (oy * other.stride[0])) + other.start_x;
                uint16_t* oU = reinterpret_cast<uint16_t*>(other.data[1] + (oy * other.stride[1])) + other.start_x / 2;
                uint16_t* oV = reinterpret_cast<uint16_t*>(other.data[2] + (oy * other.stride[2])) + other.start_x / 2;
-               uint8_t* alpha = alpha_data[0] + (oy * alpha_stride[0]) + other.start_x * 4;
+               uint8_t* alpha = other.alpha_data[0] + (oy * other.alpha_stride[0]) + other.start_x * other.alpha_bpp;
                for (int tx = target.start_x, ox = other.start_x; tx < ts.width && ox < os.width; ++tx, ++ox) {
-                       float const a = float(alpha[3]) / 255;
+                       float const a = get_alpha(alpha);
                        *tY = *oY * a + *tY * (1 - a);
                        *tU = *oU * a + *tU * (1 - a);
                        *tV = *oV * a + *tV * (1 - a);
@@ -901,7 +909,38 @@ alpha_blend_onto_yuv422p9or10le(TargetParams const& target, OtherYUVParams const
                                ++oU;
                                ++oV;
                        }
-                       alpha += 4;
+                       alpha += other.alpha_bpp;
+               }
+       }
+}
+
+
+static
+void
+alpha_blend_onto_yuv444p9or10le(TargetParams const& target, OtherYUVParams const& other, std::function<float (uint8_t* data)> get_alpha)
+{
+       auto const ts = target.size;
+       auto const os = other.size;
+       for (int ty = target.start_y, oy = other.start_y; ty < ts.height && oy < os.height; ++ty, ++oy) {
+               uint16_t* tY = reinterpret_cast<uint16_t*>(target.data[0] + (ty * target.stride[0])) + target.start_x;
+               uint16_t* tU = reinterpret_cast<uint16_t*>(target.data[1] + (ty * target.stride[1])) + target.start_x;
+               uint16_t* tV = reinterpret_cast<uint16_t*>(target.data[2] + (ty * target.stride[2])) + target.start_x;
+               uint16_t* oY = reinterpret_cast<uint16_t*>(other.data[0] + (oy * other.stride[0])) + other.start_x;
+               uint16_t* oU = reinterpret_cast<uint16_t*>(other.data[1] + (oy * other.stride[1])) + other.start_x;
+               uint16_t* oV = reinterpret_cast<uint16_t*>(other.data[2] + (oy * other.stride[2])) + other.start_x;
+               uint8_t* alpha = other.alpha_data[0] + (oy * other.alpha_stride[0]) + other.start_x * other.alpha_bpp;
+               for (int tx = target.start_x, ox = other.start_x; tx < ts.width && ox < os.width; ++tx, ++ox) {
+                       float const a = get_alpha(alpha);
+                       *tY = *oY * a + *tY * (1 - a);
+                       *tU = *oU * a + *tU * (1 - a);
+                       *tV = *oV * a + *tV * (1 - a);
+                       ++tY;
+                       ++oY;
+                       ++tU;
+                       ++tV;
+                       ++oU;
+                       ++oV;
+                       alpha += other.alpha_bpp;
                }
        }
 }
@@ -959,6 +998,9 @@ Image::alpha_blend (shared_ptr<const Image> other, Position<int> position)
                other->size(),
                other->data(),
                other->stride(),
+               nullptr,
+               nullptr,
+               other->pixel_format() == AV_PIX_FMT_RGBA64BE ? 8 : 4
        };
 
        auto byteswap = [](uint16_t* p) {
@@ -969,6 +1011,14 @@ Image::alpha_blend (shared_ptr<const Image> other, Position<int> position)
                return *p;
        };
 
+       auto get_alpha_64be = [](uint8_t* p) {
+               return ((static_cast<int16_t>(p[6]) << 8) | p[7]) / 65535.0f;
+       };
+
+       auto get_alpha_byte = [](uint8_t* p) {
+               return p[3] / 255.0f;
+       };
+
        switch (_pixel_format) {
        case AV_PIX_FMT_RGB24:
                target_params.bpp = 3;
@@ -1015,7 +1065,13 @@ Image::alpha_blend (shared_ptr<const Image> other, Position<int> position)
                auto yuv = other->convert_pixel_format (dcp::YUVToRGB::REC709, _pixel_format, Alignment::COMPACT, false);
                other_yuv_params.data = yuv->data();
                other_yuv_params.stride = yuv->stride();
-               alpha_blend_onto_yuv420p(target_params, other_yuv_params, other->data(), other->stride());
+               other_yuv_params.alpha_data = other->data();
+               other_yuv_params.alpha_stride = other->stride();
+               if (other->pixel_format() == AV_PIX_FMT_RGBA64BE) {
+                       alpha_blend_onto_yuv420p(target_params, other_yuv_params, get_alpha_64be);
+               } else {
+                       alpha_blend_onto_yuv420p(target_params, other_yuv_params, get_alpha_byte);
+               }
                break;
        }
        case AV_PIX_FMT_YUV420P10:
@@ -1023,7 +1079,13 @@ Image::alpha_blend (shared_ptr<const Image> other, Position<int> position)
                auto yuv = other->convert_pixel_format (dcp::YUVToRGB::REC709, _pixel_format, Alignment::COMPACT, false);
                other_yuv_params.data = yuv->data();
                other_yuv_params.stride = yuv->stride();
-               alpha_blend_onto_yuv420p10(target_params, other_yuv_params, other->data(), other->stride());
+               other_yuv_params.alpha_data = other->data();
+               other_yuv_params.alpha_stride = other->stride();
+               if (other->pixel_format() == AV_PIX_FMT_RGBA64BE) {
+                       alpha_blend_onto_yuv420p10(target_params, other_yuv_params, get_alpha_64be);
+               } else {
+                       alpha_blend_onto_yuv420p10(target_params, other_yuv_params, get_alpha_byte);
+               }
                break;
        }
        case AV_PIX_FMT_YUV422P9LE:
@@ -1032,7 +1094,28 @@ Image::alpha_blend (shared_ptr<const Image> other, Position<int> position)
                auto yuv = other->convert_pixel_format (dcp::YUVToRGB::REC709, _pixel_format, Alignment::COMPACT, false);
                other_yuv_params.data = yuv->data();
                other_yuv_params.stride = yuv->stride();
-               alpha_blend_onto_yuv422p9or10le(target_params, other_yuv_params, other->data(), other->stride());
+               other_yuv_params.alpha_data = other->data();
+               other_yuv_params.alpha_stride = other->stride();
+               if (other->pixel_format() == AV_PIX_FMT_RGBA64BE) {
+                       alpha_blend_onto_yuv422p9or10le(target_params, other_yuv_params, get_alpha_64be);
+               } else {
+                       alpha_blend_onto_yuv422p9or10le(target_params, other_yuv_params, get_alpha_byte);
+               }
+               break;
+       }
+       case AV_PIX_FMT_YUV444P9LE:
+       case AV_PIX_FMT_YUV444P10LE:
+       {
+               auto yuv = other->convert_pixel_format (dcp::YUVToRGB::REC709, _pixel_format, Alignment::COMPACT, false);
+               other_yuv_params.data = yuv->data();
+               other_yuv_params.stride = yuv->stride();
+               other_yuv_params.alpha_data = other->data();
+               other_yuv_params.alpha_stride = other->stride();
+               if (other->pixel_format() == AV_PIX_FMT_RGBA64BE) {
+                       alpha_blend_onto_yuv444p9or10le(target_params, other_yuv_params, get_alpha_64be);
+               } else {
+                       alpha_blend_onto_yuv444p9or10le(target_params, other_yuv_params, get_alpha_byte);
+               }
                break;
        }
        default: