Differentiate requested and actual crop.
[dcpomatic.git] / src / tools / dcpomatic_player.cc
index 9fab8b5887932afa38e2acb56531567a7bdee1d8..e409b97311be1fa5c78a5952d6d5a20c51a2102b 100644 (file)
@@ -1,5 +1,5 @@
 /*
-    Copyright (C) 2017-2020 Carl Hetherington <cth@carlh.net>
+    Copyright (C) 2017-2021 Carl Hetherington <cth@carlh.net>
 
     This file is part of DCP-o-matic.
 
@@ -32,6 +32,8 @@
 #include "wx/timer_display.h"
 #include "wx/system_information_dialog.h"
 #include "wx/player_stress_tester.h"
+#include "wx/verify_dcp_progress_dialog.h"
+#include "wx/nag_dialog.h"
 #include "lib/cross.h"
 #include "lib/config.h"
 #include "lib/util.h"
@@ -55,6 +57,7 @@
 #include "lib/ffmpeg_content.h"
 #include "lib/dcpomatic_log.h"
 #include "lib/file_log.h"
+#include <dcp/cpl.h>
 #include <dcp/dcp.h>
 #include <dcp/raw_convert.h>
 #include <dcp/exceptions.h>
@@ -68,7 +71,7 @@
 #ifdef __WXGTK__
 #include <X11/Xlib.h>
 #endif
-#include <boost/bind.hpp>
+#include <boost/bind/bind.hpp>
 #include <boost/algorithm/string.hpp>
 #include <iostream>
 
 
 #define MAX_CPLS 32
 
-using std::string;
 using std::cout;
-using std::list;
+using std::dynamic_pointer_cast;
 using std::exception;
+using std::list;
+using std::make_shared;
+using std::shared_ptr;
+using std::string;
 using std::vector;
-using boost::shared_ptr;
-using boost::weak_ptr;
+using std::weak_ptr;
 using boost::scoped_array;
 using boost::optional;
-using boost::dynamic_pointer_cast;
 using boost::thread;
 using boost::bind;
 #if BOOST_VERSION >= 106100
@@ -135,29 +139,18 @@ class DOMFrame : public wxFrame
 {
 public:
        DOMFrame ()
-               : wxFrame (0, -1, _("DCP-o-matic Player"))
-               , _dual_screen (0)
-               , _update_news_requested (false)
-               , _info (0)
+               : wxFrame (nullptr, -1, _("DCP-o-matic Player"))
                , _mode (Config::instance()->player_mode())
-               , _config_dialog (0)
-               , _file_menu (0)
-               , _history_items (0)
-               , _history_position (0)
-               , _history_separator (0)
-               , _system_information_dialog (0)
-               , _view_full_screen (0)
-               , _view_dual_screen (0)
-               , _main_sizer (new wxBoxSizer (wxVERTICAL))
-{
-               dcpomatic_log.reset (new NullLog());
+               , _main_sizer (new wxBoxSizer(wxVERTICAL))
+       {
+               dcpomatic_log = make_shared<NullLog>();
 
 #if defined(DCPOMATIC_WINDOWS)
                maybe_open_console ();
                cout << "DCP-o-matic Player is starting." << "\n";
 #endif
 
-               wxMenuBar* bar = new wxMenuBar;
+               auto bar = new wxMenuBar;
                setup_menu (bar);
                set_menu_sensitivity ();
                SetMenuBar (bar);
@@ -195,18 +188,20 @@ public:
                */
                _overall_panel = new wxPanel (this, wxID_ANY);
 
-               _viewer.reset (new FilmViewer (_overall_panel));
+               _viewer = make_shared<FilmViewer>(_overall_panel);
                if (Config::instance()->player_mode() == Config::PLAYER_MODE_DUAL) {
-                       PlaylistControls* pc = new PlaylistControls (_overall_panel, _viewer);
+                       auto pc = new PlaylistControls (_overall_panel, _viewer);
                        _controls = pc;
                        pc->ResetFilm.connect (bind(&DOMFrame::reset_film_weak, this, _1));
                } else {
                        _controls = new StandardControls (_overall_panel, _viewer, false);
                }
                _viewer->set_dcp_decode_reduction (Config::instance()->decode_reduction ());
+               _viewer->set_optimise_for_j2k (true);
                _viewer->PlaybackPermitted.connect (bind(&DOMFrame::playback_permitted, this));
                _viewer->Started.connect (bind(&DOMFrame::playback_started, this, _1));
                _viewer->Stopped.connect (bind(&DOMFrame::playback_stopped, this, _1));
+               _viewer->TooManyDropped.connect (bind(&DOMFrame::too_many_frames_dropped, this));
                _info = new PlayerInformation (_overall_panel, _viewer);
                setup_main_sizer (Config::instance()->player_mode());
 #ifdef __WXOSX__
@@ -250,12 +245,20 @@ public:
 
                reset_film ();
 
-               UpdateChecker::instance()->StateChanged.connect (boost::bind (&DOMFrame::update_checker_state_changed, this));
+               UpdateChecker::instance()->StateChanged.connect (boost::bind(&DOMFrame::update_checker_state_changed, this));
                setup_screen ();
 
                _stress.LoadDCP.connect (boost::bind(&DOMFrame::load_dcp, this, _1));
        }
 
+       ~DOMFrame ()
+       {
+               /* It's important that this is stopped before our frame starts destroying its children,
+                * otherwise UI elements that it depends on will disappear from under it.
+                */
+               _viewer.reset ();
+       }
+
        void setup_main_sizer (Config::PlayerMode mode)
        {
                _main_sizer->Detach (_viewer->panel());
@@ -277,8 +280,8 @@ public:
                }
 
                bool ok = true;
-               BOOST_FOREACH (shared_ptr<Content> i, _film->content()) {
-                       shared_ptr<DCPContent> d = dynamic_pointer_cast<DCPContent>(i);
+               for (auto i: _film->content()) {
+                       auto d = dynamic_pointer_cast<DCPContent>(i);
                        if (d && !d->kdm_timing_window_valid()) {
                                ok = false;
                        }
@@ -298,11 +301,11 @@ public:
                        return;
                }
 
-               shared_ptr<DCPContent> dcp = dynamic_pointer_cast<DCPContent>(_film->content().front());
+               auto dcp = dynamic_pointer_cast<DCPContent>(_film->content().front());
                if (dcp) {
                        DCPExaminer ex (dcp, true);
                        shared_ptr<dcp::CPL> playing_cpl;
-                       BOOST_FOREACH (shared_ptr<dcp::CPL> i, ex.cpls()) {
+                       for (auto i: ex.cpls()) {
                                if (!dcp->cpl() || i->id() == *dcp->cpl()) {
                                        playing_cpl = i;
                                }
@@ -314,12 +317,12 @@ public:
                                        "playback-started %s %s %s",
                                        time.timecode(_film->video_frame_rate()).c_str(),
                                        dcp->directories().front().string().c_str(),
-                                       playing_cpl->annotation_text().c_str()
+                                       playing_cpl->annotation_text().get_value_or("").c_str()
                                        )
                                );
                }
 
-               shared_ptr<FFmpegContent> ffmpeg = dynamic_pointer_cast<FFmpegContent>(_film->content().front());
+               auto ffmpeg = dynamic_pointer_cast<FFmpegContent>(_film->content().front());
                if (ffmpeg) {
                        _controls->log (
                                wxString::Format(
@@ -336,6 +339,25 @@ public:
                _controls->log (wxString::Format("playback-stopped %s", time.timecode(_film->video_frame_rate()).c_str()));
        }
 
+
+       void too_many_frames_dropped ()
+       {
+               if (!Config::instance()->nagged(Config::NAG_TOO_MANY_DROPPED_FRAMES)) {
+                       _viewer->stop ();
+               }
+
+               NagDialog::maybe_nag (
+                       this,
+                       Config::NAG_TOO_MANY_DROPPED_FRAMES,
+                       _(wxS("The player is dropping a lot of frames, so playback may not be accurate.\n\n"
+                         "<b>This does not necessarily mean that the DCP you are playing is defective!</b>\n\n"
+                         "You may be able to improve player performance by:\n"
+                         "• choosing 'decode at half resolution' or 'decode at quarter resolution' from the View menu\n"
+                         "• using a more powerful computer.\n"
+                        ))
+                       );
+       }
+
        void set_decode_reduction (optional<int> reduction)
        {
                _viewer->set_dcp_decode_reduction (reduction);
@@ -350,8 +372,9 @@ public:
                reset_film ();
                try {
                        _stress.set_suspended (true);
-                       shared_ptr<DCPContent> dcp (new DCPContent(dir));
-                       shared_ptr<Job> job (new ExamineContentJob(_film, dcp));
+                       // here
+                       auto dcp = make_shared<DCPContent>(dir);
+                       auto job = make_shared<ExamineContentJob>(_film, dcp);
                        _examine_job_connection = job->Finished.connect(bind(&DOMFrame::add_dcp_to_film, this, weak_ptr<Job>(job), weak_ptr<Content>(dcp)));
                        JobManager::instance()->add (job);
                        bool const ok = display_progress (_("DCP-o-matic Player"), _("Loading content"));
@@ -359,6 +382,15 @@ public:
                                return;
                        }
                        Config::instance()->add_to_player_history (dir);
+               } catch (ProjectFolderError &) {
+                       error_dialog (
+                               this,
+                               wxString::Format(_("Could not load a DCP from %s"), std_to_wx(dir.string())),
+                               _(
+                                       "This looks like a DCP-o-matic project folder, which cannot be loaded into the player.  "
+                                       "Choose the DCP directory inside the DCP-o-matic project folder if that's what you want to play."
+                                )
+                               );
                } catch (dcp::ReadError& e) {
                        error_dialog (this, wxString::Format(_("Could not load a DCP from %s"), std_to_wx(dir.string())), std_to_wx(e.what()));
                } catch (DCPError& e) {
@@ -368,12 +400,12 @@ public:
 
        void add_dcp_to_film (weak_ptr<Job> weak_job, weak_ptr<Content> weak_content)
        {
-               shared_ptr<Job> job = weak_job.lock ();
+               auto job = weak_job.lock ();
                if (!job || !job->finished_ok()) {
                        return;
                }
 
-               shared_ptr<Content> content = weak_content.lock ();
+               auto content = weak_content.lock ();
                if (!content) {
                        return;
                }
@@ -384,7 +416,7 @@ public:
 
        void reset_film_weak (weak_ptr<Film> weak_film)
        {
-               shared_ptr<Film> film = weak_film.lock ();
+               auto film = weak_film.lock ();
                if (film) {
                        reset_film (film);
                }
@@ -403,7 +435,7 @@ public:
 
        void film_changed (ChangeType type, Film::Property property)
        {
-               if (type != CHANGE_TYPE_DONE || property != Film::CONTENT) {
+               if (type != ChangeType::DONE || property != Film::Property::CONTENT) {
                        return;
                }
 
@@ -414,15 +446,15 @@ public:
                /* Start off as Flat */
                _film->set_container (Ratio::from_id("185"));
 
-               BOOST_FOREACH (shared_ptr<Content> i, _film->content()) {
-                       shared_ptr<DCPContent> dcp = dynamic_pointer_cast<DCPContent>(i);
+               for (auto i: _film->content()) {
+                       auto dcp = dynamic_pointer_cast<DCPContent>(i);
 
-                       BOOST_FOREACH (shared_ptr<TextContent> j, i->text) {
+                       for (auto j: i->text) {
                                j->set_use (true);
                        }
 
                        if (i->video) {
-                               Ratio const * r = Ratio::nearest_from_ratio(i->video->size().ratio());
+                               auto const r = Ratio::nearest_from_ratio(i->video->size().ratio());
                                if (r->id() == "239") {
                                        /* Any scope content means we use scope */
                                        _film->set_container(r);
@@ -430,7 +462,7 @@ public:
                        }
 
                        /* Any 3D content means we use 3D mode */
-                       if (i->video && i->video->frame_type() != VIDEO_FRAME_TYPE_2D) {
+                       if (i->video && i->video->frame_type() != VideoFrameType::TWO_D) {
                                _film->set_three_d (true);
                        }
                }
@@ -440,21 +472,21 @@ public:
 
                set_menu_sensitivity ();
 
-               wxMenuItemList old = _cpl_menu->GetMenuItems();
-               for (wxMenuItemList::iterator i = old.begin(); i != old.end(); ++i) {
-                       _cpl_menu->Remove (*i);
+               auto old = _cpl_menu->GetMenuItems();
+               for (auto const& i: old) {
+                       _cpl_menu->Remove (i);
                }
 
                if (_film->content().size() == 1) {
                        /* Offer a CPL menu */
-                       shared_ptr<DCPContent> first = dynamic_pointer_cast<DCPContent>(_film->content().front());
+                       auto first = dynamic_pointer_cast<DCPContent>(_film->content().front());
                        if (first) {
                                DCPExaminer ex (first, true);
                                int id = ID_view_cpl;
-                               BOOST_FOREACH (shared_ptr<dcp::CPL> i, ex.cpls()) {
-                                       wxMenuItem* j = _cpl_menu->AppendRadioItem(
+                               for (auto i: ex.cpls()) {
+                                       auto j = _cpl_menu->AppendRadioItem(
                                                id,
-                                               wxString::Format("%s (%s)", std_to_wx(i->annotation_text()).data(), std_to_wx(i->id()).data())
+                                               wxString::Format("%s (%s)", std_to_wx(i->annotation_text().get_value_or("")).data(), std_to_wx(i->id()).data())
                                                );
                                        j->Check(!first->cpl() || i->id() == *first->cpl());
                                        ++id;
@@ -470,13 +502,26 @@ public:
 
 private:
 
+       void examine_content ()
+       {
+               DCPOMATIC_ASSERT (_film);
+               auto dcp = dynamic_pointer_cast<DCPContent>(_film->content().front());
+               DCPOMATIC_ASSERT (dcp);
+               dcp->examine (_film, shared_ptr<Job>());
+
+               /* Examining content re-creates the TextContent objects, so we must re-enable them */
+               for (auto i: dcp->text) {
+                       i->set_use (true);
+               }
+       }
+
        bool report_errors_from_last_job (wxWindow* parent) const
        {
-               JobManager* jm = JobManager::instance ();
+               auto jm = JobManager::instance ();
 
                DCPOMATIC_ASSERT (!jm->get().empty());
 
-               shared_ptr<Job> last = jm->get().back();
+               auto last = jm->get().back();
                if (last->finished_in_error()) {
                        error_dialog(parent, wxString::Format(_("Could not load DCP.\n\n%s."), std_to_wx(last->error_summary()).data()), std_to_wx(last->error_details()));
                        return false;
@@ -505,18 +550,18 @@ private:
 #endif
 
 #ifdef __WXOSX__
-               wxMenuItem* prefs = _file_menu->Append (wxID_PREFERENCES, _("&Preferences...\tCtrl-P"));
+               auto prefs = _file_menu->Append (wxID_PREFERENCES, _("&Preferences...\tCtrl-P"));
 #else
-               wxMenu* edit = new wxMenu;
-               wxMenuItem* prefs = edit->Append (wxID_PREFERENCES, _("&Preferences...\tCtrl-P"));
+               auto edit = new wxMenu;
+               auto prefs = edit->Append (wxID_PREFERENCES, _("&Preferences...\tCtrl-P"));
 #endif
 
                prefs->Enable (Config::instance()->have_write_permission());
 
                _cpl_menu = new wxMenu;
 
-               wxMenu* view = new wxMenu;
-               optional<int> c = Config::instance()->decode_reduction();
+               auto view = new wxMenu;
+               auto c = Config::instance()->decode_reduction();
                _view_cpl = view->Append(ID_view_cpl, _("CPL"), _cpl_menu);
                view->AppendSeparator();
                _view_full_screen = view->AppendCheckItem(ID_view_full_screen, _("Full screen\tF11"));
@@ -530,14 +575,14 @@ private:
                view->AppendRadioItem(ID_view_scale_half, _("Decode at half resolution"))->Check(c && c.get() == 1);
                view->AppendRadioItem(ID_view_scale_quarter, _("Decode at quarter resolution"))->Check(c && c.get() == 2);
 
-               wxMenu* tools = new wxMenu;
-               _tools_verify = tools->Append (ID_tools_verify, _("Verify DCP"));
+               auto tools = new wxMenu;
+               _tools_verify = tools->Append (ID_tools_verify, _("Verify DCP..."));
                tools->AppendSeparator ();
                tools->Append (ID_tools_check_for_updates, _("Check for updates"));
                tools->Append (ID_tools_timing, _("Timing..."));
                tools->Append (ID_tools_system_information, _("System information..."));
 
-               wxMenu* help = new wxMenu;
+               auto help = new wxMenu;
 #ifdef __WXOSX__
                help->Append (wxID_ABOUT, _("About DCP-o-matic"));
 #else
@@ -556,12 +601,12 @@ private:
 
        void file_open ()
        {
-               wxString d = wxStandardPaths::Get().GetDocumentsDir();
+               auto d = wxStandardPaths::Get().GetDocumentsDir();
                if (Config::instance()->last_player_load_directory()) {
                        d = std_to_wx (Config::instance()->last_player_load_directory()->string());
                }
 
-               wxDirDialog* c = new wxDirDialog (this, _("Select DCP to open"), d, wxDEFAULT_DIALOG_STYLE | wxDD_DIR_MUST_EXIST);
+               auto c = new wxDirDialog (this, _("Select DCP to open"), d, wxDEFAULT_DIALOG_STYLE | wxDD_DIR_MUST_EXIST);
 
                int r;
                while (true) {
@@ -584,7 +629,7 @@ private:
 
        void file_add_ov ()
        {
-               wxDirDialog* c = new wxDirDialog (
+               auto c = new wxDirDialog (
                        this,
                        _("Select DCP to open as OV"),
                        wxStandardPaths::Get().GetDocumentsDir(),
@@ -603,19 +648,19 @@ private:
 
                if (r == wxID_OK) {
                        DCPOMATIC_ASSERT (_film);
-                       shared_ptr<DCPContent> dcp = boost::dynamic_pointer_cast<DCPContent>(_film->content().front());
+                       auto dcp = std::dynamic_pointer_cast<DCPContent>(_film->content().front());
                        DCPOMATIC_ASSERT (dcp);
                        dcp->add_ov (wx_to_std(c->GetPath()));
-                       JobManager::instance()->add(shared_ptr<Job>(new ExamineContentJob (_film, dcp)));
+                       JobManager::instance()->add(make_shared<ExamineContentJob>(_film, dcp));
                        bool const ok = display_progress (_("DCP-o-matic Player"), _("Loading content"));
                        if (!ok || !report_errors_from_last_job(this)) {
                                return;
                        }
-                       BOOST_FOREACH (shared_ptr<TextContent> i, dcp->text) {
+                       for (auto i: dcp->text) {
                                i->set_use (true);
                        }
                        if (dcp->video) {
-                               Ratio const * r = Ratio::nearest_from_ratio(dcp->video->size().ratio());
+                               auto const r = Ratio::nearest_from_ratio(dcp->video->size().ratio());
                                if (r) {
                                        _film->set_container(r);
                                }
@@ -628,16 +673,18 @@ private:
 
        void file_add_kdm ()
        {
-               wxFileDialog* d = new wxFileDialog (this, _("Select KDM"));
+               auto d = new wxFileDialog (this, _("Select KDM"));
 
                if (d->ShowModal() == wxID_OK) {
                        DCPOMATIC_ASSERT (_film);
-                       shared_ptr<DCPContent> dcp = boost::dynamic_pointer_cast<DCPContent>(_film->content().front());
+                       auto dcp = std::dynamic_pointer_cast<DCPContent>(_film->content().front());
                        DCPOMATIC_ASSERT (dcp);
                        try {
                                if (dcp) {
+                                       _viewer->set_coalesce_player_changes (true);
                                        dcp->add_kdm (dcp::EncryptedKDM(dcp::file_to_string(wx_to_std(d->GetPath()), MAX_KDM_SIZE)));
-                                       dcp->examine (_film, shared_ptr<Job>());
+                                       examine_content();
+                                       _viewer->set_coalesce_player_changes (false);
                                }
                        } catch (exception& e) {
                                error_dialog (this, wxString::Format (_("Could not load KDM.")), std_to_wx(e.what()));
@@ -652,7 +699,7 @@ private:
 
        void file_history (wxCommandEvent& event)
        {
-               vector<boost::filesystem::path> history = Config::instance()->player_history ();
+               auto history = Config::instance()->player_history ();
                int n = event.GetId() - ID_file_history;
                if (n >= 0 && n < static_cast<int> (history.size ())) {
                        try {
@@ -689,21 +736,24 @@ private:
 
        void view_cpl (wxCommandEvent& ev)
        {
-               shared_ptr<DCPContent> dcp = boost::dynamic_pointer_cast<DCPContent>(_film->content().front());
+               auto dcp = std::dynamic_pointer_cast<DCPContent>(_film->content().front());
                DCPOMATIC_ASSERT (dcp);
                DCPExaminer ex (dcp, true);
                int id = ev.GetId() - ID_view_cpl;
                DCPOMATIC_ASSERT (id >= 0);
                DCPOMATIC_ASSERT (id < int(ex.cpls().size()));
-               list<shared_ptr<dcp::CPL> > cpls = ex.cpls();
-               list<shared_ptr<dcp::CPL> >::iterator i = cpls.begin();
+               auto cpls = ex.cpls();
+               auto i = cpls.begin();
                while (id > 0) {
                        ++i;
                        --id;
                }
 
+               _viewer->set_coalesce_player_changes (true);
                dcp->set_cpl ((*i)->id());
-               dcp->examine (_film, shared_ptr<Job>());
+               examine_content ();
+               _viewer->set_coalesce_player_changes (false);
+
                _info->triggered_update ();
        }
 
@@ -784,21 +834,18 @@ private:
 
        void tools_verify ()
        {
-               shared_ptr<DCPContent> dcp = boost::dynamic_pointer_cast<DCPContent>(_film->content().front());
+               auto dcp = std::dynamic_pointer_cast<DCPContent>(_film->content().front());
                DCPOMATIC_ASSERT (dcp);
 
-               JobManager* jm = JobManager::instance ();
-               jm->add (shared_ptr<Job> (new VerifyDCPJob (dcp->directories())));
-               bool const ok = display_progress (_("DCP-o-matic Player"), _("Verifying DCP"));
-               if (!ok) {
+               auto job = make_shared<VerifyDCPJob>(dcp->directories());
+               auto progress = new VerifyDCPProgressDialog(this, _("DCP-o-matic Player"));
+               bool const completed = progress->run (job);
+               progress->Destroy ();
+               if (!completed) {
                        return;
                }
 
-               DCPOMATIC_ASSERT (!jm->get().empty());
-               shared_ptr<VerifyDCPJob> last = dynamic_pointer_cast<VerifyDCPJob> (jm->get().back());
-               DCPOMATIC_ASSERT (last);
-
-               VerifyDCPDialog* d = new VerifyDCPDialog (this, last);
+               auto d = new VerifyDCPDialog (this, job);
                d->ShowModal ();
                d->Destroy ();
        }
@@ -811,7 +858,7 @@ private:
 
        void tools_timing ()
        {
-               TimerDisplay* d = new TimerDisplay (this, _viewer->state_timer(), _viewer->gets());
+               auto d = new TimerDisplay (this, _viewer->state_timer(), _viewer->gets());
                d->ShowModal ();
                d->Destroy ();
        }
@@ -827,14 +874,14 @@ private:
 
        void help_about ()
        {
-               AboutDialog* d = new AboutDialog (this);
+               auto d = new AboutDialog (this);
                d->ShowModal ();
                d->Destroy ();
        }
 
        void help_report_a_problem ()
        {
-               ReportProblemDialog* d = new ReportProblemDialog (this);
+               auto d = new ReportProblemDialog (this);
                if (d->ShowModal () == wxID_OK) {
                        d->report ();
                }
@@ -843,7 +890,7 @@ private:
 
        void update_checker_state_changed ()
        {
-               UpdateChecker* uc = UpdateChecker::instance ();
+               auto uc = UpdateChecker::instance ();
 
                bool const announce =
                        _update_news_requested ||
@@ -856,11 +903,11 @@ private:
                        return;
                }
 
-               if (uc->state() == UpdateChecker::YES) {
-                       UpdateDialog* dialog = new UpdateDialog (this, uc->stable (), uc->test ());
+               if (uc->state() == UpdateChecker::State::YES) {
+                       auto dialog = new UpdateDialog (this, uc->stable (), uc->test ());
                        dialog->ShowModal ();
                        dialog->Destroy ();
-               } else if (uc->state() == UpdateChecker::FAILED) {
+               } else if (uc->state() == UpdateChecker::State::FAILED) {
                        error_dialog (this, _("The DCP-o-matic download server could not be contacted."));
                } else {
                        error_dialog (this, _("There are no new versions of DCP-o-matic available."));
@@ -904,13 +951,13 @@ private:
                        _file_menu->Remove (_history_separator);
                }
                delete _history_separator;
-               _history_separator = 0;
+               _history_separator = nullptr;
 
                int pos = _history_position;
 
                /* Clear out non-existant history items before we re-build the menu */
                Config::instance()->clean_player_history ();
-               vector<boost::filesystem::path> history = Config::instance()->player_history ();
+               auto history = Config::instance()->player_history ();
 
                if (!history.empty ()) {
                        _history_separator = _file_menu->InsertSeparator (pos++);
@@ -929,11 +976,11 @@ private:
                _history_items = history.size ();
 
                if (prop == Config::PLAYER_DEBUG_LOG) {
-                       optional<boost::filesystem::path> p = Config::instance()->player_debug_log_file();
+                       auto p = Config::instance()->player_debug_log_file();
                        if (p) {
-                               dcpomatic_log.reset (new FileLog(*p));
+                               dcpomatic_log = make_shared<FileLog>(*p);
                        } else {
-                               dcpomatic_log.reset (new NullLog());
+                               dcpomatic_log = make_shared<NullLog>();
                        }
                        dcpomatic_log->set_types (LogEntry::TYPE_GENERAL | LogEntry::TYPE_WARNING | LogEntry::TYPE_ERROR | LogEntry::TYPE_DEBUG_VIDEO_VIEW);
                }
@@ -981,30 +1028,30 @@ private:
                _viewer->seek (_film->length() - _viewer->one_video_frame(), true);
        }
 
-       wxFrame* _dual_screen;
-       bool _update_news_requested;
-       PlayerInformation* _info;
+       wxFrame* _dual_screen = nullptr;
+       bool _update_news_requested = false;
+       PlayerInformation* _info = nullptr;
        Config::PlayerMode _mode;
-       wxPreferencesEditor* _config_dialog;
-       wxPanel* _overall_panel;
-       wxMenu* _file_menu;
-       wxMenuItem* _view_cpl;
-       wxMenu* _cpl_menu;
-       int _history_items;
-       int _history_position;
-       wxMenuItem* _history_separator;
+       wxPreferencesEditor* _config_dialog = nullptr;
+       wxPanel* _overall_panel = nullptr;
+       wxMenu* _file_menu = nullptr;
+       wxMenuItem* _view_cpl = nullptr;
+       wxMenu* _cpl_menu = nullptr;
+       int _history_items = 0;
+       int _history_position = 0;
+       wxMenuItem* _history_separator = nullptr;
        shared_ptr<FilmViewer> _viewer;
        Controls* _controls;
-       SystemInformationDialog* _system_information_dialog;
-       boost::shared_ptr<Film> _film;
+       SystemInformationDialog* _system_information_dialog = nullptr;
+       std::shared_ptr<Film> _film;
        boost::signals2::scoped_connection _config_changed_connection;
        boost::signals2::scoped_connection _examine_job_connection;
-       wxMenuItem* _file_add_ov;
-       wxMenuItem* _file_add_kdm;
-       wxMenuItem* _tools_verify;
-       wxMenuItem* _view_full_screen;
-       wxMenuItem* _view_dual_screen;
-       wxSizer* _main_sizer;
+       wxMenuItem* _file_add_ov = nullptr;
+       wxMenuItem* _file_add_kdm = nullptr;
+       wxMenuItem* _tools_verify = nullptr;
+       wxMenuItem* _view_full_screen = nullptr;
+       wxMenuItem* _view_dual_screen = nullptr;
+       wxSizer* _main_sizer = nullptr;
        PlayerStressTester _stress;
 };
 
@@ -1049,7 +1096,6 @@ class App : public wxApp
 public:
        App ()
                : wxApp ()
-               , _frame (0)
        {
 #ifdef DCPOMATIC_LINUX
                XInitThreads ();
@@ -1060,7 +1106,7 @@ private:
 
        bool OnInit ()
        {
-               wxSplashScreen* splash = 0;
+               wxSplashScreen* splash = nullptr;
                try {
                        wxInitAllImageHandlers ();
 
@@ -1110,12 +1156,19 @@ private:
                        _frame->Maximize ();
                        if (splash) {
                                splash->Destroy ();
-                               splash = 0;
+                               splash = nullptr;
                        }
                        _frame->Show ();
 
-                       PlayServer* server = new PlayServer (_frame);
-                       new thread (boost::bind (&PlayServer::run, server));
+                       try {
+                               auto server = new PlayServer (_frame);
+                               new thread (boost::bind (&PlayServer::run, server));
+                       } catch (std::exception& e) {
+                               /* This is not the end of the world; probably a failure to bind the server socket
+                                * because there's already another player running.
+                                */
+                               LOG_DEBUG_PLAYER ("Failed to start play server (%1)", e.what());
+                       }
 
                        if (!_dcp_to_load.empty() && boost::filesystem::is_directory (_dcp_to_load)) {
                                try {
@@ -1228,7 +1281,7 @@ private:
                message_dialog (_frame, std_to_wx (m));
        }
 
-       DOMFrame* _frame;
+       DOMFrame* _frame = nullptr;
        string _dcp_to_load;
        boost::optional<string> _stress;
 };