Add space next to "use best" button.
[dcpomatic.git] / src / wx / dcp_panel.cc
index d8ddd1bca1be538e3dddc9ca500f82770ce06b37..b3eac1268d25690ee4eb1ee37840814b81bb09c2 100644 (file)
@@ -1,5 +1,5 @@
 /*
-    Copyright (C) 2012-2019 Carl Hetherington <cth@carlh.net>
+    Copyright (C) 2012-2020 Carl Hetherington <cth@carlh.net>
 
     This file is part of DCP-o-matic.
 
@@ -20,7 +20,6 @@
 
 #include "dcp_panel.h"
 #include "wx_util.h"
-#include "key_dialog.h"
 #include "isdcf_metadata_dialog.h"
 #include "audio_dialog.h"
 #include "focus_manager.h"
@@ -42,7 +41,6 @@
 #include "lib/dcp_content.h"
 #include "lib/audio_content.h"
 #include <dcp/locale_convert.h>
-#include <dcp/key.h>
 #include <wx/wx.h>
 #include <wx/notebook.h>
 #include <wx/gbsizer.h>
@@ -103,10 +101,6 @@ DCPPanel::DCPPanel (wxNotebook* n, shared_ptr<Film> film, weak_ptr<FilmViewer> v
         wxSize size = dc.GetTextExtent (wxT ("GGGGGGGG..."));
         size.SetHeight (-1);
 
-       _key_label = create_label (_panel, _("Key"), true);
-       _key = new StaticText (_panel, "", wxDefaultPosition, size);
-       _edit_key = new Button (_panel, _("Edit..."));
-
        _reels_label = create_label (_panel, _("Reels"), true);
        _reel_type = new wxChoice (_panel, wxID_ANY);
 
@@ -117,8 +111,6 @@ DCPPanel::DCPPanel (wxNotebook* n, shared_ptr<Film> film, weak_ptr<FilmViewer> v
        _standard_label = create_label (_panel, _("Standard"), true);
        _standard = new wxChoice (_panel, wxID_ANY);
 
-       _upload_after_make_dcp = new CheckBox (_panel, _("Upload DCP to TMS after it is made"));
-
        _markers = new Button (_panel, _("Markers..."));
        _metadata = new Button (_panel, _("Metadata..."));
 
@@ -134,11 +126,9 @@ DCPPanel::DCPPanel (wxNotebook* n, shared_ptr<Film> film, weak_ptr<FilmViewer> v
        _copy_isdcf_name_button->Bind(wxEVT_BUTTON,   boost::bind (&DCPPanel::copy_isdcf_name_button_clicked, this));
        _dcp_content_type->Bind      (wxEVT_CHOICE,   boost::bind (&DCPPanel::dcp_content_type_changed, this));
        _encrypted->Bind             (wxEVT_CHECKBOX, boost::bind (&DCPPanel::encrypted_toggled, this));
-       _edit_key->Bind              (wxEVT_BUTTON,   boost::bind (&DCPPanel::edit_key_clicked, this));
        _reel_type->Bind             (wxEVT_CHOICE,   boost::bind (&DCPPanel::reel_type_changed, this));
        _reel_length->Bind           (wxEVT_SPINCTRL, boost::bind (&DCPPanel::reel_length_changed, this));
        _standard->Bind              (wxEVT_CHOICE,   boost::bind (&DCPPanel::standard_changed, this));
-       _upload_after_make_dcp->Bind (wxEVT_CHECKBOX, boost::bind (&DCPPanel::upload_after_make_dcp_changed, this));
        _markers->Bind               (wxEVT_BUTTON,   boost::bind (&DCPPanel::markers_clicked, this));
        _metadata->Bind              (wxEVT_BUTTON,   boost::bind (&DCPPanel::metadata_clicked, this));
 
@@ -205,9 +195,6 @@ DCPPanel::add_to_grid ()
        ++r;
 
 
-       _key_label->Show (full);
-       _key->Show (full);
-       _edit_key->Show (full);
        _reels_label->Show (full);
        _reel_type->Show (full);
        _reel_length_label->Show (full);
@@ -215,22 +202,12 @@ DCPPanel::add_to_grid ()
        _reel_length_gb_label->Show (full);
        _standard_label->Show (full);
        _standard->Show (full);
-       _upload_after_make_dcp->Show (full);
        _markers->Show (full);
        _metadata->Show (full);
        _reencode_j2k->Show (full);
        _encrypted->Show (full);
 
        if (full) {
-               add_label_to_sizer (_grid, _key_label, true, wxGBPosition (r, 0));
-               {
-                       wxBoxSizer* s = new wxBoxSizer (wxHORIZONTAL);
-                       s->Add (_key, 1, wxALIGN_CENTER_VERTICAL);
-                       s->Add (_edit_key);
-                       _grid->Add (s, wxGBPosition (r, 1));
-               }
-               ++r;
-
                add_label_to_sizer (_grid, _reels_label, true, wxGBPosition (r, 0));
                _grid->Add (_reel_type, wxGBPosition (r, 1), wxDefaultSpan, wxALIGN_CENTER_VERTICAL);
                ++r;
@@ -248,9 +225,6 @@ DCPPanel::add_to_grid ()
                _grid->Add (_standard, wxGBPosition (r, 1), wxDefaultSpan, wxALIGN_CENTER_VERTICAL);
                ++r;
 
-               _grid->Add (_upload_after_make_dcp, wxGBPosition (r, 0), wxGBSpan (1, 2));
-               ++r;
-
                wxBoxSizer* extra = new wxBoxSizer (wxHORIZONTAL);
                extra->Add (_markers, 1, wxRIGHT, DCPOMATIC_SIZER_X_GAP);
                extra->Add (_metadata, 1, wxRIGHT, DCPOMATIC_SIZER_X_GAP);
@@ -259,16 +233,6 @@ DCPPanel::add_to_grid ()
        }
 }
 
-void
-DCPPanel::edit_key_clicked ()
-{
-       KeyDialog* d = new KeyDialog (_panel, _film->key ());
-       if (d->ShowModal () == wxID_OK) {
-               _film->set_key (d->key ());
-       }
-       d->Destroy ();
-}
-
 void
 DCPPanel::name_changed ()
 {
@@ -356,16 +320,6 @@ DCPPanel::standard_changed ()
        _film->set_interop (_standard->GetSelection() == 1);
 }
 
-void
-DCPPanel::upload_after_make_dcp_changed ()
-{
-       if (!_film) {
-               return;
-       }
-
-       _film->set_upload_after_make_dcp (_upload_after_make_dcp->GetValue ());
-}
-
 void
 DCPPanel::markers_clicked ()
 {
@@ -409,16 +363,6 @@ DCPPanel::film_changed (int p)
                break;
        case Film::ENCRYPTED:
                checked_set (_encrypted, _film->encrypted ());
-               if (_film->encrypted ()) {
-                       _key->Enable (_generally_sensitive);
-                       _edit_key->Enable (_generally_sensitive);
-               } else {
-                       _key->Enable (false);
-                       _edit_key->Enable (false);
-               }
-               break;
-       case Film::KEY:
-               checked_set (_key, _film->key().hex().substr (0, 8) + "...");
                break;
        case Film::RESOLUTION:
                checked_set (_resolution, _film->resolution() == RESOLUTION_2K ? 0 : 1);
@@ -505,9 +449,6 @@ DCPPanel::film_changed (int p)
        case Film::REEL_LENGTH:
                checked_set (_reel_length, _film->reel_length() / 1000000000LL);
                break;
-       case Film::UPLOAD_AFTER_MAKE_DCP:
-               checked_set (_upload_after_make_dcp, _film->upload_after_make_dcp ());
-               break;
        case Film::CONTENT:
                setup_dcp_name ();
                break;
@@ -618,7 +559,6 @@ DCPPanel::set_film (shared_ptr<Film> film)
        film_changed (Film::CONTAINER);
        film_changed (Film::RESOLUTION);
        film_changed (Film::ENCRYPTED);
-       film_changed (Film::KEY);
        film_changed (Film::J2K_BANDWIDTH);
        film_changed (Film::ISDCF_METADATA);
        film_changed (Film::VIDEO_FRAME_RATE);
@@ -629,7 +569,6 @@ DCPPanel::set_film (shared_ptr<Film> film)
        film_changed (Film::AUDIO_PROCESSOR);
        film_changed (Film::REEL_TYPE);
        film_changed (Film::REEL_LENGTH);
-       film_changed (Film::UPLOAD_AFTER_MAKE_DCP);
        film_changed (Film::REENCODE_J2K);
 
        set_general_sensitivity(static_cast<bool>(_film));
@@ -650,18 +589,9 @@ DCPPanel::setup_sensitivity ()
        _edit_isdcf_button->Enable      (_generally_sensitive);
        _dcp_content_type->Enable       (_generally_sensitive);
        _copy_isdcf_name_button->Enable (_generally_sensitive);
-
-       bool si = _generally_sensitive;
-       if (_film && _film->encrypted ()) {
-               si = false;
-       }
-
        _encrypted->Enable              (_generally_sensitive);
-       _key->Enable                    (_generally_sensitive && _film && _film->encrypted ());
-       _edit_key->Enable               (_generally_sensitive && _film && _film->encrypted ());
        _reel_type->Enable              (_generally_sensitive && _film && !_film->references_dcp_video() && !_film->references_dcp_audio());
        _reel_length->Enable            (_generally_sensitive && _film && _film->reel_type() == REELTYPE_BY_LENGTH);
-       _upload_after_make_dcp->Enable  (_generally_sensitive);
        _markers->Enable                (_generally_sensitive && _film && !_film->interop());
        _metadata->Enable               (_generally_sensitive);
        _frame_rate_choice->Enable      (_generally_sensitive && _film && !_film->references_dcp_video());
@@ -776,8 +706,6 @@ DCPPanel::setup_frame_rate_widget ()
                _frame_rate_choice->Show ();
                _frame_rate_spin->Hide ();
        }
-
-       _frame_rate_sizer->Layout ();
 }
 
 wxPanel *
@@ -798,13 +726,9 @@ DCPPanel::make_video_panel ()
 
        _frame_rate_label = create_label (panel, _("Frame Rate"), true);
        _frame_rate_choice = new wxChoice (panel, wxID_ANY);
-       _frame_rate_sizer = new wxBoxSizer (wxHORIZONTAL);
-       _frame_rate_sizer->Add (_frame_rate_choice, 1, wxALIGN_CENTER_VERTICAL);
        _frame_rate_spin = new wxSpinCtrl (panel, wxID_ANY);
-       _frame_rate_sizer->Add (_frame_rate_spin, 1, wxALIGN_CENTER_VERTICAL);
        setup_frame_rate_widget ();
        _best_frame_rate = new Button (panel, _("Use best"));
-       _frame_rate_sizer->Add (_best_frame_rate, 1, wxALIGN_CENTER_VERTICAL);
 
        _three_d = new CheckBox (panel, _("3D"));
 
@@ -869,7 +793,7 @@ DCPPanel::add_video_panel_to_grid ()
                _frame_rate_sizer = new wxBoxSizer (wxHORIZONTAL);
                _frame_rate_sizer->Add (_frame_rate_choice, 1, wxALIGN_CENTER_VERTICAL);
                _frame_rate_sizer->Add (_frame_rate_spin, 1, wxALIGN_CENTER_VERTICAL);
-               _frame_rate_sizer->Add (_best_frame_rate, 1, wxALIGN_CENTER_VERTICAL);
+               _frame_rate_sizer->Add (_best_frame_rate, 1, wxLEFT | wxALIGN_CENTER_VERTICAL, DCPOMATIC_SIZER_X_GAP);
                _video_grid->Add (_frame_rate_sizer, wxGBPosition (r, 1));
                ++r;
        }