BOOST_FOREACH.
[dcpomatic.git] / src / wx / timing_panel.cc
index f64a84f7a15231e891871e5d71d7e86223bd6ed9..ecf55640dc3f7cd5655ea482cfe639c4920293c1 100644 (file)
@@ -1,5 +1,5 @@
 /*
-    Copyright (C) 2012-2016 Carl Hetherington <cth@carlh.net>
+    Copyright (C) 2012-2018 Carl Hetherington <cth@carlh.net>
 
     This file is part of DCP-o-matic.
 
@@ -24,6 +24,8 @@
 #include "timecode.h"
 #include "content_panel.h"
 #include "move_to_dialog.h"
+#include "static_text.h"
+#include "dcpomatic_button.h"
 #include "lib/content.h"
 #include "lib/image_content.h"
 #include "lib/text_content.h"
 #include "lib/audio_content.h"
 #include "lib/string_text_file_content.h"
 #include "lib/video_content.h"
+#include "lib/dcp_content.h"
+#include "lib/ffmpeg_content.h"
 #include <dcp/locale_convert.h>
-#include <boost/foreach.hpp>
+#include "lib/warnings.h"
+#if defined(__WXGTK20__) && !defined(__WXGTK3__)
+#define TIMING_PANEL_ALIGNMENT_HACK 1
+DCPOMATIC_DISABLE_WARNINGS
+#include <gtk/gtk.h>
+DCPOMATIC_ENABLE_WARNINGS
+#endif
 #include <set>
 #include <iostream>
 
 using std::cout;
 using std::string;
 using std::set;
-using boost::shared_ptr;
-using boost::dynamic_pointer_cast;
+using std::shared_ptr;
+using std::weak_ptr;
+using std::dynamic_pointer_cast;
 using boost::optional;
+#if BOOST_VERSION >= 106100
+using namespace boost::placeholders;
+#endif
 using dcp::locale_convert;
+using namespace dcpomatic;
 
-TimingPanel::TimingPanel (ContentPanel* p, ControlFilmViewer* viewer)
+TimingPanel::TimingPanel (ContentPanel* p, weak_ptr<FilmViewer> viewer)
        /* horrid hack for apparent lack of context support with wxWidgets i18n code */
        /// TRANSLATORS: translate the word "Timing" here; do not include the "Timing|" prefix
        : ContentSubPanel (p, S_("Timing|Timing"))
        , _viewer (viewer)
+       , _film_content_changed_suspender (boost::bind(&TimingPanel::film_content_changed, this, _1))
 {
        wxSize size = TimecodeBase::size (this);
 
@@ -57,71 +73,41 @@ TimingPanel::TimingPanel (ContentPanel* p, ControlFilmViewer* viewer)
        }
 
        //// TRANSLATORS: this is an abbreviation for "hours"
-       _h_label = new wxStaticText (this, wxID_ANY, _("h"), wxDefaultPosition, size, wxALIGN_CENTRE_HORIZONTAL);
-#ifdef DCPOMATIC_LINUX
+       _h_label = new StaticText (this, _("h"), wxDefaultPosition, size, wxALIGN_CENTRE_HORIZONTAL);
+#ifdef TIMING_PANEL_ALIGNMENT_HACK
        /* Hack to work around failure to centre text on GTK */
        gtk_label_set_line_wrap (GTK_LABEL(_h_label->GetHandle()), FALSE);
 #endif
        //// TRANSLATORS: this is an abbreviation for "minutes"
-       _m_label = new wxStaticText (this, wxID_ANY, _("m"), wxDefaultPosition, size, wxALIGN_CENTRE_HORIZONTAL);
-#ifdef DCPOMATIC_LINUX
+       _m_label = new StaticText (this, _("m"), wxDefaultPosition, size, wxALIGN_CENTRE_HORIZONTAL);
+#ifdef TIMING_PANEL_ALIGNMENT_HACK
        gtk_label_set_line_wrap (GTK_LABEL (_m_label->GetHandle()), FALSE);
 #endif
        //// TRANSLATORS: this is an abbreviation for "seconds"
-       _s_label = new wxStaticText (this, wxID_ANY, _("s"), wxDefaultPosition, size, wxALIGN_CENTRE_HORIZONTAL);
-#ifdef DCPOMATIC_LINUX
+       _s_label = new StaticText (this, _("s"), wxDefaultPosition, size, wxALIGN_CENTRE_HORIZONTAL);
+#ifdef TIMING_PANEL_ALIGNMENT_HACK
        gtk_label_set_line_wrap (GTK_LABEL(_s_label->GetHandle()), FALSE);
 #endif
        //// TRANSLATORS: this is an abbreviation for "frames"
-       _f_label = new wxStaticText (this, wxID_ANY, _("f"), wxDefaultPosition, size, wxALIGN_CENTRE_HORIZONTAL);
-#ifdef DCPOMATIC_LINUX
+       _f_label = new StaticText (this, _("f"), wxDefaultPosition, size, wxALIGN_CENTRE_HORIZONTAL);
+#ifdef TIMING_PANEL_ALIGNMENT_HACK
        gtk_label_set_line_wrap (GTK_LABEL(_f_label->GetHandle()), FALSE);
 #endif
 
        _position_label = create_label (this, _("Position"), true);
        _position = new Timecode<DCPTime> (this);
-       _move_to_start_of_reel = new wxButton (this, wxID_ANY, _("Move to start of reel"));
+       _move_to_start_of_reel = new Button (this, _("Move to start of reel"));
        _full_length_label = create_label (this, _("Full length"), true);
        _full_length = new Timecode<DCPTime> (this);
        _trim_start_label = create_label (this, _("Trim from start"), true);
        _trim_start = new Timecode<ContentTime> (this);
-       _trim_start_to_playhead = new wxButton (this, wxID_ANY, _("Trim up to current position"));
+       _trim_start_to_playhead = new Button (this, _("Trim up to current position"));
        _trim_end_label = create_label (this, _("Trim from end"), true);
        _trim_end = new Timecode<ContentTime> (this);
-       _trim_end_to_playhead = new wxButton (this, wxID_ANY, _("Trim after current position"));
+       _trim_end_to_playhead = new Button (this, _("Trim from current position to end"));
        _play_length_label = create_label (this, _("Play length"), true);
        _play_length = new Timecode<DCPTime> (this);
 
-       _video_frame_rate_label = create_label (this, _("Video frame rate"), true);
-       _video_frame_rate = new wxTextCtrl (this, wxID_ANY);
-       _set_video_frame_rate = new wxButton (this, wxID_ANY, _("Set"));
-       _set_video_frame_rate->Enable (false);
-
-       /* We can't use Wrap() here as it doesn't work with markup:
-        * http://trac.wxwidgets.org/ticket/13389
-        */
-
-       wxString in = _("<i>Only change this if the content's frame rate has been read incorrectly.</i>");
-       wxString out;
-       int const width = 20;
-       int current = 0;
-       for (size_t i = 0; i < in.Length(); ++i) {
-               if (in[i] == ' ' && current >= width) {
-                       out += '\n';
-                       current = 0;
-               } else {
-                       out += in[i];
-                       ++current;
-               }
-       }
-
-       _tip = new wxStaticText (this, wxID_ANY, wxT (""));
-       _tip->SetLabelMarkup (out);
-#ifdef DCPOMATIC_OSX
-       /* Hack to stop hidden text on some versions of OS X */
-       _tip->SetMinSize (wxSize (-1, 256));
-#endif
-
        _position->Changed.connect    (boost::bind (&TimingPanel::position_changed, this));
        _move_to_start_of_reel->Bind  (wxEVT_BUTTON, boost::bind (&TimingPanel::move_to_start_of_reel_clicked, this));
        _full_length->Changed.connect (boost::bind (&TimingPanel::full_length_changed, this));
@@ -130,10 +116,10 @@ TimingPanel::TimingPanel (ContentPanel* p, ControlFilmViewer* viewer)
        _trim_end->Changed.connect    (boost::bind (&TimingPanel::trim_end_changed, this));
        _trim_end_to_playhead->Bind   (wxEVT_BUTTON, boost::bind (&TimingPanel::trim_end_to_playhead_clicked, this));
        _play_length->Changed.connect (boost::bind (&TimingPanel::play_length_changed, this));
-       _video_frame_rate->Bind       (wxEVT_TEXT, boost::bind (&TimingPanel::video_frame_rate_changed, this));
-       _set_video_frame_rate->Bind   (wxEVT_BUTTON, boost::bind (&TimingPanel::set_video_frame_rate, this));
 
-       _viewer->ImageChanged.connect (boost::bind (&TimingPanel::setup_sensitivity, this));
+       shared_ptr<FilmViewer> fv = _viewer.lock ();
+       DCPOMATIC_ASSERT (fv);
+       fv->ImageChanged.connect (boost::bind (&TimingPanel::setup_sensitivity, this));
 
        setup_sensitivity ();
        add_to_grid ();
@@ -142,8 +128,6 @@ TimingPanel::TimingPanel (ContentPanel* p, ControlFilmViewer* viewer)
 void
 TimingPanel::add_to_grid ()
 {
-       bool const full = Config::instance()->interface_complexity() == Config::INTERFACE_FULL;
-
        int r = 0;
 
        wxSizer* labels = new wxBoxSizer (wxHORIZONTAL);
@@ -161,59 +145,30 @@ TimingPanel::add_to_grid ()
        _grid->Add (_position, wxGBPosition(r, 1));
        ++r;
 
-       _move_to_start_of_reel->Show (full);
-       _full_length_label->Show (full);
-       _full_length->Show (full);
-       _trim_start_label->Show (full);
-       _trim_start->Show (full);
-       _trim_start_to_playhead->Show (full);
-       _trim_end_label->Show (full);
-       _trim_end->Show (full);
-       _trim_end_to_playhead->Show (full);
-       _play_length_label->Show (full);
-       _play_length->Show (full);
-       _video_frame_rate_label->Show (full);
-       _video_frame_rate->Show (full);
-       _set_video_frame_rate->Show (full);
-       _tip->Show (full);
-
-       if (full) {
-               _grid->Add (_move_to_start_of_reel, wxGBPosition(r, 1));
-               ++r;
-
-               add_label_to_sizer (_grid, _full_length_label, true, wxGBPosition(r, 0));
-               _grid->Add (_full_length, wxGBPosition(r, 1));
-               ++r;
-
-               add_label_to_sizer (_grid, _trim_start_label, true, wxGBPosition(r, 0));
-               _grid->Add (_trim_start, wxGBPosition(r, 1));
-               ++r;
-
-               _grid->Add (_trim_start_to_playhead, wxGBPosition(r, 1));
-               ++r;
-
-               add_label_to_sizer (_grid, _trim_end_label, true, wxGBPosition(r, 0));
-               _grid->Add (_trim_end, wxGBPosition(r, 1));
-               ++r;
-
-               _grid->Add (_trim_end_to_playhead, wxGBPosition(r, 1));
-               ++r;
-
-               add_label_to_sizer (_grid, _play_length_label, true, wxGBPosition(r, 0));
-               _grid->Add (_play_length, wxGBPosition(r, 1));
-               ++r;
-
-               {
-                       add_label_to_sizer (_grid, _video_frame_rate_label, true, wxGBPosition(r, 0));
-                       wxBoxSizer* s = new wxBoxSizer (wxHORIZONTAL);
-                       s->Add (_video_frame_rate, 1, wxEXPAND);
-                       s->Add (_set_video_frame_rate, 0, wxLEFT | wxRIGHT, 8);
-                       _grid->Add (s, wxGBPosition(r, 1), wxGBSpan(1, 2));
-               }
-               ++r;
+       _grid->Add (_move_to_start_of_reel, wxGBPosition(r, 1));
+       ++r;
 
-               _grid->Add (_tip, wxGBPosition(r, 1), wxGBSpan(1, 2));
-       }
+       add_label_to_sizer (_grid, _full_length_label, true, wxGBPosition(r, 0));
+       _grid->Add (_full_length, wxGBPosition(r, 1));
+       ++r;
+
+       add_label_to_sizer (_grid, _trim_start_label, true, wxGBPosition(r, 0));
+       _grid->Add (_trim_start, wxGBPosition(r, 1));
+       ++r;
+
+       _grid->Add (_trim_start_to_playhead, wxGBPosition(r, 1));
+       ++r;
+
+       add_label_to_sizer (_grid, _trim_end_label, true, wxGBPosition(r, 0));
+       _grid->Add (_trim_end, wxGBPosition(r, 1));
+       ++r;
+
+       _grid->Add (_trim_end_to_playhead, wxGBPosition(r, 1));
+       ++r;
+
+       add_label_to_sizer (_grid, _play_length_label, true, wxGBPosition(r, 0));
+       _grid->Add (_play_length, wxGBPosition(r, 1));
+       ++r;
 
        /* Completely speculative fix for #891 */
        _grid->Layout ();
@@ -223,12 +178,12 @@ void
 TimingPanel::update_full_length ()
 {
        set<DCPTime> check;
-       BOOST_FOREACH (shared_ptr<const Content> i, _parent->selected ()) {
-               check.insert (i->full_length ());
+       for (auto i: _parent->selected()) {
+               check.insert (i->full_length(_parent->film()));
        }
 
        if (check.size() == 1) {
-               _full_length->set (_parent->selected().front()->full_length (), _parent->film()->video_frame_rate ());
+               _full_length->set (_parent->selected().front()->full_length(_parent->film()), _parent->film()->video_frame_rate());
        } else {
                _full_length->clear ();
        }
@@ -238,12 +193,12 @@ void
 TimingPanel::update_play_length ()
 {
        set<DCPTime> check;
-       BOOST_FOREACH (shared_ptr<const Content> i, _parent->selected ()) {
-               check.insert (i->length_after_trim ());
+       for (auto i: _parent->selected()) {
+               check.insert (i->length_after_trim(_parent->film()));
        }
 
        if (check.size() == 1) {
-               _play_length->set (_parent->selected().front()->length_after_trim (), _parent->film()->video_frame_rate ());
+               _play_length->set (_parent->selected().front()->length_after_trim(_parent->film()), _parent->film()->video_frame_rate());
        } else {
                _play_length->clear ();
        }
@@ -252,6 +207,10 @@ TimingPanel::update_play_length ()
 void
 TimingPanel::film_content_changed (int property)
 {
+       if (_film_content_changed_suspender.check(property)) {
+               return;
+       }
+
        int const film_video_frame_rate = _parent->film()->video_frame_rate ();
 
        /* Here we check to see if we have exactly one different value of various
@@ -261,7 +220,7 @@ TimingPanel::film_content_changed (int property)
        if (property == ContentProperty::POSITION) {
 
                set<DCPTime> check;
-               BOOST_FOREACH (shared_ptr<const Content> i, _parent->selected ()) {
+               for (auto i: _parent->selected()) {
                        check.insert (i->position ());
                }
 
@@ -282,7 +241,7 @@ TimingPanel::film_content_changed (int property)
        } else if (property == ContentProperty::TRIM_START) {
 
                set<ContentTime> check;
-               BOOST_FOREACH (shared_ptr<const Content> i, _parent->selected ()) {
+               for (auto i: _parent->selected()) {
                        check.insert (i->trim_start ());
                }
 
@@ -295,7 +254,7 @@ TimingPanel::film_content_changed (int property)
        } else if (property == ContentProperty::TRIM_END) {
 
                set<ContentTime> check;
-               BOOST_FOREACH (shared_ptr<const Content> i, _parent->selected ()) {
+               for (auto i: _parent->selected()) {
                        check.insert (i->trim_end ());
                }
 
@@ -322,7 +281,7 @@ TimingPanel::film_content_changed (int property)
                shared_ptr<const Content> content;
                int count_ac = 0;
                int count_sc = 0;
-               BOOST_FOREACH (shared_ptr<const Content> i, _parent->selected ()) {
+               for (auto i: _parent->selected()) {
                        if (i->video && i->video_frame_rate()) {
                                check_vc.insert (i->video_frame_rate().get());
                                content = i;
@@ -337,20 +296,10 @@ TimingPanel::film_content_changed (int property)
                        }
 
                }
-
-               bool const single_frame_image_content = content && dynamic_pointer_cast<const ImageContent> (content) && content->number_of_paths() == 1;
-
-               if ((check_vc.size() == 1 || count_ac == 1 || count_sc == 1) && !single_frame_image_content) {
-                       checked_set (_video_frame_rate, locale_convert<string> (content->video_frame_rate().get(), 5));
-                       _video_frame_rate->Enable (true);
-               } else {
-                       checked_set (_video_frame_rate, wxT (""));
-                       _video_frame_rate->Enable (false);
-               }
        }
 
        bool have_still = false;
-       BOOST_FOREACH (shared_ptr<const Content> i, _parent->selected ()) {
+       for (auto i: _parent->selected()) {
                shared_ptr<const ImageContent> ic = dynamic_pointer_cast<const ImageContent> (i);
                if (ic && ic->still ()) {
                        have_still = true;
@@ -359,7 +308,6 @@ TimingPanel::film_content_changed (int property)
 
        _full_length->set_editable (have_still);
        _play_length->set_editable (!have_still);
-       _set_video_frame_rate->Enable (false);
        setup_sensitivity ();
 }
 
@@ -367,8 +315,8 @@ void
 TimingPanel::position_changed ()
 {
        DCPTime const pos = _position->get (_parent->film()->video_frame_rate ());
-       BOOST_FOREACH (shared_ptr<Content> i, _parent->selected ()) {
-               i->set_position (pos);
+       for (auto i: _parent->selected()) {
+               i->set_position (_parent->film(), pos);
        }
 }
 
@@ -377,7 +325,7 @@ TimingPanel::full_length_changed ()
 {
        int const vfr = _parent->film()->video_frame_rate ();
        Frame const len = _full_length->get (vfr).frames_round (vfr);
-       BOOST_FOREACH (shared_ptr<Content> i, _parent->selected ()) {
+       for (auto i: _parent->selected()) {
                shared_ptr<ImageContent> ic = dynamic_pointer_cast<ImageContent> (i);
                if (ic && ic->still ()) {
                        ic->video->set_length (len);
@@ -388,18 +336,22 @@ TimingPanel::full_length_changed ()
 void
 TimingPanel::trim_start_changed ()
 {
-       DCPTime const ph = _viewer->position ();
+       shared_ptr<FilmViewer> fv = _viewer.lock ();
+       if (!fv) {
+               return;
+       }
+
+       DCPTime const ph = fv->position ();
 
-       _viewer->set_coalesce_player_changes (true);
+       fv->set_coalesce_player_changes (true);
 
        shared_ptr<Content> ref;
        optional<FrameRateChange> ref_frc;
        optional<DCPTime> ref_ph;
 
-       ContentTime const trim = _trim_start->get (_parent->film()->video_frame_rate ());
-
-       BOOST_FOREACH (shared_ptr<Content> i, _parent->selected ()) {
-               if (i->position() <= ph && ph < i->end()) {
+       Suspender::Block bl = _film_content_changed_suspender.block ();
+       for (auto i: _parent->selected()) {
+               if (i->position() <= ph && ph < i->end(_parent->film())) {
                        /* The playhead is in i.  Use it as a reference to work out
                           where to put the playhead post-trim; we're trying to keep the playhead
                           at the same frame of content that we're looking at pre-trim.
@@ -409,69 +361,54 @@ TimingPanel::trim_start_changed ()
                        ref_ph = ph - i->position() + DCPTime (i->trim_start(), ref_frc.get());
                }
 
+               ContentTime const trim = _trim_start->get (i->video_frame_rate().get_value_or(_parent->film()->video_frame_rate()));
                i->set_trim_start (trim);
        }
 
        if (ref) {
-               _viewer->set_position (max (DCPTime(), ref_ph.get() + ref->position() - DCPTime (ref->trim_start(), ref_frc.get())));
+               fv->seek (max(DCPTime(), ref_ph.get() + ref->position() - DCPTime(ref->trim_start(), ref_frc.get())), true);
        }
 
-       _viewer->set_coalesce_player_changes (false);
+       fv->set_coalesce_player_changes (false);
 }
 
 void
 TimingPanel::trim_end_changed ()
 {
-       _viewer->set_coalesce_player_changes (true);
+       shared_ptr<FilmViewer> fv = _viewer.lock ();
+       if (!fv) {
+               return;
+       }
+
+       fv->set_coalesce_player_changes (true);
 
-       ContentTime const trim = _trim_end->get (_parent->film()->video_frame_rate ());
-       BOOST_FOREACH (shared_ptr<Content> i, _parent->selected ()) {
+       Suspender::Block bl = _film_content_changed_suspender.block ();
+       for (auto i: _parent->selected()) {
+               ContentTime const trim = _trim_end->get (i->video_frame_rate().get_value_or(_parent->film()->video_frame_rate()));
                i->set_trim_end (trim);
        }
 
        /* XXX: maybe playhead-off-the-end-of-the-film should be handled elsewhere */
-       if (_viewer->position() >= _parent->film()->length()) {
-               _viewer->set_position (_parent->film()->length() - DCPTime::from_frames (1, _parent->film()->video_frame_rate()));
+       if (fv->position() >= _parent->film()->length()) {
+               fv->seek (_parent->film()->length() - DCPTime::from_frames(1, _parent->film()->video_frame_rate()), true);
        }
 
-       _viewer->set_coalesce_player_changes (true);
+       fv->set_coalesce_player_changes (false);
 }
 
 void
 TimingPanel::play_length_changed ()
 {
        DCPTime const play_length = _play_length->get (_parent->film()->video_frame_rate());
-       BOOST_FOREACH (shared_ptr<Content> i, _parent->selected ()) {
+       Suspender::Block bl = _film_content_changed_suspender.block ();
+       for (auto i: _parent->selected()) {
                FrameRateChange const frc = _parent->film()->active_frame_rate_change (i->position ());
                i->set_trim_end (
-                       ContentTime (max(DCPTime(), i->full_length() - play_length), frc) - i->trim_start ()
+                       ContentTime (max(DCPTime(), i->full_length(_parent->film()) - play_length), frc) - i->trim_start()
                        );
        }
 }
 
-void
-TimingPanel::video_frame_rate_changed ()
-{
-       _set_video_frame_rate->Enable (true);
-}
-
-void
-TimingPanel::set_video_frame_rate ()
-{
-       optional<double> fr;
-       if (_video_frame_rate->GetValue() != wxT("")) {
-               fr = locale_convert<double> (wx_to_std (_video_frame_rate->GetValue ()));
-       }
-       BOOST_FOREACH (shared_ptr<Content> i, _parent->selected ()) {
-               if (fr) {
-                       i->set_video_frame_rate (*fr);
-               } else {
-                       i->unset_video_frame_rate ();
-               }
-       }
-
-       _set_video_frame_rate->Enable (false);
-}
 
 void
 TimingPanel::content_selection_changed ()
@@ -497,36 +434,46 @@ TimingPanel::film_changed (Film::Property p)
 void
 TimingPanel::trim_start_to_playhead_clicked ()
 {
+       shared_ptr<FilmViewer> fv = _viewer.lock ();
+       if (!fv) {
+               return;
+       }
+
        shared_ptr<const Film> film = _parent->film ();
-       DCPTime const ph = _viewer->position().floor (film->video_frame_rate ());
+       DCPTime const ph = fv->position().floor (film->video_frame_rate ());
        optional<DCPTime> new_ph;
 
-       _viewer->set_coalesce_player_changes (true);
+       fv->set_coalesce_player_changes (true);
 
-       BOOST_FOREACH (shared_ptr<Content> i, _parent->selected ()) {
-               if (i->position() < ph && ph < i->end ()) {
-                       FrameRateChange const frc = film->active_frame_rate_change (i->position ());
-                       i->set_trim_start (i->trim_start() + ContentTime (ph - i->position (), frc));
+       for (auto i: _parent->selected()) {
+               if (i->position() < ph && ph < i->end(film)) {
+                       FrameRateChange const frc = film->active_frame_rate_change (i->position());
+                       i->set_trim_start (i->trim_start() + ContentTime (ph - i->position(), frc));
                        new_ph = i->position ();
                }
        }
 
+       fv->set_coalesce_player_changes (false);
+
        if (new_ph) {
-               _viewer->set_position (new_ph.get());
+               fv->seek (new_ph.get(), true);
        }
-
-       _viewer->set_coalesce_player_changes (false);
 }
 
 void
 TimingPanel::trim_end_to_playhead_clicked ()
 {
+       shared_ptr<FilmViewer> fv = _viewer.lock ();
+       if (!fv) {
+               return;
+       }
+
        shared_ptr<const Film> film = _parent->film ();
-       DCPTime const ph = _viewer->position().floor (film->video_frame_rate ());
-       BOOST_FOREACH (shared_ptr<Content> i, _parent->selected ()) {
-               if (i->position() < ph && ph < i->end ()) {
+       DCPTime const ph = fv->position().floor (film->video_frame_rate ());
+       for (auto i: _parent->selected()) {
+               if (i->position() < ph && ph < i->end(film)) {
                        FrameRateChange const frc = film->active_frame_rate_change (i->position ());
-                       i->set_trim_end (ContentTime (i->position() + i->full_length() - ph - DCPTime::from_frames (1, frc.dcp), frc) - i->trim_start());
+                       i->set_trim_end (ContentTime(i->position() + i->full_length(film) - ph, frc) - i->trim_start());
                }
        }
 }
@@ -542,12 +489,13 @@ TimingPanel::setup_sensitivity ()
        _trim_start->Enable (e);
        _trim_end->Enable (e);
        _play_length->Enable (e);
-       _video_frame_rate->Enable (e);
 
-       DCPTime const ph = _viewer->position ();
+       shared_ptr<FilmViewer> fv = _viewer.lock ();
+       DCPOMATIC_ASSERT (fv);
+       DCPTime const ph = fv->position ();
        bool any_over_ph = false;
-       BOOST_FOREACH (shared_ptr<const Content> i, _parent->selected ()) {
-               if (i->position() <= ph && ph < i->end()) {
+       for (auto i: _parent->selected()) {
+               if (i->position() <= ph && ph < i->end(_parent->film())) {
                        any_over_ph = true;
                }
        }
@@ -562,7 +510,7 @@ TimingPanel::move_to_start_of_reel_clicked ()
        /* Find common position of all selected content, if it exists */
 
        optional<DCPTime> position;
-       BOOST_FOREACH (shared_ptr<Content> i, _parent->selected ()) {
+       for (auto i: _parent->selected()) {
                if (!position) {
                        position = i->position();
                } else {
@@ -576,8 +524,8 @@ TimingPanel::move_to_start_of_reel_clicked ()
        MoveToDialog* d = new MoveToDialog (this, position, _parent->film());
 
        if (d->ShowModal() == wxID_OK) {
-               BOOST_FOREACH (shared_ptr<Content> i, _parent->selected ()) {
-                       i->set_position (d->position ());
+               for (auto i: _parent->selected()) {
+                       i->set_position (_parent->film(), d->position());
                }
        }
        d->Destroy ();