Fix typo if -> of (thanks to Uwe Dittes)

[dcpomatic.git] / test / film_metadata_test.cc

diff --git a/test/film_metadata_test.cc b/test/film_metadata_test.cc
index 01cff5b06c46fbb993eb397f68bdefc9a1329a0e..92c06210a7f3a4b46440464b7f5628da7a197762 100644 (file)
--- a/test/film_metadata_test.cc
+++ b/test/film_metadata_test.cc
@@ -1,64 +1,103 @@
 /*
     Copyright (C) 2013-2014 Carl Hetherington <cth@carlh.net>
 
-    This program is free software; you can redistribute it and/or modify
+    This file is part of DCP-o-matic.
+
+    DCP-o-matic is free software; you can redistribute it and/or modify
     it under the terms of the GNU General Public License as published by
     the Free Software Foundation; either version 2 of the License, or
     (at your option) any later version.
 
-    This program is distributed in the hope that it will be useful,
+    DCP-o-matic is distributed in the hope that it will be useful,
     but WITHOUT ANY WARRANTY; without even the implied warranty of
     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
     GNU General Public License for more details.
 
     You should have received a copy of the GNU General Public License
-    along with this program; if not, write to the Free Software
-    Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+    along with DCP-o-matic.  If not, see <http://www.gnu.org/licenses/>.
 
 */
 
+
 /** @file  test/film_metadata_test.cc
  *  @brief Test some basic reading/writing of film metadata.
+ *  @ingroup feature
  */
 
-#include <boost/test/unit_test.hpp>
-#include <boost/filesystem.hpp>
-#include <boost/date_time.hpp>
-#include "lib/film.h"
+
+#include "lib/content.h"
+#include "lib/content_factory.h"
+#include "lib/dcp_content.h"
 #include "lib/dcp_content_type.h"
+#include "lib/film.h"
 #include "lib/ratio.h"
+#include "lib/text_content.h"
 #include "test.h"
+#include <boost/date_time.hpp>
+#include <boost/filesystem.hpp>
+#include <boost/test/unit_test.hpp>
+
 
 using std::string;
 using std::list;
-using boost::shared_ptr;
+using std::make_shared;
+using std::shared_ptr;
+
 
 BOOST_AUTO_TEST_CASE (film_metadata_test)
 {
-       shared_ptr<Film> f = new_test_film ("film_metadata_test");
-       boost::filesystem::path dir = test_film_dir ("film_metadata_test");
+       auto film = new_test_film ("film_metadata_test");
+       auto dir = test_film_dir ("film_metadata_test");
 
-       f->_isdcf_date = boost::gregorian::from_undelimited_string ("20130211");
-       BOOST_CHECK (f->container() == 0);
-       BOOST_CHECK (f->dcp_content_type() == 0);
+       film->_isdcf_date = boost::gregorian::from_undelimited_string ("20130211");
+       BOOST_CHECK (film->container() == Ratio::from_id ("185"));
+       BOOST_CHECK (film->dcp_content_type() == 0);
 
-       f->set_name ("fred");
-       f->set_dcp_content_type (DCPContentType::from_pretty_name ("Short"));
-       f->set_container (Ratio::from_id ("185"));
-       f->set_j2k_bandwidth (200000000);
-       f->write_metadata ();
+       film->set_name ("fred");
+       film->set_dcp_content_type (DCPContentType::from_isdcf_name ("SHR"));
+       film->set_container (Ratio::from_id ("185"));
+       film->set_j2k_bandwidth (200000000);
+       film->set_interop (false);
+       film->set_chain (string(""));
+       film->set_distributor (string(""));
+       film->set_facility (string(""));
+       film->set_release_territory (dcp::LanguageTag::RegionSubtag("US"));
+       film->write_metadata ();
 
-       list<string> ignore;
-       ignore.push_back ("Key");
+       list<string> ignore = { "Key", "ContextID" };
        check_xml ("test/data/metadata.xml.ref", dir.string() + "/metadata.xml", ignore);
 
-       shared_ptr<Film> g (new Film (dir));
+       auto g = make_shared<Film>(dir);
        g->read_metadata ();
 
        BOOST_CHECK_EQUAL (g->name(), "fred");
-       BOOST_CHECK_EQUAL (g->dcp_content_type(), DCPContentType::from_pretty_name ("Short"));
+       BOOST_CHECK_EQUAL (g->dcp_content_type(), DCPContentType::from_isdcf_name ("SHR"));
        BOOST_CHECK_EQUAL (g->container(), Ratio::from_id ("185"));
-       
+
        g->write_metadata ();
        check_xml ("test/data/metadata.xml.ref", dir.string() + "/metadata.xml", ignore);
 }
+
+
+/** Check a bug where <Content> tags with multiple <Text>s would fail to load */
+BOOST_AUTO_TEST_CASE (multiple_text_nodes_are_allowed)
+{
+       auto subs = content_factory("test/data/15s.srt").front();
+       auto caps = content_factory("test/data/15s.srt").front();
+       auto film = new_test_film2("multiple_text_nodes_are_allowed1", { subs, caps });
+       caps->only_text()->set_type(TextType::CLOSED_CAPTION);
+       make_and_verify_dcp (
+               film,
+               {
+                       dcp::VerificationNote::Code::MISSING_CPL_METADATA,
+                       dcp::VerificationNote::Code::MISSING_SUBTITLE_LANGUAGE,
+                       dcp::VerificationNote::Code::INVALID_SUBTITLE_FIRST_TEXT_TIME
+               });
+
+       auto reload = make_shared<DCPContent>(film->dir(film->dcp_name()));
+       auto film2 = new_test_film2("multiple_text_nodes_are_allowed2", { reload });
+       film2->write_metadata ();
+
+       auto test = make_shared<Film>(boost::filesystem::path("build/test/multiple_text_nodes_are_allowed2"));
+       test->read_metadata();
+}