A number of unit test fixes.
[dcpomatic.git] / test / player_test.cc
index b685404025dab6984958256eded57ea6a8649db9..1580d5902e3a4da40e3ad32c7b21593cc5fa16ee 100644 (file)
@@ -1,5 +1,5 @@
 /*
-    Copyright (C) 2014 Carl Hetherington <cth@carlh.net>
+    Copyright (C) 2014-2018 Carl Hetherington <cth@carlh.net>
 
     This file is part of DCP-o-matic.
 
@@ -23,8 +23,6 @@
  *  @ingroup selfcontained
  */
 
-#include <iostream>
-#include <boost/test/unit_test.hpp>
 #include "lib/film.h"
 #include "lib/ffmpeg_content.h"
 #include "lib/dcp_content_type.h"
 #include "lib/player.h"
 #include "lib/video_content.h"
 #include "lib/image_content.h"
+#include "lib/text_subtitle_content.h"
+#include "lib/content_factory.h"
+#include "lib/dcp_content.h"
+#include "lib/subtitle_content.h"
+#include "lib/butler.h"
+#include "lib/compose.hpp"
 #include "test.h"
+#include <boost/test/unit_test.hpp>
+#include <iostream>
 
 using std::cout;
 using std::list;
+using std::pair;
 using boost::shared_ptr;
 using boost::bind;
+using boost::optional;
 
 static shared_ptr<AudioBuffers> accumulated;
 
 static void
-accumulate (shared_ptr<AudioBuffers> audio, DCPTime t)
+accumulate (shared_ptr<AudioBuffers> audio, DCPTime)
 {
        BOOST_REQUIRE (accumulated);
        accumulated->append (audio);
@@ -84,6 +92,7 @@ BOOST_AUTO_TEST_CASE (player_black_fill_test)
        film->set_name ("black_fill_test");
        film->set_container (Ratio::from_id ("185"));
        film->set_sequence (false);
+       film->set_interop (false);
        shared_ptr<ImageContent> contentA (new ImageContent (film, "test/data/simple_testcard_640x480.png"));
        shared_ptr<ImageContent> contentB (new ImageContent (film, "test/data/simple_testcard_640x480.png"));
 
@@ -115,3 +124,109 @@ BOOST_AUTO_TEST_CASE (player_black_fill_test)
 
        check_dcp (ref.string(), check.string());
 }
+
+/** Check behaviour with an awkward playlist whose data does not end on a video frame start */
+BOOST_AUTO_TEST_CASE (player_subframe_test)
+{
+       shared_ptr<Film> film = new_test_film ("reels_test7");
+       film->set_name ("reels_test7");
+       film->set_container (Ratio::from_id ("185"));
+       film->set_dcp_content_type (DCPContentType::from_isdcf_name ("TST"));
+       shared_ptr<Content> A = content_factory(film, "test/data/flat_red.png").front();
+       film->examine_and_add_content (A);
+       BOOST_REQUIRE (!wait_for_jobs ());
+       shared_ptr<Content> B = content_factory(film, "test/data/awkward_length.wav").front();
+       film->examine_and_add_content (B);
+       BOOST_REQUIRE (!wait_for_jobs ());
+       film->set_video_frame_rate (24);
+       A->video->set_length (3 * 24);
+
+       BOOST_CHECK (A->full_length() == DCPTime::from_frames(3 * 24, 24));
+       BOOST_CHECK (B->full_length() == DCPTime(289920));
+       /* Length should be rounded up from B's length to the next video frame */
+       BOOST_CHECK (film->length() == DCPTime::from_frames(3 * 24 + 1, 24));
+
+       shared_ptr<Player> player (new Player (film, film->playlist ()));
+       player->setup_pieces ();
+       BOOST_REQUIRE_EQUAL (player->_black._periods.size(), 1);
+       BOOST_CHECK (player->_black._periods.front() == DCPTimePeriod(DCPTime::from_frames(3 * 24, 24), DCPTime::from_frames(3 * 24 + 1, 24)));
+       BOOST_REQUIRE_EQUAL (player->_silent._periods.size(), 1);
+       BOOST_CHECK (player->_silent._periods.front() == DCPTimePeriod(DCPTime(289920), DCPTime::from_frames(3 * 24 + 1, 24)));
+}
+
+static Frame video_frames;
+static Frame audio_frames;
+
+static void
+video (shared_ptr<PlayerVideo>, DCPTime)
+{
+       ++video_frames;
+}
+
+static void
+audio (shared_ptr<AudioBuffers> audio, DCPTime)
+{
+       audio_frames += audio->frames();
+}
+
+/** Check with a video-only file that the video and audio emissions happen more-or-less together */
+BOOST_AUTO_TEST_CASE (player_interleave_test)
+{
+       shared_ptr<Film> film = new_test_film ("ffmpeg_transcoder_basic_test_subs");
+       film->set_name ("ffmpeg_transcoder_basic_test");
+       film->set_container (Ratio::from_id ("185"));
+       film->set_audio_channels (6);
+
+       shared_ptr<FFmpegContent> c (new FFmpegContent (film, "test/data/test.mp4"));
+       film->examine_and_add_content (c);
+       BOOST_REQUIRE (!wait_for_jobs ());
+
+       shared_ptr<TextSubtitleContent> s (new TextSubtitleContent (film, "test/data/subrip.srt"));
+       film->examine_and_add_content (s);
+       BOOST_REQUIRE (!wait_for_jobs ());
+
+       shared_ptr<Player> player (new Player(film, film->playlist()));
+       player->Video.connect (bind (&video, _1, _2));
+       player->Audio.connect (bind (&audio, _1, _2));
+       video_frames = audio_frames = 0;
+       while (!player->pass ()) {
+               BOOST_CHECK (abs(video_frames - (audio_frames / 2000)) < 8);
+       }
+}
+
+static void
+note_handler (dcp::NoteType, std::string)
+{
+
+}
+
+/** Test some seeks towards the start of a DCP with awkward subtitles; see mantis #1085
+ *  and a number of others.  I thought this was a player seek bug but in fact it was
+ *  caused by the subtitle starting just after the start of the video frame and hence
+ *  being faded out.
+ */
+BOOST_AUTO_TEST_CASE (player_seek_test)
+{
+       shared_ptr<Film> film (new Film (optional<boost::filesystem::path>()));
+       shared_ptr<DCPContent> dcp (new DCPContent (film, private_data / "awkward_subs"));
+       film->examine_and_add_content (dcp, true);
+       BOOST_REQUIRE (!wait_for_jobs ());
+       dcp->subtitle->set_use (true);
+
+       shared_ptr<Player> player (new Player (film, film->playlist()));
+       player->set_fast ();
+       player->set_always_burn_subtitles (true);
+       player->set_play_referenced ();
+
+       shared_ptr<Butler> butler (new Butler (player, film->log(), AudioMapping(), 2));
+       butler->disable_audio();
+
+       for (int i = 0; i < 10; ++i) {
+               DCPTime t = DCPTime::from_frames (i, 24);
+               butler->seek (t, true);
+               pair<shared_ptr<PlayerVideo>, DCPTime> video = butler->get_video();
+               BOOST_CHECK_EQUAL(video.second.get(), t.get());
+               write_image(video.first->image(note_handler, PlayerVideo::always_rgb, false, true), String::compose("build/test/player_seek_test_%1.png", i), "RGB");
+               check_image(String::compose("test/data/player_seek_test_%1.png", i), String::compose("build/test/player_seek_test_%1.png", i));
+       }
+}