Fix assertion failure on making a VF, in certain circumstances.

[dcpomatic.git] / test / reels_test.cc

diff --git a/test/reels_test.cc b/test/reels_test.cc
index eea9ebfbe309c84ca36cdb73f04b37a00d1c0f38..620c934178723f21d421e458630686e23e4a9708 100644 (file)
--- a/test/reels_test.cc
+++ b/test/reels_test.cc
@@ -39,6 +39,7 @@
 using std::list;
 using std::cout;
 using boost::shared_ptr;
+using namespace dcpomatic;
 
 /** Test Film::reels() */
 BOOST_AUTO_TEST_CASE (reels_test1)
@@ -371,3 +372,44 @@ BOOST_AUTO_TEST_CASE (reels_test9)
        film2->make_dcp();
        BOOST_REQUIRE(!wait_for_jobs());
 }
+
+/** Another reels-related error; make_dcp() would raise a ProgrammingError
+ *  in AudioBuffers::allocate due to an attempt to allocate a negatively-sized buffer.
+ *  This was triggered by a VF where there are referenced audio reels followed by
+ *  VF audio.  When the VF audio arrives the Writer did not correctly skip over the
+ *  referenced reels.
+ */
+BOOST_AUTO_TEST_CASE (reels_test10)
+{
+       /* Make the OV */
+       shared_ptr<Film> ov = new_test_film2("reels_test10_ov");
+       shared_ptr<FFmpegContent> A(new FFmpegContent("test/data/flat_red.png"));
+       ov->examine_and_add_content (A);
+       BOOST_REQUIRE (!wait_for_jobs());
+       A->video->set_length (5 * 24);
+
+       shared_ptr<FFmpegContent> B(new FFmpegContent("test/data/flat_red.png"));
+       ov->examine_and_add_content (B);
+       BOOST_REQUIRE (!wait_for_jobs());
+       B->video->set_length (5 * 24);
+
+       ov->set_reel_type (REELTYPE_BY_VIDEO_CONTENT);
+       ov->make_dcp ();
+       BOOST_REQUIRE (!wait_for_jobs());
+       ov->write_metadata ();
+
+       /* Now try to make the VF; this used to fail */
+       shared_ptr<Film> vf = new_test_film2("reels_test10_vf");
+       shared_ptr<DCPContent> ov_dcp(new DCPContent(ov->dir(ov->dcp_name())));
+       vf->examine_and_add_content (ov_dcp);
+       BOOST_REQUIRE (!wait_for_jobs());
+       vf->set_reel_type (REELTYPE_BY_VIDEO_CONTENT);
+       ov_dcp->set_reference_video (true);
+       ov_dcp->set_reference_audio (true);
+       vf->examine_and_add_content (content_factory("test/data/15s.srt").front());
+       BOOST_REQUIRE (!wait_for_jobs());
+
+       vf->make_dcp ();
+       BOOST_REQUIRE (!wait_for_jobs());
+       vf->write_metadata ();
+}