Some comments.

diff --git a/src/lib/config.cc b/src/lib/config.cc
index 2420ab1b5ef6eb637a073db9dbf3a10dc9a34e2f..54b9168f2542a1bbd8ee49d0b933f4c95007ada2 100644 (file)
--- a/src/lib/config.cc
+++ b/src/lib/config.cc
@@ -181,6 +181,7 @@ Config::read ()
 void
 Config::read_old_metadata ()
 {
+       /* XXX: this won't work with non-Latin filenames */
        ifstream f (file(true).string().c_str ());
        string line;
 

diff --git a/src/lib/cross.cc b/src/lib/cross.cc
index 9aa8454c989444dd04532a4b9ef995c36c279b20..7436dbf26a9b4582edcfb8e1702638b2e91d3416 100644 (file)
--- a/src/lib/cross.cc
+++ b/src/lib/cross.cc
@@ -70,6 +70,9 @@ cpu_info ()
        string info;
        
 #ifdef DCPOMATIC_LINUX
+       /* This use of ifstream is ok; the filename can never
+          be non-Latin
+       */
        ifstream f ("/proc/cpuinfo");
        while (f.good ()) {
                string l;