Add a FIXME.
authorCarl Hetherington <cth@carlh.net>
Thu, 26 Mar 2020 20:45:14 +0000 (21:45 +0100)
committerCarl Hetherington <cth@carlh.net>
Thu, 26 Mar 2020 22:08:10 +0000 (23:08 +0100)
src/stl_binary_reader.cc

index 9a7a150fcf53b767b232ab9b7ed2375797649772..e8e88328a479c8be1ef4f7e5a6b2af199ba82dca 100644 (file)
@@ -211,6 +211,9 @@ void STLBinaryReader::read (shared_ptr<InputReader> reader)
                        RawSubtitle sub;
                        sub.from = reader->get_timecode(5, frame_rate);
                        sub.to = reader->get_timecode(9, frame_rate);
+                        /* XXX: only the verticial position of the first TTI block should be used (says the spec),
+                           so using reader->get_int(13, 1) here is wrong if i > 0
+                         */
                        sub.vertical_position.line = reader->get_int(13, 1) + i;
                        sub.vertical_position.lines = maximum_rows;
                        sub.vertical_position.reference = TOP_OF_SCREEN;