dcpomatic.git
39 hours agoBump libsub for SSA Margin{L,R} support (#2811). main
Carl Hetherington [Wed, 22 May 2024 21:31:37 +0000 (23:31 +0200)]
Bump libsub for SSA Margin{L,R} support (#2811).

This also pulls in a colour fix for binary STL but the colours are
not yet visible in the preview due to another bug.

3 days agoFix stream length for DCP content (#2688).
Carl Hetherington [Mon, 20 May 2024 13:21:51 +0000 (15:21 +0200)]
Fix stream length for DCP content (#2688).

3 days agoAllow running tests from trees made with cdist.
Carl Hetherington [Mon, 20 May 2024 13:21:24 +0000 (15:21 +0200)]
Allow running tests from trees made with cdist.

3 days agoUse $HOME rather than hard-coded user name.
Carl Hetherington [Mon, 20 May 2024 19:36:57 +0000 (21:36 +0200)]
Use $HOME rather than hard-coded user name.

4 days agoDon't make _stream_states for unmapped audio, otherwise we wait for content
Carl Hetherington [Sun, 19 May 2024 21:46:55 +0000 (23:46 +0200)]
Don't make _stream_states for unmapped audio, otherwise we wait for content
which will never arrive.

4 days agoAdd and use Content::has_mapped_audio().
Carl Hetherington [Sun, 19 May 2024 21:27:34 +0000 (23:27 +0200)]
Add and use Content::has_mapped_audio().

4 days agoCleanup: use auto.
Carl Hetherington [Sun, 19 May 2024 21:27:18 +0000 (23:27 +0200)]
Cleanup: use auto.

7 days agoEmit no audio from DCPs if none is mapped v2.16.85
Carl Hetherington [Fri, 17 May 2024 13:03:15 +0000 (15:03 +0200)]
Emit no audio from DCPs if none is mapped

This makes DCP content behave the same as FFmpeg.

7 days agoMake sure we don't say some content has audio if none will be emitted.
Carl Hetherington [Fri, 17 May 2024 13:02:57 +0000 (15:02 +0200)]
Make sure we don't say some content has audio if none will be emitted.

In the FFmpeg (and shortly DCP) case we don't emit any audio if none is mapped,
so we must take this into account in the player.

8 days agoSupporters update. v2.16.84
Carl Hetherington [Thu, 16 May 2024 07:26:00 +0000 (09:26 +0200)]
Supporters update.

8 days agoUpdate DCP encoder progress on all passe()es, not just when audio is emitted.
Carl Hetherington [Sun, 12 May 2024 13:38:31 +0000 (15:38 +0200)]
Update DCP encoder progress on all passe()es, not just when audio is emitted.

8 days agoGet DCP transcode progress from the player (#2804).
Carl Hetherington [Sun, 12 May 2024 13:22:28 +0000 (15:22 +0200)]
Get DCP transcode progress from the player (#2804).

8 days agoFix Windows test runner.
Carl Hetherington [Wed, 15 May 2024 21:48:53 +0000 (23:48 +0200)]
Fix Windows test runner.

8 days agoFix macOS environment setup.
Carl Hetherington [Tue, 14 May 2024 08:26:19 +0000 (10:26 +0200)]
Fix macOS environment setup.

10 days agoFix warning cause by previous libdcp bump.
Carl Hetherington [Mon, 13 May 2024 22:02:54 +0000 (00:02 +0200)]
Fix warning cause by previous libdcp bump.

10 days agoBump libdcp for another MCA channel ID fix (#2810).
Carl Hetherington [Mon, 13 May 2024 21:11:55 +0000 (23:11 +0200)]
Bump libdcp for another MCA channel ID fix (#2810).

10 days agoDon't bother decoding audio if none of it is mapped (#2809).
Carl Hetherington [Sun, 12 May 2024 23:20:27 +0000 (01:20 +0200)]
Don't bother decoding audio if none of it is mapped (#2809).

On a test adding subs from an MKV to an existing DCP this reduces
the processing time from ~2h to ~1m because it doesn't resample the
audio from the whole of the MKV, only to discard it.

13 days agoFix link icon width again.
Carl Hetherington [Sat, 11 May 2024 08:57:01 +0000 (10:57 +0200)]
Fix link icon width again.

Seems to be different on wxWidgets 3.1.x vs 3.2.x.

2 weeks agoWork around deadlock when destroying J2KEncoder with a full writer queue (#2784). v2.16.83
Carl Hetherington [Sun, 5 May 2024 19:34:29 +0000 (21:34 +0200)]
Work around deadlock when destroying J2KEncoder with a full writer queue (#2784).

This feels like a hack, but I can't think of a nicer way to do it.

The interruption disable makes sense because when we destroy encoder threads
during a DCP encode (because a remote server goes away, for example) we don't
want any frames to be lost due to the encode thread being interrupted between
taking the frame off the queue and sending it to the writer.

When we're destroying the encoder we don't care about this, but I can't see
how you'd differentiate.

Maybe the encoder queue could have two lists: to-do and in-progress;
the encoder thread atomically moves a frame from to-do to in-progress,
but then how do you know when the in-progress ones are orphaned and need
to be re-added to the main queue.

You could make the writer return saying "no" if the queue is full (rather
than blocking and waiting for the queue to empty) but that seems wasteful
as then the frame would be re-encoded.

2 weeks agoAdd some missing includes.
Carl Hetherington [Sun, 5 May 2024 19:34:22 +0000 (21:34 +0200)]
Add some missing includes.

2 weeks agoSupporters update.
Carl Hetherington [Tue, 7 May 2024 22:33:13 +0000 (00:33 +0200)]
Supporters update.

2 weeks agoRemove in-place translations support.
Carl Hetherington [Fri, 3 May 2024 22:19:00 +0000 (00:19 +0200)]
Remove in-place translations support.

It feels like there have been too many failed attempts and not
enough (maybe zero?) successes so it's just too confusing.

3 weeks agoUpdated cs_CZ translation from Tomáš Begeni.
Carl Hetherington [Thu, 2 May 2024 13:48:13 +0000 (15:48 +0200)]
Updated cs_CZ translation from Tomáš Begeni.

3 weeks agoUse plain git hash for VERSION when there is no exact tag.
Carl Hetherington [Sat, 27 Apr 2024 15:41:52 +0000 (17:41 +0200)]
Use plain git hash for VERSION when there is no exact tag.

3 weeks agoDon't "pollute" the library path with /usr/local/lib.
Carl Hetherington [Mon, 29 Apr 2024 20:41:37 +0000 (22:41 +0200)]
Don't "pollute" the library path with /usr/local/lib.

Sometimes we don't want to use the stuff in there.

3 weeks agoSupporters update. v2.16.82
Carl Hetherington [Tue, 30 Apr 2024 09:20:53 +0000 (11:20 +0200)]
Supporters update.

3 weeks agoFix silent stereo mixdown exports when the project audio channel count is > 6.
Carl Hetherington [Mon, 29 Apr 2024 20:34:51 +0000 (22:34 +0200)]
Fix silent stereo mixdown exports when the project audio channel count is > 6.

This became much more of a problem when we started defaulting to 8 channels
in projects.

4 weeks agoSupporters update. v2.16.81
Carl Hetherington [Wed, 24 Apr 2024 00:11:29 +0000 (02:11 +0200)]
Supporters update.

4 weeks agoRevert "Tweak how lzma is linked."
Carl Hetherington [Mon, 22 Apr 2024 22:38:14 +0000 (00:38 +0200)]
Revert "Tweak how lzma is linked."

This reverts commit 604a5f9343eebfa0108a19bb6b8ec60bc81f4819.

I don't know why I did this, and it breaks the mac-old (10.8) target
as the lzma.5.dylib is not present on those machines.

5 weeks agoMissed update to private test repo version. v2.16.80
Carl Hetherington [Thu, 18 Apr 2024 12:00:07 +0000 (14:00 +0200)]
Missed update to private test repo version.

5 weeks agoAdd missing GUI-side verification note descriptions.
Carl Hetherington [Thu, 18 Apr 2024 08:12:25 +0000 (10:12 +0200)]
Add missing GUI-side verification note descriptions.

5 weeks agoSupporters update.
Carl Hetherington [Wed, 17 Apr 2024 21:30:12 +0000 (23:30 +0200)]
Supporters update.

5 weeks agoBump libdcp for more relaxed CPL parsing (#2797).
Carl Hetherington [Wed, 17 Apr 2024 21:25:22 +0000 (23:25 +0200)]
Bump libdcp for more relaxed CPL parsing (#2797).

5 weeks agoDon't use --target-macos-arm64 any more, since it's not supported.
Carl Hetherington [Mon, 15 Apr 2024 21:13:00 +0000 (23:13 +0200)]
Don't use --target-macos-arm64 any more, since it's not supported.

7 weeks agoFix hanging/overlapping dvb subtitles (#2792).
Carl Hetherington [Sun, 31 Mar 2024 23:04:41 +0000 (01:04 +0200)]
Fix hanging/overlapping dvb subtitles (#2792).

This reverts a change made in
8ca6fd6d97e6d42492afddb655fa85130946853c
"Fix doubled subtitles if subtitle stop times are specified."

That change breaks the case where a subtitle _does_ have a stop time,
but it's wrong (30s from the start time) and we want the next subtitle
to clear the previous one.

I can't now see how reverting this could cause doubled subtitles,
so maybe that problem wlil come back.  At least now there's a test
for #2792.

7 weeks agoFix crash introduced in previous commit.
Carl Hetherington [Fri, 29 Mar 2024 22:58:36 +0000 (23:58 +0100)]
Fix crash introduced in previous commit.

7 weeks agoFix lack of video rotation in some cases (#2971).
Carl Hetherington [Fri, 29 Mar 2024 22:18:14 +0000 (23:18 +0100)]
Fix lack of video rotation in some cases (#2971).

Setting the optional to 0 here means we never even looked at the
packet side data.  This seems to be more of a problem with the
v2.17.x branch for some reason.

7 weeks agoFix video scaling when the video needs rotation (#2791).
Carl Hetherington [Fri, 29 Mar 2024 22:18:01 +0000 (23:18 +0100)]
Fix video scaling when the video needs rotation (#2791).

7 weeks agoAdd VideoContent::rotate_size().
Carl Hetherington [Fri, 29 Mar 2024 22:17:34 +0000 (23:17 +0100)]
Add VideoContent::rotate_size().

8 weeks agoHack to local build script to use environment if ~/build if present.
Carl Hetherington [Mon, 25 Mar 2024 21:31:48 +0000 (22:31 +0100)]
Hack to local build script to use environment if ~/build if present.

2 months agoFix detection of SSE, removing unnecessary --target-macos-arm64.
Carl Hetherington [Sat, 23 Mar 2024 22:25:43 +0000 (23:25 +0100)]
Fix detection of SSE, removing unnecessary --target-macos-arm64.

2 months agoTidy up and fix assertion failure when selecting a CPL from the menu. v2.16.79
Carl Hetherington [Wed, 20 Mar 2024 14:34:24 +0000 (15:34 +0100)]
Tidy up and fix assertion failure when selecting a CPL from the menu.

2 months agoFix failing tests.
Carl Hetherington [Mon, 11 Mar 2024 14:25:16 +0000 (15:25 +0100)]
Fix failing tests.

Broken in the fix for #2780, when we started to check that referenced
audio MXFs have the correct number of channels.

2 months agoThe private test repo got some v2.18.x updates.
Carl Hetherington [Tue, 19 Mar 2024 22:02:32 +0000 (23:02 +0100)]
The private test repo got some v2.18.x updates.

2 months agoBump libdcp for SMPTE timecode parsing fix and better handling of unexpected verify...
Carl Hetherington [Tue, 19 Mar 2024 09:00:55 +0000 (10:00 +0100)]
Bump libdcp for SMPTE timecode parsing fix and better handling of unexpected verify errors.

2 months agoImprove formatting of FAILED_READ errors.
Carl Hetherington [Mon, 18 Mar 2024 17:09:37 +0000 (18:09 +0100)]
Improve formatting of FAILED_READ errors.

2 months agoLog job errors as errors during verify.
Carl Hetherington [Mon, 18 Mar 2024 17:09:28 +0000 (18:09 +0100)]
Log job errors as errors during verify.

2 months agoSupporters update.
Carl Hetherington [Sun, 17 Mar 2024 09:28:59 +0000 (10:28 +0100)]
Supporters update.

2 months agoAdd dark-mode link icon.
Carl Hetherington [Fri, 15 Mar 2024 20:00:12 +0000 (21:00 +0100)]
Add dark-mode link icon.

2 months agoFix link icon width on macOS.
Carl Hetherington [Fri, 15 Mar 2024 19:41:15 +0000 (20:41 +0100)]
Fix link icon width on macOS.

2 months agoRemove some more unnecessary copying for macOS command line.
Carl Hetherington [Fri, 15 Mar 2024 19:38:13 +0000 (20:38 +0100)]
Remove some more unnecessary copying for macOS command line.

2 months agoGet prefs icons from the source tree on when starting from the macOS console.
Carl Hetherington [Fri, 15 Mar 2024 19:36:32 +0000 (20:36 +0100)]
Get prefs icons from the source tree on when starting from the macOS console.

2 months agoReplace use of sprintf with snprintf.
Carl Hetherington [Fri, 15 Mar 2024 19:11:21 +0000 (20:11 +0100)]
Replace use of sprintf with snprintf.

2 months agoA couple of macOS development notes.
Carl Hetherington [Fri, 15 Mar 2024 19:08:00 +0000 (20:08 +0100)]
A couple of macOS development notes.

2 months agoFix screen name order in KDM emails.
Carl Hetherington [Thu, 7 Mar 2024 22:33:03 +0000 (23:33 +0100)]
Fix screen name order in KDM emails.

2 months agoUse dcp_name (probably ISDCF name) for CPL_NAME in KDM emails (#2787).
Carl Hetherington [Thu, 7 Mar 2024 20:03:31 +0000 (21:03 +0100)]
Use dcp_name (probably ISDCF name) for CPL_NAME in KDM emails (#2787).

2 months agoStore attachment contents in the Email object.
Carl Hetherington [Thu, 7 Mar 2024 15:40:03 +0000 (16:40 +0100)]
Store attachment contents in the Email object.

2 months agoRename Emailer -> Email.
Carl Hetherington [Thu, 7 Mar 2024 15:12:22 +0000 (16:12 +0100)]
Rename Emailer -> Email.

2 months agoAdd a couple more Dolby certificate location / filename pairs.
Carl Hetherington [Mon, 4 Mar 2024 21:34:52 +0000 (22:34 +0100)]
Add a couple more Dolby certificate location / filename pairs.

2 months agoBuild for Ubuntu 24.04.
Carl Hetherington [Fri, 1 Mar 2024 12:42:50 +0000 (13:42 +0100)]
Build for Ubuntu 24.04.

2 months agoAdd Shift+scrollwheel to move left/right in the timeline.
Carl Hetherington [Tue, 27 Feb 2024 00:11:52 +0000 (01:11 +0100)]
Add Shift+scrollwheel to move left/right in the timeline.

2 months agoAdd Ctrl+scrollwheel zoom to the timeline (#2781).
Carl Hetherington [Mon, 26 Feb 2024 23:57:51 +0000 (00:57 +0100)]
Add Ctrl+scrollwheel zoom to the timeline (#2781).

2 months agoDisallow referring to OV audio unless channel counts match (#2780).
Carl Hetherington [Mon, 26 Feb 2024 22:18:15 +0000 (23:18 +0100)]
Disallow referring to OV audio unless channel counts match (#2780).

3 months agoMake DCPExaminer::size() optional and deal with the consequences. v2.16.78
Carl Hetherington [Wed, 21 Feb 2024 09:47:38 +0000 (10:47 +0100)]
Make DCPExaminer::size() optional and deal with the consequences.

This means we can fix the case of a VF having no known size in a nice way,
in turn fixing problems caused by the fix to #2775.

3 months agoFix failure to examine non-flat-ratio VFs (#2775).
Carl Hetherington [Wed, 21 Feb 2024 00:10:23 +0000 (01:10 +0100)]
Fix failure to examine non-flat-ratio VFs (#2775).

3 months agoFix build on Centos 7.
Carl Hetherington [Tue, 20 Feb 2024 13:37:58 +0000 (14:37 +0100)]
Fix build on Centos 7.

3 months agoSupporters update. v2.16.77
Carl Hetherington [Mon, 19 Feb 2024 21:29:53 +0000 (22:29 +0100)]
Supporters update.

3 months agoSupporters update.
Carl Hetherington [Mon, 19 Feb 2024 13:45:38 +0000 (14:45 +0100)]
Supporters update.

3 months agoFix various preview errors on high-DPI screens (#2774).
Carl Hetherington [Mon, 19 Feb 2024 13:41:49 +0000 (14:41 +0100)]
Fix various preview errors on high-DPI screens (#2774).

The logical scale was previously not taken into account so the outline
rectangle was wrong and the padding was usually missing.

3 months agoCleanup: use a dcp::Size instead of a wxSize.
Carl Hetherington [Mon, 19 Feb 2024 13:40:02 +0000 (14:40 +0100)]
Cleanup: use a dcp::Size instead of a wxSize.

3 months agoFix note about branch handling.
Carl Hetherington [Sat, 17 Feb 2024 23:37:47 +0000 (00:37 +0100)]
Fix note about branch handling.

3 months agoAdd film duration to --dump output (#1702).
Carl Hetherington [Sat, 17 Feb 2024 23:32:37 +0000 (00:32 +0100)]
Add film duration to --dump output (#1702).

3 months agoAvoid quotation marks around dumped paths.
Carl Hetherington [Sat, 17 Feb 2024 23:32:13 +0000 (00:32 +0100)]
Avoid quotation marks around dumped paths.

3 months agoAdd option to load prefs from ZIP (#2771).
Carl Hetherington [Thu, 15 Feb 2024 00:05:22 +0000 (01:05 +0100)]
Add option to load prefs from ZIP (#2771).

3 months agoUse FileDialog for saving preferences ZIPs.
Carl Hetherington [Sat, 17 Feb 2024 22:45:23 +0000 (23:45 +0100)]
Use FileDialog for saving preferences ZIPs.

3 months agoCleanup: 0 -> nullptr.
Carl Hetherington [Sat, 17 Feb 2024 22:44:55 +0000 (23:44 +0100)]
Cleanup: 0 -> nullptr.

3 months agoReturn empty optional rather than asserting.
Carl Hetherington [Fri, 16 Feb 2024 22:46:27 +0000 (23:46 +0100)]
Return empty optional rather than asserting.

3 months agoCleanup: add missing explicit.
Carl Hetherington [Thu, 15 Feb 2024 00:05:17 +0000 (01:05 +0100)]
Cleanup: add missing explicit.

3 months agoAdd Unzipper.
Carl Hetherington [Thu, 15 Feb 2024 00:05:12 +0000 (01:05 +0100)]
Add Unzipper.

3 months agoSupporters update. v2.16.76
Carl Hetherington [Thu, 15 Feb 2024 23:36:03 +0000 (00:36 +0100)]
Supporters update.

3 months agoSupporters update.
Carl Hetherington [Thu, 15 Feb 2024 00:06:16 +0000 (01:06 +0100)]
Supporters update.

3 months agoBump libdcp for fix to error about unknown asset type.
Carl Hetherington [Wed, 14 Feb 2024 22:52:29 +0000 (23:52 +0100)]
Bump libdcp for fix to error about unknown asset type.

3 months agoFix conversion of _X to underlined X with GTK (via gtk_label_set_text_with_mnemonic...
Carl Hetherington [Wed, 14 Feb 2024 22:03:24 +0000 (23:03 +0100)]
Fix conversion of _X to underlined X with GTK (via gtk_label_set_text_with_mnemonic, I think).

3 months agoCleanup: white space.
Carl Hetherington [Wed, 14 Feb 2024 22:02:53 +0000 (23:02 +0100)]
Cleanup: white space.

3 months agoCope with loading a film containing a missing DCP which itself contains subtitles.
Carl Hetherington [Wed, 14 Feb 2024 22:02:48 +0000 (23:02 +0100)]
Cope with loading a film containing a missing DCP which itself contains subtitles.

3 months agoFix exception when calling resume() without first calling suspend().
Carl Hetherington [Wed, 14 Feb 2024 21:42:35 +0000 (22:42 +0100)]
Fix exception when calling resume() without first calling suspend().

3 months agoFix message for high bitrate frames during verify.
Carl Hetherington [Mon, 12 Feb 2024 19:53:42 +0000 (20:53 +0100)]
Fix message for high bitrate frames during verify.

3 months agoDon't add a font with an empty ID for ccaps either (#2762).
Carl Hetherington [Sun, 11 Feb 2024 19:13:04 +0000 (20:13 +0100)]
Don't add a font with an empty ID for ccaps either (#2762).

Previously this was all changed so that for subs we add the default
font in a cleaner way (in db22f81ccce9e1a5f205e6d8b3c0631fc039a173).

I can't see why we shouldn't treat ccaps the same way, and indeed
not doing it causes an error as shown by the included test.

3 months agoSupporters update.
Carl Hetherington [Sun, 11 Feb 2024 21:58:25 +0000 (22:58 +0100)]
Supporters update.

3 months agoFix apparently ineffective processors when analysing audio (#2671).
Carl Hetherington [Sun, 11 Feb 2024 12:10:48 +0000 (13:10 +0100)]
Fix apparently ineffective processors when analysing audio (#2671).

A whole film ("DCP side") analysis would behave the same as a
single piece of content analysis if the film only had one piece
of content.

Here we also clarify that audio analysis of the whole film is different
to that for a single piece of content; for the whole film we use processors,
and for single pieces of content we do not.

3 months agoAdd option to stop the player using any audio processor.
Carl Hetherington [Sun, 11 Feb 2024 12:09:30 +0000 (13:09 +0100)]
Add option to stop the player using any audio processor.

3 months agoAdd comment about AudioDialog.
Carl Hetherington [Sun, 11 Feb 2024 12:08:58 +0000 (13:08 +0100)]
Add comment about AudioDialog.

3 months agoFix totally missing saving of DKDM recipients.
Carl Hetherington [Sun, 11 Feb 2024 13:36:33 +0000 (14:36 +0100)]
Fix totally missing saving of DKDM recipients.

3 months agoRemove orphaned label.
Carl Hetherington [Sun, 11 Feb 2024 13:15:44 +0000 (14:15 +0100)]
Remove orphaned label.

3 months agoExtend the only column in the editable email address list.
Carl Hetherington [Sun, 11 Feb 2024 13:14:01 +0000 (14:14 +0100)]
Extend the only column in the editable email address list.

3 months agoUpdated sl_SI translation from Martin Srebotnjak.
Carl Hetherington [Sat, 10 Feb 2024 22:46:07 +0000 (23:46 +0100)]
Updated sl_SI translation from Martin Srebotnjak.

3 months agoSupporters update. v2.16.75
Carl Hetherington [Fri, 9 Feb 2024 12:07:43 +0000 (13:07 +0100)]
Supporters update.

3 months agoBump libdcp to fix time/date format bug.
Carl Hetherington [Fri, 9 Feb 2024 01:50:09 +0000 (02:50 +0100)]
Bump libdcp to fix time/date format bug.

3 months agoFix erroneously-moved warning removal (needed for Windows).
Carl Hetherington [Wed, 7 Feb 2024 23:36:52 +0000 (00:36 +0100)]
Fix erroneously-moved warning removal (needed for Windows).

3 months agoDon't give confusing errors about WEBVTT when there are errors in a Subrip file ...
Carl Hetherington [Tue, 6 Feb 2024 10:33:12 +0000 (11:33 +0100)]
Don't give confusing errors about WEBVTT when there are errors in a Subrip file (#2733).