Robin Gareus [Sat, 17 Jun 2017 20:53:58 +0000 (22:53 +0200)]
Add option add automation-lane points on the line -- #7397
John Emmas [Sun, 18 Jun 2017 11:05:48 +0000 (12:05 +0100)]
'ARDOUR::Stripable::Sorter()' needs to be exportable (since it gets used outside of libardour)
John Emmas [Sun, 18 Jun 2017 11:02:44 +0000 (12:02 +0100)]
Accommodate newly introduced source(s) in our MSVC project (gtk2_ardour)
Hiroki Inagaki [Sun, 11 Jun 2017 09:28:14 +0000 (02:28 -0700)]
Update Japanese translation, including a fix for an issue that translation for a certain string leads failure to launch the application on Windows 10
Robin Gareus [Sat, 17 Jun 2017 16:26:59 +0000 (18:26 +0200)]
NO-OP, just cleanup & scope
Robin Gareus [Sat, 17 Jun 2017 16:26:35 +0000 (18:26 +0200)]
Fix TrackView selection after re-order.
because reordering a TreeView [pragmatically] does not retain selection.
Robin Gareus [Sat, 17 Jun 2017 15:13:06 +0000 (17:13 +0200)]
Remove delayed selection which causes duplicate selection actifacts.
The first click to select a new stripable may actually un-select strip.
counting and ignoring this leads to strange behavior.
Also when the selection_counter hit zero, VCAs were not ignored.
whatever this workaround was good for, it's more trouble than it's worth.
As side-effect this also improves DnD + Gtk::Entry behavior with stock GTK.
Robin Gareus [Sat, 17 Jun 2017 14:48:25 +0000 (16:48 +0200)]
Simplify route-display TreeView.
There's no TargetEntry receiver for the custom DnDTreeView<Route> object.
We can just use a default Gtk::TreeView.
Robin Gareus [Sat, 17 Jun 2017 13:49:01 +0000 (15:49 +0200)]
Don't de-select tracks when order changes
Robin Gareus [Sat, 17 Jun 2017 13:51:40 +0000 (15:51 +0200)]
Ignore Selection::set() without actual changes
Robin Gareus [Sat, 17 Jun 2017 12:55:32 +0000 (14:55 +0200)]
Remove Cruft
Robin Gareus [Sat, 17 Jun 2017 12:50:28 +0000 (14:50 +0200)]
Move implementation out of header file
Robin Gareus [Sat, 17 Jun 2017 02:35:48 +0000 (04:35 +0200)]
Add Lua bindings to query all stripables
Robin Gareus [Sat, 17 Jun 2017 02:31:18 +0000 (04:31 +0200)]
Fix adding tracks/busses at the top
Robin Gareus [Sat, 17 Jun 2017 02:23:55 +0000 (04:23 +0200)]
Fix stripable order for new strips & master-order
Robin Gareus [Fri, 16 Jun 2017 21:45:25 +0000 (23:45 +0200)]
Remove Cruft
Robin Gareus [Sat, 17 Jun 2017 00:40:46 +0000 (02:40 +0200)]
NO-OP: whitespace
Robin Gareus [Fri, 16 Jun 2017 21:45:16 +0000 (23:45 +0200)]
Use Stripable::Sorter in GUI consistently.
Robin Gareus [Sat, 17 Jun 2017 00:31:03 +0000 (02:31 +0200)]
Add method to ensure Stripable sort constrains (for UI use)
Robin Gareus [Fri, 16 Jun 2017 21:44:29 +0000 (23:44 +0200)]
Use Stripable::Sorter in libs
Robin Gareus [Fri, 16 Jun 2017 21:44:09 +0000 (23:44 +0200)]
Move StripableSorter into libardour
Robin Gareus [Fri, 16 Jun 2017 20:32:10 +0000 (22:32 +0200)]
Fix engine-state history.
Remove old code to remove duplicate engine state which was used to
work-around a bug since 3.x saved duplicates but broke with 4.x separate
i/o devices.
Add a new variant to purge old unused states per backend (after sorting).
Len Ovens [Fri, 16 Jun 2017 18:32:00 +0000 (11:32 -0700)]
OSC: plugin feedback mathfix - 0 param (meter) checked for.
Robin Gareus [Fri, 9 Jun 2017 12:48:33 +0000 (14:48 +0200)]
Prepare VCA Automation Lanes -- refactor TAV
* add an abstract StripableTimeAxisView (Route TAV + VCA TAV)
* move common strip-methods into STAV
* Add Automation Lanes to VCA TAV
* Allow ATAV without Automatable for VCA Controls
Robin Gareus [Thu, 15 Jun 2017 14:05:45 +0000 (16:05 +0200)]
Remove another explicit Close button.
Robin Gareus [Wed, 14 Jun 2017 20:47:22 +0000 (22:47 +0200)]
Fix region-gain offset when separating ranges
Robin Gareus [Wed, 14 Jun 2017 19:22:08 +0000 (21:22 +0200)]
Squelch error message when toggling master-bus visibility.
Len Ovens [Wed, 14 Jun 2017 17:28:45 +0000 (10:28 -0700)]
OSC: Add send/plugin page values to GUI
Len Ovens [Wed, 14 Jun 2017 15:18:02 +0000 (08:18 -0700)]
OSC: save and restore send/plugin page size.
Robin Gareus [Wed, 14 Jun 2017 13:21:02 +0000 (15:21 +0200)]
Fix range-separate for musically-locked MIDI regions
Cloning a region retains the region-lock style.
Playlist partitioning set the region start-property only (audio-time).
If a MIDI region is locked to musical-time, Properties::start is ignored
and overwritten by Properties::start_beats.
Robin Gareus [Wed, 14 Jun 2017 13:14:56 +0000 (15:14 +0200)]
Special-case VCA at 0 (-inf dB), force gain slaves to -inf dB
Robin Gareus [Wed, 14 Jun 2017 00:39:15 +0000 (02:39 +0200)]
Merge event control lists when disconnecting a master-ctrl
Robin Gareus [Wed, 14 Jun 2017 00:38:32 +0000 (02:38 +0200)]
Add infrastructure to merge ControlLists
Len Ovens [Tue, 13 Jun 2017 23:55:13 +0000 (16:55 -0700)]
OSC: Allow set_surface to set send and plugin page sizes.
Robin Gareus [Tue, 13 Jun 2017 18:57:01 +0000 (20:57 +0200)]
Apply master-value to automation on disconnect.
Robin Gareus [Tue, 13 Jun 2017 16:09:22 +0000 (18:09 +0200)]
Write inverse master automation.
* The UI and ctrl-surface controls use and display the combined value,
including control-masters.
* The Automation lane of a control is the raw value of the control
without masters.
When touching (or writing) automation, the control-master needs to be
factored out (or subtracted). e.g press+hold a control -> write inverse
master automation.
Robin Gareus [Tue, 13 Jun 2017 15:57:58 +0000 (17:57 +0200)]
amend
11ba1854 -- locked curve-evaluation is not public
Robin Gareus [Tue, 13 Jun 2017 14:07:20 +0000 (16:07 +0200)]
FP8: use proper API to detect automation-playback
The custom code didn't take touch + touching into account when
another surface was touching automation.
Robin Gareus [Tue, 13 Jun 2017 14:05:33 +0000 (16:05 +0200)]
Fix another thinko in
9581cb26 +
02b087c5 (VCA gain automation)
This went unnoticed because: VCA gain automation was always applied
(regardless of automation state) but when it was not playing
master_ratio() factored it out again (per block).
Robin Gareus [Mon, 12 Jun 2017 23:08:08 +0000 (01:08 +0200)]
Fix nasty duplicate XML node
Robin Gareus [Mon, 12 Jun 2017 23:07:48 +0000 (01:07 +0200)]
Remember subgroup-bus
Robin Gareus [Mon, 12 Jun 2017 20:37:09 +0000 (22:37 +0200)]
Allow group gain sharing + VCA again
Len Ovens [Mon, 12 Jun 2017 19:29:58 +0000 (12:29 -0700)]
OSC: select channel plugin support with paging.
Robin Gareus [Mon, 12 Jun 2017 18:47:11 +0000 (20:47 +0200)]
Fix Monitor Group override
Robin Gareus [Mon, 12 Jun 2017 15:15:07 +0000 (17:15 +0200)]
Fix relative grouped + VCA slaved gain
Robin Gareus [Mon, 12 Jun 2017 10:48:53 +0000 (12:48 +0200)]
Consistent "cancel/close" button position on the left.
"Add and Close" is an odd one out and this button should really be
removed for consistency. Still it allows for a 2-click or
2-keyboard-shortcut very common action.
Robin Gareus [Mon, 12 Jun 2017 10:47:48 +0000 (12:47 +0200)]
Fix a compiler warning (optimized builds)
Tim Mayberry [Mon, 12 Jun 2017 13:59:11 +0000 (23:59 +1000)]
Restore the state of the autoplay button in the import dialog
Tim Mayberry [Mon, 12 Jun 2017 12:52:11 +0000 (22:52 +1000)]
Make Import the default action in the Import Dialog
Double clicking on a file or pressing the Return key will now import it.
This means with autoplay enabled you can navigate a directory of audio files
using the up and down arrow keys and import the wanted files (with Return)
without having to touch the mouse.
Being able to use double click to import a file means you don't have to move
the mouse back and forth between the file browser and the import button.
You can still manually audition the file with space as before.
Tim Mayberry [Mon, 12 Jun 2017 11:19:25 +0000 (21:19 +1000)]
Remove unnecessary temporary variables in MasterRecord::set_state
XMLNode::get_property only modifies the argument if the property is found and
conversion is successful.
Robin Gareus [Mon, 12 Jun 2017 00:25:20 +0000 (02:25 +0200)]
VCA/SlavableAutomationCtrl re-design:
* remember master-ctrl value on assignment & save with session
* Control/AutomationCtrl only stores ctrl's own value (w/o master)
* virtual AutomationControl::get_value () -> use SlavableAC method
* MasterRecord uses weak-ptr (fixes recursive ~Controllable() deadlock)
Damien Zammit [Sun, 11 Jun 2017 06:24:34 +0000 (16:24 +1000)]
a-EQ: Tweak knob layout to be less confusing
Robin Gareus [Sat, 10 Jun 2017 23:57:28 +0000 (01:57 +0200)]
Fix thinko in
9581cb26 - scratch-buffer can't be used recursively.
Len Ovens [Sat, 10 Jun 2017 14:28:15 +0000 (07:28 -0700)]
OSC: add option to send /reply instead of #reply (OSC1.0 compat)
Johannes Mueller [Fri, 9 Jun 2017 19:31:15 +0000 (21:31 +0200)]
Emit Session::Located only if _engine.transport_frame() is up to date
If _engine.transport_frame() is not up to date, we emit Located in
Session::backend_sync_callback() because that's when audible_frame() is up to
date. We don't want to emit it twice, because then, the playhead jumps back and
forth.
* mouse click in the ruler -> jump to requested location
* mouse release -> jump to old location (because audible_frame has to catch up)
* backend_sync_callback() called -> jump to new location
Johannes Mueller [Fri, 9 Jun 2017 19:24:57 +0000 (21:24 +0200)]
Make Session::backend_sync_callback() emit Session::Located
If we sync to jackd AudioEngine::transport_frame() is not yet updated when
Session emits Located. Then the playhead ends up in an obsolete
position. Therefore we emit Session::Located() also from within
Session::backend_sync_callback() as that is called when AudioEngine is done
with the relocation.
Paul Davis [Sat, 10 Jun 2017 16:04:27 +0000 (12:04 -0400)]
semantically more correct ordering of previous commit
Paul Davis [Sat, 10 Jun 2017 15:53:21 +0000 (11:53 -0400)]
linker-agnostic version of recent commit to get ControlProtocol selection state set correctly
Robin Gareus [Sat, 10 Jun 2017 12:36:03 +0000 (14:36 +0200)]
Implement slaved boolean automation and update mute special-case
Robin Gareus [Sat, 10 Jun 2017 12:37:23 +0000 (14:37 +0200)]
Restore VCA Automation state
Robin Gareus [Sat, 10 Jun 2017 12:37:05 +0000 (14:37 +0200)]
amend
a1b4f9b8ab - handle disconnecting from all masters
Paul Davis [Fri, 9 Jun 2017 21:54:10 +0000 (17:54 -0400)]
set first selected stripable for control protocols before they are instantiated
Robin Gareus [Fri, 9 Jun 2017 21:24:37 +0000 (23:24 +0200)]
NO-OP: whitespace
Robin Gareus [Fri, 9 Jun 2017 20:54:09 +0000 (22:54 +0200)]
Fix deletion of VCA with slaved controls.
The crashed previously because:
A VCA is-a Automatable is-a Evoral::ControlSet
After VCA's d'tor completes ~Automatable runs and emits signal to
DropReferences of all master-controls.
This in turn calls SlavableAutomationControl::master_going_away()
for slaved parameters for the given master-control
In ::master_going_away() the weak-pointer reference to the master's
AutomationControl (owned by the destroyed VCA) is still valid.
Execution is in the d'tor of Automatable which is-a ControlSet and
the ContolSet keeps a reference to the Control and hence also to the
AutomationControl which is-a Evoral::Control.
So master_going_away() locks a boost::shared_ptr<ARDOUR::AutomationControl>
which is actually the MuteControl owned by the VCA.
It calls SlavableAutomationControl::remove_master() which
in turn calls MuteControl::pre_remove_master() which uses the
MuteMaster API to retrieve the value. The MuteMaster however is the
VCA that has just been destroyed.
The solution is twofold:
1) emit "drop_references" from the VCA d'tor itself,
before the VCA is destroyed.
2) disconnect a slaved control from the master's drop_references signal
when un-assigning a master-control.
nick_m [Fri, 9 Jun 2017 17:49:01 +0000 (03:49 +1000)]
NoteCreateDrag - Fix incorrect note length due to use of region-relative position
Robin Gareus [Fri, 9 Jun 2017 12:47:27 +0000 (14:47 +0200)]
Remove Automatable::value_as_string API from libardour
Keep Pannable::value_as_string() for now. That is another inconsistency
which needs cleaning up. GUI StereoPanner and MonoPanner print
the value as they see fit, the panner-plugin provided formatting
is not used.
Robin Gareus [Fri, 9 Jun 2017 12:46:11 +0000 (14:46 +0200)]
Update GUI, drop Automatable::value_as_string() API
Robin Gareus [Fri, 9 Jun 2017 11:41:04 +0000 (13:41 +0200)]
Prepare to eventually drop Automatable::value_as_string()
Probably due to historical reasons, there are two APIs to format a
control's value. In all both variants end up calling either
ARDOUR::value_as_string() or the Controllable's formatting function
(except for panners).
Robin Gareus [Thu, 8 Jun 2017 21:45:07 +0000 (23:45 +0200)]
Prepare AutomationTimeAxisView for non-route (VCA) automation
Damien Zammit [Fri, 9 Jun 2017 13:06:53 +0000 (23:06 +1000)]
a-EQ: Revert one of the previous changes
One of the previous changes was not a typo, revert it.
nick_m [Fri, 9 Jun 2017 01:05:56 +0000 (11:05 +1000)]
Fix incorrect positioning of tempo line subdivisions if first meter is non-zero
Commit
cebefe6 assumed that frame 0 was the music origin.
Silly me.
nick_m [Fri, 9 Jun 2017 01:01:30 +0000 (11:01 +1000)]
Add a method for obtaining the frame position of beat/whatever zero
Robin Gareus [Thu, 8 Jun 2017 19:21:13 +0000 (21:21 +0200)]
Fix crash when showing plugin-UI in safe-mode
nick_m [Thu, 8 Jun 2017 15:56:28 +0000 (01:56 +1000)]
TempoLines deletes its bfc on destruction
nick_m [Thu, 8 Jun 2017 15:44:48 +0000 (01:44 +1000)]
Tempo lines display subdivisions correctly over a tempo change
TempoMap::get_grid() supplies a list of beat positions, leaving the lines
to work out any subdivision positions.
This is fine, unless a tempo section falls in between beats.
Use a BeatsFramesConverter along with a quarter note position
(in the BBTPointsList) to make this easier.
nick_m [Thu, 8 Jun 2017 15:34:14 +0000 (01:34 +1000)]
Fix reversed logic in legacy tempo secton detection
nick_m [Thu, 8 Jun 2017 15:08:59 +0000 (01:08 +1000)]
Delete tempo lines when session goes away
nick_m [Thu, 8 Jun 2017 13:11:56 +0000 (23:11 +1000)]
Do not duplicate note id in copy constructor
This fixes selection undo after copy-dragging notes, but there
are probably other cases where duplicate note ids may cause problems.
nick_m [Thu, 8 Jun 2017 12:39:41 +0000 (22:39 +1000)]
Remove debugging from TempoTest::qnDistanceTestRamp ()
nick_m [Thu, 8 Jun 2017 12:18:57 +0000 (22:18 +1000)]
Fix uninitialised tempo section variable
Should fix 7390.
Robin Gareus [Thu, 8 Jun 2017 11:33:35 +0000 (13:33 +0200)]
Fix rec-box w/count-in
Since
478f26b2ad, transport_rolling() is only true when actually rolling.
Count-in is a no-roll process (don't move playhead, no playhead UI
position interpolation
55b8b448).
But transport isn't exactly stopped either (preparing to roll), so
during count-in transport_stopped() == transport_rolling() == false.
Robin Gareus [Thu, 8 Jun 2017 11:22:43 +0000 (13:22 +0200)]
Update LuaDialog example script to include File/Folder selection
Robin Gareus [Thu, 8 Jun 2017 11:22:00 +0000 (13:22 +0200)]
Add a file-chooser LuaDialog Widget
Paul Davis [Wed, 7 Jun 2017 16:14:44 +0000 (12:14 -0400)]
cut buffer must not mess around with libardour selection
Fixes range mode selection/cut/copy that would previously clear track selection
Damien Zammit [Wed, 7 Jun 2017 16:04:12 +0000 (02:04 +1000)]
a-EQ: DSP bugfix
Previously there were large spurious spikes in the signal when
the bandwidth parameter was adjusted on a pure sine tone
for the peaking circuits. This has been *greatly* reduced if not
eliminated by fixing a typo in two of the equations.
Len Ovens [Tue, 6 Jun 2017 14:35:24 +0000 (07:35 -0700)]
OSC: add optional paging to sends in select.
Nil Geisweiller [Sun, 4 Jun 2017 18:34:48 +0000 (21:34 +0300)]
Fix a-EQ when parameter changes are very slow
If the parameters change too slowly the filter may never get updated. Indeed,
in spite of v_f0, v_g or v_bw being updated, set_params may never be called,
thus v_filter never updated.
Daniel Sheeler [Fri, 2 Jun 2017 22:23:00 +0000 (17:23 -0500)]
add route dialog now has "Add" and "Add and Close" buttons. "Add" keeps dialog open so user can add multiple templates.
Robin Gareus [Sat, 3 Jun 2017 11:29:28 +0000 (13:29 +0200)]
Apply VCA master gain automation to Amp (Fader, Trim)
Robin Gareus [Sat, 3 Jun 2017 11:18:31 +0000 (13:18 +0200)]
Add infrastructure for evaluating VCA automation curves
Robin Gareus [Sat, 3 Jun 2017 10:31:59 +0000 (12:31 +0200)]
amend
67f9f6fd: no recursive ReaderLock
Robin Gareus [Sat, 3 Jun 2017 10:30:26 +0000 (12:30 +0200)]
add const-ness: Evaluating a curve does not change it.
Note that the ControlList's lock and cache are already mutable.
Robin Gareus [Sat, 3 Jun 2017 10:26:33 +0000 (12:26 +0200)]
Add a scratch buffer for automation.
Useful as temporary buffer: This allows a controllable to
get a master's automation-curve and combine it with its own
(gain, trim, send) automation buffer.
Robin Gareus [Fri, 2 Jun 2017 22:19:35 +0000 (00:19 +0200)]
NO-OP: whitespace
Robin Gareus [Fri, 2 Jun 2017 16:21:31 +0000 (18:21 +0200)]
Import Dialog is Window. Dialog Esc behavior needs to be emulated.
Robin Gareus [Thu, 1 Jun 2017 09:57:08 +0000 (11:57 +0200)]
Remove "Close" button from import-dialog (prefer WM close button)
Paul Davis [Wed, 31 May 2017 17:04:03 +0000 (13:04 -0400)]
if actively recording, prevent interaction between mouse and audio clock widget(s)
Len Ovens [Wed, 31 May 2017 15:38:55 +0000 (08:38 -0700)]
OSC: Some surfaces may use float for ssid. Accept this too.
Len Ovens [Wed, 31 May 2017 14:15:50 +0000 (07:15 -0700)]
OSC: check controllable exists before using
Robin Gareus [Tue, 30 May 2017 13:15:30 +0000 (15:15 +0200)]
Add Lua bindings for VCAs and VCAManager