Carl Hetherington [Tue, 8 Aug 2023 21:53:42 +0000 (23:53 +0200)]
Add some tests.
Carl Hetherington [Tue, 8 Aug 2023 16:32:14 +0000 (18:32 +0200)]
Fix some missed includes of the old boost bind header.
Carl Hetherington [Tue, 8 Aug 2023 16:32:03 +0000 (18:32 +0200)]
Move ContentSorter out of the header, and use a default constructor.
Carl Hetherington [Tue, 8 Aug 2023 16:11:11 +0000 (18:11 +0200)]
Extract Film::Property to its own header to (maybe) increase compilation speed.
Carl Hetherington [Tue, 8 Aug 2023 13:26:05 +0000 (15:26 +0200)]
Cleanup: use some better variable names and tidy ifs.
Carl Hetherington [Tue, 8 Aug 2023 13:25:47 +0000 (15:25 +0200)]
Cleanup: use nullptr.
Carl Hetherington [Tue, 8 Aug 2023 13:25:42 +0000 (15:25 +0200)]
Cleanup: use a better loop variable name.
Carl Hetherington [Tue, 8 Aug 2023 13:17:46 +0000 (15:17 +0200)]
Cleanup: use a std::find_if().
Carl Hetherington [Tue, 8 Aug 2023 13:16:35 +0000 (15:16 +0200)]
Add a test.
Carl Hetherington [Tue, 8 Aug 2023 13:06:56 +0000 (15:06 +0200)]
Cleanup: use a default constructor.
Carl Hetherington [Tue, 8 Aug 2023 13:06:49 +0000 (15:06 +0200)]
Cleanup: use a lambda.
Carl Hetherington [Tue, 8 Aug 2023 13:06:39 +0000 (15:06 +0200)]
Cleanup: use some better loop variable names.
Carl Hetherington [Wed, 2 Aug 2023 15:28:39 +0000 (17:28 +0200)]
Add new hack.
Carl Hetherington [Sun, 30 Jul 2023 22:34:22 +0000 (00:34 +0200)]
Add hint about audio channel count.
Carl Hetherington [Tue, 25 Jul 2023 09:09:46 +0000 (11:09 +0200)]
Default to writing 8 audio channels in DCPs (#2443).
It seems likely that 8 channels is slightly less likely to trip validation
warnings from some distributors, and so it seems worth accepting the potential
waste of 2 channels. Users can always set this back to 6 again (once,
and it will be saved) and those upgrading from old versions won't be affected
anyway.
Carl Hetherington [Tue, 25 Jul 2023 09:04:30 +0000 (11:04 +0200)]
Go back to respecting the user's choice for the number of audio channels in the MXF.
Carl Hetherington [Sun, 30 Jul 2023 22:51:11 +0000 (00:51 +0200)]
Only warn about a missing text language for subtitles (not closed captions).
I haven't properly checked that closed captions shouldn't have some
language metadata, but the existing GUI code explicitly disallows
setup of a closed caption language.
Carl Hetherington [Sat, 29 Jul 2023 00:27:02 +0000 (02:27 +0200)]
Check channel count when comparing audio MXFs.
Carl Hetherington [Sat, 29 Jul 2023 00:26:33 +0000 (02:26 +0200)]
Don't check sound assets in some tests.
When fiddling with MXF channel counts it makes a lot of tests fail
that probably don't need to.
Carl Hetherington [Tue, 25 Jul 2023 20:49:23 +0000 (22:49 +0200)]
Bump libdcp to one with some cleanups / header re-arrangement.
Carl Hetherington [Sun, 23 Jul 2023 22:01:22 +0000 (00:01 +0200)]
Add stubs for Georgian (ka_KA) language support.
Carl Hetherington [Sun, 23 Jul 2023 22:01:04 +0000 (00:01 +0200)]
Fix copy-paste error.
Carl Hetherington [Sat, 22 Jul 2023 15:32:45 +0000 (17:32 +0200)]
Cleanup: lengthen some short variable names.
Carl Hetherington [Wed, 19 Jul 2023 08:05:50 +0000 (10:05 +0200)]
Supporters update.
Carl Hetherington [Wed, 19 Jul 2023 08:04:56 +0000 (10:04 +0200)]
Updated zh_CN translation from Akivili Collindort.
Carl Hetherington [Mon, 17 Jul 2023 21:14:38 +0000 (23:14 +0200)]
This check used to be for asset channel count mismatches, then it was
changed to the active count, but I don't think it should be an error
to have different active counts between assets of a single DCP.
Carl Hetherington [Fri, 7 Jul 2023 11:58:28 +0000 (13:58 +0200)]
Cleanup: member variable name standard.
Carl Hetherington [Sun, 2 Jul 2023 21:51:55 +0000 (23:51 +0200)]
Fix crash if an exception is thrown before the splash screen is created.
Carl Hetherington [Sun, 2 Jul 2023 20:03:28 +0000 (22:03 +0200)]
Don't insert incorrect <Effect> nodes into metadata (#2581).
Previously we would add assume Effect=none (i.e. force all subtitles
to have no effect) if neither of the legacy tags Border or Shadow
were present in the metadata. In this case we should just leave
Effect as unset.
Carl Hetherington [Fri, 30 Jun 2023 22:05:20 +0000 (00:05 +0200)]
Add another test.
Carl Hetherington [Fri, 30 Jun 2023 21:54:42 +0000 (23:54 +0200)]
Don't write MainSoundConfiguration with 71 when we only have HI/VI (#2580).
Carl Hetherington [Fri, 30 Jun 2023 21:53:57 +0000 (23:53 +0200)]
Add channel_is_mapped().
Carl Hetherington [Thu, 29 Jun 2023 23:59:18 +0000 (01:59 +0200)]
Clean up after some more tests.
Carl Hetherington [Wed, 28 Jun 2023 21:02:49 +0000 (23:02 +0200)]
Disable asset hash checks that the libdcp bump fixes.
Carl Hetherington [Mon, 26 Jun 2023 23:33:45 +0000 (01:33 +0200)]
Missing i18n markup.
Carl Hetherington [Tue, 20 Jun 2023 20:07:50 +0000 (22:07 +0200)]
Keep "correct" hashes in dcpomatic2_map rather than recalculating them (#2555).
Carl Hetherington [Mon, 26 Jun 2023 22:16:01 +0000 (00:16 +0200)]
Bump libdcp for changes to how hashes are handled.
Carl Hetherington [Sun, 25 Jun 2023 21:37:36 +0000 (23:37 +0200)]
We no longer need to these bundle IDs.
They were being passed to altool but when switching to notarytool
it seems that these IDs were never used and can now be omitted.
Carl Hetherington [Sun, 25 Jun 2023 20:34:47 +0000 (22:34 +0200)]
Tolerate problems when reading the contents of DCPs.
This avoids errors in cases like unreadable lost+found directories
appearing inside a DCP.
Carl Hetherington [Sat, 24 Jun 2023 07:58:22 +0000 (09:58 +0200)]
Fix config test reference after ISDCF name config option.
Carl Hetherington [Fri, 23 Jun 2023 22:54:28 +0000 (00:54 +0200)]
Add config option to allow long ISDCF name parts.
Carl Hetherington [Thu, 22 Jun 2023 15:45:17 +0000 (17:45 +0200)]
Avoid virtual call to set_film() in constructor (#2571).
Carl Hetherington [Thu, 22 Jun 2023 15:41:27 +0000 (17:41 +0200)]
Remove unnecessary config_changed() which will only result in setup_sensitivity() being called again.
Carl Hetherington [Thu, 22 Jun 2023 15:35:07 +0000 (17:35 +0200)]
No need to call setup_sensitivity() here as set_film() already does it.
Carl Hetherington [Thu, 22 Jun 2023 15:23:47 +0000 (17:23 +0200)]
set_film() no longer needs to be virtual.
Carl Hetherington [Thu, 22 Jun 2023 15:21:30 +0000 (17:21 +0200)]
Controls::set_film() calls setup_sensitivity() so there's no need for PlaylistControls::set_film() also to do it.
Carl Hetherington [Tue, 20 Jun 2023 20:07:39 +0000 (22:07 +0200)]
Give a better error when map doesn't find an asset.
Carl Hetherington [Tue, 20 Jun 2023 13:03:01 +0000 (15:03 +0200)]
Add new(?) filename for some IMB certificates.
Carl Hetherington [Tue, 20 Jun 2023 12:52:05 +0000 (14:52 +0200)]
Cleanup: use a struct/pair rather than two separate lists.
Carl Hetherington [Sat, 17 Jun 2023 21:58:01 +0000 (23:58 +0200)]
Fix syntax error in cscript.
Carl Hetherington [Fri, 16 Jun 2023 20:57:06 +0000 (22:57 +0200)]
Slightly improve a crash when content goes away.
Carl Hetherington [Fri, 16 Jun 2023 19:15:26 +0000 (21:15 +0200)]
Fix crash when pressing Ctrl+T with no content (#2563).
Carl Hetherington [Fri, 16 Jun 2023 19:14:42 +0000 (21:14 +0200)]
Defend against divide by 0.
Carl Hetherington [Thu, 15 Jun 2023 22:51:38 +0000 (00:51 +0200)]
Improve some tooltips (#2560).
Carl Hetherington [Mon, 12 Jun 2023 22:03:52 +0000 (00:03 +0200)]
Cleanup: switch sense of if.
Carl Hetherington [Mon, 12 Jun 2023 21:56:48 +0000 (23:56 +0200)]
Fix failure to close verify progress window when finished.
Carl Hetherington [Mon, 12 Jun 2023 21:50:29 +0000 (23:50 +0200)]
Cleanup: swap some wx_ptrs for locals.
Carl Hetherington [Fri, 9 Jun 2023 21:22:45 +0000 (23:22 +0200)]
Cleanup: whitespace fix.
Carl Hetherington [Fri, 9 Jun 2023 21:18:55 +0000 (23:18 +0200)]
Don't call DOMFrame::start_job from a non-UI thread.
Carl Hetherington [Wed, 7 Jun 2023 07:48:58 +0000 (09:48 +0200)]
Allow building for Debian 12.
Carl Hetherington [Tue, 6 Jun 2023 17:36:24 +0000 (19:36 +0200)]
Fix player audio, almost totally broken by a stupid mistake
in
78b2c650a9249cb7165d269b4378391d31e68e8b
Following that commit 16 channel audio streams were being read
as 6-channel, with unsurprising consequences.
Carl Hetherington [Sun, 4 Jun 2023 22:52:01 +0000 (00:52 +0200)]
Supporters update.
Carl Hetherington [Sat, 3 Jun 2023 19:18:36 +0000 (21:18 +0200)]
Cope with bad DCPs better in the editor.
Carl Hetherington [Sat, 3 Jun 2023 19:14:46 +0000 (21:14 +0200)]
Fix sizing of editor's reel dialog.
Carl Hetherington [Fri, 2 Jun 2023 20:21:52 +0000 (22:21 +0200)]
Give filler subtitle reels <LoadFont> nodes in SMPTE (#2547).
Carl Hetherington [Wed, 31 May 2023 18:13:50 +0000 (20:13 +0200)]
Fix missing subtitle language in CPL on auto-created empty subtitle assets (#2548).
Carl Hetherington [Sat, 3 Jun 2023 20:23:58 +0000 (22:23 +0200)]
Tweak test timing hack script to accept stdin.
Carl Hetherington [Sat, 3 Jun 2023 18:54:42 +0000 (20:54 +0200)]
Missing ConfigRestorer.
Carl Hetherington [Fri, 2 Jun 2023 21:38:16 +0000 (23:38 +0200)]
Fix incorrect hint about having too many subtitle lines in some cases (#2546).
Carl Hetherington [Fri, 2 Jun 2023 21:37:58 +0000 (23:37 +0200)]
Improve a test failure message.
Carl Hetherington [Fri, 2 Jun 2023 14:45:55 +0000 (16:45 +0200)]
Bump lwext4 for slightly better debugging.
Carl Hetherington [Thu, 1 Jun 2023 21:45:39 +0000 (23:45 +0200)]
Bump required private git revision.
Carl Hetherington [Wed, 31 May 2023 19:13:34 +0000 (21:13 +0200)]
Add dcpomatic2_{map,cli} to the main AppImage (#2549).
Carl Hetherington [Tue, 30 May 2023 18:31:53 +0000 (20:31 +0200)]
Don't show warning when only removing an empty DKDM folder (#2541).
Carl Hetherington [Tue, 30 May 2023 16:11:55 +0000 (18:11 +0200)]
Don't add DKDMs twice (#2545).
Carl Hetherington [Tue, 30 May 2023 15:21:24 +0000 (17:21 +0200)]
Fix errors when mapping DCPs referring to the same asset multiple times (#2542).
Carl Hetherington [Tue, 30 May 2023 15:20:32 +0000 (17:20 +0200)]
Clarify some test failure messages.
Carl Hetherington [Tue, 30 May 2023 12:42:53 +0000 (14:42 +0200)]
Add a test with hard-linking.
Carl Hetherington [Tue, 30 May 2023 12:31:24 +0000 (14:31 +0200)]
Move test into its own method.
Carl Hetherington [Tue, 30 May 2023 10:23:00 +0000 (12:23 +0200)]
Add --config option to map (#2543).
Carl Hetherington [Mon, 29 May 2023 23:29:28 +0000 (01:29 +0200)]
Fix disappearing DKDM folders when dragging a folder into its own child (#2540)
Carl Hetherington [Mon, 29 May 2023 20:54:50 +0000 (22:54 +0200)]
Supporters update.
Carl Hetherington [Mon, 29 May 2023 20:47:48 +0000 (22:47 +0200)]
Focus the "make DCP/OK" button in the hints dialog (#2539).
Carl Hetherington [Sun, 28 May 2023 18:59:38 +0000 (20:59 +0200)]
Don't write Markers to interop CPLs (#2537).
Carl Hetherington [Mon, 29 May 2023 07:32:03 +0000 (09:32 +0200)]
Missing bump of libdcp version.
Carl Hetherington [Sun, 28 May 2023 21:35:25 +0000 (23:35 +0200)]
Report the number of active channels in DCPs, not the number in the MXF.
Carl Hetherington [Sat, 27 May 2023 21:44:52 +0000 (23:44 +0200)]
Bump libdcp for fix to crash with interop subtitles (#2536).
Carl Hetherington [Sun, 28 May 2023 16:10:17 +0000 (18:10 +0200)]
Supporters update.
Carl Hetherington [Thu, 18 May 2023 20:23:05 +0000 (22:23 +0200)]
Cleanup: whitespace.
Carl Hetherington [Thu, 18 May 2023 20:21:33 +0000 (22:21 +0200)]
Cleanup: replace some list with vector.
Carl Hetherington [Thu, 18 May 2023 20:20:44 +0000 (22:20 +0200)]
Cleanup: using sorting.
Carl Hetherington [Thu, 18 May 2023 20:20:34 +0000 (22:20 +0200)]
Cleanup: remove unused include.
Carl Hetherington [Mon, 15 May 2023 09:23:07 +0000 (11:23 +0200)]
Updated cs_CZ translation from Tomáš Begeni.
Carl Hetherington [Sun, 14 May 2023 22:13:47 +0000 (00:13 +0200)]
Patrons update.
Carl Hetherington [Sun, 14 May 2023 10:35:11 +0000 (12:35 +0200)]
Missing dcpomatic2_map on RPM builds.
Carl Hetherington [Sat, 13 May 2023 20:39:53 +0000 (22:39 +0200)]
Re-order binary names.
I've no idea why this works (to fix weird errors from the Apple signing
stuff) but it does...
Carl Hetherington [Sat, 13 May 2023 20:07:47 +0000 (22:07 +0200)]
Cleanup: use a namespace.
Carl Hetherington [Sat, 13 May 2023 20:02:53 +0000 (22:02 +0200)]
Cleanup: remove unnecessary explicit.
Carl Hetherington [Sat, 13 May 2023 19:09:49 +0000 (21:09 +0200)]
Missing relink of dcpomatic2_map.
Carl Hetherington [Sat, 13 May 2023 17:14:20 +0000 (19:14 +0200)]
Fix missing signing of dcpomatic2_map.