dcpomatic.git
2 months agoRemove setuid root and use setcap instead in RPM packages.
Carl Hetherington [Sat, 13 Nov 2021 18:43:19 +0000 (19:43 +0100)]
Remove setuid root and use setcap instead in RPM packages.

2 months agoPulse the progress bar 'automatically' if we haven't had a progress update for a...
Carl Hetherington [Thu, 4 Nov 2021 22:44:11 +0000 (23:44 +0100)]
Pulse the progress bar 'automatically' if we haven't had a progress update for a while.

Should help with #2119.

2 months agoAdd Job::seconds_since_last_progress_update().
Carl Hetherington [Thu, 4 Nov 2021 22:43:54 +0000 (23:43 +0100)]
Add Job::seconds_since_last_progress_update().

2 months agoCleanup: use seconds() method.
Carl Hetherington [Thu, 4 Nov 2021 22:25:21 +0000 (23:25 +0100)]
Cleanup: use seconds() method.

2 months agoOnly look for tags which start with v
Carl Hetherington [Fri, 12 Nov 2021 12:23:01 +0000 (13:23 +0100)]
Only look for tags which start with v

2 months agoRemove player activity logging. Fixes #2122.
Carl Hetherington [Thu, 11 Nov 2021 21:49:34 +0000 (22:49 +0100)]
Remove player activity logging.  Fixes #2122.

If I remember right this was for swaroop and I suspect nobody else
is really interested.

2 months agoBump libdcp for fix to closed caption line length verification.
Carl Hetherington [Tue, 9 Nov 2021 22:52:25 +0000 (23:52 +0100)]
Bump libdcp for fix to closed caption line length verification.

2 months agoSupporters update. v2.15.172
Carl Hetherington [Fri, 5 Nov 2021 06:43:13 +0000 (07:43 +0100)]
Supporters update.

2 months agoInclude subscribers / supporters in git.
Carl Hetherington [Thu, 4 Nov 2021 18:29:50 +0000 (19:29 +0100)]
Include subscribers / supporters in git.

The need for network access part-way through a build causes loads
of annoying CI failures.

2 months agoMake the prefs window a little wider on macOS to (hopefully) fit all the icons in...
Carl Hetherington [Thu, 4 Nov 2021 11:51:49 +0000 (12:51 +0100)]
Make the prefs window a little wider on macOS to (hopefully) fit all the icons in (#2117).

2 months agoStop some tests from writing things to test/data.
Carl Hetherington [Wed, 3 Nov 2021 13:24:58 +0000 (14:24 +0100)]
Stop some tests from writing things to test/data.

2 months agoRun one test with fewer cores to stop it running out of memory on a 16-core 16Gb...
Carl Hetherington [Wed, 3 Nov 2021 10:27:14 +0000 (11:27 +0100)]
Run one test with fewer cores to stop it running out of memory on a 16-core 16Gb machine.

2 months agoAdd ConfigRestorer and use it instead of setup_test_config() directly.
Carl Hetherington [Tue, 2 Nov 2021 22:14:04 +0000 (23:14 +0100)]
Add ConfigRestorer and use it instead of setup_test_config() directly.

2 months agoClarify that in this get_reel_assets() the content and film frame rates will be the...
Carl Hetherington [Tue, 2 Nov 2021 14:08:29 +0000 (15:08 +0100)]
Clarify that in this get_reel_assets() the content and film frame rates will be the same.

2 months agoBail early if nothing can be referenced from this content.
Carl Hetherington [Tue, 2 Nov 2021 14:08:05 +0000 (15:08 +0100)]
Bail early if nothing can be referenced from this content.

2 months agoCleanup variable name: k -> reel
Carl Hetherington [Tue, 2 Nov 2021 14:07:53 +0000 (15:07 +0100)]
Cleanup variable name: k -> reel

2 months agoFix errors when referencing trimmed DCPs (#2116).
Carl Hetherington [Tue, 2 Nov 2021 13:55:45 +0000 (14:55 +0100)]
Fix errors when referencing trimmed DCPs (#2116).

2 months agoCleanup: use a variable we already made.
Carl Hetherington [Tue, 2 Nov 2021 13:36:35 +0000 (14:36 +0100)]
Cleanup: use a variable we already made.

2 months agoCleanup variable name: l -> caption
Carl Hetherington [Tue, 2 Nov 2021 13:21:14 +0000 (14:21 +0100)]
Cleanup variable name: l -> caption

2 months agoCleanup variable name: k -> reel
Carl Hetherington [Tue, 2 Nov 2021 13:18:15 +0000 (14:18 +0100)]
Cleanup variable name: k -> reel

2 months agoCleanup variable name: j -> dcp
Carl Hetherington [Tue, 2 Nov 2021 13:15:41 +0000 (14:15 +0100)]
Cleanup variable name: j -> dcp

2 months agoCleanup variable name: i -> content
Carl Hetherington [Tue, 2 Nov 2021 13:13:22 +0000 (14:13 +0100)]
Cleanup variable name: i -> content

2 months agoCleanup variable name: a -> reel_assets
Carl Hetherington [Tue, 2 Nov 2021 13:11:54 +0000 (14:11 +0100)]
Cleanup variable name: a -> reel_assets

2 months agoAdd failing test.
Carl Hetherington [Mon, 1 Nov 2021 22:37:36 +0000 (23:37 +0100)]
Add failing test.

2 months agoTidying.
Carl Hetherington [Mon, 1 Nov 2021 22:37:30 +0000 (23:37 +0100)]
Tidying.

2 months agoFix typo in dcpomatic_kdm_cli help.
Carl Hetherington [Mon, 1 Nov 2021 14:39:01 +0000 (15:39 +0100)]
Fix typo in dcpomatic_kdm_cli help.

2 months agoDon't fail the transcode job if we can't write analytics.
Carl Hetherington [Fri, 29 Oct 2021 10:56:08 +0000 (12:56 +0200)]
Don't fail the transcode job if we can't write analytics.

2 months agoManual tweak.
Carl Hetherington [Wed, 27 Oct 2021 22:00:53 +0000 (00:00 +0200)]
Manual tweak.

2 months agoManual tweaks.
Carl Hetherington [Wed, 27 Oct 2021 21:47:23 +0000 (23:47 +0200)]
Manual tweaks.

2 months agoAdd a new test for subtitle timing when changing frame rate.
Carl Hetherington [Wed, 27 Oct 2021 21:23:26 +0000 (23:23 +0200)]
Add a new test for subtitle timing when changing frame rate.

2 months agoManual tweaks.
Carl Hetherington [Tue, 26 Oct 2021 22:18:13 +0000 (00:18 +0200)]
Manual tweaks.

2 months agoUpdated nl_NL translation from Rob van Nieuwkerk.
Carl Hetherington [Mon, 25 Oct 2021 20:49:09 +0000 (22:49 +0200)]
Updated nl_NL translation from Rob van Nieuwkerk.

2 months agoFix position of content outline (#2108). v2.15.171
Carl Hetherington [Mon, 25 Oct 2021 08:31:43 +0000 (10:31 +0200)]
Fix position of content outline (#2108).

2 months agoIf there is no end time in an AVSubtitle it seems we should use the AVPacket's duration.
Carl Hetherington [Sun, 24 Oct 2021 22:41:42 +0000 (00:41 +0200)]
If there is no end time in an AVSubtitle it seems we should use the AVPacket's duration.

This fixes #2110.  I don't have a particular justification for it being
the right thing to do.

2 months agoFix fade factor calculation when there is no end time.
Carl Hetherington [Sun, 24 Oct 2021 22:40:30 +0000 (00:40 +0200)]
Fix fade factor calculation when there is no end time.

In this case we can't do any fade out.

2 months agoFix missing verification messages.
Carl Hetherington [Sun, 24 Oct 2021 23:13:55 +0000 (01:13 +0200)]
Fix missing verification messages.

2 months agoBump libdcp to 1.8.4 for caption ordering fix (#2106).
Carl Hetherington [Sun, 24 Oct 2021 19:06:54 +0000 (21:06 +0200)]
Bump libdcp to 1.8.4 for caption ordering fix (#2106).

3 months agoUpdated nl_NL translation from Rob van Nieuwkerk.
Carl Hetherington [Sat, 23 Oct 2021 19:33:23 +0000 (21:33 +0200)]
Updated nl_NL translation from Rob van Nieuwkerk.

3 months agoUpdated es_ES translation from Manuel AC.
Carl Hetherington [Mon, 18 Oct 2021 05:56:01 +0000 (07:56 +0200)]
Updated es_ES translation from Manuel AC.

3 months agoFix caption in manual.
Carl Hetherington [Sun, 17 Oct 2021 21:36:12 +0000 (23:36 +0200)]
Fix caption in manual.

3 months agoMissing entry in Makefile.
Carl Hetherington [Sun, 17 Oct 2021 21:36:07 +0000 (23:36 +0200)]
Missing entry in Makefile.

3 months agoMove some screenshots to the right place.
Carl Hetherington [Sun, 17 Oct 2021 21:33:55 +0000 (23:33 +0200)]
Move some screenshots to the right place.

3 months agoRevert "Add the PDF screenshots to git; I don't know why they weren't added before."
Carl Hetherington [Sun, 17 Oct 2021 21:33:21 +0000 (23:33 +0200)]
Revert "Add the PDF screenshots to git; I don't know why they weren't added before."

This reverts commit 6ec5bbc84d6c1383c599daf52e3e9fef23c6ce34.  PDF
screenshots are supposed to be in raw-screenshots.

3 months agoManual tweaks.
Carl Hetherington [Sun, 17 Oct 2021 21:15:43 +0000 (23:15 +0200)]
Manual tweaks.

3 months agoAdd a --screenshot option to the disk writer run file.
Carl Hetherington [Sun, 17 Oct 2021 20:54:02 +0000 (22:54 +0200)]
Add a --screenshot option to the disk writer run file.

3 months agoTalk about Disk Writer in the manual.
Carl Hetherington [Sun, 17 Oct 2021 20:53:51 +0000 (22:53 +0200)]
Talk about Disk Writer in the manual.

3 months agoManual tweaks.
Carl Hetherington [Sun, 17 Oct 2021 20:53:37 +0000 (22:53 +0200)]
Manual tweaks.

3 months agoAdd the PDF screenshots to git; I don't know why they weren't added before.
Carl Hetherington [Sun, 17 Oct 2021 20:53:05 +0000 (22:53 +0200)]
Add the PDF screenshots to git; I don't know why they weren't added before.

3 months agoBasic and slightly inaccurate support for <Space> in subtitles (#2103). v2.15.170
Carl Hetherington [Fri, 15 Oct 2021 20:25:42 +0000 (22:25 +0200)]
Basic and slightly inaccurate support for <Space> in subtitles (#2103).

Adding horizontal space to a Pango layout is hard, and I think this
change probably gets it slightly wrong, but it's a step in the right
direction.

3 months agoMove some functions up the file so we can use them.
Carl Hetherington [Sat, 16 Oct 2021 20:17:24 +0000 (22:17 +0200)]
Move some functions up the file so we can use them.

3 months agopot/merge.
Carl Hetherington [Sun, 17 Oct 2021 13:26:23 +0000 (15:26 +0200)]
pot/merge.

3 months agoFix some markup quotation marks.
Carl Hetherington [Sun, 17 Oct 2021 13:19:40 +0000 (15:19 +0200)]
Fix some markup quotation marks.

3 months agoUpgrade the disk writer warning (#1971).
Carl Hetherington [Sun, 17 Oct 2021 13:18:33 +0000 (15:18 +0200)]
Upgrade the disk writer warning (#1971).

3 months agoFix error when editing colours in locales with , as a decimal separator.
Carl Hetherington [Sat, 16 Oct 2021 17:53:26 +0000 (19:53 +0200)]
Fix error when editing colours in locales with , as a decimal separator.

3 months agoAlways block waiting for audio when exporting. v2.15.169
Carl Hetherington [Fri, 15 Oct 2021 20:33:46 +0000 (22:33 +0200)]
Always block waiting for audio when exporting.

Otherwise if there is non available we'll insert silence and potentially
push the audio out of sync (late).  May help with #2098.

3 months agoUse an enum instead of a bool to specify blocking/non-blocking.
Carl Hetherington [Fri, 15 Oct 2021 20:26:47 +0000 (22:26 +0200)]
Use an enum instead of a bool to specify blocking/non-blocking.

3 months agoAdd comment.
Carl Hetherington [Fri, 15 Oct 2021 20:16:13 +0000 (22:16 +0200)]
Add comment.

3 months agoIgnore audio streams that fall too far behind (#2101).
Carl Hetherington [Thu, 14 Oct 2021 22:30:44 +0000 (00:30 +0200)]
Ignore audio streams that fall too far behind (#2101).

3 months agoFix test logging setup to actually work.
Carl Hetherington [Thu, 14 Oct 2021 22:30:27 +0000 (00:30 +0200)]
Fix test logging setup to actually work.

3 months agoAdd a failing test.
Carl Hetherington [Tue, 12 Oct 2021 22:16:15 +0000 (00:16 +0200)]
Add a failing test.

3 months agoCleanup some unused usings.
Carl Hetherington [Tue, 12 Oct 2021 22:16:10 +0000 (00:16 +0200)]
Cleanup some unused usings.

3 months agoRemove manual stuff about the hidden upmixers.
Carl Hetherington [Wed, 13 Oct 2021 21:56:32 +0000 (23:56 +0200)]
Remove manual stuff about the hidden upmixers.

3 months agoDon't allow negative trims to be set up via changes to play length (#2105). v2.15.168
Carl Hetherington [Wed, 13 Oct 2021 19:21:27 +0000 (21:21 +0200)]
Don't allow negative trims to be set up via changes to play length (#2105).

3 months agoAdd some asserts to check for negative trims.
Carl Hetherington [Wed, 13 Oct 2021 19:21:10 +0000 (21:21 +0200)]
Add some asserts to check for negative trims.

3 months agoIgnore errors from avcodec_send_packet.
Carl Hetherington [Wed, 13 Oct 2021 13:50:13 +0000 (15:50 +0200)]
Ignore errors from avcodec_send_packet.

After seeking it appears that we often get irrelevant errors from this
method.  ffplay.c seems to ignore them, and this commit means that
we do too (just logging them).

I think these errors during a non-seeking "encoding" run could be
cause for concern; perhaps we should take more note of them in that
case.

3 months agoIgnore .AppleDouble folders inside DCPs.
Carl Hetherington [Tue, 12 Oct 2021 12:19:13 +0000 (14:19 +0200)]
Ignore .AppleDouble folders inside DCPs.

3 months agoHopefully fix race between thread finishing and cleanup being run (#2100).
Carl Hetherington [Mon, 11 Oct 2021 22:13:25 +0000 (00:13 +0200)]
Hopefully fix race between thread finishing and cleanup being run (#2100).

3 months agoDon't throw an error when the Butler says it is finished (#2097).
Carl Hetherington [Mon, 11 Oct 2021 08:51:43 +0000 (10:51 +0200)]
Don't throw an error when the Butler says it is finished (#2097).

3 months agoCleanup: use enum class.
Carl Hetherington [Mon, 11 Oct 2021 10:27:22 +0000 (12:27 +0200)]
Cleanup: use enum class.

3 months agoFix a test reference to account for windows filename slashes.
Carl Hetherington [Sun, 10 Oct 2021 10:18:11 +0000 (12:18 +0200)]
Fix a test reference to account for windows filename slashes.

3 months agoDon't ignore font settings for DCP subtitles (#2074). v2.15.167
Carl Hetherington [Fri, 8 Oct 2021 21:31:24 +0000 (23:31 +0200)]
Don't ignore font settings for DCP subtitles (#2074).

3 months agoAdd comment.
Carl Hetherington [Fri, 8 Oct 2021 21:30:49 +0000 (23:30 +0200)]
Add comment.

3 months agoCleanup some unused using statements and other bits.
Carl Hetherington [Fri, 8 Oct 2021 21:29:32 +0000 (23:29 +0200)]
Cleanup some unused using statements and other bits.

3 months agoBump libdcp to 1.8.2 for fix when adding KDMs to VFs.
Carl Hetherington [Fri, 8 Oct 2021 10:54:15 +0000 (12:54 +0200)]
Bump libdcp to 1.8.2 for fix when adding KDMs to VFs.

3 months agoMore logging in the DCPExaminer.
Carl Hetherington [Thu, 7 Oct 2021 19:00:11 +0000 (21:00 +0200)]
More logging in the DCPExaminer.

3 months agoC++11 tidying.
Carl Hetherington [Thu, 7 Oct 2021 18:59:35 +0000 (20:59 +0200)]
C++11 tidying.

3 months agoUpdate manual per #2068.
Carl Hetherington [Fri, 8 Oct 2021 23:45:10 +0000 (01:45 +0200)]
Update manual per #2068.

3 months agoSome manual tidying.
Carl Hetherington [Thu, 7 Oct 2021 21:05:19 +0000 (23:05 +0200)]
Some manual tidying.

3 months agoFix manual build with libdcp dependency.
Carl Hetherington [Tue, 5 Oct 2021 23:31:49 +0000 (01:31 +0200)]
Fix manual build with libdcp dependency.

3 months agoBump libdcp (with corresponding libsub bump) for small verification fix.
Carl Hetherington [Thu, 7 Oct 2021 20:53:59 +0000 (22:53 +0200)]
Bump libdcp (with corresponding libsub bump) for small verification fix.

3 months agoAdd some details about verification to the manual.
Carl Hetherington [Tue, 5 Oct 2021 23:16:28 +0000 (01:16 +0200)]
Add some details about verification to the manual.

3 months agoDon't scale chroma subsampled images to sizes that don't align with the subsampling... v2.15.166
Carl Hetherington [Sun, 3 Oct 2021 19:22:14 +0000 (21:22 +0200)]
Don't scale chroma subsampled images to sizes that don't align with the subsampling (#1872).

There's a slightly odd effect when scaling e.g. YVU420 images to
odd and then even widths - there's a small but visible luminance
shift.  I don't know why this happens, but keeping the scaling
sizes locked to the subsampling seems to help.

3 months agoDifferentiate requested and actual crop.
Carl Hetherington [Sun, 3 Oct 2021 18:53:44 +0000 (20:53 +0200)]
Differentiate requested and actual crop.

This is so we limit cropping to what is possible considering
chroma subsampling.

3 months agoAdd PixelQuanta to VideoContent.
Carl Hetherington [Sun, 3 Oct 2021 00:02:12 +0000 (02:02 +0200)]
Add PixelQuanta to VideoContent.

3 months agoDon't build Disk Writer for appimage.
Carl Hetherington [Sun, 3 Oct 2021 21:05:56 +0000 (23:05 +0200)]
Don't build Disk Writer for appimage.

Threads like
https://discourse.appimage.org/t/nosuid-fuse-mount-option-deactivates-capabilities/1652/1
suggest that using capabilities with AppImage is not possible, so making
things work will be a bit more work than I want to get into before
2.16.0.

3 months agoUpdated it_IT translation from Riccardo Mantani.
Carl Hetherington [Sun, 3 Oct 2021 20:54:31 +0000 (22:54 +0200)]
Updated it_IT translation from Riccardo Mantani.

3 months agoRequire libsub v1.6.0.
Carl Hetherington [Sun, 3 Oct 2021 20:32:51 +0000 (22:32 +0200)]
Require libsub v1.6.0.

3 months agoRequire libdcp v1.8.0 to fix SMPTE sub XML namespaces (#2061).
Carl Hetherington [Sun, 3 Oct 2021 20:29:35 +0000 (22:29 +0200)]
Require libdcp v1.8.0 to fix SMPTE sub XML namespaces (#2061).

3 months agoRemove unused using statement.
Carl Hetherington [Sun, 3 Oct 2021 20:14:21 +0000 (22:14 +0200)]
Remove unused using statement.

3 months agoAlways call ::draw() even when we have no image.
Carl Hetherington [Sun, 3 Oct 2021 19:46:07 +0000 (21:46 +0200)]
Always call ::draw() even when we have no image.

Otherwise the screen doesn't get cleared properly when no film is
loaded.

3 months agoRemove unused parameters.
Carl Hetherington [Sun, 3 Oct 2021 19:45:12 +0000 (21:45 +0200)]
Remove unused parameters.

3 months agoFix subtitle positioning and centering of the DCP frame in the window. v2.15.165
Carl Hetherington [Fri, 1 Oct 2021 19:10:24 +0000 (21:10 +0200)]
Fix subtitle positioning and centering of the DCP frame in the window.

Also tidy up a bit with the Rectangle class.

3 months agoChange glLineWidth from 2.0 -> 1.0. v2.15.164
Carl Hetherington [Thu, 30 Sep 2021 22:37:33 +0000 (00:37 +0200)]
Change glLineWidth from 2.0 -> 1.0.

Apparently a line width of greater than 1.0 is not allowed
in some versions of OpenGL.

3 months agoMissing check_gl_error() calls.
Carl Hetherington [Thu, 30 Sep 2021 22:37:14 +0000 (00:37 +0200)]
Missing check_gl_error() calls.

3 months agoOnly support GLVideoView when building with wxWidgets >= 3.1.0.
Carl Hetherington [Wed, 29 Sep 2021 10:33:08 +0000 (12:33 +0200)]
Only support GLVideoView when building with wxWidgets >= 3.1.0.

3 months agoFix tests. v2.15.163
Carl Hetherington [Mon, 27 Sep 2021 21:58:27 +0000 (23:58 +0200)]
Fix tests.

3 months agoMerge branch 'better-gl' into v2.15.x
Carl Hetherington [Mon, 27 Sep 2021 11:43:19 +0000 (13:43 +0200)]
Merge branch 'better-gl' into v2.15.x

This changes the GL video view to use more modern GL (GLSL etc.)  It
also special-cases JPEG2000 video playback and does scaling and
colourspace conversion on the GPU.

3 months agoTest fixes. better-gl
Carl Hetherington [Thu, 23 Sep 2021 21:54:32 +0000 (23:54 +0200)]
Test fixes.

3 months agoMake merge return the right alignment even if it's not doing anything.
Carl Hetherington [Thu, 23 Sep 2021 21:54:28 +0000 (23:54 +0200)]
Make merge return the right alignment even if it's not doing anything.

3 months agoCheck that the image used to make a Cairo::ImageSurface is the right alignment and...
Carl Hetherington [Thu, 23 Sep 2021 21:54:13 +0000 (23:54 +0200)]
Check that the image used to make a Cairo::ImageSurface is the right alignment and pixel format.