David Robillard [Sun, 4 Dec 2016 18:20:15 +0000 (13:20 -0500)]
Remove dead/annoying/unsafe code
Note the old Note::operator= was unsafe, since it made shallow copies of the on
and off events, which results in a double delete of events when the notes are
destructed.
Robin Gareus [Sun, 4 Dec 2016 16:50:12 +0000 (17:50 +0100)]
Skip testing example lua scripts which are not bundled
David Robillard [Sat, 3 Dec 2016 20:49:13 +0000 (15:49 -0500)]
Fix Sequence test
David Robillard [Mon, 7 Nov 2016 12:07:42 +0000 (07:07 -0500)]
Remove dead code
David Robillard [Mon, 7 Nov 2016 10:14:55 +0000 (05:14 -0500)]
Fix event type and parameter type confusion
I'm not sure if this is really the best way to do event types (should it
just be a completely static enum in evoral, or completely dynamic and
provided by the type map, or a mix like currently?), but previously the
event type was frequently set to either total garbage, or parameter
types, which are a different thing.
This fixes all those cases, and makes Evoral::EventType an enum so the
compiler will warn about implicit conversions from int.
David Robillard [Mon, 7 Nov 2016 09:06:26 +0000 (04:06 -0500)]
Fix warnings
David Robillard [Mon, 7 Nov 2016 03:04:35 +0000 (22:04 -0500)]
Remove Evoral::MIDIEvent
It is slightly questionable whether type specific methods like
velocity() belong on Event at all, these may be better off as free
functions. However the code currently uses them as methods in many
places, and it seems like a step in the right direction, since, for
example, we might some day have events that have a velocity but aren't
stored as MIDI messages (e.g. if Ardour uses an internal musical model
that is more expressive).
In any case, the former inheritance and plethora of sloppy casts is
definitely not the right thing.
David Robillard [Mon, 7 Nov 2016 00:27:26 +0000 (19:27 -0500)]
Factor out and extend MIDIXML implementation
David Robillard [Sun, 6 Nov 2016 23:12:49 +0000 (18:12 -0500)]
Fix Sequence/Event const-correctness issues
Olivier Humbert [Fri, 2 Dec 2016 19:18:02 +0000 (20:18 +0100)]
Making one string translatable
It should allow this dialog window to be translatable : http://pix.toile-libre.org/upload/original/
1480706219.png
I hope this is the correct way to do so. Please double-check what I've done before merging.
Tobi Stadelmaier [Thu, 1 Dec 2016 20:44:28 +0000 (21:44 +0100)]
Use correct action in map for Korg nanoKontrol2
According to the comment in line 79, this button should toggle between mixer and
editor windows - but it didn't (for me). Apparently that action named has changed
in Ardour 5.x - anyway, using this command, it works for me.
Robin Gareus [Thu, 1 Dec 2016 14:51:25 +0000 (15:51 +0100)]
update summary & connection-matrix colors when route-color changes
Robin Gareus [Thu, 1 Dec 2016 14:51:00 +0000 (15:51 +0100)]
Fix un/setting group colors
Robin Gareus [Wed, 30 Nov 2016 22:19:44 +0000 (23:19 +0100)]
and a more intrusive KDE workaround
Robin Gareus [Wed, 30 Nov 2016 22:00:59 +0000 (23:00 +0100)]
remove scope from translated phrases.
Robin Gareus [Wed, 30 Nov 2016 21:52:06 +0000 (22:52 +0100)]
pay some attention to the special guest of the night: KDE window stacking
Olivier Humbert [Wed, 30 Nov 2016 21:25:46 +0000 (22:25 +0100)]
One fix.
Olivier Humbert [Wed, 30 Nov 2016 20:54:10 +0000 (21:54 +0100)]
One fix
Olivier Humbert [Wed, 30 Nov 2016 19:31:32 +0000 (20:31 +0100)]
French translation update
Olivier Humbert [Wed, 30 Nov 2016 19:24:52 +0000 (20:24 +0100)]
French translation update
more translation + fixes
Robin Gareus [Wed, 30 Nov 2016 17:13:35 +0000 (18:13 +0100)]
Ensure the window-close button is visible for the Engine-Dialog.
Olivier Humbert [Wed, 30 Nov 2016 17:10:24 +0000 (18:10 +0100)]
French translation update
A few more improvements/fixes and new strings.
Robin Gareus [Wed, 30 Nov 2016 15:00:05 +0000 (16:00 +0100)]
fix compilation with newer version of *mm and gcc-6.2 (RefPtr<> cast)
Robin Gareus [Wed, 30 Nov 2016 13:49:42 +0000 (14:49 +0100)]
update system_config
Robin Gareus [Wed, 30 Nov 2016 13:44:36 +0000 (14:44 +0100)]
Remove close/OK buttons from engine dialog
Robin Gareus [Wed, 30 Nov 2016 11:15:35 +0000 (12:15 +0100)]
prefer bool operator
Robin Gareus [Wed, 30 Nov 2016 10:07:37 +0000 (11:07 +0100)]
allow to remove a session from the recent list
Robin Gareus [Wed, 30 Nov 2016 08:21:28 +0000 (09:21 +0100)]
NO-OP backport changes from Mixbus branch.
Robin Gareus [Tue, 29 Nov 2016 21:39:20 +0000 (22:39 +0100)]
Fix route color selection dialog
Olivier Humbert [Tue, 29 Nov 2016 18:52:38 +0000 (19:52 +0100)]
French translation update - fixes
a few fixes
Olivier Humbert [Tue, 29 Nov 2016 18:38:11 +0000 (19:38 +0100)]
French translation update
- a bunch of "fuzzy" stuffs removed (after checking/correcting those)
- a bunch of min/maj fixed
- >50 new translated strings
- >40 updated/fixed strings
- consistency across "… -> ...", "xrun -> décrochage", "lock -> verrouiller" and "mixer -> console de mixage"
Olivier Humbert [Thu, 24 Nov 2016 12:48:59 +0000 (13:48 +0100)]
French translation update
Two small fixes.
David Carlier [Fri, 18 Nov 2016 12:34:11 +0000 (12:34 +0000)]
moving POSIX_VISIBLE to the waf script part
David Carlier [Tue, 1 Nov 2016 21:03:03 +0000 (21:03 +0000)]
separate openbsd cases
David Carlier [Sat, 29 Oct 2016 15:20:32 +0000 (16:20 +0100)]
Making buildable under OpenBSD.
Robin Gareus [Tue, 29 Nov 2016 08:04:13 +0000 (09:04 +0100)]
Protect a-comp's display/state against NaN/Inf.
Robin Gareus [Tue, 29 Nov 2016 07:41:10 +0000 (08:41 +0100)]
protect a-delay again Inf, NaN, HUGE and stuff.
Robin Gareus [Mon, 28 Nov 2016 14:36:04 +0000 (15:36 +0100)]
Speed up track deletion when Editor-Mixer is visible
Robin Gareus [Mon, 28 Nov 2016 11:53:20 +0000 (12:53 +0100)]
properly handle FS pitch-bend - closes #7140
Robin Gareus [Mon, 28 Nov 2016 10:34:20 +0000 (11:34 +0100)]
Consistent sub-menu separators for Preferecens in fr translation
Len Ovens [Mon, 28 Nov 2016 04:52:14 +0000 (20:52 -0800)]
OSC: Solo toggle should maintain state when locked, rec and rec_safe should show true state.
Tim Mayberry [Mon, 28 Nov 2016 02:30:38 +0000 (12:30 +1000)]
Fix Duplicate Track with Copy Playlist option selected
Previously two new empty playlists were created.
Related to and mentioned in issue #7141
Len Ovens [Mon, 28 Nov 2016 02:32:50 +0000 (18:32 -0800)]
OSC: Squelch select feedback when no feedback is configured.
Tim Mayberry [Mon, 28 Nov 2016 00:59:32 +0000 (10:59 +1000)]
Fix reversed behaviour of Playlist -> New and New Copy
Resolves: #7146
Thanks again to elgoun for the patch
Tim Mayberry [Mon, 28 Nov 2016 00:50:47 +0000 (10:50 +1000)]
Fix duplicate track with new playlist so only one playlist is created
Instead of 2 empty playlists, thanks to elgoun for the patch
Resolves: #7141
Robin Gareus [Sun, 27 Nov 2016 22:00:32 +0000 (23:00 +0100)]
update default config (see also
5ec21347a)
Robin Gareus [Sun, 27 Nov 2016 21:54:05 +0000 (22:54 +0100)]
NO-OP; Backport changes from Mixbus branch
Robin Gareus [Sun, 27 Nov 2016 20:53:16 +0000 (21:53 +0100)]
Don't include program-name with <Option name="color-file" />
This allows for e.g. mixbus and mixbus32c to share the config, but
use different color-files at runtime.
Robin Gareus [Sun, 27 Nov 2016 16:25:42 +0000 (17:25 +0100)]
Fix loading, recording & saving MIDI with PolyKeyPressure events.
GUI still does not handle this (neither automation lane, nor List Editor),
but the file loads, plays and exports correctly.
Robin Gareus [Sat, 26 Nov 2016 23:40:51 +0000 (00:40 +0100)]
revert
335debfa for the PA backend
The same device may have different names for input + output
Len Ovens [Sat, 26 Nov 2016 18:23:36 +0000 (10:23 -0800)]
OSC: no op, white space cleanup
Len Ovens [Sat, 26 Nov 2016 17:18:36 +0000 (09:18 -0800)]
OSC: Make plugin and plugin parameter numbering 1 based to match everything else.
Robin Gareus [Sat, 26 Nov 2016 13:33:07 +0000 (14:33 +0100)]
Add [hidden] option to list "Dummy" backend with optmized bundles
Robin Gareus [Sat, 26 Nov 2016 13:31:24 +0000 (14:31 +0100)]
Restrict Device selection to valid choices.
Robin Gareus [Sat, 26 Nov 2016 13:30:46 +0000 (14:30 +0100)]
Add API to enforce valid device selection.
Len Ovens [Fri, 25 Nov 2016 18:10:49 +0000 (10:10 -0800)]
OSC: Add patch from 7137 and make it work for manual port selection.
Robin Gareus [Fri, 25 Nov 2016 17:07:59 +0000 (18:07 +0100)]
speed up track/bus creation a bit
Robin Gareus [Fri, 25 Nov 2016 17:07:43 +0000 (18:07 +0100)]
RAII to postpone processor changes/graph recalculation
Len Ovens [Fri, 25 Nov 2016 15:26:18 +0000 (07:26 -0800)]
OSC: Patch from 7136 added cleaned and tested.
Robin Gareus [Fri, 25 Nov 2016 13:24:15 +0000 (14:24 +0100)]
cont'd work to prevent duplicate playlist names
Paul Davis [Fri, 25 Nov 2016 13:19:27 +0000 (13:19 +0000)]
when duplicating tracks and copying playlists, use a new name for the copied playlist
Robin Gareus [Fri, 25 Nov 2016 12:26:38 +0000 (13:26 +0100)]
Fix forwarding of output-buffers.
fbc8504f9eb74 swapped the iterators: Instead of iterating over output
buffers like BufferSet::read_from(), the new code iterates over
the current buffers. In case of 1 in -> 2 out, only the 1st channel
was be copied. Also unlike BufferSet::read_from() the ChanCount was
not updated.
Processors after a Delivery e.g. out-meter, AFL processor did not see
all channels.
Robin Gareus [Fri, 25 Nov 2016 12:03:00 +0000 (13:03 +0100)]
fix default output map display for no plugin processors
(eg. mono->stereo deliveries)
Paul Davis [Fri, 25 Nov 2016 11:50:39 +0000 (11:50 +0000)]
make the session do the right thing when clearing solo state during non-loading conditions
Paul Davis [Fri, 25 Nov 2016 11:50:08 +0000 (11:50 +0000)]
remove redundant (identical) 2nd conditional, and improve comment
Paul Davis [Fri, 25 Nov 2016 11:49:30 +0000 (11:49 +0000)]
when clearing route solo state, do the required update
Paul Davis [Fri, 25 Nov 2016 11:48:58 +0000 (11:48 +0000)]
Do not try to restore Route solo state after clearing all solo state
Paul Davis [Fri, 25 Nov 2016 11:48:18 +0000 (11:48 +0000)]
fix implementation of SoloControl::clear_all_solo_state()
This no longer emits Changed() unless a change was made, and more
importantly, calls AutomationControl::actually_set_value() if
the self-soloed value needs to be changed
Paul Davis [Fri, 25 Nov 2016 10:29:16 +0000 (10:29 +0000)]
provisional changes to speed up solo changes to large numbers of routes.
Moves global update of solo state and emission of Session::SoloChanged to
a single point after 1 to N solo controls are changed.
Also avoid unnecessarily emitted Activated() signal for listen controls,
though Process::{activate,deactive}() should probably be redesigned to
avoid this in a "deeper" way
Robin Gareus [Fri, 25 Nov 2016 09:41:23 +0000 (10:41 +0100)]
Speed up AFL/PFL changes for large sessions
update_latency_compensation() and resort_routes() are expensive and
were called for every individual change.
Robin Gareus [Fri, 25 Nov 2016 09:05:36 +0000 (10:05 +0100)]
The DisplaySuspender is useless with async Session RTEvents
Robin Gareus [Thu, 24 Nov 2016 21:11:19 +0000 (22:11 +0100)]
Don't allow duplicate playlist names
Robin Gareus [Thu, 24 Nov 2016 20:58:50 +0000 (21:58 +0100)]
_maps_from_state is legal after unfreeze (restore state)
Robin Gareus [Thu, 24 Nov 2016 20:03:14 +0000 (21:03 +0100)]
a-High/LowPass allow 8K samples inclusive
nick_m [Thu, 24 Nov 2016 17:50:46 +0000 (04:50 +1100)]
midi ghost region fill colour is per event. don't store it. ensure _outline is set.
nick_m [Thu, 24 Nov 2016 14:06:22 +0000 (01:06 +1100)]
amend last commit.
nick_m [Thu, 24 Nov 2016 13:50:29 +0000 (00:50 +1100)]
midi scroomer updates streamview during drags.
Olivier Humbert [Mon, 21 Nov 2016 20:51:41 +0000 (21:51 +0100)]
French translation update
Mainly improvements to the Preference tabs.
edogawa23 [Wed, 23 Nov 2016 22:01:17 +0000 (23:01 +0100)]
small correction to de.po
Robin Gareus [Thu, 24 Nov 2016 08:02:47 +0000 (09:02 +0100)]
Fix mysterious crashes such as #7049
Fixes an issue with corrupted std::lists<> due to concurrent writes
to the invalidation list which eventually resulted in
EventLoop::invalidate_request() not invalidating requests.
Concurrency sucks rocks hard.
Robin Gareus [Wed, 23 Nov 2016 20:39:11 +0000 (21:39 +0100)]
another hack to accommodate different project names
Mixbus32C-$MAJOR + Mixbus32C (dash before major version)
vs Ardour$MAJOR + Ardour
vs Mixbus$MAJOR + Mixbus
Edgar Aichinger [Wed, 23 Nov 2016 13:12:57 +0000 (14:12 +0100)]
catch up with .de translation
nick_m [Wed, 23 Nov 2016 04:36:26 +0000 (15:36 +1100)]
clean up pending region selection if a region goes away.
nick_m [Wed, 23 Nov 2016 04:32:13 +0000 (15:32 +1100)]
MidiRegionView::clear_events() does _selection.clear(). remove the extra one.
nick_m [Wed, 23 Nov 2016 04:29:57 +0000 (15:29 +1100)]
fix a crash when deleting a MIDI region with CC automation (see recipe below)
- object mode: select a MIDI region that has CC automation.
Move the mouse over a CC automation event,
then press backspace to delete the selected region
- the recipe is mentioned in #7049, but seems unrelated.
nick_m [Wed, 23 Nov 2016 04:09:54 +0000 (15:09 +1100)]
clicking on an automation line selects adjacent points correctly.
nick_m [Tue, 22 Nov 2016 21:04:14 +0000 (08:04 +1100)]
decouple midi region note range and height from midi streamview.
- this allows a midi region drag to update the visible notes
correctly while crossing MIDI streamviews with a differing
note range.
as a side effect, fixes a bug where changing
note range on a track did not draw some notes
(apply_note_range redisplays the model).
nick_m [Tue, 22 Nov 2016 17:55:56 +0000 (04:55 +1100)]
son't try to select non-existent notes after editing (and thus crash).
- should fix 7135
nick_m [Tue, 22 Nov 2016 14:45:43 +0000 (01:45 +1100)]
constify some TempoMap functions.
nick_m [Tue, 22 Nov 2016 11:51:10 +0000 (22:51 +1100)]
remove set but not used variable in tempo.cc
Robin Gareus [Mon, 21 Nov 2016 20:24:11 +0000 (21:24 +0100)]
MIDI LFO generator plugin
nick_m [Mon, 21 Nov 2016 16:17:01 +0000 (03:17 +1100)]
amend
66488e117 - BBT clock scrolling handles multiple audio-locked meters.
nick_m [Mon, 21 Nov 2016 15:59:57 +0000 (02:59 +1100)]
don't display notes that start at region end.
- its not obvious that this is happening in sustained mode,
but Percussive reveals all.
nick_m [Mon, 21 Nov 2016 15:21:05 +0000 (02:21 +1100)]
fix thinko in
8e8c4a73f1e.
nick_m [Mon, 21 Nov 2016 15:05:32 +0000 (02:05 +1100)]
filter events in HitCreateDrag, remove some code.
nick_m [Mon, 21 Nov 2016 15:01:01 +0000 (02:01 +1100)]
prevent Percussive mode from displaying a ghost hit at region end.
nick_m [Mon, 21 Nov 2016 14:59:57 +0000 (01:59 +1100)]
NoteCreateDrag - remove some code
nick_m [Mon, 21 Nov 2016 13:29:53 +0000 (00:29 +1100)]
TempoMap::bbt_duration_at() handles an audio-locked meter.
- fixes some odd results when scrolling down/up over the BBT clock display.
Tim Mayberry [Mon, 21 Nov 2016 12:19:56 +0000 (22:19 +1000)]
Make Cut mode respect snap modifer
Tim Mayberry [Mon, 21 Nov 2016 10:45:35 +0000 (20:45 +1000)]
Show cursor in Cut mode on button press at cutting position
Previously it would be shown at the mouse cursor position even though the
Region is cut/split at the snap/quantize point if no motion occurred.