ardour.git
6 years agoFix region-gain offset when separating ranges 5.10
Robin Gareus [Wed, 14 Jun 2017 20:47:22 +0000 (22:47 +0200)]
Fix region-gain offset when separating ranges

6 years agoSquelch error message when toggling master-bus visibility.
Robin Gareus [Wed, 14 Jun 2017 19:22:08 +0000 (21:22 +0200)]
Squelch error message when toggling master-bus visibility.

6 years agoOSC: Add send/plugin page values to GUI
Len Ovens [Wed, 14 Jun 2017 17:28:45 +0000 (10:28 -0700)]
OSC: Add send/plugin page values to GUI

6 years agoOSC: save and restore send/plugin page size.
Len Ovens [Wed, 14 Jun 2017 15:18:02 +0000 (08:18 -0700)]
OSC: save and restore send/plugin page size.

6 years agoFix range-separate for musically-locked MIDI regions
Robin Gareus [Wed, 14 Jun 2017 13:21:02 +0000 (15:21 +0200)]
Fix range-separate for musically-locked MIDI regions

Cloning a region retains the region-lock style.
Playlist partitioning set the region start-property only (audio-time).
If a MIDI region is locked to musical-time, Properties::start is ignored
and overwritten by Properties::start_beats.

6 years agoSpecial-case VCA at 0 (-inf dB), force gain slaves to -inf dB
Robin Gareus [Wed, 14 Jun 2017 13:14:56 +0000 (15:14 +0200)]
Special-case VCA at 0 (-inf dB), force gain slaves to -inf dB

6 years agoMerge event control lists when disconnecting a master-ctrl
Robin Gareus [Wed, 14 Jun 2017 00:39:15 +0000 (02:39 +0200)]
Merge event control lists when disconnecting a master-ctrl

6 years agoAdd infrastructure to merge ControlLists
Robin Gareus [Wed, 14 Jun 2017 00:38:32 +0000 (02:38 +0200)]
Add infrastructure to merge ControlLists

6 years agoOSC: Allow set_surface to set send and plugin page sizes.
Len Ovens [Tue, 13 Jun 2017 23:55:13 +0000 (16:55 -0700)]
OSC: Allow set_surface to set send and plugin page sizes.

6 years agoApply master-value to automation on disconnect.
Robin Gareus [Tue, 13 Jun 2017 18:57:01 +0000 (20:57 +0200)]
Apply master-value to automation on disconnect.

6 years agoWrite inverse master automation.
Robin Gareus [Tue, 13 Jun 2017 16:09:22 +0000 (18:09 +0200)]
Write inverse master automation.

 * The UI and ctrl-surface controls use and display the combined value,
including control-masters.

 * The Automation lane of a control is the raw value of the control
without masters.

When touching (or writing) automation, the control-master needs to be
factored out (or subtracted). e.g press+hold a control -> write inverse
master automation.

6 years agoamend 11ba1854 -- locked curve-evaluation is not public
Robin Gareus [Tue, 13 Jun 2017 15:57:58 +0000 (17:57 +0200)]
amend 11ba1854 -- locked curve-evaluation is not public

6 years agoFP8: use proper API to detect automation-playback
Robin Gareus [Tue, 13 Jun 2017 14:07:20 +0000 (16:07 +0200)]
FP8: use proper API to detect automation-playback

The custom code didn't take touch + touching into account when
another surface was touching automation.

6 years agoFix another thinko in 9581cb26 + 02b087c5 (VCA gain automation)
Robin Gareus [Tue, 13 Jun 2017 14:05:33 +0000 (16:05 +0200)]
Fix another thinko in 9581cb26 + 02b087c5 (VCA gain automation)

This went unnoticed because: VCA gain automation was always applied
(regardless of automation state) but when it was not playing
master_ratio() factored it out again (per block).

6 years agoFix nasty duplicate XML node
Robin Gareus [Mon, 12 Jun 2017 23:08:08 +0000 (01:08 +0200)]
Fix nasty duplicate XML node

6 years agoRemember subgroup-bus
Robin Gareus [Mon, 12 Jun 2017 23:07:48 +0000 (01:07 +0200)]
Remember subgroup-bus

6 years agoAllow group gain sharing + VCA again
Robin Gareus [Mon, 12 Jun 2017 20:37:09 +0000 (22:37 +0200)]
Allow group gain sharing + VCA again

6 years agoOSC: select channel plugin support with paging.
Len Ovens [Mon, 12 Jun 2017 19:29:58 +0000 (12:29 -0700)]
OSC: select channel plugin support with paging.

6 years agoFix Monitor Group override
Robin Gareus [Mon, 12 Jun 2017 18:47:11 +0000 (20:47 +0200)]
Fix Monitor Group override

6 years agoFix relative grouped + VCA slaved gain
Robin Gareus [Mon, 12 Jun 2017 15:15:07 +0000 (17:15 +0200)]
Fix relative grouped + VCA slaved gain

6 years agoConsistent "cancel/close" button position on the left.
Robin Gareus [Mon, 12 Jun 2017 10:48:53 +0000 (12:48 +0200)]
Consistent "cancel/close" button position on the left.

"Add and Close" is an odd one out and this button should really be
removed for consistency. Still it allows for a 2-click or
2-keyboard-shortcut very common action.

6 years agoFix a compiler warning (optimized builds)
Robin Gareus [Mon, 12 Jun 2017 10:47:48 +0000 (12:47 +0200)]
Fix a compiler warning (optimized builds)

6 years agoRestore the state of the autoplay button in the import dialog
Tim Mayberry [Mon, 12 Jun 2017 13:59:11 +0000 (23:59 +1000)]
Restore the state of the autoplay button in the import dialog

6 years agoMake Import the default action in the Import Dialog
Tim Mayberry [Mon, 12 Jun 2017 12:52:11 +0000 (22:52 +1000)]
Make Import the default action in the Import Dialog

Double clicking on a file or pressing the Return key will now import it.

This means with autoplay enabled you can navigate a directory of audio files
using the up and down arrow keys and import the wanted files (with Return)
without having to touch the mouse.

Being able to use double click to import a file means you don't have to move
the mouse back and forth between the file browser and the import button.

You can still manually audition the file with space as before.

6 years agoRemove unnecessary temporary variables in MasterRecord::set_state
Tim Mayberry [Mon, 12 Jun 2017 11:19:25 +0000 (21:19 +1000)]
Remove unnecessary temporary variables in MasterRecord::set_state

XMLNode::get_property only modifies the argument if the property is found and
conversion is successful.

6 years agoVCA/SlavableAutomationCtrl re-design:
Robin Gareus [Mon, 12 Jun 2017 00:25:20 +0000 (02:25 +0200)]
VCA/SlavableAutomationCtrl re-design:

* remember master-ctrl value on assignment & save with session
* Control/AutomationCtrl only stores ctrl's own value (w/o master)
* virtual AutomationControl::get_value () -> use SlavableAC method
* MasterRecord uses weak-ptr (fixes recursive ~Controllable() deadlock)

6 years agoa-EQ: Tweak knob layout to be less confusing
Damien Zammit [Sun, 11 Jun 2017 06:24:34 +0000 (16:24 +1000)]
a-EQ: Tweak knob layout to be less confusing

6 years agoFix thinko in 9581cb26 - scratch-buffer can't be used recursively.
Robin Gareus [Sat, 10 Jun 2017 23:57:28 +0000 (01:57 +0200)]
Fix thinko in 9581cb26 - scratch-buffer can't be used recursively.

6 years agoOSC: add option to send /reply instead of #reply (OSC1.0 compat)
Len Ovens [Sat, 10 Jun 2017 14:28:15 +0000 (07:28 -0700)]
OSC: add option to send /reply instead of #reply (OSC1.0 compat)

6 years agoEmit Session::Located only if _engine.transport_frame() is up to date
Johannes Mueller [Fri, 9 Jun 2017 19:31:15 +0000 (21:31 +0200)]
Emit Session::Located only if _engine.transport_frame() is up to date

If _engine.transport_frame() is not up to date, we emit Located in
Session::backend_sync_callback() because that's when audible_frame() is up to
date. We don't want to emit it twice, because then, the playhead jumps back and
forth.

* mouse click in the ruler -> jump to requested location
* mouse release -> jump to old location (because audible_frame has to catch up)
* backend_sync_callback() called -> jump to new location

6 years agoMake Session::backend_sync_callback() emit Session::Located
Johannes Mueller [Fri, 9 Jun 2017 19:24:57 +0000 (21:24 +0200)]
Make Session::backend_sync_callback() emit Session::Located

If we sync to jackd AudioEngine::transport_frame() is not yet updated when
Session emits Located. Then the playhead ends up in an obsolete
position. Therefore we emit Session::Located() also from within
Session::backend_sync_callback() as that is called when AudioEngine is done
with the relocation.

6 years agosemantically more correct ordering of previous commit
Paul Davis [Sat, 10 Jun 2017 16:04:27 +0000 (12:04 -0400)]
semantically more correct ordering of previous commit

6 years agolinker-agnostic version of recent commit to get ControlProtocol selection state set...
Paul Davis [Sat, 10 Jun 2017 15:53:21 +0000 (11:53 -0400)]
linker-agnostic version of recent commit to get ControlProtocol selection state set correctly

6 years agoImplement slaved boolean automation and update mute special-case
Robin Gareus [Sat, 10 Jun 2017 12:36:03 +0000 (14:36 +0200)]
Implement slaved boolean automation and update mute special-case

6 years agoRestore VCA Automation state
Robin Gareus [Sat, 10 Jun 2017 12:37:23 +0000 (14:37 +0200)]
Restore VCA Automation state

6 years agoamend a1b4f9b8ab - handle disconnecting from all masters
Robin Gareus [Sat, 10 Jun 2017 12:37:05 +0000 (14:37 +0200)]
amend a1b4f9b8ab - handle disconnecting from all masters

6 years agoset first selected stripable for control protocols before they are instantiated
Paul Davis [Fri, 9 Jun 2017 21:54:10 +0000 (17:54 -0400)]
set first selected stripable for control protocols before they are instantiated

6 years agoNO-OP: whitespace
Robin Gareus [Fri, 9 Jun 2017 21:24:37 +0000 (23:24 +0200)]
NO-OP: whitespace

6 years agoFix deletion of VCA with slaved controls.
Robin Gareus [Fri, 9 Jun 2017 20:54:09 +0000 (22:54 +0200)]
Fix deletion of VCA with slaved controls.

The crashed previously because:
 A VCA is-a Automatable is-a Evoral::ControlSet

 After VCA's d'tor completes ~Automatable runs and emits signal to
 DropReferences of all master-controls.

 This in turn calls SlavableAutomationControl::master_going_away()
 for slaved parameters for the given master-control

 In ::master_going_away() the weak-pointer reference to the master's
 AutomationControl (owned by the destroyed VCA) is still valid.

 Execution is in the d'tor of Automatable which is-a ControlSet and
 the ContolSet keeps a reference to the Control and hence also to the
 AutomationControl which is-a Evoral::Control.

 So master_going_away() locks a boost::shared_ptr<ARDOUR::AutomationControl>
 which is actually the MuteControl owned by the VCA.
 It calls SlavableAutomationControl::remove_master() which
 in turn calls MuteControl::pre_remove_master() which uses the
 MuteMaster API to retrieve the value. The MuteMaster however is the
 VCA that has just been destroyed.

The solution is twofold:
 1) emit "drop_references" from the VCA d'tor itself,
    before the VCA is destroyed.

 2) disconnect a slaved control from the master's drop_references signal
    when un-assigning a master-control.

6 years agoNoteCreateDrag - Fix incorrect note length due to use of region-relative position
nick_m [Fri, 9 Jun 2017 17:49:01 +0000 (03:49 +1000)]
NoteCreateDrag - Fix incorrect note length due to use of region-relative position

6 years agoRemove Automatable::value_as_string API from libardour
Robin Gareus [Fri, 9 Jun 2017 12:47:27 +0000 (14:47 +0200)]
Remove Automatable::value_as_string API from libardour

Keep Pannable::value_as_string() for now. That is another inconsistency
which needs cleaning up. GUI StereoPanner and MonoPanner print
the value as they see fit, the panner-plugin provided formatting
is not used.

6 years agoUpdate GUI, drop Automatable::value_as_string() API
Robin Gareus [Fri, 9 Jun 2017 12:46:11 +0000 (14:46 +0200)]
Update GUI, drop Automatable::value_as_string() API

6 years agoPrepare to eventually drop Automatable::value_as_string()
Robin Gareus [Fri, 9 Jun 2017 11:41:04 +0000 (13:41 +0200)]
Prepare to eventually drop Automatable::value_as_string()

Probably due to historical reasons, there are two APIs to format a
control's value. In all both variants end up calling either
ARDOUR::value_as_string() or the Controllable's formatting function
(except for panners).

6 years agoPrepare AutomationTimeAxisView for non-route (VCA) automation
Robin Gareus [Thu, 8 Jun 2017 21:45:07 +0000 (23:45 +0200)]
Prepare AutomationTimeAxisView for non-route (VCA) automation

6 years agoa-EQ: Revert one of the previous changes
Damien Zammit [Fri, 9 Jun 2017 13:06:53 +0000 (23:06 +1000)]
a-EQ: Revert one of the previous changes

One of the previous changes was not a typo, revert it.

6 years agoFix incorrect positioning of tempo line subdivisions if first meter is non-zero
nick_m [Fri, 9 Jun 2017 01:05:56 +0000 (11:05 +1000)]
Fix incorrect positioning of tempo line subdivisions if first meter is non-zero

Commit cebefe6 assumed that frame 0 was the music origin.
Silly me.

6 years agoAdd a method for obtaining the frame position of beat/whatever zero
nick_m [Fri, 9 Jun 2017 01:01:30 +0000 (11:01 +1000)]
Add a method for obtaining the frame position of beat/whatever zero

6 years agoFix crash when showing plugin-UI in safe-mode
Robin Gareus [Thu, 8 Jun 2017 19:21:13 +0000 (21:21 +0200)]
Fix crash when showing plugin-UI in safe-mode

6 years agoTempoLines deletes its bfc on destruction
nick_m [Thu, 8 Jun 2017 15:56:28 +0000 (01:56 +1000)]
TempoLines deletes its bfc on destruction

6 years agoTempo lines display subdivisions correctly over a tempo change
nick_m [Thu, 8 Jun 2017 15:44:48 +0000 (01:44 +1000)]
Tempo lines display subdivisions correctly over a tempo change

TempoMap::get_grid() supplies a list of beat positions, leaving the lines
to work out any subdivision positions.
This is fine, unless a tempo section falls in between beats.
Use a BeatsFramesConverter along with a quarter note position
(in the BBTPointsList) to make this easier.

6 years agoFix reversed logic in legacy tempo secton detection
nick_m [Thu, 8 Jun 2017 15:34:14 +0000 (01:34 +1000)]
Fix reversed logic in legacy tempo secton detection

6 years agoDelete tempo lines when session goes away
nick_m [Thu, 8 Jun 2017 15:08:59 +0000 (01:08 +1000)]
Delete tempo lines when session goes away

6 years agoDo not duplicate note id in copy constructor
nick_m [Thu, 8 Jun 2017 13:11:56 +0000 (23:11 +1000)]
Do not duplicate note id in copy constructor

This fixes selection undo after copy-dragging notes, but there
are probably other cases where duplicate note ids may cause problems.

6 years agoRemove debugging from TempoTest::qnDistanceTestRamp ()
nick_m [Thu, 8 Jun 2017 12:39:41 +0000 (22:39 +1000)]
Remove debugging from TempoTest::qnDistanceTestRamp ()

6 years agoFix uninitialised tempo section variable
nick_m [Thu, 8 Jun 2017 12:18:57 +0000 (22:18 +1000)]
Fix uninitialised tempo section variable

Should fix 7390.

6 years agoFix rec-box w/count-in
Robin Gareus [Thu, 8 Jun 2017 11:33:35 +0000 (13:33 +0200)]
Fix rec-box w/count-in

Since 478f26b2ad, transport_rolling() is only true when actually rolling.
Count-in is a no-roll process (don't move playhead, no playhead UI
position interpolation 55b8b448).

But transport isn't exactly stopped either (preparing to roll), so
during count-in transport_stopped() == transport_rolling() == false.

6 years agoUpdate LuaDialog example script to include File/Folder selection
Robin Gareus [Thu, 8 Jun 2017 11:22:43 +0000 (13:22 +0200)]
Update LuaDialog example script to include File/Folder selection

6 years agoAdd a file-chooser LuaDialog Widget
Robin Gareus [Thu, 8 Jun 2017 11:22:00 +0000 (13:22 +0200)]
Add a file-chooser LuaDialog Widget

6 years agocut buffer must not mess around with libardour selection
Paul Davis [Wed, 7 Jun 2017 16:14:44 +0000 (12:14 -0400)]
cut buffer must not mess around with libardour selection

Fixes range mode selection/cut/copy that would previously clear track selection

6 years agoa-EQ: DSP bugfix
Damien Zammit [Wed, 7 Jun 2017 16:04:12 +0000 (02:04 +1000)]
a-EQ: DSP bugfix

Previously there were large spurious spikes in the signal when
the bandwidth parameter was adjusted on a pure sine tone
for the peaking circuits. This has been *greatly* reduced if not
eliminated by fixing a typo in two of the equations.

6 years agoOSC: add optional paging to sends in select.
Len Ovens [Tue, 6 Jun 2017 14:35:24 +0000 (07:35 -0700)]
OSC: add optional paging to sends in select.

6 years agoFix a-EQ when parameter changes are very slow
Nil Geisweiller [Sun, 4 Jun 2017 18:34:48 +0000 (21:34 +0300)]
Fix a-EQ when parameter changes are very slow

If the parameters change too slowly the filter may never get updated. Indeed,
in spite of v_f0, v_g or v_bw being updated, set_params may never be called,
thus v_filter never updated.

6 years agoadd route dialog now has "Add" and "Add and Close" buttons. "Add" keeps dialog open...
Daniel Sheeler [Fri, 2 Jun 2017 22:23:00 +0000 (17:23 -0500)]
add route dialog now has "Add" and "Add and Close" buttons.  "Add" keeps dialog open so user can add multiple templates.

6 years agoApply VCA master gain automation to Amp (Fader, Trim)
Robin Gareus [Sat, 3 Jun 2017 11:29:28 +0000 (13:29 +0200)]
Apply VCA master gain automation to Amp (Fader, Trim)

6 years agoAdd infrastructure for evaluating VCA automation curves
Robin Gareus [Sat, 3 Jun 2017 11:18:31 +0000 (13:18 +0200)]
Add infrastructure for evaluating VCA automation curves

6 years agoamend 67f9f6fd: no recursive ReaderLock
Robin Gareus [Sat, 3 Jun 2017 10:31:59 +0000 (12:31 +0200)]
amend 67f9f6fd: no recursive ReaderLock

6 years agoadd const-ness: Evaluating a curve does not change it.
Robin Gareus [Sat, 3 Jun 2017 10:30:26 +0000 (12:30 +0200)]
add const-ness: Evaluating a curve does not change it.

Note that the ControlList's lock and cache are already mutable.

6 years agoAdd a scratch buffer for automation.
Robin Gareus [Sat, 3 Jun 2017 10:26:33 +0000 (12:26 +0200)]
Add a scratch buffer for automation.

Useful as temporary buffer: This allows a controllable to
get a master's automation-curve and combine it with its own
(gain, trim, send) automation buffer.

6 years agoNO-OP: whitespace
Robin Gareus [Fri, 2 Jun 2017 22:19:35 +0000 (00:19 +0200)]
NO-OP: whitespace

6 years agoImport Dialog is Window. Dialog Esc behavior needs to be emulated.
Robin Gareus [Fri, 2 Jun 2017 16:21:31 +0000 (18:21 +0200)]
Import Dialog is Window. Dialog Esc behavior needs to be emulated.

6 years agoRemove "Close" button from import-dialog (prefer WM close button)
Robin Gareus [Thu, 1 Jun 2017 09:57:08 +0000 (11:57 +0200)]
Remove "Close" button from import-dialog (prefer WM close button)

6 years agoif actively recording, prevent interaction between mouse and audio clock widget(s)
Paul Davis [Wed, 31 May 2017 17:04:03 +0000 (13:04 -0400)]
if actively recording, prevent interaction between mouse and audio clock widget(s)

6 years agoOSC: Some surfaces may use float for ssid. Accept this too.
Len Ovens [Wed, 31 May 2017 15:38:55 +0000 (08:38 -0700)]
OSC: Some surfaces may use float for ssid. Accept this too.

6 years agoOSC: check controllable exists before using
Len Ovens [Wed, 31 May 2017 14:15:50 +0000 (07:15 -0700)]
OSC: check controllable exists before using

6 years agoAdd Lua bindings for VCAs and VCAManager
Robin Gareus [Tue, 30 May 2017 13:15:30 +0000 (15:15 +0200)]
Add Lua bindings for VCAs and VCAManager

6 years agoPrepare for automation control master
Robin Gareus [Tue, 30 May 2017 13:13:37 +0000 (15:13 +0200)]
Prepare for automation control master

Basic infrastructure to allow VCA automation and Trim automation:
look up events during automation playback.

6 years agoCredit where credit is due
Robin Gareus [Mon, 29 May 2017 21:48:17 +0000 (23:48 +0200)]
Credit where credit is due

6 years agoNO-OP: whitespace
Robin Gareus [Mon, 29 May 2017 21:45:16 +0000 (23:45 +0200)]
NO-OP: whitespace

6 years agoduplicate routes start off unsoloed to avoid issues related to upstream / downstream...
Daniel Sheeler [Sun, 28 May 2017 20:46:22 +0000 (15:46 -0500)]
duplicate routes start off unsoloed to avoid issues related to upstream / downstream buses

6 years agowhen creating a new session after working on one, the "Cancel" button should be a...
Paul Davis [Mon, 29 May 2017 19:35:03 +0000 (15:35 -0400)]
when creating a new session after working on one, the "Cancel" button should be a quit button.

This avoids ending up with a null Session pointer in the GUI (#7369)

6 years agoAllow export presets for 176.4KHz -- "Ardour6: music for bats"
Robin Gareus [Mon, 29 May 2017 11:37:06 +0000 (13:37 +0200)]
Allow export presets for 176.4KHz -- "Ardour6: music for bats"

6 years agoUpdate Russian translation
Alexandre Prokoudine [Thu, 25 May 2017 23:47:21 +0000 (02:47 +0300)]
Update Russian translation

6 years agoUse string concatenation and PBD::to_string in EventTypeMap::to_symbol()
Tim Mayberry [Fri, 26 May 2017 00:50:08 +0000 (10:50 +1000)]
Use string concatenation and PBD::to_string in EventTypeMap::to_symbol()

Avoid using PBD::string_compose for serialization as correct behaviour depends
on the setting of the global C++ locale.

6 years agoRemove normalization of property names from libpbd xml code
Tim Mayberry [Fri, 23 Sep 2016 13:05:44 +0000 (23:05 +1000)]
Remove normalization of property names from libpbd xml code

It may have been OK to add this code temporarily at this low level, but as it
was introduced in 2008, this change is made with the assumption that any
Sessions that were affected have been re-saved since then with corrected
property names and that "normalization" is no longer necessary.

Timing results before changes:

XMLTest::testPerfMediumXMLDocumentTiming
   Create : Count: 10 Min: 30375 Max: 48253 Total: 431727 Avg: 43172 (43 msecs)
   Write : Count: 10 Min: 42553 Max: 49163 Total: 453353 Avg: 45335 (45 msecs)
   Read : Count: 10 Min: 70307 Max: 75987 Total: 734923 Avg: 73492 (73 msecs)
XMLTest::testPerfLargeXMLDocumentTiming
   Create : Count: 10 Min: 154486 Max: 307856 Total: 2678989 Avg: 267898 (267 msecs)
   Write : Count: 10 Min: 304273 Max: 343274 Total: 3169158 Avg: 316915 (316 msecs)
   Read : Count: 10 Min: 496920 Max: 541394 Total: 5260410 Avg: 526041 (526 msecs)

Timing results after changes:

XMLTest::testPerfMediumXMLDocumentTiming
   Create : Count: 10 Min: 21437 Max: 39749 Total: 348622 Avg: 34862 (34 msecs)
   Write : Count: 10 Min: 42320 Max: 49989 Total: 446135 Avg: 44613 (44 msecs)
   Read : Count: 10 Min: 63252 Max: 68389 Total: 660841 Avg: 66084 (66 msecs)
XMLTest::testPerfLargeXMLDocumentTiming
   Create : Count: 10 Min: 113458 Max: 263225 Total: 2215595 Avg: 221559 (221 msecs)
   Write : Count: 10 Min: 305439 Max: 339986 Total: 3150697 Avg: 315069 (315 msecs)
   Read : Count: 10 Min: 447560 Max: 488121 Total: 4698903 Avg: 469890 (469 msecs)

6 years agoUse correct property name in generic MIDI surface
Tim Mayberry [Thu, 25 May 2017 12:02:32 +0000 (22:02 +1000)]
Use correct property name in generic MIDI surface

Fixes restoring the feedback interval property, but as the mutator/setter
method doesn't seem to be used this change should have no affect.

6 years agoUse correct names when setting MidiTrack properties
Tim Mayberry [Thu, 25 May 2017 11:39:59 +0000 (21:39 +1000)]
Use correct names when setting MidiTrack properties

These were changed in the XMLProperty ctor and they now match the names used in
MidiTrack::set_state()

6 years agoRemove attempt to retrieve invalid Meterbridge properties
Tim Mayberry [Thu, 25 May 2017 11:06:36 +0000 (21:06 +1000)]
Remove attempt to retrieve invalid Meterbridge properties

The property names with underscores are "normalized" to replace the underscores
with hyphens in the XMLProperty constructor from within Meterbridge::get_state
and so have always been written with hyphens.

6 years agoUse correct property names in Meterbridge::get_state()
Tim Mayberry [Thu, 25 May 2017 10:52:34 +0000 (20:52 +1000)]
Use correct property names in Meterbridge::get_state()

These property names have been "normalized"/changed to use a hyphen in the
XMLProperty ctor since 2008. That is before the Meterbridge existed so there
should be no files existing that contain these properties with underscores.

6 years agoUse correct property names for Editor transport controllable state
Tim Mayberry [Thu, 25 May 2017 10:42:45 +0000 (20:42 +1000)]
Use correct property names for Editor transport controllable state

These are normalized in the PBD::XMLProperty ctor, which is why
Editor::get_transport_controllable_state() uses the hyphenated names to
retrieve the properties and will not result in any state format change.

6 years agoAlways create a deep copy of MIDI regions when copying playlists.
Robin Gareus [Thu, 25 May 2017 12:10:14 +0000 (14:10 +0200)]
Always create a deep copy of MIDI regions when copying playlists.

6 years agoPretty print control-outputs in generic-UI
Robin Gareus [Thu, 25 May 2017 11:48:55 +0000 (13:48 +0200)]
Pretty print control-outputs in generic-UI

6 years agoImplement basic AU parameter-printing
Robin Gareus [Thu, 25 May 2017 11:36:33 +0000 (13:36 +0200)]
Implement basic AU parameter-printing

(don't leave buf uninitialized)

6 years agoInclude ParameterDescriptor in read-only control output
Robin Gareus [Thu, 25 May 2017 11:34:11 +0000 (13:34 +0200)]
Include ParameterDescriptor in read-only control output

6 years agoOSC: fix return value for successful touch
Len Ovens [Wed, 24 May 2017 20:58:49 +0000 (13:58 -0700)]
OSC: fix return value for successful touch

6 years agoOSC: Added lpf and hpf controls for freq,enable and slope
Len Ovens [Wed, 24 May 2017 14:37:21 +0000 (07:37 -0700)]
OSC: Added lpf and hpf controls for freq,enable and slope

6 years agoOSC add feedback for extra comp and eq controls
Len Ovens [Wed, 24 May 2017 00:16:42 +0000 (17:16 -0700)]
OSC add feedback for extra comp and eq controls

6 years agoOSC - make /strip/list accept a parameter like everything else
Len Ovens [Tue, 23 May 2017 22:14:31 +0000 (15:14 -0700)]
OSC - make /strip/list accept a parameter like everything else

6 years agoAccommodate recently removed source(s) in our MSVC project (gtk2_ardour)
John Emmas [Tue, 23 May 2017 08:28:44 +0000 (09:28 +0100)]
Accommodate recently removed source(s) in our MSVC project (gtk2_ardour)

6 years agoRemove old jack_utils.h header that was moved to the JACK backend
Tim Mayberry [Tue, 23 May 2017 04:27:50 +0000 (14:27 +1000)]
Remove old jack_utils.h header that was moved to the JACK backend

Also remove a related test that has not been part of the unit tests since the
move (years).

6 years agoSort tempo map after legacy sections have been assigned a pulse
nick_m [Tue, 23 May 2017 01:41:36 +0000 (11:41 +1000)]
Sort tempo map after legacy sections have been assigned a pulse